From aea0bb6ee739387ee2da15001909954ad3b2ed40 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Tue, 4 Feb 2020 11:21:09 -0500 Subject: [PATCH 1/3] Document unsupported versions 3.3 to 4.0 --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index 87cd9c9..8943ef8 100644 --- a/README.md +++ b/README.md @@ -95,6 +95,12 @@ If you're curious and want to explore what the differences are between the `grad and one of our valid release, you can compare them using this online utility: [DiffScope](https://try.diffoscope.org/). Regardless of what you find, we still kindly request that you reach out to us and let us know about any issues you encountered. + +**Note:** When _initially_ applying this action to your project, +if your `gradle-wrapper.jar` was generated by Gradle 3.3 to 4.0, the check will fail. +This is because these `gradle-wrapper.jar` versions were dynamically generated by Gradle in a non-reproducible manner. +As such, it's not possible to verify the `gradle-wrapper.jar` for those versions are legitimate using a hash comparison. + ## Resources To learn more about verifying the Gradle Wrapper JAR locally, see our From 91b8d34dbff84839f0fa1e64aec8a162c2c248d9 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Wed, 12 Feb 2020 13:59:11 -0500 Subject: [PATCH 2/3] Add explanation of what to do if in problematic version range Co-Authored-By: Paul Merlin --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8943ef8..62731c7 100644 --- a/README.md +++ b/README.md @@ -100,7 +100,7 @@ Regardless of what you find, we still kindly request that you reach out to us an if your `gradle-wrapper.jar` was generated by Gradle 3.3 to 4.0, the check will fail. This is because these `gradle-wrapper.jar` versions were dynamically generated by Gradle in a non-reproducible manner. As such, it's not possible to verify the `gradle-wrapper.jar` for those versions are legitimate using a hash comparison. - +If the Gradle version in use is out of this range it is possible that your Wrapper JAR is out of sync. To fix this run `./gradlew wrapper`. If the Gradle version in use is in the problematic range, you should consider upgrading. ## Resources To learn more about verifying the Gradle Wrapper JAR locally, see our From 793a52f6a90d294f307c45def729a1a32b6aacac Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Thu, 13 Feb 2020 16:59:09 -0500 Subject: [PATCH 3/3] Fix spacing on README --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 62731c7..7d6e73c 100644 --- a/README.md +++ b/README.md @@ -100,7 +100,9 @@ Regardless of what you find, we still kindly request that you reach out to us an if your `gradle-wrapper.jar` was generated by Gradle 3.3 to 4.0, the check will fail. This is because these `gradle-wrapper.jar` versions were dynamically generated by Gradle in a non-reproducible manner. As such, it's not possible to verify the `gradle-wrapper.jar` for those versions are legitimate using a hash comparison. -If the Gradle version in use is out of this range it is possible that your Wrapper JAR is out of sync. To fix this run `./gradlew wrapper`. If the Gradle version in use is in the problematic range, you should consider upgrading. +If the Gradle version in use is out of this range it is possible that your Wrapper JAR is out of sync. +To fix this run `./gradlew wrapper`. If the Gradle version in use is in the problematic range, you should consider upgrading. + ## Resources To learn more about verifying the Gradle Wrapper JAR locally, see our