No description
Find a file
Paul Merlin 94ba8eeec3 Remove now unneeded typescript definitions for unhomoglyph
Signed-off-by: Paul Merlin <paul@gradle.com>
2020-04-07 15:47:11 +02:00
.github/workflows Update checkout action to v2 2020-03-17 10:30:48 +01:00
__tests__ Merge branch 'master' into feat/JLL/homoglyph_detector 2020-01-15 11:59:08 -05:00
dist Let failure message link to how to report validation errors 2020-01-16 10:08:53 +01:00
src Remove now unneeded typescript definitions for unhomoglyph 2020-04-07 15:47:11 +02:00
.eslintignore Initial commit 2020-01-05 12:04:24 +01:00
.eslintrc.json Drop now removed upstream eslint typescript rules 2020-04-07 15:46:37 +02:00
.gitignore Fix typo 2020-01-22 16:44:58 -08:00
.prettierignore Initial commit 2020-01-05 12:04:24 +01:00
.prettierrc.json Initial commit 2020-01-05 12:04:24 +01:00
action.yml Add Action branding 2020-01-10 18:04:36 +01:00
CONTRIBUTING.md Add an explanation to the README 2020-01-10 16:07:03 +01:00
jest.config.js Add a homoglyph detector for gradle-wrapper.jar files 2020-01-13 13:00:16 -05:00
jest.setup.js Add a homoglyph detector for gradle-wrapper.jar files 2020-01-13 13:00:16 -05:00
LICENSE Initial commit 2020-01-05 12:04:24 +01:00
package-lock.json Bump minimist library version 2020-03-17 12:01:07 +02:00
package.json Upgrade prod dependencies 2020-04-07 15:46:51 +02:00
README.md Add a link to the example Homoglyph attack PR 2020-03-03 10:41:27 +01:00
RELEASING.md Refine RELEASING.md 2020-03-17 11:11:49 +01:00
tsconfig.json Initial commit 2020-01-05 12:04:24 +01:00

gradle/wrapper-validation-action status

Gradle Wrapper Validation Action

This action validates the checksums of Gradle Wrapper JAR files present in the source tree and fails if unknown Gradle Wrapper JAR files are found.

The Gradle Wrapper Problem in Open Source

The gradle-wrapper.jar is a binary blob of executable code that is checked into nearly 2.8 Million GitHub Repositories.

Searching across GitHub you can find many pull requests (PRs) with helpful titles like 'Update to Gradle xxx'. Many of these PRs are contributed by individuals outside of the organization maintaining the project.

Many maintainers are incredibly grateful for these kinds of contributions as it takes an item off of their backlog. We assume that most maintainers do not consider the security implications of accepting the Gradle Wrapper binary from external contributors. There is a certain amount of blind trust open source maintainers have. Further compounding the issue is that maintainers are most often greeted in these PRs with a diff to the gradle-wrapper.jar that looks like this.

Image of a GitHub Diff of Gradle Wrapper displaying text 'Binary file not shown.'

A fairly simple social engineering supply chain attack against open source would be contribute a helpful “Updated to Gradle xxx” PR that contains malicious code hidden inside this binary JAR. A malicious gradle-wrapper.jar could execute, download, or install arbitrary code while otherwise behaving like a completely normal gradle-wrapper.jar.

Solution

We have created a simple GitHub Action that can be applied to any GitHub repository. This GitHub Action will do one simple task: verify that any and all gradle-wrapper.jar files in the repository match the SHA-256 checksums of any of our official releases.

If any are found that do not match the SHA-256 checksums of our official releases, the action will fail.

Additionally, the action will find and SHA-256 hash all homoglyph variants of files named gradle-wrapper.jar, for example a file named gradlе-wrapper.jar (which uses a Cyrillic е instead of e). The goal is to prevent homoglyph attacks which may be very difficult to spot in a GitHub diff. We created an example Homoglyph attack PR here.

Usage

Add to an existing Workflow

Simply add this action to your workflow after having checked out your source tree and before running any Gradle build:

uses: gradle/wrapper-validation-action@v1

Add a new dedicated Workflow

Here's a sample complete workflow you can add to your repositories:

.github/workflows/gradle-wrapper-validation.yml

name: "Validate Gradle Wrapper"
on: [push, pull_request]

jobs:
  validation:
    name: "Validation"
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: gradle/wrapper-validation-action@v1

Contributing to an external GitHub Repository

Since GitHub Actions are completely free for open source projects and are automatically enabled on almost all projects, adding this check to a project's build is as simple as contributing a PR. Enabling the check requires no overhead on behalf of the project maintainer beyond merging the action.

You can add this action to your favorite Gradle based project without checking out their source locally via the GitHub Web UI thanks to the 'Create new file' button.

GitHub 'Create new file' Button bar picture

Simply add a new file named .github/workflows/gradle-wrapper-validation.yml with the contents mentioned above.

We recommend the message commit contents of:

  • Title: Official Gradle Wrapper Validation Action
  • Body (at minimum): See: https://github.com/gradle/wrapper-validation-action

From there, you can easily follow the rest of the prompts to create a Pull Request against the project.

Reporting Failures

If this GitHub action fails because a gradle-wrapper.jar doesn't match one of our published SHA-256 checksums, we highly recommend that you reach out to us at security@gradle.com.

If you're curious and want to explore what the differences are between the gradle-wrapper.jar in your possession and one of our valid release, you can compare them using this online utility: DiffScope. Regardless of what you find, we still kindly request that you reach out to us and let us know about any issues you encountered.

Note: When initially applying this action to your project, if your gradle-wrapper.jar was generated by Gradle 3.3 to 4.0, the check will fail. This is because these gradle-wrapper.jar versions were dynamically generated by Gradle in a non-reproducible manner. As such, it's not possible to verify the gradle-wrapper.jar for those versions are legitimate using a hash comparison. If the Gradle version in use is out of this range it is possible that your Wrapper JAR is out of sync. To fix this run ./gradlew wrapper. If the Gradle version in use is in the problematic range, you should consider upgrading.

Resources

To learn more about verifying the Gradle Wrapper JAR locally, see our guide on the topic.