wbrawner/Simple-Keyboard
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed issue with caching for mini keyboard views: Getting 'miniKeyboardView' from 'mMiniKeyboardCache' and not from the previously shown layout. Fix #251.

Browse source 
+ removed mMiniKeyboard!!.mOnKeyboardActionListener is not needed in MyKeyboardView.onLongPress() func. Originally defined in SimpleKeyboardIME class.
This commit is contained in:
Dmitriy Chernysh 2023-10-09 22:26:29 +03:00
parent 7f2b90cb82
commit 59de752615
1 changed files with 3 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
app/src/main/kotlin/com/simplemobiletools/keyboard/views/MyKeyboardView.kt
View file

@ -1012,37 +1012,6 @@ class MyKeyboardView @JvmOverloads constructor(context: Context, attrs: Attribut
mMiniKeyboard = miniKeyboardView
}
mMiniKeyboard!!.mOnKeyboardActionListener = object : OnKeyboardActionListener {
override fun onKey(code: Int) {
mOnKeyboardActionListener!!.onKey(code)
dismissPopupKeyboard()
}
override fun onPress(primaryCode: Int) {
mOnKeyboardActionListener!!.onPress(primaryCode)
}
override fun onActionUp() {
mOnKeyboardActionListener!!.onActionUp()
}
override fun moveCursorLeft() {
mOnKeyboardActionListener!!.moveCursorLeft()
}
override fun moveCursorRight() {
mOnKeyboardActionListener!!.moveCursorRight()
}
override fun onText(text: String) {
mOnKeyboardActionListener!!.onText(text)
}
override fun reloadKeyboard() {
mOnKeyboardActionListener!!.reloadKeyboard()
}
}
val keyboard = if (popupKey.popupCharacters != null) {
MyKeyboard(context, popupKeyboardId, popupKey.popupCharacters!!, popupKey.width)
} else {
@ -1056,7 +1025,9 @@ class MyKeyboardView @JvmOverloads constructor(context: Context, attrs: Attribut
)
mMiniKeyboardCache[popupKey] = mMiniKeyboardContainer
} else {
mMiniKeyboard = keyboardPopupBinding!!.miniKeyboardView
//Using 'miniKeyboardView' from cache
mMiniKeyboard = mMiniKeyboardCache[popupKey]?.let(KeyboardPopupKeyboardBinding::bind)?.miniKeyboardView
?: keyboardPopupBinding!!.miniKeyboardView
}
getLocationInWindow(mCoordinates)