wbrawner/Simple-Music-Player
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove the fake notification

Browse source 
Fixes issues related to notification disappearing plus it's not really needed. The `setupNotification()` method is called within 100ms on most devices included emulators
This commit is contained in:
Naveen 2022-12-16 05:16:56 +05:30
parent 010db61a5b
commit 3304051720
1 changed files with 2 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
app/src/main/kotlin/com/simplemobiletools/musicplayer/services/MusicService.kt
View file

@ -185,12 +185,7 @@ class MusicService : Service(), MediaPlayer.OnPreparedListener, MediaPlayer.OnEr
notifyFocusGained()
val action = intent.action
if (isOreoPlus() && action != NEXT && action != PREVIOUS && action != PLAYPAUSE) {
setupFakeNotification()
}
when (action) {
when (intent.action) {
INIT -> handleInit(intent)
INIT_PATH -> handleInitPath(intent)
INIT_QUEUE -> handleInitQueue()
@ -550,7 +545,7 @@ class MusicService : Service(), MediaPlayer.OnPreparedListener, MediaPlayer.OnEr
try {
notification.setLargeIcon(mCurrTrackCover)
} catch (e: OutOfMemoryError) {
} catch (ignored: OutOfMemoryError) {
}
try {
@ -570,30 +565,6 @@ class MusicService : Service(), MediaPlayer.OnPreparedListener, MediaPlayer.OnEr
return PendingIntent.getBroadcast(applicationContext, 0, intent, PendingIntent.FLAG_IMMUTABLE)
}
// on Android 8+ the service is launched with startForegroundService(), so startForeground must be called within a few secs
@SuppressLint("NewApi")
private fun setupFakeNotification() {
val notificationManager = getSystemService(Context.NOTIFICATION_SERVICE) as NotificationManager
val name = resources.getString(R.string.app_name)
val importance = NotificationManager.IMPORTANCE_LOW
NotificationChannel(NOTIFICATION_CHANNEL, name, importance).apply {
enableLights(false)
enableVibration(false)
notificationManager.createNotificationChannel(this)
}
val notification = NotificationCompat.Builder(applicationContext, NOTIFICATION_CHANNEL)
.setContentTitle("")
.setContentText("")
.setSmallIcon(R.drawable.ic_headset_small)
.setVisibility(NotificationCompat.VISIBILITY_PUBLIC)
.setPriority(NotificationCompat.PRIORITY_MAX)
.setChannelId(NOTIFICATION_CHANNEL)
.setCategory(Notification.CATEGORY_SERVICE)
startForeground(NOTIFICATION_ID, notification.build())
}
private fun getNewTrackId(): Long {
return when (mTracks.size) {
0 -> -1L