Fix free flavor builds

This commit is contained in:
William Brawner 2021-03-12 15:38:44 -07:00
parent 62720ddd05
commit 94cdb70da7
4 changed files with 10 additions and 9 deletions

View file

@ -18,9 +18,9 @@ jobs:
- name: Grant execute permission for gradlew - name: Grant execute permission for gradlew
run: chmod +x gradlew run: chmod +x gradlew
- name: Build with Gradle - name: Build with Gradle
run: ./gradlew assemblePlayDebug assemblePlayDebugAndroidTest assemblePlayDebugUnitTest run: ./gradlew assembleDebug assembleDebugAndroidTest assembleDebugUnitTest
- name: Run unit tests - name: Run unit tests
run: ./gradlew testPlayDebugUnitTest run: ./gradlew testDebugUnitTest
- name: Grant execute permission for flank_auth.sh - name: Grant execute permission for flank_auth.sh
run: chmod +x flank_auth.sh run: chmod +x flank_auth.sh
- name: Add auth for flank - name: Add auth for flank

View file

@ -3,7 +3,6 @@ apply plugin: 'kotlin-android-extensions'
apply plugin: 'kotlin-android' apply plugin: 'kotlin-android'
apply plugin: 'kotlin-kapt' apply plugin: 'kotlin-kapt'
apply plugin: 'jacoco' apply plugin: 'jacoco'
apply plugin: 'com.google.firebase.crashlytics'
apply plugin: "com.osacky.fladle" apply plugin: "com.osacky.fladle"
def keystoreProperties = new Properties() def keystoreProperties = new Properties()
@ -48,7 +47,7 @@ android {
buildConfigField "boolean", "ENABLE_CUSTOM_CSS", "false" buildConfigField "boolean", "ENABLE_CUSTOM_CSS", "false"
} }
signingConfigs { signingConfigs {
release { playRelease {
keyAlias keystoreProperties['keyAlias'] keyAlias keystoreProperties['keyAlias']
keyPassword keystoreProperties['keyPassword'] keyPassword keystoreProperties['keyPassword']
storeFile file(keystoreProperties['storeFile']) storeFile file(keystoreProperties['storeFile'])
@ -62,7 +61,6 @@ android {
release { release {
minifyEnabled true minifyEnabled true
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
signingConfig signingConfigs.release
buildConfigField "boolean", "ENABLE_CUSTOM_CSS", "false" buildConfigField "boolean", "ENABLE_CUSTOM_CSS", "false"
} }
} }
@ -72,7 +70,9 @@ android {
applicationIdSuffix ".free" applicationIdSuffix ".free"
versionNameSuffix "-free" versionNameSuffix "-free"
} }
play {} play {
signingConfig signingConfigs.playRelease
}
samsung { samsung {
applicationId "com.wbrawner.simplemarkdown.samsung" applicationId "com.wbrawner.simplemarkdown.samsung"
} }
@ -134,6 +134,7 @@ android.productFlavors.each { flavor ->
if (getGradle().getStartParameter().getTaskRequests().toString().toLowerCase().contains(flavor.name) if (getGradle().getStartParameter().getTaskRequests().toString().toLowerCase().contains(flavor.name)
&& flavor.name == 'play') { && flavor.name == 'play') {
apply plugin: 'com.google.gms.google-services' apply plugin: 'com.google.gms.google-services'
apply plugin: 'com.google.firebase.crashlytics'
} }
} }
repositories { repositories {

View file

@ -1,6 +1,6 @@
package com.wbrawner.simplemarkdown.utility package com.wbrawner.simplemarkdown.utility
import android.util.Log import timber.log.Timber
import kotlin.reflect.KProperty import kotlin.reflect.KProperty
class errorHandlerImpl { class errorHandlerImpl {

View file

@ -1,11 +1,11 @@
package com.wbrawner.simplemarkdown.utility package com.wbrawner.simplemarkdown.utility
import android.app.Application import android.app.Application
import android.util.Log import timber.log.Timber
object ReviewHelper { object ReviewHelper {
// No review library for F-droid, so this is a no-op // No review library for F-droid, so this is a no-op
fun init(application: Application) { fun init(application: Application) {
Timber.w("ReviewHelper", "ReviewHelper not enabled for free builds") Timber.tag("ReviewHelper").w("ReviewHelper not enabled for free builds")
} }
} }