wbrawner/SimpleMarkdown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #26 from wbrawner/crashlytics

Browse source 
Remove Crashlytics
This commit is contained in:
William Brawner 2018-03-27 17:49:52 -06:00 committed by GitHub
commit af4a3c8526
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 12 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
app/build.gradle
View file

@ -1,19 +1,4 @@
buildscript {
repositories {
maven { url 'https://maven.fabric.io/public' }
}
dependencies {
//noinspection GradleDynamicVersion
classpath 'io.fabric.tools:gradle:1.+'
}
}
apply plugin: 'com.android.application'
apply plugin: 'io.fabric'
repositories {
maven { url 'https://maven.fabric.io/public' }
}
android {
configurations.all {
@ -99,8 +84,4 @@ dependencies {
implementation 'io.reactivex.rxjava2:rxjava:2.1.0'
samsungImplementation project(":IAP5Helper")
implementation('com.crashlytics.sdk.android:crashlytics:2.8.0@aar') {
transitive = true
}
}

5
app/src/main/java/com/wbrawner/simplemarkdown/MarkdownApplication.java
View file

@ -1,8 +1,6 @@
package com.wbrawner.simplemarkdown;
import android.app.Application;
import com.crashlytics.android.Crashlytics;
import io.fabric.sdk.android.Fabric;
public class MarkdownApplication extends Application {
@ -11,9 +9,6 @@ public class MarkdownApplication extends Application {
@Override
public void onCreate() {
super.onCreate();
if (!BuildConfig.DEBUG) {
Fabric.with(this, new Crashlytics());
}
component = DaggerAppComponent.builder()
.appModule(new AppModule())
.build();

7
app/src/main/java/com/wbrawner/simplemarkdown/utility/MarkdownObserver.java
View file

@ -1,7 +1,5 @@
package com.wbrawner.simplemarkdown.utility;
import com.crashlytics.android.Crashlytics;
import com.wbrawner.simplemarkdown.BuildConfig;
import com.wbrawner.simplemarkdown.presentation.MarkdownPresenter;
import io.reactivex.Observable;
@ -31,10 +29,7 @@ public class MarkdownObserver implements Observer<String> {
public void onError(Throwable e) {
System.err.println("An error occurred while handling the markdown");
e.printStackTrace();
// TODO: Remove this once the error is confirmed to have disappeared
if (!BuildConfig.DEBUG) {
Crashlytics.logException(e);
}
// TODO: report this?
obs.subscribe(this);
}

5
app/src/main/java/com/wbrawner/simplemarkdown/utility/Utils.java
View file

@ -10,8 +10,6 @@ import android.os.HandlerThread;
import android.preference.PreferenceManager;
import android.support.v4.content.ContextCompat;
import com.crashlytics.android.Crashlytics;
import java.io.Closeable;
import java.io.File;
import java.io.IOException;
@ -104,7 +102,8 @@ public class Utils {
HandlerThread handlerThread = new HandlerThread(name);
handlerThread.start();
handlerThread.setUncaughtExceptionHandler((t, e) -> {
Crashlytics.logException(e);
// TODO: Report this?
// Crashlytics.logException(e);
t.interrupt();
});
return new Handler(handlerThread.getLooper());

12
app/src/main/java/com/wbrawner/simplemarkdown/view/activity/ExplorerActivity.java
View file

@ -15,7 +15,6 @@ import android.widget.EditText;
import android.widget.ListView;
import android.widget.SimpleAdapter;
import com.crashlytics.android.Crashlytics;
import com.wbrawner.simplemarkdown.R;
import com.wbrawner.simplemarkdown.utility.Constants;
import com.wbrawner.simplemarkdown.utility.Utils;
@ -120,11 +119,12 @@ public class ExplorerActivity extends AppCompatActivity {
} catch (NullPointerException e) {
updateListView();
menu.findItem(R.id.action_use_sdcard).setVisible(false);
Crashlytics.logException(e);
Crashlytics.log(mounts.length + " mounts found");
for (File mount : mounts) {
Crashlytics.log(mount.getAbsolutePath());
}
// TODO: Report this?
// Crashlytics.logException(e);
// Crashlytics.log(mounts.length + " mounts found");
// for (File mount : mounts) {
// Crashlytics.log(mount.getAbsolutePath());
// }
}
if (sdcardSelected) {
menu.findItem(R.id.action_use_sdcard).setChecked(true);

6
app/src/main/java/com/wbrawner/simplemarkdown/view/fragment/SettingsFragment.java
View file

@ -10,7 +10,6 @@ import android.preference.PreferenceManager;
import android.support.annotation.Nullable;
import android.util.Log;
import com.crashlytics.android.Crashlytics;
import com.wbrawner.simplemarkdown.R;
import com.wbrawner.simplemarkdown.utility.Constants;
import com.wbrawner.simplemarkdown.utility.Utils;
@ -62,8 +61,8 @@ public class SettingsFragment extends PreferenceFragment
try {
index = Integer.valueOf(storedValue);
} catch (NumberFormatException e) {
// TODO: Report this?
Log.e("SimpleMarkdown", "Unable to parse " + storedValue + " to integer");
Crashlytics.logException(e);
}
String summary = listPreference.getEntries()[index].toString();
preference.setSummary(summary);
@ -80,7 +79,8 @@ public class SettingsFragment extends PreferenceFragment
case Constants.REQUEST_ROOT_DIR:
File root = (File) data.getSerializableExtra(Constants.EXTRA_FILE);
if (root == null) {
Crashlytics.logException(new RuntimeException("Got null/empty response from setting default root dir"));
// TODO: Report this?
// Crashlytics.logException(new RuntimeException("Got null/empty response from setting default root dir"));
return;
}
Preference defaultRoot = findPreference(Constants.KEY_DOCS_PATH);