From e6786d20dc70460ccca1e3431f0da2693c0e21ac Mon Sep 17 00:00:00 2001
From: Ajesh <ajesh_nair@ymail.com>
Date: Sat, 4 Mar 2023 07:05:09 +0530
Subject: [PATCH] Make bookkeeper optional (#529)

Signed-off-by: Ajesh <ajesh_nair@ymail.com>
Co-authored-by: Ajesh <aj@Ajeshs-MacBook-Pro.local>
---
 .../store/store5/StoreBuilder.kt                       |  2 +-
 .../store/store5/impl/RealMutableStore.kt              | 10 +++++-----
 .../store/store5/impl/RealStoreBuilder.kt              |  2 +-
 .../store/store5/impl/extensions/store.kt              |  2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreBuilder.kt b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreBuilder.kt
index 2f2c763..da467d3 100644
--- a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreBuilder.kt
+++ b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/StoreBuilder.kt
@@ -27,7 +27,7 @@ interface StoreBuilder<Key : Any, Network : Any, Output : Any, Local : Any> {
 
     fun <Response : Any> build(
         updater: Updater<Key, Output, Response>,
-        bookkeeper: Bookkeeper<Key>
+        bookkeeper: Bookkeeper<Key>? = null
     ): MutableStore<Key, Output>
 
     /**
diff --git a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealMutableStore.kt b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealMutableStore.kt
index 1494f05..8c1b714 100644
--- a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealMutableStore.kt
+++ b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealMutableStore.kt
@@ -30,7 +30,7 @@ import org.mobilenativefoundation.store.store5.internal.result.EagerConflictReso
 internal class RealMutableStore<Key : Any, Network : Any, Output : Any, Local : Any>(
     private val delegate: RealStore<Key, Network, Output, Local>,
     private val updater: Updater<Key, Output, *>,
-    private val bookkeeper: Bookkeeper<Key>,
+    private val bookkeeper: Bookkeeper<Key>?,
 ) : MutableStore<Key, Output>, Clear.Key<Key> by delegate, Clear.All by delegate {
 
     private val storeLock = Mutex()
@@ -107,9 +107,9 @@ internal class RealMutableStore<Key : Any, Network : Any, Output : Any, Local :
                 created = request.created,
                 updaterResult = updaterResult
             )
-            bookkeeper.clear(request.key)
+            bookkeeper?.clear(request.key)
         } else {
-            bookkeeper.setLastFailedSync(request.key)
+            bookkeeper?.setLastFailedSync(request.key)
         }
 
         return updaterResult
@@ -199,7 +199,7 @@ internal class RealMutableStore<Key : Any, Network : Any, Output : Any, Local :
     }
 
     private suspend fun conflictsMightExist(key: Key): Boolean {
-        val lastFailedSync = bookkeeper.getLastFailedSync(key)
+        val lastFailedSync = bookkeeper?.getLastFailedSync(key)
         return lastFailedSync != null || writeRequestsQueueIsEmpty(key).not()
     }
 
@@ -215,7 +215,7 @@ internal class RealMutableStore<Key : Any, Network : Any, Output : Any, Local :
         withThreadSafety(key) {
             val latest = delegate.latestOrNull(key)
             when {
-                latest == null || conflictsMightExist(key).not() -> EagerConflictResolutionResult.Success.NoConflicts
+                latest == null || bookkeeper == null || conflictsMightExist(key).not() -> EagerConflictResolutionResult.Success.NoConflicts
                 else -> {
                     try {
                         val updaterResult = updater.post(key, latest).also { updaterResult ->
diff --git a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStoreBuilder.kt b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStoreBuilder.kt
index 71ad56c..e0cdbc8 100644
--- a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStoreBuilder.kt
+++ b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/RealStoreBuilder.kt
@@ -70,7 +70,7 @@ internal class RealStoreBuilder<Key : Any, Network : Any, Output : Any, Local :
 
     override fun <UpdaterResult : Any> build(
         updater: Updater<Key, Output, UpdaterResult>,
-        bookkeeper: Bookkeeper<Key>
+        bookkeeper: Bookkeeper<Key>?
     ): MutableStore<Key, Output> =
         build().asMutableStore<Key, Network, Output, Local, UpdaterResult>(
             updater = updater,
diff --git a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/extensions/store.kt b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/extensions/store.kt
index 097b95c..29f4198 100644
--- a/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/extensions/store.kt
+++ b/store/src/commonMain/kotlin/org/mobilenativefoundation/store/store5/impl/extensions/store.kt
@@ -38,7 +38,7 @@ suspend fun <Key : Any, Output : Any> Store<Key, Output>.fresh(key: Key) =
 @Suppress("UNCHECKED_CAST")
 fun <Key : Any, Network : Any, Output : Any, Local : Any, Response : Any> Store<Key, Output>.asMutableStore(
     updater: Updater<Key, Output, Response>,
-    bookkeeper: Bookkeeper<Key>
+    bookkeeper: Bookkeeper<Key>?
 ): MutableStore<Key, Output> {
     val delegate = this as? RealStore<Key, Network, Output, Local>
         ?: throw Exception("MutableStore requires Store to be built using StoreBuilder")