Resolved #1405 - upgrading Spearman to Landsknecht no longer gives you gold

core/src/com/unciv/logic/city/CityInfo.kt

@@ -326,6 +326,7 @@ class CityInfo {
         }
 
         isPuppet=false
+        cityConstructions.inProgressConstructions.clear() // undo all progress of the previous civ on units etc.
         cityStats.update()
         UncivGame.Current.worldScreen.shouldUpdate=true
     }

core/src/com/unciv/logic/map/MapUnit.kt

@@ -238,6 +238,7 @@ class MapUnit {
             goldCostOfUpgrade = (goldCostOfUpgrade * 0.66f).toInt()
         if(civInfo.containsBuildingUnique("Gold cost of upgrading military units reduced by 33%"))
             goldCostOfUpgrade = (goldCostOfUpgrade * 0.66f).toInt()
+        if(goldCostOfUpgrade<0) return 0 // For instance, Landsknecht costs less than Spearman, so upgrading would cost negative gold
         return goldCostOfUpgrade
     }