ansible/test/utils/shippable/code-smell.sh

#!/bin/bash -eux

source_root=$(python -c "from os import path; print(path.abspath(path.join(path.dirname('$0'), '../../..')))")

install_deps="${INSTALL_DEPS:-}"

cd "${source_root}"

if [ "${install_deps}" != "" ]; then
    apt-add-repository 'deb http://archive.ubuntu.com/ubuntu trusty-backports universe'
    apt-get update -qq
    apt-get install shellcheck

    pip install -r "${source_root}/test/utils/shippable/code-smell-requirements.txt" --upgrade
    pip list
fi

yamllint ./test

test/sanity/code-smell/replace-urlopen.sh
test/sanity/code-smell/use-compat-six.sh
test/sanity/code-smell/boilerplate.sh
test/sanity/code-smell/required-and-default-attributes.sh
test/sanity/code-smell/shebang.sh
test/sanity/code-smell/line-endings.sh
test/sanity/code-smell/empty-init.sh
test/sanity/code-smell/no-basestring.sh

shellcheck \
    test/integration/targets/*/*.sh \
    test/utils/shippable/*.sh
Add full support for Shippable CI. 2016-06-02 04:08:14 +00:00			`#!/bin/bash -eux`

			`source_root=$(python -c "from os import path; print(path.abspath(path.join(path.dirname('$0'), '../../..')))")`

Fix YAML source and check it on Shippable (#15678) Fix YAML source and check it on Shippable 2016-06-04 17:58:17 +00:00			`install_deps="${INSTALL_DEPS:-}"`

Add full support for Shippable CI. 2016-06-02 04:08:14 +00:00			`cd "${source_root}"`

Fix YAML source and check it on Shippable (#15678) Fix YAML source and check it on Shippable 2016-06-04 17:58:17 +00:00			`if [ "${install_deps}" != "" ]; then`
Add shellcheck to code-smell checks. (#17715) 2016-09-22 23:12:10 +00:00			`apt-add-repository 'deb http://archive.ubuntu.com/ubuntu trusty-backports universe'`
			`apt-get update -qq`
			`apt-get install shellcheck`

Pin yamllint to 1.2.2 to avoid issues in 1.3.0. (#16464) This also moves shippable test requirements to external files. 2016-06-27 23:34:19 +00:00			`pip install -r "${source_root}/test/utils/shippable/code-smell-requirements.txt" --upgrade`
			`pip list`
Fix YAML source and check it on Shippable (#15678) Fix YAML source and check it on Shippable 2016-06-04 17:58:17 +00:00			`fi`

Lint YAML files under test/ This commit extends YAML linting by enabling standard rules from the `yamllint` tool [1]. Since syntax errors and key duplicates are already checked since 4d48711, this change only adds detection for cosmetic problems. It also narrows checks to the test/ dir only. The main goal is to prevent future problems to enter the code base without being noticed. While it would be a huge effort to be PEP8 compliant, it is relatively easy to have correct YAML style now and prevent future errors by enabling linting. Note: for those (like me) caring about code attribution: use `git blame -w` to ignore whitespace-only changes. Note: I disabled some linting checks (such as indentation), they can be enforced in the future if needed. Similarly, current checks can also be disabled. See the `.yamllint` file. [1]: https://yamllint.readthedocs.io/ 2016-04-18 15:25:39 +00:00			`yamllint ./test`

Clean up code-smell sanity scripts. (#18407) - Replace find ';' with '+' for faster execution. - Replace grep -R with -r to avoid recursive warnings. - Exclude .git and .tox directories from recursive grep. - Improve messaging on failed sanity checks. - Add no-basestring check to Shippable. 2016-11-08 00:46:33 +00:00			`test/sanity/code-smell/replace-urlopen.sh`
			`test/sanity/code-smell/use-compat-six.sh`
Test reorganization and cleanup. (#18270) - Correct directory name in test/README.md - Move code-smell tests to test/sanity/code-smell - Update code-smell.sh to use new script paths - Add test/integration/target-prefixes.win for ansible-test - Move module unit tests to match module directory layout 2016-10-31 19:53:11 +00:00			`test/sanity/code-smell/boilerplate.sh`
			`test/sanity/code-smell/required-and-default-attributes.sh`
Clean up shebangs for various files. - Remove shebangs from: - ini files - unit tests - module_utils - plugins - module_docs_fragments - non-executable Makefiles - Change non-modules from '/usr/bin/python' to '/usr/bin/env python'. - Change '/bin/env' to '/usr/bin/env'. Also removed main functions from unit tests (since they no longer have a shebang) and fixed a python 3 compatibility issue with update_bundled.py so it does not need to specify a python 2 shebang. A script was added to check for unexpected shebangs in files. This script is run during CI on Shippable. 2016-11-02 21:47:42 +00:00			`test/sanity/code-smell/shebang.sh`
Fix and create code-smell test for line endings. 2016-11-03 21:33:17 +00:00			`test/sanity/code-smell/line-endings.sh`
Add empty-init code-smell script. (#18406) Also removed boilerplate from otherwise empty __init__.py files which should not contain any code (checked by empty-init script). 2016-11-07 23:02:13 +00:00			`test/sanity/code-smell/empty-init.sh`
Clean up code-smell sanity scripts. (#18407) - Replace find ';' with '+' for faster execution. - Replace grep -R with -r to avoid recursive warnings. - Exclude .git and .tox directories from recursive grep. - Improve messaging on failed sanity checks. - Add no-basestring check to Shippable. 2016-11-08 00:46:33 +00:00			`test/sanity/code-smell/no-basestring.sh`
Add shellcheck to code-smell checks. (#17715) 2016-09-22 23:12:10 +00:00
			`shellcheck \`
Split integration tests out from Makefile. (#17976) 2016-10-12 21:57:53 +00:00			`test/integration/targets//.sh \`
Add shellcheck to code-smell checks. (#17715) 2016-09-22 23:12:10 +00:00			`test/utils/shippable/*.sh`