Change the retry_files_enabled to False and modify the comments to reflect that this has been disabled (#52581)

* Change the retry_files_enabled to False and modify the comments to reflect that
this has been disabled.

* Change the default action of retry_files_enabled to False

* Update porting guide to reflect change in default state of retry_files_enabled variable

* Change log documenting a change in default behaviour of retry_files_enabled

* Revert config change to comment out the retry_files_enabled line to let the user decided what is best.
Comment above still states how to change.

changelogs/fragments/52581-change-default-behaviour-of-retry_files_enabled.yaml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+  - retry_files_enabled now defaults to False instead of True.

docs/docsite/rst/porting_guides/porting_guide_2.8.rst

@@ -141,6 +141,12 @@ options:
   #. Use ``auto_legacy``. This setting lets Ansible find and use the workaround Python on hosts that have it, while also finding the correct default Python on newer hosts. But remember, the default will change in 4 releases.
 
 
+Retry File Creation default
+---------------------------
+
+In Ansible 2.8, ``retry_files_enabled`` now defaults to ``False`` instead of ``True``.  The behavior can be
+modified to previous version by editing the default ``ansible.cfg`` file and setting the value to ``True``.
+
 Command Line
 ============
 

examples/ansible.cfg

@@ -251,8 +251,8 @@
 
 
 # retry files
-# When a playbook fails by default a .retry file will be created in ~/
-# You can disable this feature by setting retry_files_enabled to False
+# When a playbook fails a .retry file can be created that will be placed in ~/
+# You can enable this feature by setting retry_files_enabled to True
 # and you can change the location of the files by setting retry_files_save_path
 
 #retry_files_enabled = False

lib/ansible/config/base.yml

@@ -1663,7 +1663,7 @@ PYTHON_MODULE_RLIMIT_NOFILE:
   version_added: '2.8'
 RETRY_FILES_ENABLED:
   name: Retry files
-  default: True
+  default: False
   description: This controls whether a failed Ansible playbook should create a .retry file.
   env: [{name: ANSIBLE_RETRY_FILES_ENABLED}]
   ini: