wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix orphan resource pool crash (Issue #24078) (#24079)

Browse source 
Fixes issue [#24078](https://github.com/ansible/ansible/issues/24078)

Resource pools are retrieved from VSphere regardless of the state of the `resource_pool` parameter. During this process, each retrieved Resource Pool is checked for the `parent` attribute, and if it exists, the currently-scoped parent object is compared against the Resource Pool's parent object. The method doing the check, however, `assert`s that the parent object is not `None`. In some cases, a Resource Pool will have the `parent` attr, but that `parent` object will be `None`, causing the `assert` to fail.

This should avoid that. :-)
This commit is contained in:
Cody Boggs 2017-04-28 14:14:05 -05:00 committed by jctanner
parent f9ec06d1dc
commit 1c11a35f70
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/modules/cloud/vmware/vmware_guest.py
View file

@ -1011,7 +1011,7 @@ class PyVmomiHelper(object):
if not rp[0]:
continue
if not hasattr(rp[0], 'parent'):
if not hasattr(rp[0], 'parent') or not rp[0].parent:
continue
# Find resource pool on host