wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor firewalld module with object abstraction (#26487)

Browse source 
* refactor firewalld module with object abstraction

This change creates a FirewallTransaction object that each
individual transaction type is a sub-class of as they all follow the
same pattern to enable or disable something in the firewall.

Also, there's a few bugfixes here:
    - Fix the "source" type to handle permanent operations
    - Remove ambiguity of required parameters for only specific use
      cases that can lead to transactions effectively being a no-op.
      Instead, pick sane defaults and document them.
    - Change how imports are done so globals are no longer needed

This is based on the original feedback by Toshio from the last
refactor attempt:

    https://github.com/ansible/ansible-modules-extras/pull/3383

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* fix line too long for pep8 for shippable tests

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* remove firewalld from pep8/legacy-files

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

(cherry picked from commit 75127092f2)
This commit is contained in:
Adam Miller 2017-09-11 14:10:07 -07:00 committed by Toshio Kuratomi
parent 34db3cd9be
commit 1c7a91a725
2 changed files with 675 additions and 806 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1480
lib/ansible/modules/system/firewalld.py
View file

File diff suppressed because it is too large Load diff

1
test/sanity/pep8/legacy-files.txt
View file

@ -426,7 +426,6 @@ lib/ansible/modules/system/crypttab.py
lib/ansible/modules/system/debconf.py
lib/ansible/modules/system/facter.py
lib/ansible/modules/system/filesystem.py
lib/ansible/modules/system/firewalld.py
lib/ansible/modules/system/gconftool2.py
lib/ansible/modules/system/getent.py
lib/ansible/modules/system/gluster_volume.py