wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cloudstack: fix has_changed dict values comparsion (#17632)

Browse source 
In some rare situations, the CloudStack API returns string for numbers
when we expected int.

With this fix, we ensure we compare the types expected.
This commit is contained in:
René Moser 2016-09-19 14:02:29 +02:00 committed by Rene Moser
parent 7bfa36eb8b
commit 27c621950c
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/ansible/module_utils/cloudstack.py
View file

@ -157,7 +157,17 @@ class AnsibleCloudStack(object):
continue
if key in current_dict:
if isinstance(current_dict[key], (int, long, float, complex)):
if isinstance(value, (int, float, long, complex)):
# ensure we compare the same type
if isinstance(value, int):
current_dict[key] = int(current_dict[key])
elif isinstance(value, float):
current_dict[key] = float(current_dict[key])
elif isinstance(value, long):
current_dict[key] = long(current_dict[key])
elif isinstance(value, complex):
current_dict[key] = complex(current_dict[key])
if value != current_dict[key]:
return True
else: