From 3bd71d06195cdce01a85257545723e221f9c9698 Mon Sep 17 00:00:00 2001
From: James Cammarata <jimi@sngx.net>
Date: Wed, 30 Sep 2015 09:27:29 -0400
Subject: [PATCH] Use delegated_to field for play context remote_addr, if none
 other exists

Fixes #12527
---
 lib/ansible/playbook/play_context.py | 17 +++++++++++++++++
 lib/ansible/vars/__init__.py         |  1 +
 2 files changed, 18 insertions(+)

diff --git a/lib/ansible/playbook/play_context.py b/lib/ansible/playbook/play_context.py
index 5c0c1a8735..2da61f2d59 100644
--- a/lib/ansible/playbook/play_context.py
+++ b/lib/ansible/playbook/play_context.py
@@ -39,6 +39,13 @@ from ansible.utils.unicode import to_unicode
 
 __all__ = ['PlayContext']
 
+try:
+    from __main__ import display
+    display = display
+except ImportError:
+    from ansible.utils.display import Display
+    display = Display()
+
 # the magic variable mapping dictionary below is used to translate
 # host/inventory variables to fields in the PlayContext
 # object. The dictionary values are tuples, to account for aliases
@@ -296,6 +303,16 @@ class PlayContext(Base):
             # the host name in the delegated variable dictionary here
             delegated_host_name = templar.template(task.delegate_to)
             delegated_vars = variables.get('ansible_delegated_vars', dict()).get(delegated_host_name, dict())
+            # make sure this delegated_to host has something set for its remote
+            # address, otherwise we default to connecting to it by name. This
+            # may happen when users put an IP entry into their inventory, or if
+            # they rely on DNS for a non-inventory hostname
+            for address_var in MAGIC_VARIABLE_MAPPING.get('remote_addr'):
+                if address_var in delegated_vars:
+                    break
+            else:
+                display.warning("no remote address found for delegated host %s, using its name by default" % delegated_host_name)
+                delegated_vars['ansible_host'] = delegated_host_name
         else:
             delegated_vars = dict()
 
diff --git a/lib/ansible/vars/__init__.py b/lib/ansible/vars/__init__.py
index 52983557c7..e313a2bcf1 100644
--- a/lib/ansible/vars/__init__.py
+++ b/lib/ansible/vars/__init__.py
@@ -407,6 +407,7 @@ class VariableManager:
                         include_delegate_to=False,
                         include_hostvars=False,
                     )
+
                 all_vars['ansible_delegated_vars'] = delegated_host_vars
 
         if self._inventory is not None: