wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

iam_policy: Make 'iam_name' a required option to match the documentation (#65559)

Browse source 
Without it we'd always throw a boto error
This commit is contained in:
Mark Chappell 2019-12-09 10:38:43 +01:00 committed by Abhijit Menon-Sen
parent 4919d5658a
commit 5c9539903e
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/65559-iam_policy-require-iam_name.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- iam_policy - make `iam_name` a required field.

2
lib/ansible/modules/cloud/amazon/iam_policy.py
View file

@ -292,7 +292,7 @@ def main():
argument_spec = dict( argument_spec = dict(
iam_type=dict(required=True, choices=['user', 'group', 'role']), iam_type=dict(required=True, choices=['user', 'group', 'role']),
state=dict(default='present', choices=['present', 'absent']), state=dict(default='present', choices=['present', 'absent']),
iam_name=dict(default=None, required=False), iam_name=dict(required=True),
policy_name=dict(required=True), policy_name=dict(required=True),
policy_document=dict(default=None, required=False), policy_document=dict(default=None, required=False),
policy_json=dict(type='json', default=None, required=False), policy_json=dict(type='json', default=None, required=False),

1
test/sanity/ignore.txt
View file

@ -492,7 +492,6 @@ lib/ansible/modules/cloud/alicloud/ali_instance.py validate-modules:parameter-ty
lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-missing-type lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-missing-type
lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:doc-required-mismatch
lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:parameter-type-not-in-doc lib/ansible/modules/cloud/alicloud/ali_instance_info.py validate-modules:parameter-type-not-in-doc
lib/ansible/modules/cloud/amazon/iam_policy.py validate-modules:doc-required-mismatch
lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:doc-missing-type lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:doc-missing-type
lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:doc-required-mismatch lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:doc-required-mismatch
lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:no-default-for-required-parameter lib/ansible/modules/cloud/atomic/atomic_container.py validate-modules:no-default-for-required-parameter