wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change wording of Going Further section (#35949) (#36032)

Browse source 
* Change wording of Going Further section

The original wording was confusing with its non-devel branch part.
Made it much clearer for people to understand what to do.

Also removed the git command for creating branches, I believe a
develop should be aware of how basic git commands work.

(cherry picked from commit d5ae63c0ea)
This commit is contained in:
John R Barker 2018-02-12 10:54:06 +00:00 committed by GitHub
parent 1b9dde7c29
commit 72ad157b07
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
docs/docsite/rst/dev_guide/developing_modules_general.rst
View file

@ -291,15 +291,15 @@ test/units/modules/.../test/my_new_test_module.py``
Going Further
=============
If you are starting new development or fixing a bug, create a new branch:
If you would like to contribute to the main Ansible repository
by adding a new feature or fixing a bug, `create a fork <https://help.github.com/articles/fork-a-repo/>`_
of the Ansible repository and develop against a new feature
branch using the ``devel`` branch as a starting point.
``$ git checkout -b my-new-branch``.
If you are planning on contributing
back to the main Ansible repository, fork the Ansible repository into
your own GitHub account and develop against the new non-devel branch
in your fork. When you believe you have a good working code change,
submit a pull request to the Ansible repository.
When you you have a good working code change,
submit a pull request to the Ansible repository by selecting
your feature branch as a source and the Ansible devel branch as
a target.
If you want to submit a new module to the upstream Ansible repo, be sure
to run through sanity checks first. For example: