wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

match interpreter on stdout also (#49446)

Browse source 
fixes #46980
This commit is contained in:
Brian Coca 2018-12-10 11:43:30 -05:00 committed by GitHub
parent e53a7856f6
commit 758ac1846b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/detect_interpreter_stdout.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- Also check stdout for interpreter errors for more intelligent messages to user

14
lib/ansible/plugins/action/__init__.py
View file

@ -918,12 +918,16 @@ class ActionBase(with_metaclass(ABCMeta, object)):
if res['stderr'].startswith(u'Traceback'):
data['exception'] = res['stderr']
# try to figure out if we are missing interpreter
if self._used_interpreter is not None and '%s: No such file or directory' % self._used_interpreter.lstrip('!#') in data['module_stderr']:
data['msg'] = "The module failed to execute correctly, you probably need to set the interpreter."
else:
data['msg'] = "MODULE FAILURE"
# The default
data['msg'] = "MODULE FAILURE"
# try to figure out if we are missing interpreter
if self._used_interpreter is not None:
match = '%s: No such file or directory' % self._used_interpreter.lstrip('!#')
if match in data['module_stderr'] or match in data['module_stdout']:
data['msg'] = "The module failed to execute correctly, you probably need to set the interpreter."
# always append hint
data['msg'] += '\nSee stdout/stderr for the exact error'
if 'rc' in res: