From 7f2ba1aaf8634b594cc9c86a55027277deaab3c3 Mon Sep 17 00:00:00 2001
From: Matt Clay <matt@mystile.com>
Date: Fri, 13 Sep 2019 19:21:54 -0700
Subject: [PATCH] [stable-2.9] Fix display of sanity test doc links.

The documentation links are now displayed when running from an install.

Previously the links were only displayed when running from source.
This was due to ansible-test checking for the presence of documentation files locally, which are only present when running from source.
The check is no longer necessary since there is a sanity test in place to enforce the presence of documentation for all sanity tests.
(cherry picked from commit 32d965e)

Co-authored-by: Matt Clay <matt@mystile.com>
---
 changelogs/fragments/ansible-test-doc-links.yml |  2 ++
 test/lib/ansible_test/_internal/test.py         | 10 +++-------
 2 files changed, 5 insertions(+), 7 deletions(-)
 create mode 100644 changelogs/fragments/ansible-test-doc-links.yml

diff --git a/changelogs/fragments/ansible-test-doc-links.yml b/changelogs/fragments/ansible-test-doc-links.yml
new file mode 100644
index 0000000000..6a86175f36
--- /dev/null
+++ b/changelogs/fragments/ansible-test-doc-links.yml
@@ -0,0 +1,2 @@
+bugfixes:
+    - ansible-test now shows sanity test doc links when installed (previously the links were only visible when running from source)
diff --git a/test/lib/ansible_test/_internal/test.py b/test/lib/ansible_test/_internal/test.py
index e31a6f0dc2..e1ef4f3bf8 100644
--- a/test/lib/ansible_test/_internal/test.py
+++ b/test/lib/ansible_test/_internal/test.py
@@ -364,6 +364,8 @@ class TestFailure(TestResult):
         """
         :rtype: str
         """
+        if self.command != 'sanity':
+            return None  # only sanity tests have docs links
 
         # Use the major.minor version for the URL only if this a release that
         # matches the pattern 2.4.0, otherwise, use 'devel'
@@ -373,19 +375,13 @@ class TestFailure(TestResult):
             url_version = '.'.join(ansible_version.split('.')[:2])
 
         testing_docs_url = 'https://docs.ansible.com/ansible/%s/dev_guide/testing' % url_version
-        testing_docs_dir = 'docs/docsite/rst/dev_guide/testing'
 
         url = '%s/%s/' % (testing_docs_url, self.command)
-        path = os.path.join(testing_docs_dir, self.command)
 
         if self.test:
             url += '%s.html' % self.test
-            path = os.path.join(path, '%s.rst' % self.test)
 
-        if os.path.exists(path):
-            return url
-
-        return None
+        return url
 
     def format_title(self, help_link=None):
         """