wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[2.8] VMware: Handle VMs with no configurations

Browse source 
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 7505550500)
This commit is contained in:
Abhijeet Kasurde 2019-04-30 19:43:07 +05:30 committed by Toshio Kuratomi
parent dfc47bd6d6
commit 91b703b0f0
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/55929-vmware_vm_inventory-skip_orphan_vm.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- Skip orphan VMs from inventory while running vmware_vm_inventory as VMs does not return any facts (https://github.com/ansible/ansible/pull/55929).

4
lib/ansible/plugins/inventory/vmware_vm_inventory.py
View file

@ -411,6 +411,10 @@ class InventoryModule(BaseInventoryPlugin, Cacheable):
# VMware does not provide a way to uniquely identify VM by its name # VMware does not provide a way to uniquely identify VM by its name
# i.e. there can be two virtual machines with same name # i.e. there can be two virtual machines with same name
# Appending "_" and VMware UUID to make it unique # Appending "_" and VMware UUID to make it unique
if not vm_obj.obj.config:
# Sometime orphaned VMs return no configurations
continue
current_host = vm_obj_property.val + "_" + vm_obj.obj.config.uuid current_host = vm_obj_property.val + "_" + vm_obj.obj.config.uuid
if current_host not in hostvars: if current_host not in hostvars: