wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

paramiko_ssh: fix crash upon pass prompt in py3

Browse source 
The pass prompt expects an answer and compares a `str` to a binary buffer, thus crashing.

It's an obvious fix to help transitioning towards Python3 and hopes it does not need a specific test.
(cherry picked from commit bc44175d8d)
This commit is contained in:
Victor Perron 2017-03-29 15:02:28 +02:00 committed by Toshio Kuratomi
parent 2273800f7c
commit 972660968a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/plugins/connection/paramiko_ssh.py
View file

@ -291,7 +291,7 @@ class Connection(ConnectionBase):
chunk = chan.recv(bufsize) chunk = chan.recv(bufsize)
display.debug("chunk is: %s" % chunk) display.debug("chunk is: %s" % chunk)
if not chunk: if not chunk:
if 'unknown user' in become_output: if b'unknown user' in become_output:
raise AnsibleError( 'user %s does not exist' % self._play_context.become_user) raise AnsibleError( 'user %s does not exist' % self._play_context.become_user)
else: else:
break break