From 993da476a0b86b55e358e523c8b6429d0c5a6d4f Mon Sep 17 00:00:00 2001 From: Pierre-Louis Bonicoli Date: Mon, 12 Jan 2015 18:52:25 +0100 Subject: [PATCH] Avoid to use the builtin 'echo' By default, the interpretation of escape characters could be disabled (bash) or enabled (dash). --- lib/ansible/modules/extras/system/debconf.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/ansible/modules/extras/system/debconf.py b/lib/ansible/modules/extras/system/debconf.py index 592c2c865c..b5af4744d5 100644 --- a/lib/ansible/modules/extras/system/debconf.py +++ b/lib/ansible/modules/extras/system/debconf.py @@ -86,8 +86,6 @@ debconf: name='oracle-java7-installer' question='shared/accepted-oracle-license- debconf: name='tzdata' ''' -import pipes - def get_selections(module, pkg): cmd = [module.get_bin_path('debconf-show', True), pkg] rc, out, err = module.run_command(' '.join(cmd)) @@ -106,14 +104,14 @@ def get_selections(module, pkg): def set_selection(module, pkg, question, vtype, value, unseen): - data = ' '.join([ question, vtype, value ]) - setsel = module.get_bin_path('debconf-set-selections', True) - cmd = ["echo %s %s |" % (pipes.quote(pkg), pipes.quote(data)), setsel] + cmd = [setsel] if unseen: cmd.append('-u') - return module.run_command(' '.join(cmd), use_unsafe_shell=True) + data = ' '.join([pkg, question, vtype, value]) + + return module.run_command(cmd, data=data) def main():