From b127221f503b43af4af5cf5e7eb8b9ec80ecf173 Mon Sep 17 00:00:00 2001 From: Abhijit Menon-Sen Date: Fri, 2 Oct 2015 20:04:01 +0530 Subject: [PATCH] Pass default None to getattr, remove repeated call --- lib/ansible/plugins/connection/ssh.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ansible/plugins/connection/ssh.py b/lib/ansible/plugins/connection/ssh.py index 10e96ae039..29648b591a 100644 --- a/lib/ansible/plugins/connection/ssh.py +++ b/lib/ansible/plugins/connection/ssh.py @@ -204,8 +204,9 @@ class Connection(ConnectionBase): # (i.e. inventory or task settings or overrides on the command line). for opt in ['ssh_common_args', binary + '_extra_args']: - if getattr(self._play_context, opt): - args = self._split_args(getattr(self._play_context, opt)) + attr = getattr(self._play_context, opt, None) + if attr is not None: + args = self._split_args(attr) self._add_args("PlayContext set %s" % opt, args) # Check if ControlPersist is enabled and add a ControlPath if one hasn't