From b2f1993b20615d24669fd35d8c2f8a9188931029 Mon Sep 17 00:00:00 2001
From: Alexandre Mulatinho <alex@mulatinho.net>
Date: Wed, 14 Aug 2019 07:08:06 -0300
Subject: [PATCH] FreeIPA: Add dynamic update to zones in IPA (#59489)

This feature add a new option to `ipa_dnszone` called
**dynamicupdate** as requested by issue #46768.

It allow user to change between default option `false`
to `true` if user/sysadmin wishes to make zone dynamically
updated.

Fixes #46768

Signed-off-by: Alexandre Mulatinho <alex@mulatinho.net>
---
 .../modules/identity/ipa/ipa_dnszone.py       | 32 ++++++++++++++++---
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/lib/ansible/modules/identity/ipa/ipa_dnszone.py b/lib/ansible/modules/identity/ipa/ipa_dnszone.py
index 483147a619..f5a1bd45fb 100644
--- a/lib/ansible/modules/identity/ipa/ipa_dnszone.py
+++ b/lib/ansible/modules/identity/ipa/ipa_dnszone.py
@@ -29,6 +29,12 @@ options:
     required: false
     default: present
     choices: ["present", "absent"]
+  dynamicupdate:
+    description: Apply dynamic update to zone
+    required: false
+    default: "false"
+    choices: ["false", "true"]
+    version_added: "2.9"
 extends_documentation_fragment: ipa.documentation
 version_added: "2.5"
 '''
@@ -41,6 +47,14 @@ EXAMPLES = '''
     state: present
     zone_name: example.com
 
+# Ensure dns zone is present and is dynamic update
+- ipa_dnszone:
+    ipa_host: spider.example.com
+    ipa_pass: Passw0rd!
+    state: present
+    zone_name: example.com
+    dynamicupdate: true
+
 # Ensure that dns zone is removed
 - ipa_dnszone:
     zone_name: example.com
@@ -66,18 +80,26 @@ class DNSZoneIPAClient(IPAClient):
     def __init__(self, module, host, port, protocol):
         super(DNSZoneIPAClient, self).__init__(module, host, port, protocol)
 
-    def dnszone_find(self, zone_name):
+    def dnszone_find(self, zone_name, details=None):
+        itens = {'idnsname': zone_name}
+        if details is not None:
+            itens.update(details)
+
         return self._post_json(
             method='dnszone_find',
             name=zone_name,
-            item={'idnsname': zone_name}
+            item=itens
         )
 
     def dnszone_add(self, zone_name=None, details=None):
+        itens = {}
+        if details is not None:
+            itens.update(details)
+
         return self._post_json(
             method='dnszone_add',
             name=zone_name,
-            item={}
+            item=itens
         )
 
     def dnszone_del(self, zone_name=None, record_name=None, details=None):
@@ -88,6 +110,7 @@ class DNSZoneIPAClient(IPAClient):
 def ensure(module, client):
     zone_name = module.params['zone_name']
     state = module.params['state']
+    dynamicupdate = module.params['dynamicupdate']
 
     ipa_dnszone = client.dnszone_find(zone_name)
 
@@ -96,7 +119,7 @@ def ensure(module, client):
         if not ipa_dnszone:
             changed = True
             if not module.check_mode:
-                client.dnszone_add(zone_name=zone_name)
+                client.dnszone_add(zone_name=zone_name, details={'idnsallowdynupdate': dynamicupdate})
         else:
             changed = False
     else:
@@ -112,6 +135,7 @@ def main():
     argument_spec = ipa_argument_spec()
     argument_spec.update(zone_name=dict(type='str', required=True),
                          state=dict(type='str', default='present', choices=['present', 'absent']),
+                         dynamicupdate=dict(type='str', required=False, default='false', choices=['true', 'false']),
                          )
 
     module = AnsibleModule(argument_spec=argument_spec,