From cb70fbc9d104cae2433b3a6eccc719718d7c2b63 Mon Sep 17 00:00:00 2001 From: anatoly techtonik Date: Thu, 9 Oct 2014 18:58:03 +0300 Subject: [PATCH] composer: Fix `changed` status that always returns False re.match in has_changed function never worked properly, because match requires searched sequence to be present exactly at a start of processed string, which is not the case here. --- lib/ansible/modules/extras/packaging/composer.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ansible/modules/extras/packaging/composer.py b/lib/ansible/modules/extras/packaging/composer.py index 2930018bd9..c94d3ecb7e 100644 --- a/lib/ansible/modules/extras/packaging/composer.py +++ b/lib/ansible/modules/extras/packaging/composer.py @@ -101,7 +101,10 @@ def parse_out(string): return re.sub("\s+", " ", string).strip() def has_changed(string): - return (re.match("Nothing to install or update", string) != None) + if "Nothing to install or update" in string: + return False + else: + return True def composer_install(module, command, options): php_path = module.get_bin_path("php", True, ["/usr/local/bin"])