wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cloudstack: cs_account re-factor error handling state=present

Browse source
This commit is contained in:
Rene Moser 2015-09-11 19:04:41 +02:00 committed by Matt Clay
parent f84b40e542
commit cd39bdd11d
1 changed files with 10 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
lib/ansible/modules/extras/cloud/cloudstack/cs_account.py
View file

@ -277,21 +277,16 @@ class AnsibleCloudStackAccount(AnsibleCloudStack):
def present_account(self): def present_account(self):
missing_params = [] missing_params = []
if not self.module.params.get('email'): missing_params = []
missing_params.append('email') for required_params in [
'email',
if not self.module.params.get('username'): 'username',
missing_params.append('username') 'password',
'first_name',
if not self.module.params.get('password'): 'last_name',
missing_params.append('password') ]:
if not self.module.params.get(required_params):
if not self.module.params.get('first_name'): missing_params.append(required_params)
missing_params.append('first_name')
if not self.module.params.get('last_name'):
missing_params.append('last_name')
if missing_params: if missing_params:
self.module.fail_json(msg="missing required arguments: %s" % ','.join(missing_params)) self.module.fail_json(msg="missing required arguments: %s" % ','.join(missing_params))