wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Minor typo and PEP8 fixes for dnf module (#23845)

Browse source 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
This commit is contained in:
Abhijeet Kasurde 2017-04-26 17:27:49 +05:30 committed by John R Barker
parent 9fbbb5e10f
commit d16fe5bef3
2 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/ansible/modules/packaging/os/dnf.py
View file

@ -288,7 +288,7 @@ def _mark_package_install(module, base, pkg_spec):
try:
base.install(pkg_spec)
except dnf.exceptions.MarkingError:
module.fail_json(msg="No package {} available.".format(pkg_spec))
module.fail_json(msg="No package {0} available.".format(pkg_spec))
def _parse_spec_group_file(names):
@ -340,7 +340,7 @@ def ensure(module, base, state, names):
environments.append(environment.id)
else:
module.fail_json(
msg="No group {} available.".format(group_spec))
msg="No group {0} available.".format(group_spec))
if state in ['installed', 'present']:
# Install files.
@ -409,7 +409,7 @@ def ensure(module, base, state, names):
# Group is already uninstalled.
pass
for envioronment in environments:
for environment in environments:
try:
base.environment_remove(environment)
except dnf.exceptions.CompsError:
@ -427,13 +427,15 @@ def ensure(module, base, state, names):
if not base.resolve(allow_erasing=allow_erasing):
if failures:
module.fail_json(msg='Failed to install some of the specified packages',
module.fail_json(msg='Failed to install some of the '
'specified packages',
failures=failures)
module.exit_json(msg="Nothing to do")
else:
if module.check_mode:
if failures:
module.fail_json(msg='Failed to install some of the specified packages',
module.fail_json(msg='Failed to install some of the '
'specified packages',
failures=failures)
module.exit_json(changed=True)
@ -446,7 +448,8 @@ def ensure(module, base, state, names):
response['results'].append("Removed: {0}".format(package))
if failures:
module.fail_json(msg='Failed to install some of the specified packages',
module.fail_json(msg='Failed to install some of the '
'specified packages',
failures=failures)
module.exit_json(**response)

1
test/sanity/pep8/legacy-files.txt
View file

@ -659,7 +659,6 @@ lib/ansible/modules/packaging/os/apt.py
lib/ansible/modules/packaging/os/apt_key.py
lib/ansible/modules/packaging/os/apt_repository.py
lib/ansible/modules/packaging/os/apt_rpm.py
lib/ansible/modules/packaging/os/dnf.py
lib/ansible/modules/packaging/os/dpkg_selections.py
lib/ansible/modules/packaging/os/homebrew.py
lib/ansible/modules/packaging/os/homebrew_cask.py