Commit graph

38458 commits

Author SHA1 Message Date
Matt Clay
f3f266874c [stable-2.6] Install rabbitmq from s3 in tests..
(cherry picked from commit e105f5b436)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-30 12:41:05 -05:00
Sandra McCann
7e5d22d0c2 Update Ansible docsite CSS to fix multi-page printing issue (#51472) (#55667)
* Update css to fix multi-page printing issue
* Add margin edit

(cherry picked from commit 51ac4d3441)
2019-04-23 14:04:04 -05:00
Martin Krizek
3ae0296b14 ansible-test yamllint: fix UnicodeDecodeError (#55364)
* ansible-test yamllint: fix UnicodeDecodeError

* Conditional fix

(cherry picked from commit f8bebc61c8)
2019-04-22 09:37:50 -07:00
Dag Wieers
c1b640b65d ACI: Ensure we use native strings for signature (#55163)
* ACI: Ensure we use native strings for signature

* Add changelog fragment
2019-04-16 14:57:50 -07:00
Matt Clay
126b68591d [stable-2.6] Fix ansible-test unicode error with redact option.
(cherry picked from commit 2ef4ba3b4d)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-15 13:34:30 -07:00
Jordan Borean
2fab4dd204 win_domain - fix for checking for domain on new host (#55195)
(cherry picked from commit 6039ff9a24)
2019-04-12 12:28:53 -07:00
Matt Clay
a3f1fda8de [stable-2.6] Compat fix for ansible-core-ci on Python 3.7.
(cherry picked from commit 5b133f3455)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-10 10:47:45 -07:00
Matt Clay
29bbb1b3bb [stable-2.6] Fix apache shutdown in subversion test.
(cherry picked from commit 58f4947ffe)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-08 11:19:43 -07:00
Matt Clay
2f48995a24
[stable-2.6] Limit supervisor in tests to < 4.0.0. (#54938)
Tests fail when using version 4.0.0.

(cherry picked from commit 4b3662605d)
2019-04-05 18:33:24 -07:00
Lukasz Szczesny
0d3b577774 Backport/2.6/54105 pamd: fix idempotence issue when removing rules 2019-04-04 12:08:06 -07:00
Martin Krizek
8b05790a45 2.6: Fix copy module to reset filesystem acls (#51868) (#54795)
* Fix copy module to reset filesystem acls (#51868)

The controller's fixup_perms2 uses filesystem acls to make the temporary
file for copy readable by an unprivileged become user. On Python3, the
acls are then copied to the destination filename so we have to remove
them from there.

We can't remove them prior to the copy because we may not have
permission to read the file if the acls are not present. We can't
remove them in atomic_move() because the move function shouldn't know
anything about controller features. We may want to generalize this into
a helper function, though.

Fixes #44412

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
(cherry picked from commit d15812fabf)

* Fix get_bin_path usage
2019-04-04 12:07:26 -07:00
Toshio Kuratomi
61aa22f32a Update Ansible release version to v2.6.16.post0. 2019-04-04 10:30:55 -07:00
Toshio Kuratomi
da048ae80d New release v2.6.16 2019-04-03 15:38:52 -07:00
Matt Clay
d2d7556da7 [stable-2.6] Reduce testing of Ubuntu versions.
Removing:

- Ubuntu 14.04 with Python 2.7
- Ubuntu 16.04 with Python 3.5

Keeping:

- Ubuntu 16.04 with Python 2.7
- Ubuntu 18.04 with Python 3.6.
(cherry picked from commit c8f2becb7a)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-04-02 22:52:00 -07:00
Simon Westphahl
7d6c925e38 Catch all request timeouts for winrm connection (#54104)
* Catch all request timeouts for winrm connection

The current implementation only catches 'ConnectTimeout' exceptions.
Instead we should catch 'Timout' which also catches ReadTimeout
exceptions.

Improves on: #51744

Co-Authored-By: westphahl <westphahl@gmail.com>

* Changelog for winrm error handling improvement
2019-04-01 14:38:52 -07:00
Jordan Borean
707c75ab0b win_user_right - fix non json output issue (#54495)
(cherry picked from commit e2d2874d81)
2019-04-01 14:38:17 -07:00
Jordan Borean
40edb80f39 Get tests working on older Ansible versions 2019-04-01 14:37:42 -07:00
Jordan Borean
2166d4bc48 win_acl - remove test return values
(cherry picked from commit 1034b892df)
2019-04-01 14:37:42 -07:00
Jordan Borean
64eb25eb1d win_acl - fix support for registry paths (#54427)
(cherry picked from commit 10f006036c)
2019-04-01 14:37:42 -07:00
Felix Fontein
e1c53bdfed openssl_publickey: fix handling of OpenSSH private keys with passphrase (#54192)
* Cleanup.
* Make sure that OpenSSH passphrases are handled correctly.
* Add changelog.

(cherry picked from commit 1a94cf140c)
2019-03-22 11:16:28 -07:00
Matt Clay
d983dbad27 [stable-2.6] Disable failing azure_rm_managed_disk test.
(cherry picked from commit 1a286a95e5)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-03-21 07:10:50 -07:00
Matt Clay
0e4558e805 [stable-2.6] Add constraint for deepdiff.
(cherry picked from commit 9a135fbcef)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-03-19 15:19:09 -07:00
Jordan Borean
92b3c3a65b win_file - fix glob like paths (#54003)
(cherry picked from commit c053bc1fc7)
2019-03-19 11:09:35 -07:00
Jordan Borean
1859c5bac6 win_copy - fix glob like paths (#54006)
(cherry picked from commit 2f1bc34589)
2019-03-19 11:09:35 -07:00
Jordan Borean
fed3df4d44 win_certificate_store - fix glob like paths (#54007)
(cherry picked from commit eb18df1a0f)
2019-03-19 11:09:35 -07:00
Jordan Borean
7c800167c0 win_find - fix glob like paths (#54005)
(cherry picked from commit 8a4079ddbf)
2019-03-19 11:09:35 -07:00
Jordan Borean
0429b10ddc Merge pull request #53845 from jborean93/win-paths-2.6
Windows - Fix issues with glob like path chars - 2.6
2019-03-18 14:35:28 -07:00
Toshio Kuratomi
00a02574c2 Make the timeout decorator raise an exception out of the function's scope (#49921)
* Revert "allow caller to deal with timeout (#49449)"

This reverts commit 63279823a7.

Flawed on many levels

* Adds poor API to a public function
* Papers over the fact that the public function is doing something bad
  by catching exceptions it cannot handle in the first place
* Papers over the real cause of the issue which is a bug in the timeout
  decorator
* Doesn't reraise properly
* Catches the wrong exception

Fixes #49824
Fixes #49817

* Make the timeout decorator properly raise an exception outside of the function's scope

signal handlers which raise exceptions will never work well because the
exception can be raised anywhere in the called code.  This leads to
exception race conditions where the exceptions could end up being
hanlded by unintended pieces of the called code.

The timeout decorator was using just that idiom.  It was especially bad
because the decorator syntactically occurs outside of the called code
but because of the signal handler, the exception was being raised inside
of the called code.

This change uses a thread instead of a signal to manage the timeout in
parallel to the execution of the decorated function.  Since raising of
the exception happens inside of the decorator, now, instead of inside of
a signal handler, the timeout exception is raised from outside of the
called code as expected which makes reasoning about where exceptions are
to be expected intuitive again.

Fixes #43884

* Add a common case test.

Adding an integration test driven from our unittests.  Most of the time
we'll timeout in run_command which is running things in a subprocess.
Create a test for that specific case in case anything funky comes up
between threading and execve.

* Don't use OSError-based TimeoutError as a base class

Unlike most standard exceptions, OSError has a specific parameter list
with specific meanings.  Instead follow the example of other stdlib
functions, concurrent.futures and multiprocessing and define a separate
TimeoutException.

* Add comment and docstring to point out that this is not hte Python3 TimeoutError

(cherry picked from commit bd072fe83a)
2019-03-18 14:35:04 -07:00
Jordan Borean
19dfb2f396 Handle binary files when scanning metadata in python 3 (#53773)
(cherry picked from commit c2466c545b)
2019-03-18 14:34:27 -07:00
Jordan Borean
a36b86c0c0 win_psexec: make the tests more stable (#53716)
(cherry picked from commit 33939f7fe8)
2019-03-18 14:33:40 -07:00
Matt Clay
b4aa70e0a1 [stable-2.6] Changelog lint and generation bug fixes. (#53792)
* Add missing dict entry for changelog generation.
* Enforce str and list types on sections.
* Check type of section list items.
* Support non-ascii characters in changelogs..
(cherry picked from commit 90a38670be)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-03-15 10:11:02 -07:00
Jordan Borean
7ee89d4ac6 win_chocolatey Fix incompatibilities with latest Chocolcatey release 2019-03-15 10:10:41 -07:00
Toshio Kuratomi
995a7e6453 Update Ansible release version to v2.6.15.post0. 2019-03-14 21:39:41 -07:00
Toshio Kuratomi
dd6a174ff0 New release v2.6.15 2019-03-14 20:21:57 -07:00
Matt Clay
2cae458ba9 [stable-2.6] Keep existing to_yaml behavior with pyyaml >= 5.1. (#53772)
In pyyaml versions before 5.1 the default_flow_style for yaml.dump
was None. Starting with 5.1 it is now False. This change explicitly
sets the value to None to maintain the original to_yaml behavior.

The change to pyyaml was made in the following commit:

507a464ce6
(cherry picked from commit 7f0e09aa31)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-03-13 18:30:30 -07:00
S
4c3a5629b3 Fixed win_file crash with hidden files (#52584)
* Fixed crash with hidden files

added "-force" parameter on "Get-Item" cmdlet. this is needed to get file info if the file is "hidden" 
without this option modules like win_file, win_template, win_copy crashes on hidden files. this is because with "test-path" it sees that the file exists, but "get-item" can't get the file info. 
for more information on "-force option": https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.management/get-item

* Add changelog and integration tests

* fix tests for older Windows versions

(cherry picked from commit 3bc474bf99)
2019-03-11 11:50:10 -07:00
Jordan Borean
1e8b9daaa2 win_domain: fix issue when running without credential delegation (#53480)
* win_domain: fix issue when running without credential delegation

* Add check for reboot is required to complete role e install

* Fix changelog sanity issue

* removed meta file accidentally committed

(cherry picked from commit 008db85d44)
2019-03-11 11:49:48 -07:00
Sloane Hertel
b7b780650d Mark ec2_vpc_vgw as disabled to avoid hitting the resource limit (#53082)
* Mark ec2_vpc_vgw as disabled to avoid hitting the resource limit

(cherry picked from commit c4d0c58c5a)
2019-03-08 22:39:47 -08:00
Jordan Borean
2bf946d25e winrm - try and recover from a send input failure (#53187) (#53306)
(cherry picked from commit ae24bbff4a)
2019-03-06 14:49:49 -08:00
Jordan Borean
8b483b1640 OpenSUSE - Add OpenSUSE 15 test containers (#52793)
* OpenSUSE - Add OpenSUSE 15 test containers ci_complete

* Reset matrix back to normal

* Set container version instead of latest

* Remove old Docker completion file

(cherry picked from commit 3635c59b23)
2019-03-04 17:10:55 -08:00
Jordan Borean
1ab1c22659 Add changelog fragment 2019-03-04 07:13:35 -08:00
Robin Roth
150edc4605 Make zypper work with python3
(cherry picked from commit 24e94ec3c6)
2019-03-04 07:13:35 -08:00
Wojciech Sciesinski
8ac0f26b28 Don't run integration tests for OS'es older than Windows 2016 (#53057) 2019-03-01 15:14:37 -08:00
s-hertel
19590192f4 fix no_log indentation so AWS temporary credentials aren't displayed in tests
(cherry picked from commit 6cacbcba665af685608253d16275d3bcf33dfa79)
2019-03-01 15:13:46 -08:00
Dag Wieers
fd38985604 ACI: Fix examples in documentation (stable-2.6) 2019-02-26 10:05:17 -08:00
Jordan Borean
91dee57e5f Suse add py3 package vars (#52794)
(cherry picked from commit 80652ad054)
2019-02-22 11:05:44 -08:00
Jordan Borean
c078da9e09 test - add setup target that creates the nobody user (#52750)
* test - add setup target that creates the nobody user

* do not set explicit gid/uid for nobody user

* Do no create group and only touch basic attributes

(cherry picked from commit 17bfc60423)
2019-02-22 11:05:25 -08:00
Jordan Borean
b94a34d9fa test - add Python 3 package for OpenSUSE in setup_openssl (#52775)
(cherry picked from commit 63c22f6eb0)
2019-02-21 17:07:58 -08:00
Jordan Borean
68507a55b8 fix filesystem tests on OpenSUSE 15+ (#52716)
(cherry picked from commit 5e3e0eb946)
2019-02-21 17:07:47 -08:00
Jordan Borean
8964ef5cfc test suse: get tests working on newer OpenSUSE distributions (#52539)
(cherry picked from commit c312287731)
2019-02-21 17:07:25 -08:00