Commit graph

4292 commits

Author SHA1 Message Date
Brian Coca
04e94274fb safe_eval fix ()
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23015)
2019-06-20 18:22:29 -07:00
Sam Doran
169dfc807e [stable-2.8] passwordstore lookup - replace expired GPG key ()
- Replace private key that expired an 2019-06-20 with a key that does not expire
- Document how to generate a new GPG key using an input file
(cherry picked from commit b9d77b997e)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-20 15:33:00 -07:00
Dmitriy Yakovlev
cd00cb1e8c docker_swarm_service: Added default value for mounts.source ()
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end

(cherry picked from commit 122d4164c5)
2019-06-20 13:58:45 -07:00
Paul Belanger
546cc087aa Use wait_for in prepare_junos_tests.yaml ()
This should reduce the amount of time we are waiting for netconf to come
online.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 7f536630eb)
2019-06-20 13:58:08 -07:00
Sumit Jaiswal
4cb505a310 PR to fix ios bgp TC failure ()
* fix ios bgp tc failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 77b6255305)
2019-06-20 11:01:35 -07:00
Sam Doran
32503a55c4 [stable-2.8] Change integration tests in order to pass on Fedora 30 ()
* Use different package for DNF tests
    Ninja caused errors in Fedora 30. This works in both Fedora 29 and 30.

* Fix git integration tests
    Git >= 2.21.0 has either a bug or change in behavior where it errors when fetching a
    repository containing submodules that are behind the upstream submodule commits.
    It's weird and I don't fully understand it.

    Get around this my checking out specific commits from a repository rather than
    switch the origin URL.

* Fix PostgreSQL tests
    The error message is slightly different
(cherry picked from commit 18feeb51a8)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-19 10:55:13 -07:00
Paul Belanger
7bd503c52a Remove pause logic form junos_netconf tests ()
We can switch to wait_for / meta, as using pause can lead to race
conditions on slower / faster hardware.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 8dc51dfe1c)
2019-06-19 10:54:46 -07:00
Nilashish Chakraborty
05c7f7a230 Remove backup from iosxr replace_config test ()
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit af25274d6a)
2019-06-19 10:53:41 -07:00
Daniel Mellado Area
20fa1156b7 Add support for vlan update on ovs bridges ()
This commit adds support for vlan update on openvswitch_bridge module.

(cherry picked from commit 091bebcbf7)
2019-06-19 06:18:30 -07:00
Ganesh Nalawade
bafc95eb0f More iosxr integration zuul CI test fixes ()
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test

(cherry picked from commit 4a3e14f90b)
2019-06-19 06:16:08 -07:00
Ganesh B Nalawade
ae995a19e2 Fix junos integration zuul CI failures
(cherry picked from commit 0957835a4814bfc0c7649675963de5e88df5060e)
2019-06-18 11:20:39 -07:00
Paul Belanger
ee02a98d19 ansible-test: ios_command cli test should only be network_cli ()
We do not support testing under ansible_connection=local

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 21:57:07 -07:00
Kevin Breit
81dc2ac233 [stable-2.8] - Restructure meraki_network execution ()
* Resolve conflicts

* Fixes for the merge since 2.8 and devel are quite different

* Add changelog
2019-06-17 21:56:40 -07:00
ShachafGoldstein
ee48ceaf10 win_get_url - Fix handling of restricted headers ()
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test

(cherry picked from commit 66728cb93f)
2019-06-17 21:47:14 -07:00
Jordan Borean
c1391fd636 win_shell - fix space escaping for custom executable ()
(cherry picked from commit d0c4914469)
2019-06-17 21:38:16 -07:00
Sam Doran
0cc78fa3af [stable-2.8] Change RHEL8 image name to match changes in ansible-test ()
* Change RHEL8 image name to match changes in ansible-test

Continue to use the beta version of RHEL 8 until we fix tests that are breaking with the GA version.

* Skip ufw integration test on RHEL 8 Beta
(cherry picked from commit 84075fe351)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-17 20:07:05 -07:00
Felix Fontein
fd04094bde acme_*: new test container, tests for IP certificates ()
* Bump container version.

* Use new URLs.

* Add IP certificate tests.

* Disable IPv6 IP from IP certificate.

Background: in CI, the ACME test container apparently has no IPv6 support.
Without IPv6 support, Pebble can't connect to validate, and thus validation
fails.

(cherry picked from commit c50a75a41e)
2019-06-17 18:27:47 -07:00
Martin Krizek
0690aab25d Actually run valid_include_keywords test ()
(cherry picked from commit e8948f7655)
2019-06-17 18:27:02 -07:00
Paul Belanger
07806f36b6 Remove hardcoded ansible user for junos_user integration tests ()
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: https://github.com/ansible/ansible/pull/57639
Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 15:46:33 -07:00
Sebastiaan Mannem
7b73604058 Issue 56430 ()
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes 

* Adding changelog for MR 57147/Issue 56430
2019-06-17 13:01:08 -07:00
Paul Belanger
57e323dd8f Fix ios_smoke failure
Set ansible_buffer_read_timeout to be larger then
ansible_command_timeout, as both appliance / controller are on the same
physical network and we are not triggering ansible_command_timeout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Sumit Jaiswal
7f1888cef4 PR to fix the IOS_NTP integration TC failure ()
* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* ios_ntp tc fail

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix for local connection

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
545b5af2fb ios_ntp: Switch interface to GigabitEthernet0/1 for tests ()
* ios_ntp: Switch interface to GigabitEthernet0/1 for tests

Lets use an interface we know that exists for testing, in some cases
Loopback0 maybe not be configured.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* ios_ntp: properly register result variable for testing

This is currently broken, and tests don't work. Fix this by properly
registering the result variable.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
b381967194 Fix syntax issue with ios_ntp tests
This was missing a yaml anchor.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Paul Belanger
ac2f1c4a26 ansible-test: use become for connection=local on ios_user
ios_user requires escalated privledges, rather then doing this in the
inventory, we can just add it into the playbook tasks.

Also add missing provider settings for authorize.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Abhijeet Kasurde
034d030a89 [2.8] VMware: Fix vmware_guest_move undefined VM name error
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: 

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 00604d3f2c)
2019-06-17 12:51:13 -07:00
Sloane Hertel
01386cca4a preserve same order as inventory manager when using host lookup ()
* preserve same order as inventory manager when using host lookup ()

* preserve same order as inventory manager when using inventory_hostnames lookup

add a test

* move generic code

(cherry picked from commit afb5e02c19)

* changelog
2019-06-17 11:22:21 -07:00
Martin Krizek
ea735a1602 Fix --diff to produce output when creating a new file ()
* Fix --diff to produce output when creating a new file

Fixes 

* Make the check more defensive

(cherry picked from commit 1fa7bfcd5d)
2019-06-14 19:23:08 -07:00
Ian Wienand
daef4d9c95 openssh_keypair: make fingerprint result a string ()
The extant documentation says that the fingerprint return value is a
single string, but it is currently being returned as a split list.
Convert the returned value to a string as documented, and add some
basic test-case coverage for the return values.

(cherry picked from commit 6f06fc9945)
2019-06-11 19:54:54 -07:00
Jordan Borean
074b71f7fe win_chocolatey - honour version when bootstrapping chocolatey and fix package listing - 2.8 ()
* win_chocolatey - honour version when bootstrapping chocolatey and fix package listing ()

* win_chocolatey - honour version when bootstrapping chocolatey

* skip upgrade all step

* Fix install latest step

* Remove test changes now that Chocolatey is released

* tweak the package version detection

(cherry picked from commit b5b75daaa5)

* removed disabled alias
2019-06-11 19:54:11 -07:00
Trishna Guha
b8a41594fc nxos_snmp_user, nxos_snmp_host integration test fixes. () ()
* Fix nxos_snmp tests

* Add imagetag check for nxos_snmp_user test

(cherry picked from commit 87422ea7e7)
2019-06-11 19:53:28 -07:00
Trishna Guha
736e26f019 Fix nxos_vtp_version test () ()
(cherry picked from commit 870d8bf10b)
2019-06-11 19:52:19 -07:00
Trishna Guha
b428d36724 nxos_install_os: Fix nxapi local failures () ()
* nxos_install_os: Fix nxapi local failures ()

* Fix nxapi failures

* Remove logit debug calls

* Remove msg_timestamps

* Fix code alignment issue

(cherry picked from commit 7c73dd3e78)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:51:50 -07:00
Trishna Guha
30aba1a7fd nxos_vlan purge fix 2.8 ()
* nxos_vlan: fix broken purge behavior (issue ) ()

* nxos_vlan: fix broken purge behavior (issue )

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix  caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check

(cherry picked from commit 6bb13bbb84)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:50:35 -07:00
Sloane Hertel
95b1b42d4f improve conditional warnings ()
* Fix order for warning on templated conditionals

Fix bare variable warnings when the variable is a boolean

* changelog

* Add tests for cases that should and should not give warnings

If the behavior may change when the default behavior for CONDITIONAL_BARE_VARS becomes False there should be a warning. Boolean type conditionals will not change in behavior so don't warn.

* oops, forgot to add files

* typo

(cherry picked from commit 21cd24a0dd)
2019-06-11 19:44:01 -07:00
Matt Clay
208bb48942 Revert "Disable the rabbitmq tests for now"
This reverts commit 5f47ab958f.

(cherry picked from commit 047fd3cfbc)
2019-06-10 14:46:47 -07:00
Matt Clay
0812a08ea3 [stable-2.8] Use bintray to install erlang for rabbitmq tests.
(cherry picked from commit b2791718e5)

Co-authored-by: Matt Clay <matt@mystile.com>
2019-06-10 14:46:47 -07:00
Matt Clay
318f46c829 Revert "Temp disable podman_image_info tests."
This reverts commit f6600b5b99.
2019-06-10 14:44:47 -07:00
Toshio Kuratomi
a31a8c2a53 [stable-2.8] Disable the rabbitmq tests for now
The erlang-solutions repository is broken for Ubuntu18 (They did not
sign their repository metadata).  For now, disable the rabbitmq tests
which depend upon that.  I'll open a PR with a revert of this commit.
We can watch it to see when it passes in Ci to know that the
erlang-soutions repository has been fixed
(cherry picked from commit 5f47ab9)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-06-06 15:22:38 -07:00
Matt Clay
f6600b5b99 Temp disable podman_image_info tests.
The fix in https://github.com/ansible/ansible/pull/57433 is required for tests to pass.
2019-06-05 15:04:57 -07:00
Jordan Borean
77e88ae5d4 Mark win_chocolatey as unstable in 2.8 until next release 2019-06-05 06:15:05 -07:00
Felix Fontein
5c88199db3 [2.8] docker_image: fix compatibility bugs ()
* docker_image: fix default handling of old docker-build options nocache and rm ()

* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.

(cherry picked from commit 56e2d48612)

* docker_image: fix module failing when build option is used without specifying path ()

* Fix module failing when build option is used without specifying path.

* Add changelog.

(cherry picked from commit 86928a5f74)

* Extend docker_image tests. ()


(cherry picked from commit c54d79bc13)
2019-06-03 09:34:58 -07:00
Felix Fontein
059589794e Fix assignments in docker tests. ()
(cherry picked from commit 7cd229aa97)
2019-06-03 09:31:15 -07:00
Rohit
3ae459b3b4 Vyos interface desc fix28 ()
* vyos interfacefix and  test cases

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
(cherry picked from commit be1820d3aff5958991911aed55c7e7627bcbc1d8)

* backport 28

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-06-03 09:21:12 -07:00
Daniel Mellado Area
e826eca1f2 Fix junos_facts test ()
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.

(cherry picked from commit 0ada6b8d8d)
2019-05-30 11:12:27 -07:00
Felix Fontein
0d48ead822 docker_container: fix container creation with networks_cli_compatible=yes ()
* Fix behavior.

* Add changelog.

* Add simple test to prevent .

(cherry picked from commit d8dcd20294)
2019-05-28 17:14:09 -07:00
Lukas Kämmerling
116262e5e8 Backport hcloud_volume attach step should be idempotent 2019-05-28 15:06:19 -07:00
Felix Fontein
0a624eaad3 [2.8] [docker_network] Fix idempotency when using aux_addresses in ipam_config ()
* [docker_network] Fix idempotency when using aux_addresses in ipam_config ()

* [docker_network] Fix idempotency when using aux_addresses in ipam_config

Mismatch between keys returned by Docker API (AuxilliaryAddresses) vs
expected by Ansible module (aux_addresses) resulted in tasks always
have status 'changed'. The existing code normalizing one set of
keys to another missed this special case where converting
CamelCase to lowercase is not sufficent.

Please see
https://github.com/moby/moby/blob/master/api/types/network/network.go
for reference.

* Correct keywords formatting in changelog file

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit 37df89b2d8)

* docker_network: Integration tests for IPAM config idempotence ()

Integration tests for pull request  which fixes found issues with idempotence.

(cherry picked from commit 6a50c6aae4)
2019-05-28 15:01:52 -07:00
Nathaniel Case
5a1985cb06 [stable-2.8] eos_l2_interface handle "Interface does not exist" () ()
* [stable-2.8] eos_l2_interface handle "Interface does not exist" ()

* Quick and dirty attempt to handle eapi error

* Well this should probably change

* Hopefully this works correctly?

* Fix check_rc handling with httpapi

* Add tests that should hopefully cover the error

* Fix warnings

* Improve tests.
(cherry picked from commit cebb363fcc)

Co-authored-by: Nathaniel Case <ncase@redhat.com>

* Add changelog

* Remove backport overreach

* Fix debug statements in new tests while I'm here
2019-05-28 07:18:11 -07:00
Paul Belanger
cb6ece6b4e [stable-2.8] Don't validate ip address for mgmt interface ()
It is possible the EOS appliance doesn't have an IP address on the
management1 interface, instead just check we have found that interface.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f9589bd)

Co-authored-by: Paul Belanger <pabelanger@redhat.com>
2019-05-24 14:29:01 -07:00