Commit graph

36223 commits

Author SHA1 Message Date
Jordan Borean
7e621b3dbe
win_uri: backport 2.5 fix for when status codes are provided as a comma separated list (#38509)
* fix for when status codes are provided as a comma separated list (#38080)

* fix for when status codes are provided as an array of strings

* convert status codes to int, additional tests

(cherry picked from commit c38617a736)

* Added changelog fragment
2018-04-10 14:24:00 +10:00
Jordan Borean
3ac6c6ebd9
win_exec_wrapper: fix tests after recent change (#38504) (#38506)
(cherry picked from commit 0d374f28d2)
2018-04-10 11:31:03 +10:00
Adrian Likins
31e28a04a5 Fix 'New Vault password' on vault 'edit' (#35923) (#38003)
* Fix 'New Vault password' on vault 'edit'

ffe0ddea96 introduce a
change on 'ansible-vault edit' that tried to check
for --encrypt-vault-id in that mode. But '--encrypt-vault-id'
is not intended for 'edit' since the 'edit' should always
reuse the vault secret that was used to decrypt the text.

Change cli to not check for --encrypt-vault-id on 'edit'.

VaultLib.decrypt_and_get_vault_id() was change to return
the vault secret used to decrypt (in addition to vault_id
and the plaintext).

VaultEditor.edit_file() will now use 'vault_secret_used'
as returned from decrypt_and_get_vault_id() so that
an edited file always gets reencrypted with the same
secret, regardless of any vault id configuration or
cli options.

Fixes #35834

(cherry picked from commit 6e737c8cb6)
2018-04-09 14:57:34 -07:00
Dag Wieers
b9ccac8550 Fix incorrect RN used in module (#38249)
This is backported from devel as this bug makes the module fail for VMM
domains.
2018-04-09 14:46:59 -07:00
Ondra Machacek
9d0ebfdea6 ovirt: Cherry picks of recent fixes to devel branch (#38341)
* ovirt_host_networks: Fix idempotency

* ovirt_hosts: Fix failed_state after PM fence

* ovirt_host_networks: Fix of bond assignment (#38054)

* ovirt_host_networks: Fix of bond assignment

* ovirt_host_networks: Fix bond modes

* ovirt_host_networks: Fix incorrect prefix documentation

* ovrit_cluster: fix for CPU arch entity #37425 (#37436)

* ovrit_cluster: fix for CPU arch entity #37425

* Corrected Indentation

* Condition to check if `architecture` is defined
2018-04-09 14:35:50 -07:00
Jordan Borean
9bb2a36289
win_updates: backport 2.5 handle failure on module load (#38498)
* win_updates: handle if module failed to run (#38363)

(cherry picked from commit ccc56e138a)

* Added changelog fragment
2018-04-10 06:39:09 +10:00
Jordan Borean
38a13f41cd
powershell: 2.5 backport display non-ascii characters in command outputs (#38365)
* powershell: display non-ascii characters in command outputs (#37229)

(cherry picked from commit 71e8527d7c)

* Added changelog fragment
2018-04-10 05:25:02 +10:00
Markos Chandras
2e881f2929 modules: zypper: Optimize the 'search' subcommand (#37191) (#37234)
When looking for installed packages we do not need to query
repositories since we only care about the rpmdb. As such, we can
disable all the repositories operations in order to improve the
performance of that step

Before this patch, when using 'state: present' in the zypper module,
the operation was taking about 12 seconds to complete:

time ansible-playbook foo.yml 1>/dev/null

real	0m12.614s
user	0m10.880s
sys	0m0.683s

After this patch:

time ansible-playbook foo.yml 1>/dev/null

real	0m4.193s
user	0m2.560s
sys	0m0.575s

see:
https://bugzilla.opensuse.org/show_bug.cgi?id=1084525
(cherry picked from commit 5234b78b5f)
2018-04-09 11:54:39 -07:00
Martin Krizek
28b41f5c83 Update playbooks_loops.rst (#38440) (#38475)
Missing parentheses
+label: docsite_pr

(cherry picked from commit 061ecac3b5)
2018-04-09 11:35:04 -07:00
Adam Miller
f96c109286
Backport azure_rm_image Tag fix for 2.5 (#38131) (#38228)
* fix typo (#38131)

(cherry picked from commit 1c00a14c31)

* add changelog fragment for 38131 backport to 2.5

Signed-off-by: Adam Miller <admiller@redhat.com>

* Fixes #37700 Azure image can be created with tag (#37981)

* image can be create or add

* update tags

* can remove all tags

* Update azure_rm_common.py
2018-04-09 10:46:42 -05:00
Ganesh Nalawade
4875477d17
Fix junos transport check (#38460) (#38467)
For connection=local check only if the transport value in
provider is cli and the respective module support cli
transport. If not report back appropriate error message.
(cherry picked from commit e10e0d42d8)
2018-04-09 19:13:40 +05:30
John R Barker
4f0389ad4e
Backport/2.5/38386 (#38462)
* openssl_certificate: Handle dump() in check_mode (#38386)

Currently, when ones run the module in check_mode it tries to retrieve
values from the actual certificate generated in the generate() function.

Since in check_mode we call dump() without calling generate(), self.cert
is None, leading to self.cert.get_notBefore(), self.cert.get_notAfter()
and self.cert.get_serial_number() raising an error.

>  NoneType' object has no attribute 'get_notBefore'

The solution is to have two way to handle dump() method, whether its run
in check_mode=True or check_mode=False leading to different way the
information is retrieved.
(cherry picked from commit 99497ce54c)
2018-04-09 09:49:09 +01:00
scottb
57931804ed
Mobile CSS update - adds scrolling inertia (#38443) (#38445) 2018-04-07 16:47:31 -07:00
scottb
2895daacdb
Tweaks docs CSS to fix minor issue with main content page display cutting off at the bottom. (#38432) (#38434) 2018-04-06 23:28:38 -07:00
Toshio Kuratomi
e60c4d4690 Removes modules from TOC, speeding up build time and reducing doc disk space requirements. (#38428)
(cherry picked from commit 62c2b9a544)
2018-04-06 15:12:05 -07:00
scottb
14011dbe2a Additional docs CSS fix for mobile (#38376)
(cherry picked from commit 2381d2207e)
2018-04-06 14:45:53 -07:00
Toshio Kuratomi
32a99acc88 The ssh change note has been removed
Since the note was about 2.0 versus 1.x, this has been removed.  The
file implementing it is gone so we need to stop referencing it.

(cherry picked from commit f1b63f435e)
2018-04-06 12:44:52 -07:00
scottb
2b78985ff2 Fixes CSS so docs display properly on mobile (#38373)
(cherry picked from commit 79c5a34b0b)
2018-04-06 12:42:32 -07:00
scottb
604b748295 Reinstated element to fix doc display on mobile devices. (#38246)
(cherry picked from commit 68f81a6799)
2018-04-06 12:42:32 -07:00
Alicia Cozine
222c1f1090 DOCS: Network Best Practices fixes (#38293) (#38360)
* fixes typo per #38217, corrects link anchor

* adds ssh-agent info per #35649

(cherry picked from commit 24fe8674a6)
2018-04-06 14:34:47 +01:00
David Newswanger
f10b82c0d3
Add eos_smoke integration tests (#36957) (#38397)
* added eos_smoke tests

* removed left over file

* added note to uncomment broken eapi test when #36919 is fixed

* uncommented fixed test, added unbecome test

* skip become tests when connection=local

(cherry picked from commit 712d30f46c)
2018-04-06 08:44:14 -04:00
David Newswanger
f25eea16e6
added junos_smoke tests (#37216) (#38396)
* added junos_smoke tests

* enable check mode test

* fix check mode test

(cherry picked from commit 0bd2cd4394)
2018-04-06 08:40:24 -04:00
David Newswanger
cbeadb2c9a
added iosxr_smoke (#37828) (#38395)
* added iosxr_smoke tests

* finalized netconf tests

* cleaning up files

(cherry picked from commit 38fa1d0b15)
2018-04-06 08:37:32 -04:00
Deepak Agrawal
4aafa90c89
Backport/2.5/37287 Eos :do not push config to device if check_mode is enabled (#38382)
* Eos :do not push config to device if check_mode is enabled (#37287)

* eos can not check config without config session support

* add testcase for check_mode without config session

* fix eos eapi to read use_session env var

(cherry picked from commit a1026dbce5)

* Backport/2.5/37287 - Eos do not push config is check_mode is enabled
2018-04-06 14:31:54 +05:30
Trishna Guha
536dff507d
stable-2.5 nxos bugfix cherry-pick (#38372)
* nxos_vlan purge (#38202)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 119352b538)

* fix nxos_aaa_server issues (#38117)

(cherry picked from commit 697c301f04)

* fix nxos_aaa_server_host issues (#38188)

(cherry picked from commit 24cc6b80bd)

* fix nxos_static_route issues (#37614)

* fix nxos_static_route issues

* remove nxos_static_route from ignore

(cherry picked from commit 0df5cfd41f)

* fix nxos_acl issues (#38283)

* fix nxos_acl issues

* typo fix

* typo fix in sanity.yaml

* another typo fix in sanity.yaml

(cherry picked from commit 1bf29651af)

* nxos_acl_interface tests addition (#38230)

(cherry picked from commit b8cb382a40)

* update changelog with nxos bugfixes for 2.5

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert ignore.txt

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-04-06 02:30:32 -04:00
Jordan Borean
ff03fc0f67
win_setup: backport Added connection name to interfaces (#38362)
* win_setup: Added connection name to interfaces (#37327)

(cherry picked from commit fd4d264253)

* Added changelog fragment
2018-04-06 08:38:13 +10:00
John R Barker
c97c02e83b
Fix the automatic docsite_pr label (#37999) (#38351)
(cherry picked from commit cdf9e39647)
2018-04-05 19:20:03 +01:00
John R Barker
8b62aef632
Update docs to reflect support for CDP neighbors (#38051) (#38350)
(cherry picked from commit dca61cc397)
2018-04-05 19:17:03 +01:00
David Newswanger
58bafcb01c added nxos_smoke tests (#36647) (#37252)
* added nxos_smoke tests

* add connection information, check length of output

* updated name of task

(cherry picked from commit 5e827f4cc4)
2018-04-05 18:12:23 +01:00
Matt Martz
8277989039 Backport #38194 for 2.5 - include_vars error fix (#38225)
* Don't pass keyword args as positional, include file_name. Fixes #38190 (#38194)

(cherry picked from commit ddf937d642)

* Add changelog for #38194
2018-04-05 12:29:01 -04:00
Nathaniel Case
63566334f6
fixes issue when netconf would report ios is not supported (#38155) (#38240)
* fixes issue when netconf would report ios is not supported

This change now will map ansible_network_os=ios to the correct netconf
plugin implementation.  This will resolve an error where the netconf
connection plugin will report that ios is unsupported.

(cherry picked from commit 91a748e33b)
2018-04-05 10:37:01 -04:00
Nathaniel Case
50c971df43
Network connection backports (#37529)
* Close & remove paramiko connection where appropriate (#37528)

* Update unit test

(cherry picked from commit 594840c1d6)

* Put back $PATH checking in ansible-connection call (#37933)

(cherry picked from commit 169209c32a)
2018-04-05 10:36:31 -04:00
Daniel Andrei Mincă
5cf1420251 Fix typo in Slack Callback plugin (#38286)
`get_options` is an undefined method from CallbackBase

As a result, remove the trailing `s` letter.

Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
2018-04-05 16:18:41 +02:00
James Hogarth
20a5987c30 ISSUE-37945 output not populated on failure (#37952) (#38322)
* ISSUE-37945 output not populated on failure

This always includes output, but it is empty on failure.

* handle the other failcases as well

(cherry picked from commit 509f52a8ed)
2018-04-05 13:41:20 +01:00
Alicia Cozine
92562a2ba9 demonstrates best practices for group vars (#37930) (#38287)
* demonstrates best practices for group vars

* removes vm-specific var from example

* adds brackets to all [group:vars] refs

(cherry picked from commit 380c074808)
2018-04-05 13:17:44 +01:00
John R Barker
05cf76cbd7
Backport/2.5/38191 (#38327)
* issue:38167 add support for onyx version 3.6.6000 for onyx_linkagg (#38191)

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 72d42bd065)

* fragment
2018-04-05 12:27:56 +01:00
John R Barker
08029a38df
issue:37307 Add support for changes in pfc output in onyx 3.6.6000 (#… (#38330)
* issue:37307 Add support for changes in pfc output in onyx 3.6.6000 (#37651)

* issue:37307 Add support for changes in pfc output in onyx 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 9dfb665e43)

* fragment
2018-04-05 12:27:37 +01:00
John R Barker
aed8aea3f3
issue:37306 Fix issue with vlan support for onyx version 3.6.6000 (#37310) (#37635)
* issue:37306 Fix issue with vlan support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit a89bafce2e)
2018-04-05 12:12:24 +01:00
John R Barker
323e3b6914
nso_verify handle leaf-list in 4.5 and identityref (#37393) (#37634)
* nso_verify handle leaf-list in 4.5 and identityref (#37393)

NSO verify did not handle leaf-list value verification in 4.5 and
later due to changes made for configuration writing made.

map prefix for identityref types in verification.
(cherry picked from commit 6308047dc9)

* Remove timeout
2018-04-05 12:02:44 +01:00
John R Barker
5ee10ad19c
fixes example address parameters (#37765) (#38328)
(cherry picked from commit 7324f49829)
2018-04-05 11:55:56 +01:00
Renato Orgito
4e3e2c712a Have the ios_interface module include CDP when checking neighbors (#38046)
* Add CDP support for the neighbors option (#37655)

(cherry picked from commit 0f90853f67147d68ad5899407e96a53eed8e4d46)

* Add ios_interface CDP support to changelog
2018-04-05 11:51:18 +01:00
John R Barker
febd1ca44a
ansible_password & ansible_ssh_pass are the ENV variable (#38035) (#38324)
* ansible_password & ansible_ssh_pass are the ENV variable
(cherry picked from commit a4e932ee9f)
2018-04-05 11:47:34 +01:00
Toshio Kuratomi
b86d376a85 Document that this module was renamed recently (#37420) (#37422)
(cherry picked from commit ff15a9e7e2)
2018-04-05 10:44:30 +10:00
Matt Davis
eaa484f05d fix RPM builds when REPOTAG is not defined
* add to mock/rpmbuild args only when defined
2018-04-04 13:55:56 -07:00
Alicia Cozine
6e1ca544dd Update EdgeOS modules to be community supported (#38112) (#38125)
(cherry picked from commit a4c82d5842)
2018-04-04 09:31:01 -07:00
Ganesh Nalawade
fa57dec5e0
Add error handling for junos in case wrong connection type (#38023) (#38256)
* Add error handling for junos in case wrong connection type

Fixes #37990

If a junos module doesn't support given connection/transport type
return appropriate error message.

* Fix CI issues

* Fix review comment

(cherry picked from commit 3a4fc4af08)
2018-04-04 16:23:16 +05:30
Jordan Borean
09dc621238
win_service: backport of special char in name handler (#38250)
* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets (#37897)

* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets

* compare username in lowercase for test

(cherry picked from commit f37a44430f)

* Added changelog fragment
2018-04-04 13:43:33 +10:00
scottb
f629825299 Adds VMWare to TOC; sort scenario guides alphabetically (#38238) 2018-04-03 13:44:10 -07:00
Jordan Borean
f2b0171b93
azure_rm_virtualmachine - backport of docs change around images supported (#37764)
* Updated text for azure_rm_virtualmachine around images that can be used (#37686)

(cherry picked from commit 04539ca448)

* Added changelog fragment
2018-04-03 08:32:02 +10:00
Jordan Borean
800980ec83
win_copy: backport 2.5 preserve local tmp path when sending multiple files (#37977)
* win_copy: added fix for win_copy deleting local tmp folder (#37964)

(cherry picked from commit b1ac65d95a)

* Added changelog fragment
2018-04-03 08:30:49 +10:00