Commit graph

33425 commits

Author SHA1 Message Date
James Cammarata
0b7d78d67f
Don't use getattr in _get_parent_attribute to avoid recursion issues (#33595) (#34532)
* Don't use getattr in _get_parent_attribute to avoid recursion issues

Fixes #23609

* Move extend/prepend to field attribute

Also removes _get_attr* methods that were basically just calling
_get_parent_attribute because it needed to set those params.

Also modifies _get_parent_attribute() to pull those values from the
FieldAttributes instead of using the ones passed into the function.

* Better fixes for _get_parent_attribute
2018-01-05 23:20:47 -06:00
Trishna Guha
cf31e47cdc
Make eos_vlan idempotent (#34503)
* make eos_vlan idempotent (#34443)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 0f24199012)

* Make eos_vlan idempotent CHANGELOG

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-05 18:35:59 +05:30
Toshio Kuratomi
1546ddb3c3 Fix up the test-set_mode_if_different unittests 2018-01-04 21:05:38 -08:00
Toshio Kuratomi
3b5e9522d2 Add changelog for checkmode with missing files 2018-01-04 20:36:26 -08:00
Pilou
ffd448e0ad If check mode enabled and file missing set changed to true 32676 (#33967)
* basic.py: add mock to os.path.exists

* set_*_if_different: if check_mode enabled & file missing: set changed to True

Fixes #32676
Thanks to mscherer and Spredzy for the distributed triplet programming
session!

(cherry picked from commit e9df2083a3)
2018-01-04 20:35:27 -08:00
Jordan Borean
5f329134c9 Updated changelog for win_mapped_drive doc update 2018-01-05 08:04:16 +10:00
Jordan Borean
91a0ea20c0 win_mapped_drive: add extra note around win_mapped_drive (#34478)
(cherry picked from commit edf56c9743)
2018-01-05 08:03:18 +10:00
Jordan Borean
a4418fffa2 Updated changelog for win_package fix 2018-01-05 07:14:27 +10:00
Jordan Borean
cb92c4bea1 win_package: remove case sensitive check for msi extension (#34476)
(cherry picked from commit da69f5aeae)
2018-01-05 07:13:18 +10:00
Brian Coca
2c53d012bc really disable inventory cache 2018-01-03 20:09:05 -05:00
yungez
3998a485bd add Azure user agent for Visual Studio Code extension (#33366)
(cherry picked from commit 392b55b70b)
2018-01-03 16:45:37 -08:00
Toshio Kuratomi
ccf10e95fc New release v2.4.3-0.3.beta3 2018-01-03 10:46:56 -08:00
Matt Davis
9a45611c02 backport WinRM IPv6 escaping
* https://github.com/ansible/ansible/pull/34072
* cherry-picked from 57ed6a866f
2018-01-03 09:31:35 -08:00
Martin Krizek
307b9b25ca Update CHANGELOG.md 2018-01-03 17:09:25 +01:00
Martin Krizek
888816b437 yum: case for multilib when installing from a file (#32236)
(cherry picked from commit 356901b72d)
2018-01-03 17:07:24 +01:00
Matt Davis
3a853fc9b8 fix win_firewall test failure on 2008/2008r2 (#34391)
* ensure that "starting" profile is known instead of relying on default
2018-01-03 05:36:40 -05:00
Matt Davis
266afc61b8
Update CHANGELOG.md 2018-01-02 20:43:12 -08:00
Matt Davis
cbc07cf9cc backport win_firewall_rule updates
from devel  SHA 89d9444ad560ef5c4a8aac911e2e7abcf7aa9c76
2018-01-02 20:38:00 -08:00
Matt Davis
8708105616 avoid use of Write-Host in config script
(cherry picked from commit 82996d5b267994d9806bbba62ceee2cd6613e9da)
2017-12-20 22:51:54 -08:00
Matt Davis
ae0d7da822 add GlobalHttpFirewallAccess arg
(cherry picked from commit a9ca0389b6cdf2992b04d6bafbd2cb3feb861d12)
2017-12-20 21:34:27 -08:00
Toshio Kuratomi
9dc4e0cec7 New release v2.4.3.0-0.2.beta2 2017-12-20 11:53:43 -08:00
Toshio Kuratomi
48a0cf1148 add cloudscale fix to the changelog 2017-12-19 14:31:39 -08:00
Gaudenz Steinlin
03eccdea19 Send API parameters as JSON in cloudscale_server module
Use JSON to send the POST data to the API instead of an urlencoded
string. Urlencoding is not really a good match for some Python
datatypes.

This fixes an issue when submitting a list of SSH keys which did not get
translated properly.

Partial cherry-pick of the important parts of 4c94c6f9ba.
2017-12-19 14:28:02 -08:00
Brian Coca
b375d5f3ea dont warn on not matching 'all' (#32806)
* dont warn on not matching 'all'

the implicit localhost warning shoudl be enough

* centralized no hosts handling

also extended info on implicit only

(cherry picked from commit 87c75b19dd)
2017-12-19 15:07:31 -05:00
Brian Coca
7d976c6484 fix reconcile to ensure 'ungrouped'
also removed redundant 'hosts to all' as all groups already ensure that inheritance

(cherry picked from commit ad94a3a6a2)
2017-12-19 15:02:44 -05:00
Trishna Guha
284625f18c
NXOS Commit Integration tests to Ansible (part 2) (#28939) (#33964)
* add nxos_aaa_server IT

* add nxos_aaa_server_host ITs

* Add nxos_gir IT

* Add nxos_gir_profile_management IT

* add newly added tests to nxos.yaml

* fix nxos.yaml indentation

* fix indentation again

* skip nxos_git_profile_management IT for titanium

* change idempotency to non-idempotency check

(cherry picked from commit a130549ead)
2017-12-16 10:10:19 +05:30
Toshio Kuratomi
aa50818506 changelog for file attribute fix 2017-12-15 09:51:32 -08:00
Maxime de Roucy
86fbaffc07 fix file attributes changed detection
https://docs.python.org/2/library/stdtypes.html#str.split
str.split([sep[, maxsplit]])
If sep is given, consecutive delimiters are not grouped together and are deemed
to delimit empty strings.

>>> "85563      ----------------C-- /var/lib/libvirt/images".split(' ')[0:2]
['85563', '']
>>> "85563      ----------------C-- /var/lib/libvirt/images".split()[0:2]
['85563', '----------------C--']

(cherry picked from commit c2ac9d0831)
2017-12-15 09:50:29 -08:00
Jordan Borean
e95611980a update changelog for win_iis_webapppool for password fix 2017-12-15 09:53:33 +10:00
Jordan Borean
5dd40349b2 win_iis_webapppool: stop any passwords from being returned (#33931)
(cherry picked from commit 0ca828ebab)
2017-12-15 09:52:52 +10:00
Jardar Marshall Bond
c08ae38a9d Fix example with proceccModel in win_iis_webapppool (#32971)
The attribute processModel.userName have to be written i camelCase. Otherwise this fails silently.

(cherry picked from commit 1eae3b6b59)
2017-12-15 09:34:14 +10:00
Matt Martz
df3b45e0f4 Add changelog entry for #33926 2017-12-14 16:05:31 -06:00
Matt Martz
0850a7635b Handle vault filenames with nonascii chars when displaying messages. Fixes #33879 (#33926)
(cherry picked from commit 0b9f1f7982)
2017-12-14 16:03:28 -06:00
Ganesh Nalawade
2a007e2b4d
Fix ios_interface integration test failure (#33901) 2017-12-14 14:17:08 +05:30
Ganesh Nalawade
13937ce772
ios_config save (#33791) (#33872)
* Fixing save so it still works. Adding changed as an option for save_when.

* Updating unit tests.

* Updating description to state that changed was added in 2.5.

(cherry picked from commit 3a9083cf48)

* Update Changelog
2017-12-13 22:31:09 +05:30
John R Barker
3f7b1ba606
Fix CloudEngine host failed 27876 2017-12-13 13:45:52 +00:00
QijunPan
4f1586ec07 fix CloudEngine host failed #27903 (#33732)
* Update ce.py

* Update ce.py

fix CloudEngine host failed #27903
2017-12-13 13:44:45 +00:00
Will Thames
06ddcf6fa7 Remove deprecated restart: parameter from win_feature examples (#33848)
`restart` is a deprecated parameter. Show how to use `reboot_required`
in examples instead

(cherry picked from commit 1f8f394de3)
2017-12-13 16:50:01 +10:00
Jordan Borean
a635a7861b updated changelog for win_iis_webapppool fix 2017-12-13 16:36:09 +10:00
Gianluca
07a1217aa7 Fixes #33771 - win_iis_webapppool bugfix (#33777)
* Fixes #33771

* Fixes #33771 - mod 1

* removed some unneeded whitespace

(cherry picked from commit 1d10a2867c)
2017-12-13 16:35:23 +10:00
Matt Martz
926dfb7c04 Add test for clean_copy preservation of keys
(cherry picked from commit 5c63bb0090)
2017-12-12 14:27:41 -06:00
Adam Miller
74de512bfc remove unnecessary extra conditional (thanks bcoca)
Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
(cherry picked from commit 7bc7c347dd)
2017-12-12 13:09:25 -05:00
Brian Coca
5067a1340a always preserve certain keys (#33637)
* always preserve certain keys

fixes #33433

* results

(cherry picked from commit 8d78a829c6)
2017-12-12 13:05:38 -05:00
Jordan Borean
5fb97aa6c9 Updated changelog for windows fetch fix 2017-12-12 15:01:30 +10:00
Jordan Borean
39f590523f Fix fetch when retrieving a file with a multiple of the buffer size (#33697)
* Fix fetch when retrieving a file with a multiple of the buffer size

* fixed sanity issue

(cherry picked from commit 6e4c690a37)
2017-12-12 15:00:43 +10:00
Toshio Kuratomi
109471cb7f Remove files from legacy that pass now that W503 is ignored 2017-12-08 11:28:39 -08:00
John R Barker
c7a903c34b Ignore W503 in stable-2.4 (#33716)
* Ignore W503

To avoid backporting from devel (2.5) to 2.4 any code that may fail pep8
backport the current-ignore change.
2017-12-08 10:45:10 -08:00
Toshio Kuratomi
298255095d Fix Command module documentation
The command module docs were unclear.  They talked about ignoring the user's environment which lead people to believe the user's environment variables were not used.  In actual fact, the user's environment variables are used.  They just are not expanded in the command.

(cherry picked from commit 824ec37a4f)
2017-12-08 10:07:21 -08:00
s-hertel
6a6ae0cede loop doesn't exist in 2.4 2017-12-08 09:53:51 -08:00
Toshio Kuratomi
132d6fe78c Add environment on loop fix 2017-12-08 07:22:54 -08:00