Commit graph

36627 commits

Author SHA1 Message Date
Jordan Borean
09dc621238
win_service: backport of special char in name handler (#38250)
* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets (#37897)

* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets

* compare username in lowercase for test

(cherry picked from commit f37a44430f)

* Added changelog fragment
2018-04-04 13:43:33 +10:00
scottb
f629825299 Adds VMWare to TOC; sort scenario guides alphabetically (#38238) 2018-04-03 13:44:10 -07:00
Jordan Borean
f2b0171b93
azure_rm_virtualmachine - backport of docs change around images supported (#37764)
* Updated text for azure_rm_virtualmachine around images that can be used (#37686)

(cherry picked from commit 04539ca448)

* Added changelog fragment
2018-04-03 08:32:02 +10:00
Jordan Borean
800980ec83
win_copy: backport 2.5 preserve local tmp path when sending multiple files (#37977)
* win_copy: added fix for win_copy deleting local tmp folder (#37964)

(cherry picked from commit b1ac65d95a)

* Added changelog fragment
2018-04-03 08:30:49 +10:00
Jordan Borean
886a88a967
win_uri: backport fix custom header override (#37889)
* append request headers instead of replacing (#37845)

(cherry picked from commit 2c44061a04)

* Added changelog fragment
2018-04-03 08:30:09 +10:00
Jordan Borean
0c88f199ec
azure_rm_networkinterface: backport no public IP fix (#37762)
* azure_rm_networkinterface: fixed issue when public ip address should not be created (#36824)

* fixed issue when public ip address should not be created

* adding test for public ip address

* fixed samples

* another fix to sample formatting

* fixed test

* fix test

* fixed test

* another attempt to fix test

* maybe it works now

* still wrong

* improved check per customer request

* removed stupid semicolon

* updated test to match main scenario

* changed ip configurations to list

* another attempt

(cherry picked from commit 89401f13f7)

* Added changelog fragment
2018-04-03 06:32:01 +10:00
Jordan Borean
c056b8a35c
win_reboot: backport warning message arguments (#37971)
* win_reboot: fixed up warning message for dep args (#37898)

(cherry picked from commit c4e7b54630)

* Added changelog fragment
2018-04-03 06:31:07 +10:00
Jordan Borean
d0f1a23c45
Ansible.ModuleUtils.FileUtil - backport catch DirectoryNotFoundException (#37976)
* Ansible.ModuleUtils.FileUtil: catch DirectoryNotFoundException when testing a path (#37968)

(cherry picked from commit 68e44e082e)

* Added changelog fragments
2018-04-03 06:30:53 +10:00
Sam Doran
f1a060743a Doc build warning/broken link clean-a-palooza (#37382) (#38185)
* Doc build warning/broken link clean-a-palooza, WIP commit 1.

* Fixed broken anchor

* Fixing additional broken links; converting from doc to ref.

* Fix anchor

(cherry picked from commit 381359a8f8)
2018-04-02 11:53:24 -07:00
Felix Fontein
112f577d3a letsencrypt: doc: Making clearer that the module has to be executed twice, and that the second run needs the data of the first (#37884). (#38135) (#38160)
(cherry picked from commit 93fc99c576)
2018-03-31 20:15:50 +02:00
René Moser
00623c3da5
cloudstack: do not rely on APIs list queries for names (#37910) (#38014)
Fixes #37824
(cherry picked from commit abae7a49f7)
2018-03-31 09:41:07 +02:00
René Moser
46cf6ed677
cs_vpc_offering: listVPCOffering API returns any matching names (#37783) (#37832)
(cherry picked from commit 270e799cb6)
2018-03-31 09:39:29 +02:00
Felix Fontein
3ac91f7e28 Improving EC account key parsing (see #37275). (#37276)
(cherry picked from commit ec977988b35caacd0f13470ef62d55ec91d16de1)
2018-03-31 09:36:49 +02:00
Matt Clay
ca3457458f Fix PEP 8 issue. 2018-03-29 19:27:12 -07:00
Toshio Kuratomi
8f5565f948 Add changelog for https://github.com/ansible/ansible/pull/37460 2018-03-29 19:10:47 -07:00
Brian Coca
663400b504 Avoid 2nd processing of facts for actions
include_vars and set_fact are already updating hostvars in strategy
no need to 're add again' with lower priority the same data.

fixes #37535, mostly by avoiding reprocessing and 'cleaning'

(cherry picked from commit 3bec76fc85)
2018-03-29 15:26:40 -07:00
Adrian Likins
d64a352a40 Fix redundant yaml error blurbs on ModArgs parse errors (#36923)
* Fix redundant yaml error blurbs on ModArgs parse errors

Some of the AnsibleParserErrors from parsing.mod_args
are created with the obj=some_yaml_ds options but
some are not.

If they were, we don't want to add another yaml_ds to
it, because that will result in double yaml error blurbs.
And since we dont need to add info, we can just re raise it.

But if there is no ._obj, add it here so we get the extra
detail in the error message (see issue #14790) and raise
a new AnsibleParserError instance.

Fixes #36848

* cleanup existing test_tasks pep8/sanity issues

(cherry picked from commit e166946a0a)
2018-03-29 15:23:32 -07:00
René Moser
27382f38dc Fixing domain to authorization matching for ACME v2. (#37558) (#37572)
(cherry picked from commit 190755ff65)
Signed-off-by: Rene Moser <mail@renemoser.net>
2018-03-29 15:20:43 -07:00
Izuke
5b0d8ab868 Fixes #32146 Fixes reconcile inventory to correctly remove hosts from ungrouped
(cherry picked from commit e02c72d856)
2018-03-29 15:19:29 -07:00
Toshio Kuratomi
4ecd16b2ae Bkprt py3 pull fix (#37663)
* Compare byte strings to byte strings

* Fix a traceback in ansible-pull on python3 comparing output from
  subprocess with a text string.
* Rename variables that hold byte strings so we are clear that those are
  not text strings.
* Use to_text() to transform variable that's being displayed as it's
  less fragile than str().

Fixes #36962

(cherry picked from commit b98ad3a12b)

* Add changelog entry for python3 ansible-pull fix
2018-03-29 15:16:12 -07:00
Toshio Kuratomi
389c4d1536 Bkprt py3 ec2 user data (#37664)
* Fix use of user_data field with spot_price in ec2 module (#37628)

The user_data field is base64 encoded inside of the boto library.  In
Python3, base64 must be used with byte strings.  So we make sure to
encode the user_data into a byte string before passing it on to the boto
library.

Fixes #34978

(cherry picked from commit 0d55081ba8)

* Python3 ec2 fix added to changelog
2018-03-29 15:13:42 -07:00
Toshio Kuratomi
97a0516cf6 Bkprt py3 csvfile (#37665)
* Fix csvfile traceback on Python3 (#37625)

* Fix csvfile traceback on Python3

The csvfile lookup uses some custom iterators.  These needed to be
ported to handle the python3 iterator protocol.  In addition, the
csvfile module takes an iterator of byte strings in Python2 and an
iterator of text strings in Python3

Fixes #36808

(cherry picked from commit 09325b619e)

* Add changelog entry for csvfile python3 fix
2018-03-29 15:11:14 -07:00
Abhijeet Kasurde
87119348b5 VMware: Use environment variable for connection (#37726) (#37745)
This fix adds environment variables for connection in vmware_*
modules.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 0ae7a0e88c)
2018-03-29 15:05:44 -07:00
Toshio Kuratomi
64cdeba7a2 Bkprt py3 jira (#37800)
* make jira authentication Python3 compatible (#33862)

* make jira authentication Python3 compatible

(cherry picked from commit a51a699314)

* Add changelog fragment for py3 jira fix
2018-03-29 14:59:15 -07:00
Toshio Kuratomi
8d008d00ed Py3 vargrant inv (#37803)
* Fix dynamic inventory for vagrant does not work on python3 (#37631)

* Fix dynamic inventory for vagrant does not work on python3 #35129

(cherry picked from commit 1b121fc9e4)

* Add vagrant python3 fix to the changelog
2018-03-29 14:58:19 -07:00
Toshio Kuratomi
f23c100419 Bkprt py3 haproxy (#37791)
* Fix python3 interpreter issue (#34811) (#35176)

* Fix python3 interpreter issue (#34811)

* Update ansible.module_utils._text (#34811)

* Convert to text later to account for multibyte characters

(cherry picked from commit 340064bfb9)

* Add a changelog fragment for haproxy python3 fix
2018-03-29 14:57:40 -07:00
Abhijeet Kasurde
2dd02eb812 Fixed issue with accessing response in digital_ocean module (#37780)
(cherry picked from commit 6ad784bbbb)
2018-03-29 14:56:30 -07:00
Adrian Likins
ae0a9a5e9c continue fact gathering even without dmidecode (#34925) (#38001)
* continue fact gathering even without dmidecode

If dmidecode is not available we still wan to continue with fact
gathering.
On certain platforms dmidecode just won't work

(cherry picked from commit cbe2915ba5)

Fixes #37911
2018-03-29 14:48:45 -07:00
Matt Davis
d47e020d55 add missing to_bytes import in interfaces_file 2018-03-29 14:46:17 -07:00
Olivier Bourdon
98633e5157 Fix interfaces_file for proper file contents (#37818)
The generated file was completely unusable by the system
therefore the fix which ensures that diffing the file
prior to changes and after only shows diffs

Furthermore the code did not work for Python 3.6
>       f.writelines(to_bytes(lines, errors='surrogate_or_strict'))
E       TypeError: a bytes-like object is required, not 'int'

The other modifications (lambda variable renaming) is to
comply with default flake8 rules
(cherry picked from commit 612d0d6634)
2018-03-29 14:42:25 -07:00
Jordan Borean
4e5f17e52d win_certificate_store: backport fix of typo key_storage (#37862)
* win_certificate_store: fix typo stopping key_storage from working (#37810)

(cherry picked from commit b7ce2b1c5a)

* Added changelog fragment
2018-03-29 14:18:53 -07:00
Fabian Zimmermann
5ac9a7418f fixes bug: puppet module is no longer updating persistent external facts (#38026)
(cherry picked from commit 0efbb702b9)
2018-03-29 14:13:35 -07:00
Ganesh Nalawade
f91cda4b02
Fix junos modules check_mode issue (#37311) (#37918)
Fixes #37208

If check_mode is enabled instead of committing th config need to
discard all the chnages to cnadidate db
In case of cli to discard changes issue `rollback 0` command
and for netconf execute `discard-changes` rpc call
(cherry picked from commit 8eaa9cc938)
2018-03-29 19:00:15 +05:30
Ganesh Nalawade
ec59181a28
Fix eos_facts eapi integration test failures (#37919)
(cherry picked from commit af777c0f895fb37db0e28fbcea9ddaaa66e451e1)
2018-03-29 18:59:14 +05:30
Ganesh Nalawade
4dffcd35cd
eos_config module exit session gracefully (#37920)
Fixes #36979
If `abort` is not issued in the top level session prompt
the existing session goes to pending state.
The fix is to come out of config mode by issuing `end` command
and again to same config session and execute `abort` which
`abort` is issued at the top level session prompt.

(cherry picked from commit 017ea018d0649b8b6f392f9505992f39e99943fa)
2018-03-29 18:58:43 +05:30
Trishna Guha
a716fe97e3
nxos bugfixes cherry-pick (#38091)
* Fix nxos_switchport (#37328)

(cherry picked from commit ff57fd0bb4)

* Fix nxos_l2_interface and test typo (#37336)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ba5e562c76)

* fix ios_l2_interface (#37389)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dd37857884)

* fix required args for nxos_snapshot and docs improvement (#37232)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a10df8b0b5)

* add nxos_snapshot test for missing required param (#37248)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2501834c42)

* Ensure network_cli nxos test is run only once - remove unnecessary files (#37462)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 957ab02e52)

* Integration Tests only: nxos_user (#37852)

* add new integration file to nxos_user

* fix shippable error

* change nxapi to connection

* review comments

(cherry picked from commit 63da50e1d8)

* fix UnboundLocalError nxos_bgp_af module (#37610)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 00abe6dbe7)

* Fix nxos_vrf issues (#37092)

* fix nxos_vrf issues

* fix doc

(cherry picked from commit dc61f4c6b1)

* fix nxos_vrf_af issues (#37211)

(cherry picked from commit 74e79d9f5e)

* fix nxos_udld issues (#37418)

(cherry picked from commit 05b266cc66)

* fix nxos_vlan issues (#38008)

(cherry picked from commit 6f2cb28bb9)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-29 08:47:32 -04:00
Will Thames
60e7aa0dbd [cloud]Ensure SGs in default VPCs get default egress rule (#38018)
SGs created when a VPC ID was not specified would not necessarily
get the default egress rule, even when no explicit egress rules
were set.

Add some checks for egress rules in results from existing tests

(cherry picked from commit 98b29f8ad6)
2018-03-28 17:52:17 -04:00
msven
ae4c246a3c ec2_asg: fix #28087 and #35993 (#36679)
Fixes #35993 - Changes to update_size in commit eb4cc31 made it so
the group dict passed into update_size was not modified. As a result,
the 'replace' call does not see an updated min_size like it previously
did and doesn't pause to wait for any new instances to spin up. Instead,
it moves straight into terminating old instances. Fix is to add batch_size
to min_size when calling wait_for_new_inst.

Fixes #28087 - Make replace_all_instances and replace_instances behave
exactly the same by setting replace_instances = current list of instances
when replace_all_instances used. Root cause of issue was that without lc_check
terminate_batch will terminate all instances passed to it and after updating
the asg size we were querying the asg again for the list of instances - so terminate batch
saw the list including new ones just spun up.

When creating new asg with replace_all_instances: yes and lc_check: false
the instances that are initially created are then subsequently replaced.
This change makes it so replace only occurs if the asg already existed.

Add integration tests for #28087 and #35993.

(cherry picked from commit a2b3120e85)
2018-03-28 17:36:32 -04:00
Matt Martz
0b0bb65198
Backport #36372 for 2.5 (#37666)
* Fix name parameter templating in include_role module (#36372)

An IncludedFile() object built using the original_task will have
its _task bound to the original_task. The iterative reassignment of
original_task._role_name during with_item loops leaves all returned
included_files with the same ._task._role_name (the final name from
the with_items list). This commit builds IncludedFile() objects
from an original_task.copy() to avoid the problematic binding.

(cherry picked from commit 54e70fc783)

* Test include role with items in name #36372 (#37001)

* Tests for #36372

* Tests for #36372

* Tests for #36372

(cherry picked from commit 8c4f349743)

* Add changelog for #36372
2018-03-28 11:05:03 -05:00
Matt Martz
687780323a
Backport #37881 for 2.5.1 (#37937)
* Don't overwrite builtin jinja2 filters with tests (#37881)

* Don't overwrite builtin jinja2 filters with tests. Fixes #37856

* Fix tests and other callers of _get_filters

(cherry picked from commit 1f824bd620)

* Add changelog for #37881
2018-03-28 11:04:44 -05:00
Matt Martz
e33f1777fe
Backport #37646 for 2.5 (#37653)
* Fix py3 issue in wait_for_connection (#37646)

(cherry picked from commit 6c3e565ba3)

* Add changelog entry for #36470
2018-03-28 11:04:06 -05:00
Alicia Cozine
617d156eac revises network portion of 2.5 porting guide (#37938)
* revises network portion of 2.5 porting guide
(cherry picked from commit b72960fdd4)
2018-03-28 08:27:44 -07:00
scottb
2604832858 Fixes scrolling issue without breaking header nav (#37864)
(cherry picked from commit 3554e2c2d9)
2018-03-26 13:08:26 -07:00
Matt Davis
4b406de19a pick up missing plugin docs boolean coercion backport 2018-03-23 05:04:13 -07:00
Dag Wieers
f237508caa Fix nested parameters in module docs (#37793)
(cherry picked from commit 69c0f96112)
2018-03-23 00:00:30 -07:00
Matt Davis
44d3bcbc6f re-sort unified RPM changelog 2018-03-22 23:03:42 -07:00
Matt Davis
2c2dd1a1b3 New release v2.5.0 2018-03-22 17:50:20 -07:00
Matt Davis
a57a2e1d4f sync old changelogs 2018-03-22 16:45:26 -07:00
Matt Clay
2665912356 Fix docker_secret test on RHEL.
(cherry picked from commit f1899f784b)
2018-03-22 12:03:03 -07:00
Matt Clay
6b0b4ddf00 Pin httptester SHA.
(cherry picked from commit 8232c95f42)
2018-03-21 10:02:11 -07:00