Commit graph

33525 commits

Author SHA1 Message Date
Toshio Kuratomi
8a7f9beab7 New release v2.4.3.0-1 2018-01-31 13:28:08 -08:00
Toshio Kuratomi
c8941cb103 Update version in the versions.yml file 2018-01-31 12:34:42 -08:00
Toshio Kuratomi
252863512a Update changelog with release date 2018-01-31 12:32:53 -08:00
Toshio Kuratomi
de6f60b03c Update the release doc with ansible-2.4.3
(cherry picked from commit 0b4debad53)
2018-01-31 12:32:02 -08:00
Matt Clay
75da39fbce Fix failing zypper_repository integration test.
(cherry picked from commit b1d14d5b06)
(cherry picked from commit 9c0cf0eafa2a7218976d64918ad3f2084580f8aa)
2018-01-25 15:34:32 -08:00
Toshio Kuratomi
6b29b3c638 Add link to maximum recursion depth fix in changelog 2018-01-24 18:52:03 -08:00
Toshio Kuratomi
10eba9494c New release v2.4.3.0-0.6.rc3 2018-01-24 11:24:58 -08:00
James Cammarata
a21f44dc0a Restore the behavior of 2.4 to that before ebf971f9
Fixes #35065
2018-01-23 19:46:26 -08:00
Toshio Kuratomi
055cae3c0f Revert "Integration tests for import/include (#33418)"
This reverts commit 8c822018db.

There's some other bugs in 2.4's import/include that aren't blockers for
2.4.3 (becaues they aren't regressions) that prevent the new integration
tests from passing.  Revert the integration tests.
2018-01-20 13:34:45 -08:00
Sam Doran
8c822018db Integration tests for import/include (#33418)
* First pass at include_role tests

* Reorganize test structure

Do all import and include tests in a single target.

* Build out more tests and test with linear and free strategy for each type

* import_role tests

* Set target host for play test

* Basic import_playbook tests

* Basic import/include_tasks tests

* Add recursion test

* import_playbook tests

* Add import_playbook group_vars test

Issue #33177

* Additional group_var tests for import_playbook

* Enable recursion test

* More work on import_tasks

* Run all tests via run.sh, improve conditional tests, add never tag

Add never tag to certain failining tests and explicitly skip it for now until #34104 is merged. Some tasks need to remain commented out because they cause the entire play to fail and aren't skippable by tags because they are syntax and/or variable checks.

Improve test for whether or not a role was run based on a conditional. Since the [import|include]_role does not register a variable, use a variable that is set inside a role as a canary test for whether or not the role was run.

* Use a fail task rather than trigger a failure via bogus command

This should resolve the "unstable" test results.

* Import tag tests

Fix bug it tests where validate tasks weren't run on tag tests.
Add tests for task import/include with tags.

* Remove test for playbook group_var inheritance

(cherry picked from commit 10a8c6bc25)
2018-01-19 08:24:31 -08:00
Toshio Kuratomi
0f03f82fd5 Add ssh stdin flush() fix to changelog 2018-01-19 08:06:07 -08:00
Matt Martz
bd4b92c0b6 Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727
(cherry picked from commit 29c1d5cb5d)
2018-01-19 08:06:07 -08:00
Toshio Kuratomi
95e162dc32 Add another commit related to memory optimization of includes 2018-01-19 08:06:07 -08:00
James Cammarata
4f0c962b4d Don't use the Task object in the dictionary of results for include_role
The short-circuiting of include_role in TaskExecutor was using the _task object
in the result dictionary. This causes the playbook class to be serialized, which
is something we no longer do due to speed/size problems with nested objects.

Simply removing this should fix a lot of memory and speed problems with include_role.

(cherry picked from commit c30ee42fe1)
2018-01-19 08:06:07 -08:00
Toshio Kuratomi
c570a2fff9 Revert "Don't use the Task object in the dictionary of results for include_role"
This reverts commit 0945694252.

This commit causes a behaviour change that may break playbooks so we're
reverting this for now.
2018-01-18 19:43:46 -08:00
Toshio Kuratomi
ff31828ec3 Revert "Add another commit related to memory optimization of includes"
This reverts commit 794c531158.

This commit is proving to cause a behaviur change that may break
playbooks so we're reverting it from 2.4.3 for now
2018-01-18 19:42:49 -08:00
Toshio Kuratomi
649ffc10a2 Revert "Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727"
This reverts commit fb9e7a85b3.

We may not have a 2.4.3rc3 so reverting this for now
2018-01-18 19:42:24 -08:00
Toshio Kuratomi
da6834f02c Revert "Add ssh stdin flush() fix to changelog"
This reverts commit 1810e486ec.

We may not have a 2.4.3 rc3 so reverting this for now.
2018-01-18 19:41:49 -08:00
Toshio Kuratomi
1810e486ec Add ssh stdin flush() fix to changelog 2018-01-18 09:36:45 -08:00
Matt Martz
fb9e7a85b3 Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727
(cherry picked from commit 29c1d5cb5d)
2018-01-18 09:33:08 -08:00
Toshio Kuratomi
794c531158 Add another commit related to memory optimization of includes 2018-01-18 09:23:48 -08:00
James Cammarata
0945694252 Don't use the Task object in the dictionary of results for include_role
The short-circuiting of include_role in TaskExecutor was using the _task object
in the result dictionary. This causes the playbook class to be serialized, which
is something we no longer do due to speed/size problems with nested objects.

Simply removing this should fix a lot of memory and speed problems with include_role.

(cherry picked from commit c30ee42fe1)
2018-01-18 09:23:48 -08:00
Toshio Kuratomi
64e6eb5086 New release v2.4.3.0-0.5.rc2 2018-01-17 16:45:47 -08:00
Toshio Kuratomi
6ba624b05b Fix number of arguments to format string 2018-01-17 15:57:34 -08:00
Toshio Kuratomi
fa025db5e5 Fix PEP8 issue 2018-01-17 15:18:33 -08:00
Matt Davis
84dab220bf fix minimum client version checking
* bump minimum client versions to match requirements file
* improve prescriptive error messaging to match current recommendations
(cherry-pick of #35018)
2018-01-17 15:12:55 -08:00
Matt Davis
949e2f06e5 revert azure_rm model pinning (#35011)
* reverts #33897/#34682
* revisit in 2.4.4/2.5.0
2018-01-17 13:08:07 -08:00
Toshio Kuratomi
93297fd0d0 Add azure_rm_securitygroup fix to the changelog 2018-01-15 10:45:14 -08:00
ZhijunZhao
f37a776fc8 fix failure got multiple values for keyword argument id (cherry-picked from 99551818a1) 2018-01-15 10:43:13 -08:00
Toshio Kuratomi
79f359ac99 Add nxos_banner and win_dns_client module fixes to changelog 2018-01-15 10:40:20 -08:00
Trishna Guha
0b0b02fd72 fix nxos_banner (#34695)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 303894dd17)
2018-01-15 10:40:17 -08:00
chriskarel
6e594340c2 Adding "-SyncWindow 0" flag to Compare-Object call (#34656)
Adding "-SyncWindow 0" flag to the Compare-Object call used to determine if the existing and proposed IP address lists are the same.  This makes the array comparison mark changes in order as a difference.

Fix for bug #34651

(cherry picked from commit bb9dcb0d2b)
2018-01-15 10:37:52 -08:00
Toshio Kuratomi
4eea0cec58 Add memory usage with includes optimization to changelog 2018-01-15 10:06:07 -08:00
James Cammarata
f1c458303a Backport of b107e397 (Cache tasks as they are queued)
* Cache tasks as they are queued instead of en masse

This also moves the task caching from the PlayIterator to the
StrategyBase class, where it makes more sense (and makes it easier
to not have to change the strategy class methods leading to an API
change).

Fixes #31673

* Cleaning up unit tests due to 502ca780

(cherry picked from commit b107e397cb)
2018-01-15 10:04:08 -08:00
Matt Martz
b971b87aa4 Add note to 2.4 porting guide about initial playbook relative host/group_vars and inheritance (#34769)
* Add note to 2.4 porting guide about initial playbook relative host/group_vars and inheritance

(cherry picked from commit ae49dd65d9)
2018-01-15 10:01:30 -08:00
Toshio Kuratomi
fe9019e646 Add cloudstack fix to changelog 2018-01-15 08:09:58 -08:00
Rene Moser
2df3f310fa cloudstack: fix timeout in ini config file is ignored
(partly cherry picked from commit 1c3bba0bdb)
2018-01-15 08:08:23 -08:00
Toshio Kuratomi
e2e64ed49c New release v2.4.3.0-0.4.rc1 2018-01-10 20:35:01 -08:00
Toshio Kuratomi
126576d430 Add ios_config deprecaation doc change to changelog 2018-01-10 20:28:10 -08:00
James Mighion
2ad755fca1 Ios config save (#33885)
* Fixing save so it still works. Adding changed as an option for save_when.

* Updating description to state that changed was added in 2.5.

* Fixing removal version for deprecated options.

(cherry picked from commit ded4e6ac0f)
2018-01-10 20:24:53 -08:00
Matt Davis
79d1ba35ad
Cherrypick misc Azure test fixes (#34713)
* Fix test case failure for Azure ACS module (#33623)

* fix azure acs test failure

* change acs location

(cherry picked from commit 8e20ae2de4)

* fix azure test case failure for function apps module (#33658)

(cherry picked from commit f8d7e477f0)

* Fix storage endpoint for Azure Stack (#33946)

* Fix storage endpoint for Azure Stack

https://github.com/Azure/msrestazure-for-python/issues/64

* corrected visual indentation

(cherry picked from commit 6643fe821e)

* Fix incorrect formatting call in azure module (#33561)

Fix corrects formatting call in azure_rm_resourcegroup_facts module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 6654d69569)
2018-01-10 13:27:52 -08:00
Adam Miller
ef0b705c08
Fix Linux blockdevice size computation (#34475) (#34647)
Linux' sysfs _always_ reports device size in 512b sector units,
regardless of the device's actual, physical blocksize.
2018-01-10 06:28:38 -08:00
Matt Clay
564e013534 Fix pylint issue. 2018-01-10 02:17:04 -08:00
Matt Davis
6f679b45de cherry-pick #34442 2018-01-09 23:29:31 -08:00
Matt Davis
bb9577418e
cherry-pick #33897 (#34682)
* resolved a number of conflicts
2018-01-09 23:25:50 -08:00
Trishna Guha
85a181e715
fix nxos_bgp failure for graceful_restart warning (#34630)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-01-10 10:50:40 +05:30
Matt Clay
02b1d90cf3 Make xattr test conditional on feature support.
(cherry picked from commit 77726b471f)
2018-01-08 23:57:50 -08:00
Jordan Borean
e2fa2526ae Updated changelog with win_iis_website fix 2018-01-08 10:28:27 +10:00
jn-bedag
61ec5c070a Fixing issue with win_iis_website parameter types. Issue #34500 (#34501)
* remidate Windows debugging

Using $complex_args is not working (anymore?). We need to set $params directly.

* Fixing issue with win_iis_website parameter types

There are two types of attributes. "String" and "Configuration Attribute". We need to get the real "value" based on the type.

* Revert "remidate Windows debugging"

This reverts commit df75d3bb0d152b10c24187ce4c643b4733bae336.

(cherry picked from commit 7f59f7d80e)
2018-01-08 10:27:41 +10:00
Jordan Borean
9a5bca5668 fix windows tests after recent patch (#34548)
(cherry picked from commit 460deb08cb)
2018-01-07 14:09:25 +10:00