This reverts commit 8c822018db.
There's some other bugs in 2.4's import/include that aren't blockers for
2.4.3 (becaues they aren't regressions) that prevent the new integration
tests from passing. Revert the integration tests.
* First pass at include_role tests
* Reorganize test structure
Do all import and include tests in a single target.
* Build out more tests and test with linear and free strategy for each type
* import_role tests
* Set target host for play test
* Basic import_playbook tests
* Basic import/include_tasks tests
* Add recursion test
* import_playbook tests
* Add import_playbook group_vars test
Issue #33177
* Additional group_var tests for import_playbook
* Enable recursion test
* More work on import_tasks
* Run all tests via run.sh, improve conditional tests, add never tag
Add never tag to certain failining tests and explicitly skip it for now until #34104 is merged. Some tasks need to remain commented out because they cause the entire play to fail and aren't skippable by tags because they are syntax and/or variable checks.
Improve test for whether or not a role was run based on a conditional. Since the [import|include]_role does not register a variable, use a variable that is set inside a role as a canary test for whether or not the role was run.
* Use a fail task rather than trigger a failure via bogus command
This should resolve the "unstable" test results.
* Import tag tests
Fix bug it tests where validate tasks weren't run on tag tests.
Add tests for task import/include with tags.
* Remove test for playbook group_var inheritance
(cherry picked from commit 10a8c6bc25)
The short-circuiting of include_role in TaskExecutor was using the _task object
in the result dictionary. This causes the playbook class to be serialized, which
is something we no longer do due to speed/size problems with nested objects.
Simply removing this should fix a lot of memory and speed problems with include_role.
(cherry picked from commit c30ee42fe1)
The short-circuiting of include_role in TaskExecutor was using the _task object
in the result dictionary. This causes the playbook class to be serialized, which
is something we no longer do due to speed/size problems with nested objects.
Simply removing this should fix a lot of memory and speed problems with include_role.
(cherry picked from commit c30ee42fe1)
* bump minimum client versions to match requirements file
* improve prescriptive error messaging to match current recommendations
(cherry-pick of #35018)
Adding "-SyncWindow 0" flag to the Compare-Object call used to determine if the existing and proposed IP address lists are the same. This makes the array comparison mark changes in order as a difference.
Fix for bug #34651
(cherry picked from commit bb9dcb0d2b)
* Cache tasks as they are queued instead of en masse
This also moves the task caching from the PlayIterator to the
StrategyBase class, where it makes more sense (and makes it easier
to not have to change the strategy class methods leading to an API
change).
Fixes#31673
* Cleaning up unit tests due to 502ca780
(cherry picked from commit b107e397cb)
* Fixing save so it still works. Adding changed as an option for save_when.
* Updating description to state that changed was added in 2.5.
* Fixing removal version for deprecated options.
(cherry picked from commit ded4e6ac0f)
* remidate Windows debugging
Using $complex_args is not working (anymore?). We need to set $params directly.
* Fixing issue with win_iis_website parameter types
There are two types of attributes. "String" and "Configuration Attribute". We need to get the real "value" based on the type.
* Revert "remidate Windows debugging"
This reverts commit df75d3bb0d152b10c24187ce4c643b4733bae336.
(cherry picked from commit 7f59f7d80e)