wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
25788 commits 42 branches 295 tags 186 MiB
Commit graph

12403 commits

Author SHA1 Message Date
Dreamcat4
40a1bd1962 fix: Add 'enable:' flag for enabling existing rules which are disabled by default. 
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
 2016-12-08 11:33:27 -05:00
Dreamcat4
e0da4a3362 fix: update documentation with new module name "win_firewall_rule" 2016-12-08 11:33:27 -05:00
Dreamcat4
7188ae4fe1 fix: The names of firewall profiles are different on win10 & win2008r2 
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
 2016-12-08 11:33:27 -05:00
Dreamcat4
f64e438150 fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch. 
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
 2016-12-08 11:33:26 -05:00
Dreamcat4
b9dd3568f3 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()' 
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
 2016-12-08 11:33:26 -05:00
Ramon de la Fuente
1d09eaf6d0 updated the examples to the new Slack API 2016-12-08 11:33:26 -05:00
Ramon de la Fuente
918012a42f module guidelines compliency 2016-12-08 11:33:26 -05:00
Stefan Berggren
aeb1090542 Add attachments support to slack module. 2016-12-08 11:33:26 -05:00
Kevin
b43329b6a0 Remove homebrew- prefix when checking if repo has already been tapped 
See: https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/cmd/tap.rb

Example:

```
$ brew tap neovim/homebrew-neovim
$ brew tap
neovim/neovim
...
```
 2016-12-08 11:33:26 -05:00
Luis Rodriguez
adedc7ef3f Fix bug #1067 2016-12-08 11:33:26 -05:00
Brian Coca
1426c3ba02 added missing GPL licences fixes #508 2016-12-08 11:33:26 -05:00
Michael Perzel
f84dc8fd5d Improve example wide_ip variable 2016-12-08 11:33:26 -05:00
Michael Perzel
9c8891740c Wrap main() in conditional 2016-12-08 11:33:26 -05:00
Michael Perzel
21425f36ef Update bigip_api method to use variable name server 2016-12-08 11:33:26 -05:00
Michael Perzel
6681a5b386 Style updates 2016-12-08 11:33:26 -05:00
Michael Perzel
ca0d4aad52 Module for managing F5 wide ip 2016-12-08 11:33:26 -05:00
Toby Fleming
3293fe7231 Homebrew: Allow colons, direct check for outdated formula 2016-12-08 11:33:26 -05:00
Indrajit Raychaudhuri
e115f62a2d homebrew: Also add 'formula' as alias for 'name' and reformat 2016-12-08 11:33:25 -05:00
Indrajit Raychaudhuri
c397dfe9ed homebrew: Improve 'argument_spec' handling 
- Remove choice list for boolean values in argument_spec and make it
  more consistent with core modules
- Add 'package' alias and support for list type for 'name' parameter
- Added self as maintainer
 2016-12-08 11:33:25 -05:00
jhawkesworth@users.noreply.github.com
17d1c8916d Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 2016-12-08 11:33:25 -05:00
Matt Martz
803d9695e0 sys.exit removal for system/capabilities.py 2016-12-08 11:33:25 -05:00
Matt Martz
a87cf4967e sys.exit removal for notification/mail.py 2016-12-08 11:33:25 -05:00
Matt Martz
e99a202ac5 sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 2016-12-08 11:33:25 -05:00
Matt Martz
7cb0d86c27 sys.exit removal for cloud/misc/ovirt.py 2016-12-08 11:33:25 -05:00
Matt Martz
950c951e06 sys.exit removal for cloud/xenserver_facts.py 2016-12-08 11:33:25 -05:00
James Cammarata
766ad0ace2 Updating version for 2.0.0-0.3.beta1 release 2016-12-08 11:33:25 -05:00
Matt Martz
9c4fae7e3f Fix open_iscsi EXAMPLES section 2016-12-08 11:33:25 -05:00
Matt Martz
e2872a984a Switch from old style replacer code to new style for ansible.module_utils.basic 2016-12-08 11:33:25 -05:00
Matt Martz
793f0e0fd1 Fix interpreter line in a few vmware modules 2016-12-08 11:33:25 -05:00
Rick Mendes
7bb6a5aa90 added missing license 2016-12-08 11:33:25 -05:00
Charles Paul
0acfd95747 allow floating point input for size vale 2016-12-08 11:33:25 -05:00
Brian Coca
4134b7a04d doc formatting fixes 2016-12-08 11:33:25 -05:00
Toshio Kuratomi
7ccd6a4de0 Change documented requirement from dnf to python-dnf as dnf could be taken to mean the command line tool. 
Fixes #1032
 2016-12-08 11:33:25 -05:00
nitzmahone
bf59d1cc1e win_updates rewrite for 2.0 
uses scheduled job to run under a local token (required for WU client)
supports check mode
no external PS module deps
 2016-12-08 11:33:24 -05:00
Brian Coca
ae84177514 switched to use module loggigng 2016-12-08 11:33:24 -05:00
Brian Coca
a04972c79b changed use_sudo to system_lib (kept alias) and expanded description to explain how it works 2016-12-08 11:33:24 -05:00
Milad Soufastai
c3c9f46ba4 Updating Description to provide better explanation of what the use_sudo flag does 2016-12-08 11:33:24 -05:00
Milad Soufastai
07a4ab2fc5 Adding the --sudo flag for CPANM use since the sudo: yes on the task doesn't work 2016-12-08 11:33:24 -05:00
Trond Hindenes
86be6b1dba added module author 2016-12-08 11:33:24 -05:00
Trond Hindenes
6890cc81be fixes #984 2016-12-08 11:33:24 -05:00
Matt Martz
503948203f znode requires a minimum of python2.6 2016-12-08 11:33:24 -05:00
Michael J. Schultz
6b6aeefa7b sns: remove BabyJSON 2016-12-08 11:33:24 -05:00
Toshio Kuratomi
dc788cf045 Make the znode module a valid ansible module 2016-12-08 11:33:24 -05:00
Toshio Kuratomi
07af4c3627 Fix doc build 2016-12-08 11:33:24 -05:00
Rene Moser
a134a71187 cloudstack: implement common argument spec handling 2016-12-08 11:33:24 -05:00
Alan Loi
6e4c78d165 Docfixes - add version_added and missing default values. 2016-12-08 11:33:24 -05:00
Alan Loi
a14420dcf0 Fix sqs_queue module to check that boto library is installed and AWS region & credentials are provided. 2016-12-08 11:33:24 -05:00
Alan Loi
e8e1e41e08 Updated documentation for sqs_queue - state option is not required. 2016-12-08 11:33:24 -05:00
Alan Loi
6022f5abc7 Rename module to sqs_queue.py to differentiate from other potential modules e.g. reading/writing messages. 2016-12-08 11:33:23 -05:00
Alan Loi
e018a12572 Add .py file extension to sqs module. 2016-12-08 11:33:23 -05:00
Alan Loi
1cb506c556 Add new amazon sqs module. 2016-12-08 11:33:23 -05:00
whiter
2294e5708e Documentation examples fix 2016-12-08 11:33:23 -05:00
Rob White
8bd69e9033 New module - ec2_vpc_subnet_facts 2016-12-08 11:33:23 -05:00
ToBeReplaced
faee617b21 Fix fail_json call in _mark_package_install 2016-12-08 11:33:23 -05:00
kovacsbalu
a034f19a41 Use push_type and send link with push_link. 2016-12-08 11:33:23 -05:00
Peter Sprygada
7ff11a72aa cleaned up vca_vapp module to focus on managing vapps 2016-12-08 11:33:23 -05:00
Rene Moser
57a9af5693 cloudstack: fix redundant security_group return 2016-12-08 11:33:23 -05:00
Siert Zijl
47cfb2c734 #931 append dot to zone if not defined 2016-12-08 11:33:23 -05:00
Trond Hindenes
cb88c17856 win_chocolatey bugfixes 2016-12-08 11:33:23 -05:00
Rene Moser
859b2f7948 composer: smarter arguments handling 
To get all available options in json for each command, `composer help <command> --format=json` can be used. This allows us to simply parse the output and dynamically find out if an option is available. Neat!
 2016-12-08 11:33:23 -05:00
Rene Moser
b9960c0172 composer: rename composer_install to composer_command 2016-12-08 11:33:23 -05:00
Rene Moser
61fcbe0d51 composer: simplify has_changed() 2016-12-08 11:33:23 -05:00
Indrajit Raychaudhuri
42a28d92e2 Additional upgrade mode fixes for pacman module with check_mode safety - ensure upgrade option honors and actually supports check_mode - enabling just upgrade and update_cache should perform upgrade - example added for the equivalent for pacman -Syu 2016-12-08 11:33:22 -05:00
gfrank
3ea3b9efc9 Move comments to the documentation 2016-12-08 11:33:22 -05:00
gfrank
6fa4292bed Remove unnecessary aliases arrays 2016-12-08 11:33:22 -05:00
gfrank
ebbe086d3a Clean up unneeded comment and comma 2016-12-08 11:33:22 -05:00
gfrank
fbf6c2ddc3 Adding nssm requirement note 2016-12-08 11:33:22 -05:00
gfrank
d6c42c0e6f Adding win_nssm module 2016-12-08 11:33:22 -05:00
Michael Perzel
9fd59bde6d Remove duplicate action declaration. 2016-12-08 11:33:22 -05:00
Michael Perzel
6f752a871b Note parameters that are not idempotent 2016-12-08 11:33:22 -05:00
Michael Perzel
141b3ce41f Fix logging of error message 2016-12-08 11:33:22 -05:00
Michael Perzel
0f9c81a8c2 Add support for specifying user for scheduled task to run as 2016-12-08 11:33:22 -05:00
Michael Perzel
7ea34369f7 Add support for command arguments 2016-12-08 11:33:22 -05:00
Michael Perzel
f1e8de2f67 Show order of operations with parenthesis 2016-12-08 11:33:22 -05:00
Michael Perzel
0d78c01d32 Use helper methods to validate vars. Cleanup logic. 2016-12-08 11:33:22 -05:00
Michael Perzel
dae8cfe0a9 Remove accidental newlines 2016-12-08 11:33:22 -05:00
Michael Perzel
e3c6dbf14e Cleanup enable/disable logic 2016-12-08 11:33:22 -05:00
Michael Perzel
66d9d896e4 Update method to determine if task exists, add days of week parameter to weekly triggers 2016-12-08 11:33:22 -05:00
Michael Perzel
28164d2ae4 Ability to add/remove scheduled task 2016-12-08 11:33:21 -05:00
Konstantin Manna
21d1cd81f7 bugfix: uncall an uncallable dict 2016-12-08 11:33:21 -05:00
Konstantin Manna
19da801665 bugfix: use correct function close calls 2016-12-08 11:33:21 -05:00
Indrajit Raychaudhuri
f10de6e47b Add 'package' alias and support for list type for pacman 'name' parameter 2016-12-08 11:33:21 -05:00
Jonathan Mainguy
1b7b7a2578 Adds part=false feature to irc module. This allows people to use a faux bot without part/dconns between messages, tested using a user logged into znc as our faux bot, defaults to old style of part/dconn if part= not specified 2016-12-08 11:33:21 -05:00
Toshio Kuratomi
d763a4f874 Fix for errors in the generated rst 2016-12-08 11:33:21 -05:00
Toshio Kuratomi
4350ed28c3 docs fixes 2016-12-08 11:33:21 -05:00
Chris Hoffman
fa82572f01 Removing token obfuscation 2016-12-08 11:33:21 -05:00
Chris Hoffman
3f7fe00110 Adding support for service ACLs in consul_acl module 2016-12-08 11:33:21 -05:00
Andy Baker
507352e4f0 Fix existing_mailbox check 2016-12-08 11:33:21 -05:00
Robyn Bergeron
899784c638 Update REVIEWERS.md with full picture process 
Made process picture be inline. Yay, me!
 2016-12-08 11:33:21 -05:00
Robyn Bergeron
ca87872e03 Update REVIEWERS.md 
Updated version of REVIEWERS.md with new review process for ansible-modules-extras, as outlined here: https://groups.google.com/forum/#!topic/ansible-project/bJF3ine7890
 2016-12-08 11:33:21 -05:00
Benno Joy
20368cbc2c remove facts and fix docs for taskdefinition module 2016-12-08 11:33:21 -05:00
Mark Chance
1e758cf6a0 cloud amazon ECS task modules 2016-12-08 11:33:21 -05:00
Mark Chance
241aeebdc1 cloud amazon ECS task definition module 2016-12-08 11:33:21 -05:00
Mark Chance
495e029c75 fix docs, enhance fail msgs 2016-12-08 11:33:21 -05:00
Mark Chance
aa4cecdcf5 cloud amazon ECS cluster module 2016-12-08 11:33:20 -05:00
TimothyVandenbrande
8cb80ce7bf upon request, added the license 2016-12-08 11:33:20 -05:00
Timothy Vandenbrande
12a26a8f81 add version_added: "2.0" 2016-12-08 11:33:20 -05:00
Timothy Vandenbrande
8aa14ac4aa renamed profile var 2016-12-08 11:33:20 -05:00
Timothy Vandenbrande
c7fb582b9c windows default to current instead of all 2016-12-08 11:33:20 -05:00
Timothy Vandenbrande
3511497dc1 renamed the module 2016-12-08 11:33:20 -05:00