Commit graph

13785 commits

Author SHA1 Message Date
Peter Sprygada
817881d64f fixes problem where wrong ACL could be selected (#3099)
This fixes a bug where the wrong acl name could be matched in the running
config if the desired acl name is a starting subset.
2016-12-08 11:34:56 -05:00
Tim Rupp
6f0477a780 Fixes the enabled_vlans argument (#3061)
This argument had a couple of issues with it. First, as it was
being interpreted in the code, it did not check for idempotency.

Second, the model of having the parameters be "all_*" is going to
hinder the ability to "undo", so-to-speak, what the user did while
maintaining legibility.

Consider if the user specified "all_enabled_vlans='net1'" and then
decided they wanted to backout of this decision. What is the proper
argument to fulfill this wish? "all_enabled_vlans='...?'

This patch changes the all_enabled_vlans argument to be "enabled_vlans",
ensures that idempotency works, and also provides for a way to "undo" a
change to the enabled VLANs by allowing the user to specify the special
case VLAN named "ALL" (all capitals).

This makes the parameter more intuitive because the users will specify
which vlans they want to make the virtual available on

  * enabled_vlans="net1"

but also allows them to "undo" what they did by setting it back with
the case of all

  * enabled_vlans="ALL"
2016-12-08 11:34:56 -05:00
Tim Rupp
223d5cc7ee Adds copyright line for F5 contributed modules (#3081)
I was asked to do this as part of the contribution effort in house
2016-12-08 11:34:56 -05:00
Tim Rupp
de08965ab3 Corrects the required SDK version (#3095)
The SDK version that was mentioned originally was incorrect
2016-12-08 11:34:56 -05:00
Pieter Hollants
c2992fbb81 zypper_repository: Prepend --gpg-auto-import-keys before refresh command (#3088)
Fixes #3086.
2016-12-08 11:34:55 -05:00
Robin Roth
48ee364950 Add documention for enabled option in zypper_repository (#3083) 2016-12-08 11:34:55 -05:00
René Moser
d2eeabf129 slack: fix handling of html entities and escaping (#3032)
for < > & ' and "
2016-12-08 11:34:55 -05:00
Jonathan Mainguy
d4b94ec6bb fix timezone for centos6 (#3078) 2016-12-08 11:34:55 -05:00
John R Barker
66eaa464ee Typos in doc's strings (#3071) 2016-12-08 11:34:55 -05:00
Toshio Kuratomi
d52fc0f8a6 Update shippable config (#3063) 2016-12-08 11:34:55 -05:00
THEBAULT Julien
bfb1ad6690 Fix mongodb user compatibility check (#2731)
- Check the compatibility asap
2016-12-08 11:34:55 -05:00
Bryan Hundven
50092ed629 Fix the comment in the example. (#3050)
Fix the typo: `Crate` -> `Create`. Make a complete sentence.

Signed-off-by: Bryan Hundven <bryanhundven@gmail.com>
2016-12-08 11:34:55 -05:00
Ryan Brown
cdd874e61d Fix owner on gce_img 2016-12-08 11:34:55 -05:00
Rob
20cfe15e56 If parameters for policy, tags or versioning are not supplied, do not change the existing values defined for the bucket (#2938) 2016-12-08 11:34:55 -05:00
John R Barker
3a3612f57b asa_template is now deprecated (#2992)
* asa_template is now deprecated

* Delete asa_template

Since asa_template was added during 2.2 development, rather than
deprecate them
2016-12-08 11:34:55 -05:00
John R Barker
94bd3a70e5 Correct typos (#3055) 2016-12-08 11:34:55 -05:00
Ondra Machacek
7f51ec8bab ovirt_vms: wait for VM to be created for states stopped/suspended (#3044) 2016-12-08 11:34:55 -05:00
Thierno IB. BARRY
c0cfd1db45 elasticsearch_plugin: rewrite module to not use unsupported parameters (#2839)
* elasticsearch_plugin: rewrite module to not use unsupported parameters (#1785)

Avoid using parameters when they are not needed (#1785)

* elasticsearch_plugin: add version only during plugin installation and parse plugin name for its removal

* elasticsearch_plugin: join command args before running it
2016-12-08 11:34:55 -05:00
Tim Rupp
781dd9c459 Distinguish between untagged and tagged vlans
We were incorrectly making VLANS always be untagged when they could
be either tagged or untagged. This change corrects the arguments to
the vlan module to allow for specifying either untagged or tagged
interfaces. The arguments are mutually exclusive
2016-12-08 11:34:55 -05:00
Michael Scherer
9ec65db778 Use 'path' type for file arguments 2016-12-08 11:34:55 -05:00
Michael Scherer
c8bfab9c08 Add missing deps, since we use openssl to verify the date 2016-12-08 11:34:54 -05:00
Ryan Saunders
b48e1e9b65 Fix documentation typos and broken URL (#3039) 2016-12-08 11:34:54 -05:00
René Moser
91277fc0c7 twilio: fix false negative failure - sms was sent successfully (#3033) 2016-12-08 11:34:54 -05:00
Lujeni
e226211c5b Fix mongodb_user ssl_cert_reqs param (#2963) (#2965) 2016-12-08 11:34:54 -05:00
Michael Scherer
ead83cd148 Fix error in description of acme_directory (#3034) 2016-12-08 11:34:54 -05:00
Matt Clay
10ac3ba617 Revert "Set PRIVILEGED=true for Linux integration tests. (#3031)"
This reverts commit 7df7b52a5e4ce876910aaa61bc75d5e66d16adb6.
2016-12-08 11:34:54 -05:00
steve-dave
587636b525 ec2_win_password.py - handle missing or unparseable key file more intuitively (#2729) 2016-12-08 11:34:54 -05:00
shane-walker
f108f8ef72 Fixes #1375, will check for new and outdated packages when running. (#3020) 2016-12-08 11:34:54 -05:00
Matt Clay
eedca027ee Set PRIVILEGED=true for Linux integration tests. (#3031)
This should allow test_mount tests to run on Shippable.
2016-12-08 11:34:54 -05:00
Matt Clay
841ec9ef1b Fix handling of ansible-doc errors. (#3030) 2016-12-08 11:34:54 -05:00
Lujeni
477d174fbc Fix mongodb_user default role value when update_password is set (#2997) 2016-12-08 11:34:54 -05:00
jctanner
981d1d3f96 vmware_guest: set the cpu and memory settings on clone (#3027)
Fixes #3026
2016-12-08 11:34:54 -05:00
Ryan S. Brown
bdec3a7cbb Fix ec2_asg_facts when name parameter is None
Closes #3021
2016-12-08 11:34:54 -05:00
Tim Rupp
15df1c84ad Fixes the bigip_selfip module to respect traffic groups (#3009)
The code for traffic groups was not being tested and therefore
had errors associated with it. It is now covered in coverage tests
and bugs that were found in it have been fixed.

See this issue for details
https://github.com/F5Networks/f5-ansible/issues/28
2016-12-08 11:34:54 -05:00
nitzmahone
4ff086c1a8 Fix win_chocolatey version comparison
fixes #2995
2016-12-08 11:34:54 -05:00
Matt Clay
b2b3d99839 Add shellcheck to sanity checks. (#3013)
Also disable deprecation warnings during module validation.
2016-12-08 11:34:54 -05:00
Tim Rupp
5abc8a1927 Corrects an implied map() usage as list (#3010)
In the six package, the map() function returns an iterator instead
of a list. This code was continuing to use the map() return value
as if it were a list and this broke the address_class facts.

This patch changes the code to use the list() method on the return
value of map().
2016-12-08 11:34:53 -05:00
Tom Melendez
fd92b66332 Change 'values' to 'record_data' for gcdns module. (#3003)
Using values caused problems while creating an integration playbook as it is a reserved word.  Seeing as this module is not yet released, it's prudent to make this change now.  'record_data' is more descriptive and uses the _data convention that we've established for instances.

No functionality in the module has changed.
2016-12-08 11:34:53 -05:00
Ondra Machacek
e7afabf060 Fix example in ovirt_auth module (#3001)
This patch fix missing quotes in ovirt_auth revoke token example
2016-12-08 11:34:53 -05:00
Robin Roth
a9cd8abb75 List python-xml in requirements for zypper* (#2937) 2016-12-08 11:34:53 -05:00
René Moser
59e6203a17 composer: update docs about issues on macOS if installed by homebrew (#2987) 2016-12-08 11:34:53 -05:00
Ondra Machacek
999a6488cf Ovirt auth/vms/disks modules (#2836)
* Add oVirt module to manage VMs

This patch add oVirt module to manage Virtual Machines

* Add oVirt module to manage authentication

This patch add oVirt module to manage authentication

* Add oVirt module to manage disks

* Added VM state management and fixups
2016-12-08 11:34:53 -05:00
perbly
ec05027c7e added enabled vlan functionality for f5 vip (#2988)
* added vlan functionality for f5 vip

* line 91, : was missing after description
2016-12-08 11:34:53 -05:00
Matt Clay
2152291960 Remove script previously used by Travis. 2016-12-08 11:34:53 -05:00
Lujeni
aa6aedf26c Improve mongodb_user exception (#2962)
- Better error message
2016-12-08 11:34:53 -05:00
Matt Clay
46d0b4dc16 Test module docs on Shippable. (#2976) 2016-12-08 11:34:53 -05:00
Matt Clay
5d78239f07 Combined notes to avoid duplicate key warning. (#2980) 2016-12-08 11:34:53 -05:00
Rob
e07c71dd99 Modification of describe_gateways key so that it is consistent with w… (#2936)
* Modification of describe_gateways key so that it is consistent with what create_gateway returns.
Also added AnsibleModule spec to require bgp_ip on state=present as defined in the doc

* Don't remove CustomerGateways key to preserve backward compatibility
2016-12-08 11:34:53 -05:00
jctanner
4cb3e87ca4 vmware_guest: do not assume disk params contain a datastore (#2974)
* vmware_guest: do not assume disk params contain a datastore
* Fix missed line during connection refactor
2016-12-08 11:34:53 -05:00
Matt Clay
f3e2f5d002 Remove Travis config since we only use Shippable. (#2975) 2016-12-08 11:34:53 -05:00
Matt Clay
a88dae905d Enable python 3 sanity tests for more modules. (#2973) 2016-12-08 11:34:52 -05:00
Michael Scherer
5f0017d99d Remove duplicate key from the doc (#2970) 2016-12-08 11:34:52 -05:00
Michael Scherer
6b5b90c4b8 Merge duplicated notes, fix warning returned by ansible-doc (#2969) 2016-12-08 11:34:52 -05:00
Adrian Likins
f4943bcf4c Fix 'netapp_e_lun_mapping ... documentation error' (#2966)
The 'short_description' in netapp_e_lun_mapping was a
list instead of txt.

This fixes errors on 'ansible-doc -l' of form:

        ERROR! module netapp_e_lun_mapping has a documentation
        error formatting or is missing documentation

Fixes: #17634 (ansible/ansible)
2016-12-08 11:34:52 -05:00
Adrian Likins
50dcce185f Remove redundant doc keys for netapp_e_ modules (#2968)
Fixes #2967
2016-12-08 11:34:52 -05:00
jctanner
10e50652b2 vmware_guest: small refactor (#2955)
* use connecion method from module_utils
* use resource group related to host system

Addresses #2911
2016-12-08 11:34:52 -05:00
Michael Scherer
1702937ab3 Do not import xenapi without checking, so we can avoid (#1953)
backtrace
2016-12-08 11:34:52 -05:00
Michael Scherer
6967a32ce4 Fix the mysql_replication argument (#2111)
Login_password and master_password are password, should not
be logged. And config_file is a path t be expanded, so tagged as
such.
2016-12-08 11:34:52 -05:00
Hans-Joachim Kliemeck
443dba148c Fix mongodb user idempotence with 2.4 version (#2725) (#2920) 2016-12-08 11:34:52 -05:00
Alexandre Garnier
f06e2e7a0b Fix mixed type comparison resulting in wrong changed (#2772)
When using `use_max` or `use_min` in `pam_limits`, the new value is an integer compared with the actual_value which is a string, so they are always different and the module reports a changed but none occurred.
2016-12-08 11:34:52 -05:00
Matt Clay
839adc208f Update CI badge. 2016-12-08 11:34:52 -05:00
Matt Clay
d1ba765ba0 Cosmetic fix to test PR and merge hooks. (#2949) 2016-12-08 11:34:52 -05:00
Matt Clay
3e86ad1a3a Run same tests on Shippable as on Travis. (#2948)
Run the same tests as used on Travis.
2016-12-08 11:34:52 -05:00
Ryan S. Brown
dc6fd4ee8a Add lambda_event module 2016-12-08 11:34:52 -05:00
Ryan Sydnor
3c6ae0063b Add Amazon Elastic File System Facts (efs_facts) module
Also switch EFS module to using boto3_conn from boto3.Session
2016-12-08 11:34:52 -05:00
Ryan Sydnor
dfec3d3c4c Add Amazon Elastic File System (efs) module 2016-12-08 11:34:51 -05:00
Ryan Brown
d92c3c6fa8 Import Lambda alias module from https://github.com/pjodouin/ansible-lambda (#2829) 2016-12-08 11:34:51 -05:00
Ryan S. Brown
ce72e52c50 Fix redshift module Python 3.5 syntax 2016-12-08 11:34:51 -05:00
Ryan Brown
559093f1a3 Fix exception syntax for Python 3.x (#2940)
since boto already precludes python2.4, no need to use a common 2.4/3 syntax
2016-12-08 11:34:51 -05:00
Steyn Huizinga
4240d2a511 Add AWS Lambda module (#1270) 2016-12-08 11:34:51 -05:00
Jim Dalton
cee898f73a Add module for managing CloudWatch Event rules and targets (#2101) 2016-12-08 11:34:51 -05:00
Jens Carl
9f2b1abbc3 New ansible module for aws Redshift and Redshift subnet group (#185) 2016-12-08 11:34:51 -05:00
Adrian Likins
68823a4e2d Add modules for NetApp SANtricity storage platform (#2929)
The modules prefixed with netapp_e* are built to support the
SANtricity storage platform.

The modules provide idempotent provisioning for volume groups, disk
pools, standard volumes, thin volumes, LUN mapping, hosts, host groups
(clusters), volume snapshots, consistency groups, and asynchronous
mirroring.

They require the SANtricity WebServices Proxy.
The WebServices Proxy is free software available at
the NetApp Software Download site:

   http://mysupport.netapp.com/NOW/download/software/eseries_webservices/1.40.X000.0009/

Starting with the E2800 platform (11.30 OS), the modules will work
directly with the storage array.  Starting with this platform, REST API
requests are handled directly on the box.  This array can still be
managed by proxy for large scale deployments.
2016-12-08 11:34:51 -05:00
jctanner
3dedecd81e vmware_guest improve and fix some of the errors (#2926)
* Add more comments and fix issue with unit conversion
2016-12-08 11:34:51 -05:00
Marcin Kawa
dde76066d3 Fix undefined info error and accept HTTP 201 response code (#2643)
Prevent referenced before assignment error when `notify` argument is not specified and accept HTTP 201 (created) code.
2016-12-08 11:34:51 -05:00
jctanner
d9b5d9e551 vmware_guest: use the disk argument to modify disk size and type (#2918)
Fixes #2706
2016-12-08 11:34:51 -05:00
Rene Moser
bbf60e36eb zabbix_host: fix typos in arg spec of login_user
Credits to @JasonCormie
2016-12-08 11:34:51 -05:00
Ryan Brown
dae2daf692 New module: lambda_facts (#2874) 2016-12-08 11:34:51 -05:00
David Stygstra
3539238ec7 Use modprobe -r instead of rmmod in modprobe module (#2669)
If any modules that the module being removed depends on are unused, they
will also be removed. Fixes #2140.
2016-12-08 11:34:51 -05:00
Michael Grüner
3dd0752746 letsencrypt: Improve error handling (#2868)
* letsencrypt: improve error handling

Use the new "body" field of the info dict in case of a HTTPError.

* letsencrypt: HTTP 202 is a valid status while polling
2016-12-08 11:34:51 -05:00
Steve Gargan
b57b74e40b remove duration from lock delay as seconds are the only granularity supported. (#2877)
add utf header to file so that it loads correctly
2016-12-08 11:34:51 -05:00
René Moser
c203283889 jenkins_job fix: NameError: global name 'module' is not defined (#2910) 2016-12-08 11:34:50 -05:00
Tim Rupp
4e8566739e Fixes domains method not defined (#2907)
The domains method was not defined, and therefore when specifying
a parent domain during route domain creation, the process would
fail.

Tests have been added to detect this going forward
2016-12-08 11:34:50 -05:00
jctanner
b6fd074bd0 vmware_guest implement clonevm for multi-dc environments (#2909)
* Fix bug in processing of null return
* Fix multi-dc folder location by enhancing the foldermap and using it to search
* Remove unused functions
* Refactor finding vm by folder

Fixes #2900
2016-12-08 11:34:50 -05:00
Cougar
7dbdadb396 vmware_guest Fix: remove 'nic' and 'disk' requirements for facts (#2844) 2016-12-08 11:34:50 -05:00
Benjamin Doherty
ac72df08dd Updates to archive module based on code review (#2699)
* Use common file arguments on destination file
* Rename 'compression' to 'format' h/t @abadger
* Add support for plain 'tar' format
* Ensure check_mode is respected
2016-12-08 11:34:50 -05:00
Peter Sprygada
4932df69bc updates to asa_config module for Ansible 2.2
* clean up functions and remove unneeded code
* config difference now includes keyword argument
* module reports changed when save argument is yes with or without check_mode
* updated fail_json return with exc kwargs
* fixed up import statements
2016-12-08 11:34:50 -05:00
Peter Sprygada
dc52d3627a fixes a number of nagging issues in asa_acl due to refactoring
* fixes issues with import error
* removes need for filter attribute in Cli instance
* now filters config either from device or provided via config argument

ref: #2890
2016-12-08 11:34:50 -05:00
Rene Moser
edb24dac2d jenkins_job: refactoring 2016-12-08 11:34:50 -05:00
Rene Moser
3c04ed977d jenkins_job: implement diff support 2016-12-08 11:34:50 -05:00
Rene Moser
171b71cfa0 jenkins_job: rename enable to enabled and mutually exclusive with config
Jenkins stores the information about the state (disabled/enabled) in the config, which result in a race condition between `config` and `enabled` and we loose idempotency. It makes sense to define them mutually exclusive.

Renamed `enable` to `enabled`. Ansible uses the name `enabled` in many modules, e.g. service as it indicates a state not an action.
2016-12-08 11:34:50 -05:00
Rene Moser
bd4c935fd7 jenkins_job: default state to present 2016-12-08 11:34:50 -05:00
Will Thames
3eeda4f844 firewalld should fail nicely when service is stopped (#2871)
Ensure the HAVE_FIREWALLD checks check only for the
presence of the python dependencies, and not the age
of the library or the state of the service, which
are checked later.
2016-12-08 11:34:50 -05:00
Peter Sprygada
7ce98f52cf bug fix in asa_acl module for missing candidate config
This bug was introduced accidentally when refactoring to 2.2.  The instance
of the candidate config was deleted.  This adds the candidate config
instance back

fixes #2890
2016-12-08 11:34:50 -05:00
Tobias Wolf
62575fdf48 Fix one character typo in my previous PR for debconf module (#2899)
Small oops in the previous PR #2530 commit.

Instead of `diff_dict` it slipped through as `diffdict`.

Please merge and sorry.
2016-12-08 11:34:50 -05:00
Alex
e2795d1401 Start zypper in non-interactive mode (#2854) 2016-12-08 11:34:50 -05:00
sgujic
d34f3b4c05 Create temporary file in a secure manner. (#2887) 2016-12-08 11:34:49 -05:00
Nils Pascal Illenseer
acadc2ac9c Delete lxd container in state stopped (#2885)
If a lxd container is stopped, do not stop it before deleting it.
2016-12-08 11:34:49 -05:00
Gilles Gagniard
05c8630b48 GCE : Fix image family handling with libcloud > 0.20.1 (#2289)
* fix image family handling with libcloud > 0.20.1

* add missing import
2016-12-08 11:34:49 -05:00
Robyn Bergeron
7c27f57052 Updating GUIDELINES.md
Updating info on how issues are routed via bot.
2016-12-08 11:34:49 -05:00