Christoph Dittmann
1f1febaa0d
Let PlayIterator.add_tasks accept empty task lists
...
PlayIterator.add_tasks raised an error when trying to add an empty task
list. This was the root cause of ansible issue #13370 .
2015-12-02 09:00:26 -05:00
Brian Coca
346a9fe87d
unconditionally set vars on init to avoid issues with var precedence
2015-12-01 21:25:43 -08:00
Peter Sprygada
5b5c6c4f47
fixes a syntax issue with module_utils/eapi.py
...
This patch fixes an issue with the common args dict in the eapi shared
module. This patch is required for the eapi shared module to be properly
imported and is therefore should be applied to all instances.
2015-12-01 20:46:11 -08:00
Peter Sprygada
02d059271c
initial add of ssh shared module.
...
This ssh shared module is used for building modules that require an
interactive shell environment such as those required for connecting
to network devices
2015-12-01 19:15:41 -08:00
Peter Sprygada
a6771b2255
adds module create function for eapi.py shared module
...
This commit changes the way modules create an instance of AnsibleModule to
now use a common function, eapi_module. This function will now automatically
append the common argument spec to the module argument_spec. Module
arguments can override common module arguments
2015-12-01 19:14:38 -08:00
Peter Sprygada
a9e8b54246
initial add of the ios shared module
...
This adds shared module support for building modules that connect to Cisco
IOS devices. It builds on the module_utils/ssh.py shared module.
2015-12-01 19:05:14 -08:00
Brian Coca
d2108e9ff3
fixed signature for init on callbacks
...
also removed passing display to base class which already handles this
2015-12-01 14:07:47 -08:00
nitzmahone
59dadc4f6b
allow shell plugin to affect remote module filename
...
Fix for 13368, added get_remote_filename to shell plugins, powershell version appends .ps1 if necessary, base shell plugin no-ops
2015-12-01 14:02:01 -08:00
Toshio Kuratomi
b0e22d7701
_connect no longer takes a port argument
2015-12-01 09:12:55 -08:00
Brian Coca
ca8c6e8e1c
ignore password flags in become conflict check
...
since all the --ask pass options end up triggering the same code
and are functionally equivalent, ignore them when it comes to checking
privilege escalation conflicts. This allows using -K when --become-method=su
and so on.
2015-12-01 08:57:33 -08:00
Brian Coca
204e27ca66
avoid inheritance issues with default=dict declaration at class level
...
this should avoid the issue of subsequent plays not prompting for a var
prompted for in a previous play.
fixes #13363
2015-11-30 15:12:53 -08:00
James Cammarata
f96730003b
Also make sure remote_user is defaulted correctly for delegated hosts
...
Fixes #13323
2015-11-30 16:16:11 -05:00
Toshio Kuratomi
4f3f79d37b
Call the function :-)
...
Fixes #13330
2015-11-30 12:34:55 -08:00
James Cammarata
89f0207007
Ensure port is (re)set for delegated-to hosts
...
Fixes #13265
2015-11-30 14:41:05 -05:00
Brian Coca
f8ed1c003a
fixed typo
2015-11-30 09:21:26 -08:00
Brian Coca
c5cd908c33
allow for bad stdout return from make temp dir command
...
fixes #13359
2015-11-30 09:20:24 -08:00
Brian Coca
958da26d18
corrected become_methods class variable in winrm
...
This should now correctly react when using become with winrm
fixes #13331
2015-11-30 08:35:33 -08:00
James Cammarata
a5d6be6dd2
Make sure run_once tasks properly set variables for all active hosts
...
Fixes #13267
2015-11-30 11:28:28 -05:00
James Cammarata
7af506e7cf
Use text_type instead of unicode
2015-11-30 11:28:25 -05:00
James Cammarata
3a0f2475b2
Make sure the uuid in vars is string
2015-11-30 10:27:21 -05:00
James Cammarata
2db3f12027
Re-implement lookup wantlist
...
Fixes #13285
2015-11-29 23:45:14 -05:00
Yannig Perré
bb52b45ea0
Do not copy variable_manager each time. Instead, keep host and local variable_manager sync.
...
Fix https://github.com/ansible/ansible/issues/13221
2015-11-29 23:15:01 -05:00
James Cammarata
4114a3097f
Tweak location of stats callback execution and properly relocate stats output code
2015-11-28 14:02:50 -05:00
Monty Taylor
73a269f9a5
Put in trap for args being None
...
_normalize_old_style_args can return None. If it does, the loop
"for args in args" blows up.
2015-11-28 13:44:44 -05:00
James Cammarata
737e467b8a
Trigger on_stats just once, not once for each play
...
Fixes #13271
2015-11-28 13:37:02 -05:00
Abhijit Menon-Sen
cac0eea291
Explicitly accept become_success in awaiting_prompt state
...
If we request escalation with a password, we start in expecting_prompt
state. If the escalation then succeeds without the password, i.e., the
become_success response arrives, we must explicitly move into the next
state (awaiting_escalation, which immediately goes into ready_to_send),
so that we no longer try to apply the timeout.
Otherwise, we would leak the success notification and eventually
timeout. But if the module response did arrive before the timeout
expired, the "process has already exited" test would do the right
thing by accident (which is why it didn't fail more often).
Fixes #13289
2015-11-28 10:22:35 -05:00
James Cammarata
54843d88ee
Re-adding role_name/role_uuid variables
2015-11-28 10:00:42 -05:00
Yannig Perré
47651e6c22
More restrictive test against variable name to allow setting variable starting with _.
2015-11-28 10:00:38 -05:00
Yannig Perré
9e6ec4c6b0
Switch parameters validation after parsing in order to be more consistent between old and new style.
2015-11-28 10:00:34 -05:00
Brian Coca
dbedcd3538
avoids prompting for vars during syntax check
...
fixes #13319
2015-11-27 11:46:32 -08:00
Toshio Kuratomi
056372690f
Do not double transform to unicode
2015-11-25 07:56:06 -08:00
Charles Paul
9cee982a62
fixing errors with utf-8 values
...
removing utf-8 stanza
changing cast to binary_type instead
using to_unicode
2015-11-25 07:55:52 -08:00
Brian Coca
b69942a6d2
added missing :
2015-11-25 10:57:55 -08:00
Brian Coca
d9858ee73a
added missing events to base class
2015-11-25 10:57:55 -08:00
Brian Coca
64bcab9253
fixes to fetch action module
...
* now only runs remote checksum when needed (fixes #12290 )
* unified return points to simplify program flow
2015-11-25 10:57:04 -08:00
James Cammarata
fc4326dc0c
Fix ssh state issues by simply assuming it's never connected
2015-11-24 12:01:42 -05:00
James Cammarata
92ea5c9f7b
Properly check for prompting state when re-using ssh connection
...
Fixes #13278
2015-11-24 09:10:51 -05:00
Yannig Perré
90021104d5
Use to_unicode instead of str()
2015-11-23 16:49:00 -05:00
Yannig Perré
8bd5abaf1e
Allow debug var parameter to accept a list or dict. Fix https://github.com/ansible/ansible/issues/13252
2015-11-23 16:49:00 -05:00
Sebastien Couture
2859933a79
We should give pipes.quote() a string every time
2015-11-23 14:27:56 -05:00
James Cammarata
42bffeec7c
Template (and include vars) PlaybookInclude paths
...
Fixes #13249
2015-11-23 14:04:14 -05:00
Chris Church
9a8e95bff3
Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items.
2015-11-23 14:04:00 -05:00
Brian Coca
1e9e6339d1
marked spot that should send per item reulsts
2015-11-23 14:03:51 -05:00
Toshio Kuratomi
5bc3efe34b
Update submodule refs
2015-11-23 09:02:12 -08:00
Toshio Kuratomi
011df4ad24
Update docker_login so docs work
2015-11-20 13:59:02 -08:00
Toshio Kuratomi
c71ef9e3d7
Fix non-module plugins picking up files that did not end in .py.
...
This was caused by accessing the cache using the passed in mod_type
rather than the suffix that we calculate with knowledge of whether this
is a module or non-module plugin.
2015-11-20 13:51:29 -08:00
Toshio Kuratomi
e9ed190f7b
Update submodule refs
2015-11-20 12:45:27 -08:00
Toshio Kuratomi
50a924bb04
Docker cp sets file ownership to root:root so we can't use it.
...
Fixes #13219
2015-11-20 07:54:07 -08:00
Toshio Kuratomi
1e968d34cb
Simplify code a little
2015-11-19 09:56:58 -08:00
Joern Heissler
c99fffa936
Use ansible_host in synchronize module
...
Fixes #13073
2015-11-19 09:56:49 -08:00