Commit graph

1083 commits

Author SHA1 Message Date
Sam Doran
2cc8f3afb7 [stable-2.8] hostname - Correct distribution for various Linux distros based on output from distro library (#56936)
* Adjust hostname classes based on output from distro

Corrects the following:
- OpenSUSE Leap
- ArchARM
- Oracle Linux

* Add CoreOS and Clear Linux distributions
(cherry picked from commit bd55617a5b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-21 15:40:22 -07:00
Sumit Jaiswal
062074e68e Backport PR to fix ios_facts ansible_net_model (#58174)
* PR to fix where ansible_net_model was not being populated (#58159)

* fix bug 57285

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* minor fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding TC fix related

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable error

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 58d446e61a)

* fix ansible_net_model

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* Fix ios test for python2 non-ascii paths

(cherry picked from commit eb7e4591ae)
2019-06-21 15:35:33 -07:00
Andrey Klychkov
f548999290 PostgreSQL modules: move params mapping from main to connect_to_db() function Backport/2.8/55799 (#57473)
* PostgreSQL modules: move params mapping from main to connect_to_db() function (#55799)

* PostgreSQL modules: move params mapping from main to connect_to_db() function

* PostgreSQL modules: fix postgresql_db

* PostgreSQL modules: fixes

(cherry picked from commit 9b17346d1e)

* postgresql moving params mapping to connect_to_db: added changelog fragment

* postgresql moving params mapping to connect_to_db: add get_conn_params, fix conflicts
2019-06-21 06:32:18 -07:00
Felix Fontein
6a71aef6c5 docker_*: make modules more robust on Docker errors (#57913)
* Improve general error behavior if a Docker error is not caught.

* Don't die when network doesn't exist.

* Add changelog.

* Make API version always available. Also catch errors when retrieving version.

* Fix error message.

* Adjust fallback error messages.

(cherry picked from commit f8f2738351)
2019-06-20 19:09:57 -07:00
Brian Coca
04e94274fb safe_eval fix (#57188)
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23015)
2019-06-20 18:22:29 -07:00
Matt Martz
5e0c623f38 [stable-2.8] Create new instance of the action plugin per until iteration. Fixes #57886 (#58022)
(cherry picked from commit ffd1171)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-20 18:21:53 -07:00
Dmitriy Yakovlev
cd00cb1e8c docker_swarm_service: Added default value for mounts.source (#58039)
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end

(cherry picked from commit 122d4164c5)
2019-06-20 13:58:45 -07:00
Felix Fontein
5f719bba18 crypto modules: Improve requirements / error messages (#57868)
* Reformat requirements.

* Include Python lib versions in lib required error messages, if available.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>

* Add changelog.

(cherry picked from commit 4188cd299b)
2019-06-20 13:57:33 -07:00
Matt Martz
c42a6155a9 [stable-2.8] ssh: Ensure debug messages are properly converted to text (#57850)
* ssh: Ensure debug messages are properly converted to text. Fixes #57843

* surrogate_then_replace is default, be less explicit

* We only needed to_text for display, not exceptions
(cherry picked from commit 375ac76)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-20 10:58:15 -07:00
Yurii Vlasenko
7d9a527086 docker_container: Change expected config source (#57969)
* Change expected config source

* make it conditional

* rename property

* Add changelog fragment

* make it string

* Update changelogs/fragments/57969-docker_container-change-expected-config-source.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8c1c2afd02)
2019-06-20 10:40:36 -07:00
Paul Belanger
2dac2d1601 Pull request for temp/iosxr-back (#58075)
* Fix python3 encoding with iosxr_config (#57919)

Python3 requires bytes when writing files.

(cherry picked from commit d40c44bd56)
Depends-On https://github.com/ansible/ansible/pull/58073
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

* Add changelog fragment

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-19 10:57:10 -07:00
Chris Archibald
ba30649af9 Backport/2.8/57379 (#58080)
* Duplicate rules were being created if rule index was not set (#57379)

* bug fixes

* Revert "bug fixes"

This reverts commit 2d839ecf350260ba857ef820f761c8a0e1241102.

* bug fix

(cherry picked from commit e80d6f18ce)

* add fragment
2019-06-19 10:56:15 -07:00
Nathaniel Case
378ddec5c6 [stable-2.8] Fix RESTCONF media types (#58015)
Fixes #56680
(cherry picked from commit f656959)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
2019-06-19 10:39:34 -07:00
Martin Nečas
ab50e41a4c Ovirt vnic profile fix backport (#58058)
* Ovirt vnic profile fix (#57936)

* ovirt vnic profile fix init

* ovirt vnic profile fix init

* update syntax whitespace

* document pass_through

* create get entity method

* update example syntax

* update docs

* change force_create style

* add fragment
2019-06-19 06:24:02 -07:00
Martin Nečas
4a7a8ecf50 Ovirt nic default vnic backport (#58057)
* Ovirt nic default vnic (#57945)

* default vnic init

* ovirt default nic

* add spacing

* use network must be specified

* Update ovirt_nic.py

* Update ovirt_nic.py

* add no vnic profile exception

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax

* correct pep8 syntax

* add fragment
2019-06-19 06:22:25 -07:00
Daniel Mellado Area
20fa1156b7 Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.

(cherry picked from commit 091bebcbf7)
2019-06-19 06:18:30 -07:00
Ganesh Nalawade
bafc95eb0f More iosxr integration zuul CI test fixes (#57909)
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test

(cherry picked from commit 4a3e14f90b)
2019-06-19 06:16:08 -07:00
Will Thames
1e5e663d42 rds_instance: allow empty iops and storage_type (#57943)
(cherry picked from commit a66687f2d2)
2019-06-18 12:22:27 -07:00
Stefan Horning
e720df0e5d Fix rds_instance module to run against an (older) existing RDS instance successfully
Only pop Iops param if no storage_type is given. If given and set to wrong type we get to the AWS client error that informs the user

Docs syntax fix

Fix typo in docs

Co-Authored-By: stefanhorning <stefan@hornings.de>

Added changelog fragment for rds_instance bugfix
2019-06-18 12:22:27 -07:00
Chris Archibald
221a14f674 add fragment 2019-06-18 12:22:03 -07:00
Jordan Borean
0c85472e9b Fix changelog entry (#57979)
(cherry picked from commit 40540f4d98)
2019-06-18 11:21:25 -07:00
Ganesh B Nalawade
ae995a19e2 Fix junos integration zuul CI failures
(cherry picked from commit 0957835a4814bfc0c7649675963de5e88df5060e)
2019-06-18 11:20:39 -07:00
Sumit Jaiswal
db13610701 fix 57447 bug (#57938)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit d63ccb5bc8)
2019-06-18 11:18:04 -07:00
Mariusz Mazur
b41bbd9564 Backport/2.8/57617 (#57756)
* kubevirt_pvc: fix parameter priority (#57617)

* Add changelog

* Drop superfluous dict()

Co-Authored-By: Toshio Kuratomi <a.badger@gmail.com>
2019-06-18 11:16:18 -07:00
Guillaume Martinez
36df5d22a4 gitlab_runner: Fix idempotency when creating runner (#57833)
(cherry picked from commit ec7b18952b)
2019-06-18 10:51:51 -07:00
Chris Archibald
fa6e39ddf2 Backport/2.8/57320 (#58009)
* new feature

(cherry picked from commit dbeaf30f975190cc20fbece88b12d8dd062aad07)

* add fragment
2019-06-18 10:47:47 -07:00
Sayed Anisul Hoque
9da6fc1754 Documentation error (#57924)
* Update changelogs/fragments/contains-test.yaml - allowed filters are 'select/reject' and 'selectattr/rejectattr'.
2019-06-18 09:10:24 -05:00
Brian Coca
808c2faba2 show host_vars/ also in --graph (#56307)
* show host_vars/ also in --graph

  fixes #53422

(cherry picked from commit de87b25a45)
2019-06-17 21:58:41 -07:00
Kevin Breit
81dc2ac233 [stable-2.8] - Restructure meraki_network execution (#57663)
* Resolve conflicts

* Fixes for the merge since 2.8 and devel are quite different

* Add changelog
2019-06-17 21:56:40 -07:00
ShachafGoldstein
ee48ceaf10 win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test

(cherry picked from commit 66728cb93f)
2019-06-17 21:47:14 -07:00
Jordan Borean
c1391fd636 win_shell - fix space escaping for custom executable (#57455)
(cherry picked from commit d0c4914469)
2019-06-17 21:38:16 -07:00
YuandongXu
ad0cc5dc1e Backport/2.8/57268 update acl (#57268) (#57890)
* update acl (#57268)


(cherry picked from commit e009936f87)

* add a changelog fragment for PR 57890.

* add a changelog fragment for PR 27890.
2019-06-17 21:37:42 -07:00
YuandongXu
da9f3021be Backport/2.8/57264 update vxlan to fix bugs (#57889)
* update vxlan (#57264)

* update vxlan

* add a changelog fragment for the PR 57264

* Update 57264-update-vxlan-to-fix-bugs.yml

update for change request

* Update ce_vxlan_vap.py

remove commented codes.

(cherry picked from commit 5bddd55703)

* add a changelog fragment for PR 57889.

* add a changelog fragment for PR 57889.
2019-06-17 21:35:28 -07:00
YuandongXu
9d3d8bec23 backport/2.8/57025 update snmp modules to fix bugs for cloudengine (#57025) (#57888)
* update snmp modules to fix bugs for cloudengine (#57025)

* update snmp modules to fix bugs for cloudengine

* update snmp modules to fix bugs for cloudengine

* update "ce_snmp_contact", list may be out range

(cherry picked from commit 5ac3661176)

* add a changelog fragment for PR 5788.

* add a changelog fragment for PR 57888.
2019-06-17 21:33:57 -07:00
Guillaume Martinez
0f651baf41 Backport/2.8/57024 (#57846)
* Adds visibility parameter to gitlab group creation (#57024)

(cherry picked from commit e7bf46d8bc)

* Add changelog for backport/2.8/57024
2019-06-17 21:32:42 -07:00
Martin Krizek
188688cc6b gather_facts: clean up tmp files upon completion (#57845)
Fixes #57248

(cherry picked from commit e9c83b7a17)
2019-06-17 20:05:41 -07:00
Sander Steffann
d46c187470 netbox: inventory: fix implementation of groups option (#57689)
(cherry picked from commit 71a704cc14)
2019-06-17 20:04:24 -07:00
Nijin Ashok
bad860ad46 ovirt_vm: Fix issue in resetting the storage domain lease (#57469)
Currently, there is no way to remove the lease. The patch allows to
reset it by passing an empty string ('') to lease.
2019-06-17 20:03:55 -07:00
Alexey Kamenskiy
15880a0c23 lvg: fix default value type, should be str (#57723)
(cherry picked from commit 793c18506a)
2019-06-17 20:03:13 -07:00
Martin Nečas
0521b30515 set ovirt disk active default (#57464) (#57748)
* set ovirt disk active default  (#57464)

* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs

* Update ovirt_disk.py

* Update ovirt_disk.py
2019-06-17 20:01:57 -07:00
YuandongXu
466b039b1c backport/2.8/57269 update info-center (#57269) (#57752)
* update info-center (#57269)


(cherry picked from commit 4dc6faea59)

* add a changelog fragment fot PR 57752.
2019-06-17 20:00:11 -07:00
YuandongXu
bb6955c5eb Backport/2.8/57257 option is marked as required but specifies a default (#57750)
* option is marked as required but specifies a default (#57257)

* required and default are conflicting

(cherry picked from commit 05e6339c49)

* add a changelog fragment for PR 57750.
2019-06-17 18:29:35 -07:00
YuandongXu
1b073fccc2 backport/2.8/57187 update ce_facts to fix array out of range bug (#57187) (#57698)
* update ce_facts (#57187)


(cherry picked from commit 229d20b6d9)

* add a changlog fragment for PR 57698
2019-06-17 17:15:41 -07:00
Paul Belanger
d419a2777c Make netconf_get python3 compat (#57578)
This uses to_text to ensure tostring() from lxml is decoded properly.

Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f709d2e2bb)
2019-06-17 17:15:08 -07:00
YuandongXu
ce3e358587 Backport/2.8/57183 update lib/ansible/plugins/action/ce.py to fix a bug (#57696)
* update lib/ansible/plugins/action/ce.py to fix a bug. (#57183)

* update lib/ansible/plugins/action/ce.py

(cherry picked from commit 9c3ae4c1f4)

* add a changelog fragment for PR 57696
2019-06-17 17:14:22 -07:00
Anton Nikulin
afb718f001 [stable-2.8] ftd_configuration: fix a bug with response parsing (#57480) (#57676)
* FTD configuration module: fix a bug with response parsing (#57480)

* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message

(cherry picked from commit 4fa93d5b9b)

* Add backlog entry
2019-06-17 16:27:42 -07:00
Abhijeet Kasurde
91b703b0f0 [2.8] VMware: Handle VMs with no configurations
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 7505550500)
2019-06-17 16:23:40 -07:00
ShachafGoldstein
dfc47bd6d6 win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog

(cherry picked from commit a87495d07c)
2019-06-17 15:48:47 -07:00
Matt Williams
133c7adad5 Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return

(cherry picked from commit cf00883c9d)
2019-06-17 15:47:20 -07:00
Sloane Hertel
4b0c8f1a12 [FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog

(cherry picked from commit 598a058afe)
2019-06-17 15:45:58 -07:00