Commit graph

3809 commits

Author SHA1 Message Date
Cristian Ciupitu
0749112286 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
Ali Asad Lotia
9180013682 Fix acl module doc and error messages
- Fix typos in module doc
- Provide clearer error message when entry and etype are both missing
2014-03-16 16:41:37 +00:00
Michael DeHaan
d186196901 Remove nova_fip (redundant merge relative to quantum module) 2014-03-16 12:29:19 -04:00
Steve Smith
9a8a8dfb2a Add a JIRA control module for Ansible. This version uses fetch_url rather than urllib2. 2014-03-16 17:14:04 +01:00
follower
c4f20be774 Fix typo
"a the" -> "the"
2014-03-17 00:23:16 +13:00
Brian Coca
2d25577e11 Fixes and cleanup to file functions and module
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
2014-03-15 13:54:24 -04:00
Michael DeHaan
01b7465a03 Merge pull request #6504 from follower/patch-2
Fix typo
2014-03-15 09:15:53 -05:00
Michael DeHaan
9e8a4c9d23 Merge pull request #6502 from follower/patch-1
Fix typo in example name
2014-03-15 09:15:17 -05:00
follower
af6109c169 Fix typo
"resort" -> "result"
2014-03-15 20:04:38 +13:00
follower
e05e57e0a9 Fix typo in example name 2014-03-15 19:16:14 +13:00
Brian Coca
b81a3bbb20 fixed bad detection of change on default and premature break 2014-03-15 01:10:15 -04:00
tmperret
94198690c1 Made load_balencers in ec2_lc non-required as not all ASGs require an ELB 2014-03-14 22:39:57 +00:00
Michael DeHaan
8082f74798 Add GCE guide and retool a bit to show the add_host interactions, improvements/upgrades are welcome.
Had to shoot the recently merged nova_group module in the head temporarily as it contained a dict comprehension, which means it can't work on all the platforms
and was also breaking docs builds on CentOS.  Will engage with list about that shortly.
2014-03-14 15:02:22 -04:00
Matt Martz
e2bfa86484 New module: nexmo 2014-03-14 11:06:25 -05:00
Michael DeHaan
30cdac6061 Fix docs for ec2_lc module. 2014-03-14 12:01:23 -04:00
Michael DeHaan
34f961157d Merge pull request #6491 from jlaska/apt_repository_signing_fix
[apt_repository] Correct check_mode conditional logic
2014-03-14 10:21:31 -05:00
James Tanner
9d6518de5a Fixes #6482 Check sysctl file path and catch read exceptions 2014-03-14 11:16:45 -04:00
James Laska
5cfefb326a Correct check_mode conditional logic
The desired behavior is to _not_ add the ppa signing key when check_mode is
enabled.  This fix corrects the conditional logic to comply with the stated
behavior.
2014-03-14 10:24:52 -04:00
Patrick Gerken
38d6956c1f Properly catch import errors in apt
When one accidentally tries to run this module as a user, he gets the error message that python-apt must be installed, no matter what. Because importing apt will trigger an exception as a regular user. Explicitly catching the ImportError will let the exception bubble. The exception clearly says Permission denied somewhere, and the user has a better idea, what he must fix.
2014-03-14 02:13:20 +01:00
Michael DeHaan
9eb3f8779c Merge pull request #6468 from philpep/fix_apt_key
apt_key: Fix traceback when key_id format is invalid
2014-03-13 17:58:40 -05:00
Michael DeHaan
9c189ed7a4 Merge pull request #6470 from patrickheeney/doc-git-fix
Fix documentation for accept_hostkey in GIT module
2014-03-13 17:57:56 -05:00
Paul Durivage
32996bf121 Documentation updates 2014-03-13 16:18:50 -05:00
James Cammarata
b93b99871b Fix small typo resulting in a traceback for the apt_key module 2014-03-13 13:51:59 -05:00
patrickheeney
fae36165a2 Fix documentation for accept_hostkey 2014-03-13 07:58:12 -07:00
Philippe Pepiot
92e8e59cad apt_key: Fix traceback when key_id format is invalid
Signed-off-by: Philippe Pepiot <phil@philpep.org>
2014-03-13 15:28:37 +01:00
Richard Isaacson
e6f6a73328 Merge pull request #6461 from risaacson/modules_make_run_command_safer
Modules make run command safer
2014-03-12 23:28:06 -05:00
Richard C Isaacson
2b53ece3ab mysql_db module: typo fix
Tests clean.
2014-03-12 23:25:22 -05:00
Richard C Isaacson
427221786c Shell updates. 2014-03-12 22:15:56 -05:00
James Cammarata
bd16cce3e9 Merge pull request #6460 from jsmartin/riak-bugfix
Fixes various typos, fetch_url now working, changed command composure for wait_for_service
2014-03-12 21:56:39 -05:00
James Cammarata
ccc0a8cbb0 Fix regression in dnsmadeeasy module caused by fetch_url change
Also:
* changed this module to use https for requests to the API
* fixed a bug in which a traceback was caused when the domain wasn't found

Fixes #6457
2014-03-12 20:48:22 -05:00
James Martin
3d032b9db9 Fixes various typos introduced in a9017af2bb.
Fixes odd encoding problem with wait_for_service.
2014-03-12 21:26:16 -04:00
Daniel Jaouen
81f2e43b76 Fix Homebrew._current_package_is_installed 2014-03-12 19:52:16 -04:00
Michael DeHaan
78ebf5d266 Still more shell fixes. 2014-03-12 17:44:53 -04:00
Michael DeHaan
98500b335b Fixup shell handling in monit module. 2014-03-12 17:43:31 -04:00
Michael DeHaan
dac90278db More shell fixes 2014-03-12 17:43:31 -04:00
James Tanner
6067d826e4 Close parens in portinstall 2014-03-12 17:36:48 -04:00
Michael DeHaan
4e8b97ddeb More shell updates 2014-03-12 17:31:00 -04:00
James Tanner
e7f74251c8 Fix missing colons in cpanm 2014-03-12 17:25:32 -04:00
James Tanner
89024f5d9f Fix typo in portinstall 2014-03-12 17:12:38 -04:00
Michael DeHaan
c193604f60 Some more run_command updates. 2014-03-12 17:04:34 -04:00
Michael DeHaan
81b4ebbe1d Fixes for run_command shell usage in remainder of packaging modules, save portinstall. 2014-03-12 16:57:18 -04:00
Michael DeHaan
6010e74839 Various commits to enable no-shell or safe-shell usage, more to come. 2014-03-12 16:44:35 -04:00
Patrick Smith
4173608b58 git: Execute git commands in dest directory 2014-03-12 13:28:39 -04:00
Jakub Jirutka
2bfaacd170 Fix #5679 again after recent changes in core 2014-03-12 18:21:53 +01:00
Richard C Isaacson
154f123b7f setup module: Mark unsafe commands as use_unsafe_shell=True. 2014-03-12 11:13:20 -05:00
James Cammarata
d8a81c488e Remove validate_certs parameter from fetch_url calls 2014-03-12 10:31:01 -05:00
James Cammarata
a9017af2bb Adding validate_certs to all modules that use fetch_url 2014-03-12 10:19:54 -05:00
Ryan
e4805fe411 add module param to Network & sub-classes
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
2014-03-12 09:37:12 -04:00
Michael DeHaan
c8db3c2db9 Revert "Fix issue#6430 by instantiating Network() with expected arguments"
This reverts commit 2a723e908e.
2014-03-12 09:23:13 -04:00
James Laska
2a723e908e Fix issue#6430 by instantiating Network() with expected arguments 2014-03-12 09:04:42 -04:00
Michael DeHaan
e0147f18b1 Merge pull request #6421 from bcoca/stat_noread_nomd5
now stat skips md5 if file isn't readable
2014-03-12 07:55:17 -05:00
Andy Trevorah
e4ad97b918 reworked apt-repository auto-install to be like yum 2014-03-12 11:15:27 +00:00
Richard Isaacson
681dcf437a Merge pull request #6429 from risaacson/migrate_booleans_bool_django_manage
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 23:25:54 -05:00
Richard Isaacson
0fd80f3f6f Merge pull request #6428 from risaacson/migrate_booleans_bool_postgresql_user
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 23:25:44 -05:00
Richard Isaacson
d0795a8336 Merge pull request #6427 from risaacson/migrate_booleans_bool_rax_files_objects
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 23:25:40 -05:00
Richard Isaacson
a6c89a86f6 Merge pull request #6426 from risaacson/migrate_booleans_bool_rax_files
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 23:25:30 -05:00
Richard Isaacson
9bb8c2aa42 Merge pull request #6425 from risaacson/migrate_booleans_bool_rax
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 23:25:25 -05:00
Richard Isaacson
2bd97dc8b6 Merge pull request #6424 from risaacson/migrate_booleans_bool_quantum_subnet
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 23:25:17 -05:00
Richard Isaacson
125775dc3d Merge pull request #6423 from risaacson/migrate_booleans_bool_gce
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 23:25:08 -05:00
Richard C Isaacson
c1af272ba1 Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 23:04:19 -05:00
Richard C Isaacson
c2bf201bce Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:56:51 -05:00
Richard C Isaacson
c3dc195362 Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:53:24 -05:00
Richard C Isaacson
3121a7f3ec Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:50:03 -05:00
Richard C Isaacson
86adb60a82 Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:46:53 -05:00
Richard C Isaacson
05a1883cb9 Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:43:01 -05:00
Richard C Isaacson
1ea5b04e05 Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:39:42 -05:00
Richard C Isaacson
e40fd9bb0d Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 22:36:44 -05:00
Brian Coca
463a1c21ea now stat skips md5 if file isn't readable 2014-03-11 22:50:05 -04:00
jctanner
f1301f6fd9 Merge pull request #6415 from devoncrouse/devel
Fixed references to missing method in ec2 modules
2014-03-11 22:37:19 -04:00
James Tanner
6da2c37112 Fixes #6411 Return None for ec2 api endpoints that return 404 2014-03-11 21:38:00 -04:00
James Tanner
bd3322824f Remove duplicate digital_ocean_droplet module 2014-03-11 20:59:46 -04:00
Devon Crouse
b853778a93 Fixed references to missing method in ec2 modules
Change-Id: I9b89d433b545269d111b3c290b6411aabf58dd24
2014-03-11 18:19:03 -06:00
Michael DeHaan
a689e42d32 Fix ec2_facts module by removing stray fail statement 2014-03-11 19:17:22 -04:00
Michael DeHaan
3b79a36641 Merge pull request #6409 from risaacson/migrate_booleans_bool_ec2_eip
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 17:59:05 -05:00
Michael DeHaan
9b7da52ed7 Merge pull request #6408 from risaacson/migrate_booleans_bool_digital_ocean
Bulk update of choices=BOOLEANS to type='bool'
2014-03-11 17:58:46 -05:00
Richard C Isaacson
a1c87e6deb Fix docstring issue. 2014-03-11 16:23:18 -05:00
Richard C Isaacson
1b28e3bf41 Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 15:44:34 -05:00
Richard C Isaacson
10f70bee49 Bulk update of choices=BOOLEANS to type='bool' 2014-03-11 15:42:45 -05:00
Richard Isaacson
6e13c1ebe0 Merge pull request #6406 from risaacson/at_module2
This fixes what was merged in 1.5.0.
2014-03-11 15:27:51 -05:00
James Cammarata
10f7a20e60 Merge pull request #5079 from candlerb/candlerb/virt_states
Additional target states for virt module: "destroyed" and "paused"
2014-03-11 15:25:09 -05:00
James Cammarata
11f500fa2f Merge pull request #4630 from mmoya/mysql_variables-fix2
Add support for string values
2014-03-11 15:20:46 -05:00
James Tanner
c73cb77689 Fix name in locale_gen docstring 2014-03-11 16:13:55 -04:00
Michael DeHaan
4a94a5d80a Merge pull request #6400 from vadimkuznetsov/bug5959
bug 5959: https://github.com/ansible/ansible/issues/5959
2014-03-11 15:08:29 -05:00
James Tanner
41b7badb13 Fix snippet imports and version_added in ufw module 2014-03-11 16:07:08 -04:00
James Cammarata
1d6750afec Merge pull request #5518 from pyykkis/ufw
UFW module (another take)
2014-03-11 15:03:33 -05:00
James Tanner
8ffb964f45 Set version_added for locale_gen 2014-03-11 15:56:30 -04:00
James Tanner
da95310d86 Rename locale module to locale_gen 2014-03-11 15:55:26 -04:00
James Cammarata
74335b6e59 Merge pull request #5411 from AugustusKling/locale
locale module
2014-03-11 14:54:36 -05:00
James Tanner
b3ff88d06a Fix version_added and snippet imports on new digital ocean modules 2014-03-11 15:43:59 -04:00
jctanner
748588b516 Merge pull request #4315 from mgregson/add-digital-ocean-domains
Add digital ocean domains
2014-03-11 15:40:15 -04:00
James Tanner
53777bbbc9 Fix docstring and snippet import style in portage module 2014-03-11 15:26:26 -04:00
Fabian Freyer
064722aa5e Added support for package annotations. 2014-03-11 20:24:32 +01:00
jctanner
e94a4aa70f Merge pull request #4493 from sayap/portage
Add packaging module for Gentoo Portage.
2014-03-11 15:24:14 -04:00
James Cammarata
f36de32863 Adding version_added field to metadata field in s3 module 2014-03-11 13:50:21 -05:00
Jake Kreider
777f0a8080 Updated S3 metadata examples 2014-03-11 13:50:21 -05:00
Jake Kreider
b837e5275c Added metadata support to s3 module 2014-03-11 13:50:21 -05:00
Richard C Isaacson
85b3c4d907 nova_compute: Adding the version_added flag to user_data.
Per note in GH-5916.
2014-03-11 13:45:04 -05:00
Richard Isaacson
971199d433 Merge pull request #6403 from risaacson/nova_group
Nova group
2014-03-11 13:35:02 -05:00
Richard C Isaacson
e6d099852e Bump relased in version and update module snippets.
Closes GH-5069
2014-03-11 13:33:18 -05:00
Richard Isaacson
cdea88661e Merge pull request #6402 from risaacson/nova-fip
Nova fip
2014-03-11 13:29:01 -05:00
Richard C Isaacson
5fdf7f9f75 Bump relased in version and update module snippets.
Closes GH-5154
2014-03-11 13:25:16 -05:00
Vadim Kuznetsov
546d514f87 bug 5959: https://github.com/ansible/ansible/issues/5959 2014-03-11 13:41:50 -04:00
James Cammarata
b95fe470c4 Fixing up some docstrings causing make webdocs to fail 2014-03-11 12:29:02 -05:00
Fabian Freyer
efe7bfa74a Changed old variable names that referred to pkgin. 2014-03-11 18:03:14 +01:00
Fabian Freyer
880eaf38a6 Added support for pkgng multiple repositories.
Currently checking if pkgng >= 1.1.4, as specified in
https://wiki.freebsd.org/pkgng . I guess that's when using PKGSITE was
deprecated.
2014-03-11 17:55:40 +01:00
James Tanner
3d07db26e3 Update docstring in digital_ocean for backups_enabled version_added 2014-03-11 12:17:29 -04:00
jctanner
bfd9323274 Merge pull request #5935 from zimbatm/do-backups
library/digital_ocean: Adds the missing backups_enabled create option
2014-03-11 12:16:12 -04:00
James Tanner
351ebd0b43 Update docstrings in ec2_ami_search 2014-03-11 12:14:14 -04:00
James Cammarata
b10d174ab4 Merge branch 'silkapp-ec2-eip-reuse' into devel 2014-03-11 11:13:01 -05:00
James Cammarata
2b84a40d8e Renaming reuse parameter in ec2_eip and adding a version_added string 2014-03-11 11:12:23 -05:00
jctanner
7a45e04777 Merge pull request #4845 from lorin/ec2_ubuntu_ami
New module: ec2_ami_search
2014-03-11 12:11:49 -04:00
James Cammarata
89c091d689 Merge branch 'ec2-eip-reuse' of https://github.com/silkapp/ansible into silkapp-ec2-eip-reuse 2014-03-11 11:09:26 -05:00
James Tanner
f0704159ae Update docstrings in ec2_vol 2014-03-11 12:02:04 -04:00
James Cammarata
67e9cbe637 Merge branch 'josephtate-devel' into devel 2014-03-11 11:00:40 -05:00
jctanner
7dcc8e2460 Merge pull request #5287 from ebrevdo/ec2_vol_existing
ec2_vol module: add support for name / id to mount volume on instance
2014-03-11 11:58:36 -04:00
James Cammarata
5d4980459f Merge branch 'drcapulet/ec2-sourcedestcheck' of https://github.com/drcapulet/ansible into drcapulet-drcapulet/ec2-sourcedestcheck 2014-03-11 10:56:44 -05:00
jctanner
b2539ae5d8 Merge pull request #5454 from claco/rax_identity
Add rax_identity module
2014-03-11 11:51:30 -04:00
James Cammarata
eabcbb830f Merge branch 'willthames-ec2_security_token' into devel 2014-03-11 10:48:52 -05:00
jctanner
e658dc292b Merge pull request #5703 from ethercrow/fakes3
[s3] Compatibility with fakes3.
2014-03-11 11:48:21 -04:00
James Cammarata
8ca3bb4137 Updating profile/security_token version_added labels 2014-03-11 10:48:16 -05:00
Michael DeHaan
40b82a33c0 Merge pull request #5916 from tidzo/issue4992
Fix for #4992 - Add userdata to cloud/nova_compute
2014-03-11 10:45:40 -05:00
James Cammarata
430cce9df3 Merge branch 'ec2_security_token' of https://github.com/willthames/ansible into willthames-ec2_security_token 2014-03-11 10:45:38 -05:00
James Tanner
cd3fcd843a Set version-added for new parameters in ec2_elb_lb and elasticache 2014-03-11 11:44:47 -04:00
Michael DeHaan
2e10e1e0d6 Merge pull request #5997 from jonasi/elasticache_vpc_security_groups
Elasticache vpc security groups
2014-03-11 10:42:13 -05:00
Michael DeHaan
2df40933f1 Merge pull request #6262 from willthames/ec2_tags_print
Allow ec2_tag module to print the tags of an instance
2014-03-11 10:33:07 -05:00
Michael DeHaan
faef76b818 Merge pull request #6264 from sqs/cloud-rds-add-new-db-instance-types
Add new cloud/rds DB instance types (db.m3 and db.cr1 families)
2014-03-11 10:32:39 -05:00
Michael DeHaan
10f852a807 Update version_added for wait_timeout parameter on elb module. 2014-03-11 11:22:17 -04:00
Michael DeHaan
f6878d4ada Merge pull request #6020 from bpennypacker/ec2_elb_timeout
cloud/ec2_elb module: Added wait_timeout parameter
2014-03-11 10:21:38 -05:00
Michael DeHaan
003a405182 Merge pull request #6104 from gianlucaborello/digitalocean_fix_deletion
Make sure droplet deletion works even when idempotency is achieved using 'name' and 'unique_name' rather than 'id'
2014-03-11 10:20:43 -05:00
Michael DeHaan
f824a846bc Merge pull request #6230 from joshuaconner/bugfix_nova_computer_partial_server_name_match
nova_compute: fix for partial match b/w params['name'] and an existing name
2014-03-11 10:20:02 -05:00
Michael DeHaan
1eed6f46bf Merge pull request #6306 from willthames/ec2_module_clearer_failures
Make it easier to determine whether instance creation or tagging fails
2014-03-11 10:18:50 -05:00
Michael DeHaan
3af6befbae Merge pull request #6324 from scottanderson42/bugfix/route53-characters
BUGFIX: route53 module won't round-trip * and @ in records
2014-03-11 10:18:23 -05:00
Michael DeHaan
5978567509 Merge pull request #6366 from cloudify/devel
Fix for #6365: cloudformation module fails to update if stack exists
2014-03-11 10:17:47 -05:00
Michael DeHaan
fd9df5f429 Merge pull request #6372 from mriedelumab/devel
Returning 'NA' when no virtualization found
2014-03-11 10:17:22 -05:00
Michael DeHaan
247d688c13 Merge pull request #6233 from garethr/aws-autoscaling-groups
Added modules to manage ec2 autoscaling groups
2014-03-11 10:15:40 -05:00
Michael DeHaan
297b048d0e Fix other reference to APT_ENV_VARS. 2014-03-11 10:47:53 -04:00
Michael DeHaan
c09d4b1c7a Update apt module so that environment variables are set correctly since not going through shell. Very sorry folks, it will be addressed. 2014-03-11 08:39:28 -04:00
Michael DeHaan
0f962dba14 Missing comma in argument spec. 2014-03-10 19:37:34 -04:00
James Tanner
ba0fec4f42 Force command action to not be executed by the shell unless specifically enabled 2014-03-10 16:13:30 -05:00
James Cammarata
9730157525 Validate SSL certs accessed through urllib*
* Adds another module utility file which generalizes the
  access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.

Fixes #6211
2014-03-10 16:06:52 -05:00
Matthew Riedel
5875d19f4d Returning 'NA' when no virtualization found 2014-03-10 11:58:04 -04:00
Richard C Isaacson
c6fbb0059b Some cleanup. 2014-03-10 10:31:08 -05:00
Federico Feroldi
b9ab31ebd8 Fix for #6365: cloudformation module fails to update if stack exists 2014-03-10 13:11:09 +01:00
Charles Duffy
18f53d9219 #6341: use shared function for parsing systemd status; check rc code 2014-03-10 01:05:48 -05:00
Charles Duffy
d59973295d #6341: check systemd service status with show subcommand 2014-03-10 00:09:29 -05:00
Jarno Keskikangas
37ef39d0fa Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
2014-03-09 12:56:52 +02:00
Jarno Keskikangas
4d5340587e Insert rule to a specific num. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
0247708199 Fix typo: 'reseted' -> 'reset'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
2613e6fb14 Add protocol options 'esp' and 'ah'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
f4e8a86c87 Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
2014-03-09 12:56:51 +02:00