Commit graph

9629 commits

Author SHA1 Message Date
Tad Merchant
493ec588ab Ec2 metric alarm boto3 and treat missing data (#62669)
* Converted ec2_metric_alarm to boto3. Added treat_missing_data option.

* Handle potentially non-existent alarm keys in ec2_metric_alarm module

* Add treat missing data to ec2_metric_alarms wth some tests

Continues the work of #23407

* Clean up ec2_metric_alarm main test playbook

* fix test suite and sanity checks

* more fixes for sanity tests

* fixes to ec2_metric_alarms requested in code review

* import ClientError from botocore, catch generic ClientError

* more fixes from review

drops extra dict in argument spec and set_facts for aws access

* Fix pep8 blank line issue

* switch to fail_json_aws, add idempotency test

* fix under indented continuation

* remove unsupported alias

* Add group to ec2_metric_alarm aliases

* Put alarm prefix before resource prefix to match aws-terminator pr 63

* Add type for treat_missing_data
2019-12-12 14:09:09 -07:00
Pilou
226bf7b227 apt target: use 'until' when the cache is updated (#65456)
This integration target can be unstable due to network/mirror issues:

    TASK [apt : uninstall hello with apt] ***
    fatal: [testhost]: FAILED! => {
        "changed": false,
        "cmd": "apt-get update",
        "msg": "E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/bionic-updates/universe/source/Sources.gz File has unexpected size (354740 != 354745). Mirror sync in progress? [...]",
        "rc": 100,
        [...]
2019-12-12 12:45:54 -07:00
Nilashish Chakraborty
7af98f9724 Always cleanup vlan interfaces (#65756)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-12 13:02:52 -05:00
Andrew Klychkov
0079b8eaa2 mysql_info: add return_empty_dbs parameter (#65755)
* Bugfix of 65727: mysql_info doesn't list empty DBs

* add changelog

* mysql_info: add return_empty_dbs parameter

* fix
2019-12-12 14:10:52 +01:00
Paul Belanger
80333f9c4b
Clean up flake8 errors for eos unit tests (#65753)
These were found while migrating our content to eos collections.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-12 07:44:13 -05:00
Abhijeet Kasurde
41e19a4058
inventory: Fail on non-existing limit file (#59758)
Ansible now fails with error message when user provides
non-existing limit file.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-12 09:09:40 +05:30
Sebastian Wagner
a0cf42ae32 removed unnecessary ipv* address-family statements from vrf if the ip version is not used (#53866) 2019-12-12 00:29:23 +05:30
Abhijeet Kasurde
19220a0607
VMware: Add associable_object_types in vmware_category (#62347)
User can specify associable object types while creating the categories.
VMware API does not allow to modify associable object types after creation of
category.

Fixes: #61220

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-11 13:45:07 +05:30
Paul Belanger
bcc2ffdbf9
Fix version_compare with nxos_snmp_user tests (#65527)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-10 21:54:02 -05:00
Paul Belanger
da82ecadd6
Use fact cache to make nxos tests faster (#65479)
This should cut down about 1hour worth of test time, due to not looping
over the set_fact functions more then 60 times.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-10 21:53:48 -05:00
Prasad Katti
056b035c98 add module aws_step_functions_state_machine_execution (#64431)
* add module aws_step_functions_state_machine_execution

* AWS step functions tests - Use module defaults

* Return all attributes from aws api calls as ansible task output

* aws_sfn - make start and stop execution idempotent and fix check mode

* aws sfn - use build_full_result method of the paginator

* aws sfn - remove changes made to help with local debugging
2019-12-10 14:08:49 -05:00
Gonéri Le Bouder
030b20b024
prepare_vmware_tests: ensure 'VM Network' exists (#65616)
Depending on the ESXi configuration, the 'VM Network' may missing.
2019-12-10 09:08:42 -05:00
Paul Belanger
d39870a693 Remove unused code in nxos_user (#65529)
There is no longer the need to warn on password, it is not supported any
more.

Update nxos_user tests not to purge current SSH user for nxos, otherwise
we loose access for testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-10 19:01:59 +05:30
Toshio Kuratomi
ddd786eedf Fix tests which have unparsable yaml 2019-12-09 16:54:29 -08:00
Sam Doran
7767f0bb23
Mark yum tests as unstable (#65671)
Fedora 31 tests are failing due to a missing packages error. I am unable to duplicate this issue when running locally, so it is possibly an issue with a mirror that is being used when run from Shippable
2019-12-09 16:24:11 -05:00
Dusan Matejka
880bbb9946 fixed inconsistent required set to True in zabbix modules 2019-12-09 10:20:17 -08:00
Felix Fontein
ecb6f2e76c Fix bug in format handling. (#65642) 2019-12-09 18:56:15 +05:30
Felix Fontein
57c042243f
crypto modules: fix various errors in argument specs (#65633)
* Fix various errors in crypto module argument specs.

* Adjust PR #.

* Fix provider requirement.

* Make sure openssl binary is installed.
2019-12-09 13:40:11 +01:00
Felix Fontein
e9cec0262d
docker_* modules: fix various errors in argument specs (#65632)
* Fix various errors in docker module argument specs.

* Adjust PR #.

* Fix option name.

* Fix username/password requirements for docker_login.
2019-12-09 13:39:02 +01:00
Mark Chappell
5c9539903e iam_policy: Make 'iam_name' a required option to match the documentation (#65559)
Without it we'd always throw a boto error
2019-12-09 15:08:43 +05:30
Mark Chappell
4919d5658a iam_cert: Make 'name' a required option to match the documentation (#65558)
Without it we'd always throw a boto error
2019-12-09 14:53:53 +05:30
Mark Chappell
cf3f1b9d3f iam: Make 'name' required to match the documentation (#65557)
With the exception of deleting Users and Roles (where we'd do nothing and exit) not passing a name would trigger a boto exception.
2019-12-09 14:46:02 +05:30
Mark Chappell
eac7d2a958 ec2_placement_group: Make name 'required' to match the documentation (#65555)
Previously you'd get one of the following behaviours:
- A boto3 error
- Nothing would change
- An error that you're not allowed to change the strategy

So of the bahaviour would depend on the random order that AWS returns the list of all Placement Groups
2019-12-09 14:35:36 +05:30
Matt Martz
03a4edb477 Add method to automatically clean up after an action plugin (#65509)
* Use correct var, move cleanup for async
* Add changelog and tests. Fixes #65393. Fixes #65277.
* Kill off all long running async tasks from listen_ports_facts
* Update task to work with older jinja2
2019-12-06 17:29:26 -05:00
Gonéri Le Bouder
b8cd4c5409 remove some tests from zuul/vmware/vcenter_only
Depends-On: ansible/ansible-zuul-jobs#253

We cannot run the following tests without any ESXi host:

- vmware_drs_rule_info
- vmware_drs_rule_facts
- vmware_host_acceptance
- vmware_host_active_directory
- vmware_host_powerstate
2019-12-06 12:20:21 -05:00
Lukas Kämmerling
5ad61ed7c1 Fix and reenable hcloud tests 2019-12-06 08:30:01 -08:00
Sergey
e444e68bf0 Add podman_container_info module (#64361)
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-12-06 09:50:30 -05:00
Jürgen Hötzel
47aea84924 Don't return module error when mysql_connect fails (#64560) (#64585)
* Don't return module error when mysql_connect fails (#64560)

mysql_user expects an Exception when using check_implicit_admin.

* Adds integration tests for mysql_user check_implicit_admin (#64560)
2019-12-06 11:22:34 +05:30
Jordan Borean
f21e72d55a
win_package - Use newer module wrapper as refactor baseline (#65586)
* win_package - Use newer module wrapper as refactor baseline

* Fix aliases in new arg spec
2019-12-06 13:37:52 +10:00
Jordan Borean
9a81f5c3b7
win_uri win_get_url - Fix up redirection defaults (#65584) 2019-12-06 11:47:35 +10:00
Jordan Borean
eaba5572cd
ansible-galaxy - expand User-Agent string for Galaxy endpoints (#65578) 2019-12-06 10:34:14 +10:00
Jordan Borean
fcdebe41e9
win_find - Refactor for better performance and alignment to find (#65536)
* win_find - refactor to make more performance and use newer style

* win_find - refactor for performance improvements and alignment to find

* More path alignment to find

* Fix yamllint error
2019-12-06 10:01:11 +10:00
Felix Fontein
a0f26b40cb Sanity checks: test for print statement (#65219)
* Add test for print() call in module_utils and modules.

* Add changelog fragment.

* Add ignore.txt entries.

* Use blacklist plugin instead of adding a new.

* Update ignore.txt
2019-12-06 05:31:31 +10:00
Gawain
e1be5a8acb vmware host system fact add uuid (#65415)
* vmware host system fact add uuid
2019-12-05 12:00:41 -05:00
Mark Chappell
631120e749 Yet more Sanity test "required" Amazon module cleanup (#65554)
* More 'required' cleanup on AWS modules.
2019-12-05 09:58:55 -06:00
Andrew Gaffney
8a409f37db Throw an error on unsupported vars_prompt keys (#65487) 2019-12-05 10:54:32 -05:00
Paul Belanger
b975fd407d
Remove timeout from nxos tests (#65470)
This fixes the following:

  Unsupported parameters for (nxos_rollback) module: timeout unsupported

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-05 10:39:35 -05:00
Felix Fontein
95c85b395c Add hetzner_firewall_info module. (#65421) 2019-12-05 20:40:11 +05:30
Andrey Klychkov
c59e061cff mysql_info: add exclude_fields parameter (#63371)
* mysql_info: add exclude_fields parameter

* mysql_info: add exclude_fields parameter, add changelog fragment

* change logic
2019-12-05 13:29:58 +00:00
Andrey Klychkov
8f78a0f8bf postgresql_publication: use query params with cursor object (#65404)
* postgresql_publication: use query params with cursor object

* add changelog
2019-12-05 10:44:45 +00:00
Andrey Klychkov
0c71249b03 mysql_db: add force parameter (#65547)
* mysql_db: add force parameter

* mysql_db: add force parameter

* add changelog

* add the param to state dump
2019-12-05 10:44:22 +00:00
Andrey Klychkov
c266fc3b74 postgresql_db: add executed_commands returned value (#65542)
* postgresql_db: add executed_commands returned value

* add changelog

* fix tests
2019-12-05 10:53:08 +01:00
Matt Clay
fb69d68821
Fix plugin paths for ansible-test pylint test. (#65526)
* Fix plugin paths for ansible-test pylint test.
2019-12-04 18:07:16 -08:00
Jordan Borean
4d3ebd65db
win_auto_logon - check, diff and store pass in LSA (#65528)
* win_auto_logon - check, diff and store pass in LSA

* Ensure baseline keys are set for test

* Skip remove item prop on check mode due to win bug

* Start at a cleared baseline to ensure old LSA secrets are cleared
2019-12-05 11:24:30 +10:00
haiyuan_zhang
cff80f1319 azure_rm_galleryimageversion: support data disk snapshot as source input (#65405)
* azure_rm_galleryimageversion: support data disk snapshot as source

* fixing typo
2019-12-05 08:31:47 +08:00
PRASOON KARUNAN V
2dcaa108d8 Adding new module win_auto_logon (#63414)
* add new modul

* correct password var

* fix for linting issues

* add return values documentation

* linting fixes

* Get tests working and simplify a bit
2019-12-05 09:27:08 +10:00
Matt Clay
567c860027
Split up docker-registry test target. (#65211)
* Copy relevant docker-registry files:

docker-registry/files/nginx.conf -> setup_docker_registry/files/nginx.conf
docker-registry/files/nginx.htpasswd -> setup_docker_registry/files/nginx.htpasswd
docker-registry/meta/main.yml -> setup_docker_registry/meta/main.yml
docker-registry/tasks/main.yml -> setup_docker_registry/tasks/main.yml
docker-registry/tasks/main.yml -> setup_docker_registry/handlers/cleanup.yml

* Remove non-cleanup code from handlers/cleanup.yml.

* Remove tests and cleanup from tasks/main.yml.

* Register cleanup handler.

* Use setup_docker_registry in docker-registry test.

* Fix handler execution order.

* Split out docker_login integration test.

* Move remaining tests into docker_image test.

* Cleanup before running docker_image options test.

* Improve reliability of test cleanup.

* Move files for conditional inclusion.

* Set proper conditions on tests.

* Rename tasks file for conditional inclusion.

* Conditionally include tasks.
2019-12-04 14:14:43 -08:00
Gonéri Le Bouder
a8efe7442c
vmware/test: set vmware/scenario/vcenter_only alias (#65515)
Add the `vmware/scenario/vcenter_only` alias to be able to identify the
vmware test roles that can be tested with just on vcenter instance.

Also, add a check to be sure we don't try to attach ESXi hosts if none
has been defined.
2019-12-04 17:12:29 -05:00
Sam Doran
2a7623dd5c
Add CentOS 8 to the test matrix (#63649) 2019-12-04 13:39:00 -05:00
Mark Chappell
b51a1bc429 Fixup parameter documentation ("doc-required-mismatch") AWS simple cases (#65462)
* Clean up "required" lines in AWS module docs, remove corresponding ignore.txt entries, general docs cleanup
2019-12-04 10:00:50 -06:00