Commit graph

36672 commits

Author SHA1 Message Date
Matt Clay
fe61636d66 Remove unused test matrix entries. 2018-07-24 10:02:00 -07:00
Matt Clay
bf8f228fd5 Update Shippable integration test groups. (#43118)
* Update Shippable integration test groups.
* Update integration test group aliases.
* Rebalance AWS and Azure tests with extra group.
* Rebalance Windows tests with another group.

(cherry picked from commit 4e489d1be8)
2018-07-24 10:02:00 -07:00
Matt Clay
5805e6a89b Mark win_uri unstable.
(cherry picked from commit 547f11ad8f)
2018-07-23 18:28:04 -07:00
Sumit Jaiswal
30a0c88c35 To fix EOS_FACTS failure when lldp will be disabled. (#42347)
* to fix the bug 41165

* adding the changelog file

* Hook check_rc failure up so that this will actually work

* Update eos_facts-failure.yml
2018-07-23 10:53:42 -07:00
Nathaniel Case
f320b1507d Eos subnet overlap fix (#43023) (#43099)
* Detect overlapping subnet & provide better errors

(cherry picked from commit dba975470d)
2018-07-23 09:41:10 -07:00
Shuang Wang
d48ebcee40 [doc] fix a typo in ec2_eni docs (#36571) (#43068)
(cherry picked from commit 918b29f0fc)
2018-07-23 09:34:15 -07:00
Deepak Agrawal
8f3a82dc9b Avoid exiting config mode before configuring port-channel members (#42999) 2018-07-23 09:33:41 -07:00
Nilashish Chakraborty
85122a6c38 Fix ios_vlan issue CP in 2.5 (#42668)
* Make ios_vlan identify vlans starting with 9 (#42247)

* Make ios_vlan identify vlans starting with 9

* Add unit test for vlan id start with 9

(cherry picked from commit 70e33ef92c)

* Added changelog for ios_vlan fix
2018-07-23 09:25:18 -07:00
Nilashish Chakraborty
3a481c4548 Fix ios_linkagg issue CP in 2.5 (#42663)
* Fixed regex to pick correct items (#42557)

(cherry picked from commit fa624eba29)

* Added changelog for ios_linkagg fix
2018-07-23 09:23:07 -07:00
Sam Doran
67859c3476 Fix NameError in pause module (#42038) (#42635)
* Fix NameError in pause module

* Add comment and changelog

Co-authored-by: Jerry Chong <jchong@netbase.com>
(cherry picked from commit 42f44b24c6)
2018-07-23 09:22:25 -07:00
Nathaniel Case
dc37b41b72 [2.5] Update ios tests (#42509) (#42515)
* [2.5] Update ios tests (#42509)

* 192.168.0.1/24 conflicts with management IP

* Images don't have the hostnames we expect
(cherry picked from commit 399d13d)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>

* ios test cleanup pt 2 (#42570)

* Remove local from ios_config to avoid needing to add provider

* ios_smoke should test all with local to pick up the slack

(cherry picked from commit 381263ad99)
2018-07-23 09:21:16 -07:00
Trishna Guha
e3993bd01b nxos_nxapi fix pick-2.5 (#42490)
* Enforcing NXAPI default HTTP behavior (#41817)

* nxos_nxapi http default behavior

* Use nxos_nxapi module in prepare_nxos_tests

* Refactor nxos_nxapi configure test to use yaml block

* Extend nxos_nxapi https & http test cases

* Removed NXOS internal release naming

* Resolved ansibot sanity errors

* Fix typo in prepare_nxos_tests

* Address PR comments

* Shippable indicates this is no longer needed

* Add port change logic and testing

(cherry picked from commit db7300904d)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add get_capabilities in nxapi module_utils (#42688)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d5e9653c96)
2018-07-23 09:20:54 -07:00
Sam Doran
306be9f23c Fix pause module so it does not stack trace when redirecting stdout. (#42217) (#42441)
* Use separate variables for stdin and stdout file descriptors

* Do not set stdout to raw mode when output is not a TTY

(cherry picked from commit 1d1595b990)
2018-07-23 09:20:14 -07:00
Alicia Cozine
d6bc698ed8 Changing example code block language from yaml to yaml+jinja. (#40365) (#42436)
(cherry picked from commit 9f84c09bf3)
2018-07-23 09:19:32 -07:00
Matt Clay
b00358e4fb Remove unwanted containers at CI job start.
(cherry picked from commit 528de5b82f)
2018-07-09 21:50:29 -07:00
Matt Davis
0c985fee8a New release v2.5.6 2018-07-05 11:49:44 -07:00
John R Barker
75ada884d2 Backport/2.5/42316 Galaxy doc link (#42320)
* Correct link to Galaxy docs

* add trailing slash
2018-07-05 09:42:53 -07:00
Trishna Guha
dc6a187603 nxos and eos bugfix pick-2.5 (#42289)
* fix nxos_vxlan_vtep_vni issue (#42183)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 981c9f6a79)

* Update eos_l2_interface.py (#42270)

(cherry picked from commit 51092c6ea5)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-05 09:42:12 -07:00
Sam Doran
0fa56ed65d Add warning when using an empty regexp in lineinfile (#42013) (#42207)
* Revert "Account for empty string regexp in lineinfile (#41451)"

This reverts commit 4b5b4a760c.

* Use context managers for interacting with files

* Store line and regexp parameters in a variable

* Add warning when regexp is an empty string

* Remove '=' from error messages

* Update warning message and add changelog

* Add tests

* Improve warning message

Offer an equivalent regexp that won't trigger the warning.
Update tests to match new warning.

* Add porting guide entry for lineinfile change

(cherry picked from commit fb55038d75)
2018-07-05 09:41:07 -07:00
Abhijeet Kasurde
eef9d0bf04 Restore BOOLEANS import in basic.py (#42008) (#42235)
This import was removed by mistake. This is required for backward
compatibility.

Fixes: #41988

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-03 13:29:16 -07:00
René Moser
eda69dff92 [2.5] influxdb_query: fix use of common return (#42231)
* influxdb_query: fix use of common return results (#39626)


(cherry picked from commit aa874c3c36)

* changelog: influxdb_query fix use of common return
2018-07-03 13:28:51 -07:00
John R Barker
7dc06bed83 Backport/2.5/42209 (#42213)
* nsupdate.py: Fix typo (#42209)

Signed-off-by: David Galloway <dgallowa@redhat.com>
(cherry picked from commit 9539284010)

* nsupdate_fix_hmac-sha384
2018-07-03 13:28:26 -07:00
Sviatoslav Sydorenko
5056f0801c [2.5] Add CoC and mailing lists links to PYPI (#42157)
PR #42101
(cherry picked from commit fc25d28)

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2018-07-03 13:27:21 -07:00
Toshio Kuratomi
ff980afefd [stable-2.5] ignore ansible.cfg in world writable cwd (#42070) (#42142)
* [stable-2.5] ignore ansible.cfg in world writable cwd (#42070)

* ignore ansible.cfg in world writable cwd
 * also added 'warnings' to config
 * updated man page template
(cherry picked from commit b6f2aad)

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>

* Update wrcwd_ansible.cfg.yml
2018-07-03 13:26:57 -07:00
Toshio Kuratomi
10d6fe6c98 [stable-2.5] avoid loading vars on unspecified basedir (cwd) (#42067) (#42139)
* avoid loading vars on unspecified basedir (cwd)
(cherry picked from commit de0e11c)

Co-authored-by: Brian Coca <bcoca@users.noreply.github.com>
2018-07-03 13:23:58 -07:00
Ganesh Nalawade
f942d71b36 Fix junos_config confirm commit issue (#41527) (#42099)
Fixes #40626

* Due to issue in ncclient commit() method for Juniper
  device (ncclient/ncclient#238)
  add a workaround in junos netconf plugin to generate proper
  commit-configuration xml and execute it using ncclient
  generic `rpc()` method.

* Update junos_config doc

* Update changelog

(cherry picked from commit 88b966e23b)
2018-07-03 13:23:04 -07:00
Brian Coca
fdb813766a service_facts correct meaning of state for systemd service units (#40914) (#42068)
* service_facts correct meaning of state for systemd service units

Fixes #40809

Previously this module used the commend `systemctl list-unit-files
--type=service` to query state of services but list-unit-files only
shows enabled vs disabled which is not what we want for "state"

Signed-off-by: Adam Miller <admiller@redhat.com>

* make sure to define service_name before referencing it

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit bf1cc2f1f4)
2018-07-03 13:22:30 -07:00
Jordan Borean
ceb14fcc33 win_domain: fix typo in cmdlet call (#41993) (#41994)
(cherry picked from commit 77526a5036)
2018-07-03 13:20:09 -07:00
Matt Martz
7a1fa8d363 Fix docs for all test. Fixes #41956 (#41965) (#41980)
(cherry picked from commit 11ce954226)
2018-07-03 13:19:49 -07:00
Jordan Borean
c2d905fc11 win_iis_webapppool: do not output some cmdlet outputs (#41884) (#41942)
(cherry picked from commit abfcc35e6f)
2018-07-03 13:18:10 -07:00
Toshio Kuratomi
d4d52856df [stable-2.5] Changes to support building docs with old jinja2 (#41938)
This commit: fa5c0282a4 relied upon
features present in Jinja-2.10 and above.  The changes here allow us to
build the *rst* with older versions of jinja2.
(cherry picked from commit ad2e8dd)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2018-07-03 13:15:48 -07:00
Sam Doran
ab93ad8a0a Backport #41767 for 2.5 -Skip if insertbefore is using BOF until later in the module (#41930)
* Skip if insertbefore BOF until later (#41767)

If a line match is found in the file and no regexp is specified, insertbefore would improperly try to add a line if set to BOF.

Add tests for this scenario.

(cherry picked from commit eaae1318f8)

* Add changelog fragment
2018-07-03 13:08:49 -07:00
Matt Martz
916317466d Backport #41860 for 2.5 - support group_by with implicit localhost (#41926)
* Use inventory.get_host instead of direct access to inventory.hosts (#41860)

* Use inventory.get_host instead of direct access to inventory.hosts. Fixes #32152

* Prevent potential side effect, by using self._inventory.localhost directly instead of get_host

(cherry picked from commit 1a2ef0922f)

* Add changelog for #41860
2018-07-03 12:08:58 -07:00
Jordan Borean
9757233a93 Stop displaying kinit pass input on a failure (#41882) (#41923)
* Stop displaying kinit pass input on a failure

* Fixed up minor logic info and added tests

(cherry picked from commit 9b7b564d75)
2018-07-03 12:08:26 -07:00
Martin Krizek
ab18048147 Fix rabbitmq_* integration tests (#41836) (#41922)
(cherry picked from commit a8d4bf8642)
2018-07-03 12:08:03 -07:00
Jordan Borean
c65bf12741 windows dsc docs: fix missing colon in example (#41886) (#41892)
(cherry picked from commit 0b2ec9b11c)
2018-07-03 12:07:42 -07:00
Alicia Cozine
fee754fa59 playbooks_intro.rst: remove duplicite playbook (#38521) (#41864)
(cherry picked from commit f1e41cbb36)
2018-07-03 12:06:39 -07:00
Brian Coca
e9a32c1107 fix vars hostname fallback (#41858)
also made it optimistic, rely on exceptions instead of copmlex if chains

(cherry picked from commit 11dbed1350)
2018-07-03 12:06:23 -07:00
Brian Coca
40c47b7785 fix minor issues with debug and item labels (#41331) (#41815)
* fix minor issues with debug and item labels

 - no more `item=None`, we always have a label now
 - debug should only show expected information, either msg= or the var in var=
 - also fixed method name, deprecated misleading _get_item

(cherry picked from commit 27c43daab8)
2018-07-03 12:05:13 -07:00
Nilashish Chakraborty
9101dd6857 Fixed eos_logging test issue (#41777) 2018-07-03 12:04:35 -07:00
Nilashish Chakraborty
b9904b9fe7 Fix vyos_vlan aggregate issue & added tests CP into 2.5 (#41638) (#41775)
* Fix vyos_vlan aggregate issue & added tests (#41638)

* Fix vyos_vlan aggregate issue & Added tests

* Fix #2 for vyos_vlan aggregate issue

(cherry picked from commit 837c216587)

* Added changelog for vyos_vlan aggregate issue fix
2018-07-03 12:02:11 -07:00
Martin Krizek
dcf95a3adc Backport 2.5: apt: fix apt-mark on debian6 (#41724)
* apt: fix apt-mark on debian6 (#41530)


(cherry picked from commit 2e68811c34)

* Add changelog/fragment
2018-07-03 12:01:36 -07:00
Brian Coca
36b0756c3b update play_context for reset_connection (#40866) (#41655)
steps taken from lib/ansible/executor/task_executor.py

fixes: https://github.com/ansible/ansible/issues/27520
(cherry picked from commit 23fbe0ce8e)
2018-07-03 11:58:49 -07:00
Markos Chandras
e20294c1e1 facts: suse: Fix major version detection for SUSE (#41416) (#41650)
When parsing the distribution files such as /etc/os-release, we extract
the full distribution version but not the major version. As such, the
ansible_distribution_major_version ends up being 'NA' whereas the
ansible_distribution_version contains the full version.

Before this patch we get this on openSUSE Leap 15

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "NA"}, "changed": false}

After this patch we get this

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "15"}, "changed": false}

This also fixes the Tumbleweed distribution test to report a proper
major version and also adds a test for openSUSE Leap 15.0 to avoid
potential future regressions.

Fixes: #41410
(cherry picked from commit 1737b7be3e)
2018-07-03 11:58:00 -07:00
Ricordeau Raphael
4314798d3e Fix changelog order in the rpm spec file (#38272) 2018-07-03 11:57:23 -07:00
Trishna Guha
15ac94f87c fix nxos_linkagg issue (#41550) (#41620)
* fix nxos_linkagg issue (#41550)

* fix nxos_linkagg issue

* fix shippable

(cherry picked from commit 119e6d680b)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-03 11:50:57 -07:00
Toshio Kuratomi
f56197df94 [stable-2.5] sort the port list properly (.sort() returns None) (#41603)
(cherry picked from commit 63f2ad8776)

Co-authored-by: schp <schonhofen@gmail.com>
2018-07-03 11:50:36 -07:00
Toshio Kuratomi
b9b1a65067 [2.5] Update user module docs (#41572) (#41602)
* Clarify append and groups behavior
* Document return values.
(cherry picked from commit 6fa2d9ac6f)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2018-07-03 11:50:13 -07:00
Toshio Kuratomi
7b325baa22 Bkprt recursive copy fix (#40268)
* Fixes #34893 (#40166)

Fixes several bugs exposed in #34893
* Fixes relative path handling in copy so that it splits directories and
  reconstructs the correct file path
* Return failed in the proper circumstances

(cherry picked from commit ca4147f2cc)

* Add changelog for recursive copy fix

(cherry picked from commit cab0f21564)
2018-07-03 11:49:45 -07:00
Toshio Kuratomi
6a7c43b0ba [stable-2.5] Make the copy module pass correct parameters to file module (#42021)
(cherry picked from commit d994595660)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2018-07-03 08:55:42 -07:00