Commit graph

36059 commits

Author SHA1 Message Date
Ganesh Nalawade
51673f431f
Update network debug troubleshooting guide (#36288) (#36391)
* Update network debug troubleshooting guide

Fix #35914

Command timeout and connection timeout error messages
are dsiplayed in log file instead on console.
Update the same in troubleshooting guide.

* Update example error

* Fix CI issues

* Fix more CI failures

* More fixes

* Fix review comments

* Fix more review comments

* Copy edit

(cherry picked from commit b57cc7cf31)
2018-02-19 21:17:54 +05:30
John R Barker
7dcf5aed02
sphinx_rtd_theme/layout.html 2.5 (#36390) 2018-02-19 15:12:01 +00:00
Trishna Guha
9692394c7d
Stable 2.5 (#36374)
* Set hostname to 'switch' on nxos_system (#36373)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit eb7f4460c8)

* fix nxos_config json pipeline error (#36236)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 736d6406c0)
2018-02-19 11:22:30 +05:30
Trishna Guha
22b4d69a7b
nxos_system test fix inventory_hostname_short (#36359) (#36360)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a5654bd63c)
2018-02-18 10:38:34 +05:30
Trishna Guha
f5fa91c152
Remove kickstart_image_required check (#36319) (#36342)
(cherry picked from commit 6e096cb0c9)
2018-02-17 13:16:11 +05:30
Trishna Guha
b08bdc5f6d
nxos fix cherry-pick (#36340)
* Fix nxos_system tests (#36201)

* Fix nxos_system tests

* Add debug connection plugin info

* Move sanity test under common

(cherry picked from commit 5b5d24631a)

* Fixes for the N3500 platform that uses the A8 image (#36261)

* fix nxos_l3_interface tests as n35 doesn't support ipv6

* add terminal dont-ask to nxos_feature and nxos_lldp

* put interfaces in L2 mode for N35

* fix nxos_feature unit-tests

(cherry picked from commit e24c547a3a)
2018-02-17 12:20:42 +05:30
Trishna Guha
d568701254
Fix structured output bug (#36193) (#36310)
(cherry picked from commit ac169f5ffd)
2018-02-17 09:57:16 +05:30
Nathaniel Case
9049ba0f2d
Fix None stringification call to send_command (#36254) (#36309)
send_command already performs the to_bytes safely on prompts (checking
for None).  Without this check the literal 'None' became a subprompt trigger!

Fixes #35662

(cherry picked from commit f2818caa61)
2018-02-16 15:48:13 -05:00
tedder
99b23dce92 fix spelling. Seriously, that's it.
(cherry picked from commit e8fc269cd3)
2018-02-16 13:20:44 -05:00
Adrian Likins
f00dd99ea2 Fix ansible-console always asking for vault passwords
ansible-console was calling setup_vault_secrets
twice. Once directly and once via _play_prereqs()

The direct invocation was not setting auto_prompt=False.

However, the direct invocation isn't need at all so
this removes it so only _play_reqs() is used.
That fixes the unrequested vault password
prompting.

Fixes #33027

(cherry picked from commit 810fa7046b)
2018-02-16 13:19:59 -05:00
Brian Coca
57bccd10af updates to module testing (#36043)
* updates to module testing

gives those using internal modules an alternative

* Copy edit

(cherry picked from commit 3eff279dd7)
2018-02-16 13:19:28 -05:00
David Newswanger
cf196613ff
re enabled tests that were fixed in ansible/ansible-modules-core#5008 (#36257) (#36303)
(cherry picked from commit a7c2f6d092)
2018-02-16 10:54:41 -05:00
John R Barker
80b91613a8
Improved language around in_vpc parameter. (#36137) (#36302)
(cherry picked from commit 6a3fd92654)
2018-02-16 13:17:35 +00:00
Matt Davis
62139bb828 v2.5.0b2 release cut 2018-02-16 01:13:00 -08:00
Brian Coca
3635961b1b updates to porting guide (#36219)
* updates to porting guide

(cherry picked from commit 7a6d6870d4633ae38a14cc799521b5fc1c0320fd)

* Edits to correct spelling, grammar, and clarify wording.

* Fixed typo

(cherry picked from commit 1f363a6a7c)
2018-02-15 23:55:09 -08:00
Dag Wieers
179aa475a5 aci_firmware_source: Add integration tests (#36246)
This PR includes:
- Rename 'protocol' parameter to 'url_protocol'
- Add limited integration tests (as we have no public firmware access)
- Add missing examples
(cherry picked from commit e1b5bc049c)
2018-02-15 23:53:17 -08:00
Dag Wieers
dd92db800a aci_taboo_contract: Add integration tests and examples (#36276)
This PR includes:
- Missing integration tests
- Missing examples
- Two typo's in other integration tests
(cherry picked from commit 334e405e6f)
2018-02-15 23:52:06 -08:00
Dag Wieers
51c4fceb64 aci_domain_to_encap_pool: Add integration tests (#36217)
(cherry picked from commit d86c5aee3c)
2018-02-15 23:50:07 -08:00
Dag Wieers
eb0232fa86 aci_encap_pool: Standardize on 'pool_allocation_mode' (#36215)
(cherry picked from commit e431d578da)
2018-02-15 23:46:35 -08:00
Dag Wieers
66e7c8d938 ACI: Avoid using 'previous' with query operations (#36181)
When ACI modules are being used for querying MOs, we should not return
the previous state, as there is no previous state, there's only the
current state.

This impacts a lot of tests that were used to testing the current state
as 'previous'.
(cherry picked from commit dba561efa7)
2018-02-15 23:45:50 -08:00
Dag Wieers
38b000062f aci_vlan_pool: Improve integration tests (#36173)
This PR includes:
- More elaborate integration tests
- Split static and dynamic VLAN pools in separate files
(cherry picked from commit 3093285c94)
2018-02-15 23:44:12 -08:00
scottb
92cb719a2d Relocate ACI guide and add to TOC (#36208)
(cherry picked from commit c5dd0d97af)
2018-02-15 23:43:12 -08:00
Matt Davis
abd7a9a384 2.5 changelog update for 33393 2018-02-15 23:41:43 -08:00
Abhijeet Kasurde
fb46cf3718
VMware: Fix DVPG idempotency issue (#36285)
This fixes, cloning operation where template or existing VM
does not have network or DVPG. Also, adds some strict type checking in
network parameters.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit a377302d6b)
2018-02-16 13:07:23 +05:30
Patrick Fink
ba6a242f17 Fix typo in vars.rst (#35098)
(cherry picked from commit 43eb97ef92)
2018-02-15 23:36:53 -08:00
Dag Wieers
5ce2822855 aci_aep_to_domain: Fix query all objects (#36131)
This PR includes:
- A fix to the module where domain_type without domain caused havoc
- A fix to the integration tests when querying all binding objects
- Improvements to integration tests
(cherry picked from commit 7897558b95)
2018-02-15 23:36:11 -08:00
Dag Wieers
a3ae64440d ACI docs: Add more links to resources and community (#36101)
This PR includes:
- Adding more resources to each section
- Improving wordings
- Add links to the Ansible ACI community pages
(cherry picked from commit a875363e35)
2018-02-15 23:35:03 -08:00
Dag Wieers
5a8313f3a2 ACI docs: Add a section about common error messages (#36088)
Since we pass information directly to ACI, we sometimes get error messages back to the user that require some additional information or context.

This PR includes:
- Changes to the default error output so the error is easier to find
  when searching in e.g. Google
- 3 specific error messages that we have encountered and has confused
  our users before
(cherry picked from commit 218f008dab)
2018-02-15 23:34:25 -08:00
Dag Wieers
b85989205f aci_domain_to_vlan_pool: Add missing integration tests (#36079)
(cherry picked from commit 9f028e9dea)
2018-02-15 23:33:46 -08:00
Brian Coca
66eed80f71 better sudo/su deprecation on config entries (#36074)
* better sudo/su deprecation on config entries

fixes #32130

* typo fixes

* Copy edit

* Fixed more instances

(cherry picked from commit 9066b17d5d)
2018-02-15 23:33:18 -08:00
Dag Wieers
e81c181881 aci_aep_to_domain: Add missing integration tests (#36071)
(cherry picked from commit 98a3059f7b)
2018-02-15 23:32:22 -08:00
Martin Krizek
b546dde48c add_host: check if name or hostname arg is provided
(cherry picked from commit 39d9496282)
2018-02-15 23:31:25 -08:00
Dag Wieers
eec7945222 aci_interface_policy_leaf_policy_group: Fix tests (#35973)
(cherry picked from commit d76db835ff)
2018-02-15 23:30:06 -08:00
Dag Wieers
76648f358e ACI: Fixes to recent change to parameter choices (#35968)
This PR includes:
- Fixes related to the recent merge of #31637 and #34537
- A generic fix for a reference for assignment issue
- Fixes to aci.boolean() in order to catch exception
(cherry picked from commit 01ba3a4efc)
2018-02-15 23:28:42 -08:00
Dag Wieers
36e5e4ad62 Fix issue with module (#35960)
(cherry picked from commit 764e78d302)
2018-02-15 23:23:51 -08:00
Dag Wieers
dd215eac0b ACI: Assorted set of fixes to docs (#35780)
* Assorted set of fixes

* Cosmetic changes to lists

* Add more information related to connection throttling

* Changes to TOC

* Document return values

* More improvements

* Fix casing in title

(cherry picked from commit 80e1e0b017)
2018-02-15 23:12:44 -08:00
Dag Wieers
c5f7b5baa5 aci_domain: Add missing integration tests (#36051)
(cherry picked from commit 30adc2f124)
2018-02-15 23:11:40 -08:00
Matt Davis
6f62dd66bb convert CHANGELOG to per-major-ver and generated
* CHANGELOGs are now per-version
* CHANGELOGs are now RST format
* CHANGELOGs are now generated via reno from YAML fragments located in changelogs/fragements. This allows feature/bugfix changelog fragments to be cherry-picked alongside the code changes
* each version's CHANGELOG_vX.Y.rst is generatd at release-time and can be easily copied/cherry-picked into other branches
2018-02-15 23:06:39 -08:00
Ganesh Nalawade
e8beb180e1
Add eos_command doc with more examples (#36245) (#36289)
* Add eos_command doc with more examples

*  More examples using cli and eapi transport
*  Example on how to handle json output
*  Example on handling result output in wait_for

* Fix typo

(cherry picked from commit cb52509775)
2018-02-16 12:25:50 +05:30
Abhijeet Kasurde
92e64c9eb9
VMware: re-enable vmware_guest_powerstate tests (#36094)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit 66743f33fa)
2018-02-16 11:01:19 +05:30
Trishna Guha
fe9e887f86
fix nxos_bgp_af issues (#36147) (#36283)
* fix nxos_bgp_af issues

* shippable fix

* review comments

* shippable error fix

(cherry picked from commit 75a34f6668)
2018-02-16 10:12:42 +05:30
Deiwin Sarjas
f8918e54bb Fix Porting Guide links for Ansible 2.5 (#36185)
The current links result in 404 Not Found. Also changed protocol to HTTPS.

(cherry picked from commit 86918db312)
2018-02-15 16:41:18 -05:00
Michael Nugent
5ca8b7829a False matches the docs and intentions of the previous developer (#35762)
(cherry picked from commit d212ca11b3)
2018-02-15 15:41:22 -05:00
John R Barker
784932875f
Reduces the unit test time of select bigip modules (#36256) (#36260)
The modules in this patch include waits that need to happen to ensure
something is correctly configured on a BIG-IP. These waits were
raised as an issue in a recent ansible-testing meeting.

This patch eliminates the waits by mocking time.sleep
(cherry picked from commit 77fa41795e)
2018-02-15 20:28:45 +00:00
Nathaniel Case
3d81f94349
Update ios_ping.py to allow for count > 70. (#36142) (#36250)
* Update ios_ping.py to allow for count > 70.

Find 'Success...' output rather than relying on list index.  Index -1 won't pass unit test.

(cherry picked from commit fed20b825f)
2018-02-15 14:54:30 -05:00
Toshio Kuratomi
a7a03bbf4a Normalize usage of temp and tmp on tmp (#36221)
* Normalize usage of temp and tmp on tmp
* Rename system_tmps system_tmpdirs
* Add ANSIBLE_REMOTE_TMP spelling of environment variables

(cherry picked from commit 06f73ad578)
2018-02-15 09:01:33 -08:00
Monty Taylor
4848652c7a Add a module_utils OpenStack Cloud constructor (#20974)
Start using this to construct shade OpenStack Cloud objects in a
consistent manner. This will let us centralize things like dealing with
password arguments and whatnot. It also allows us to introduce the
ability to pass a fully formed config dict directly to the module.

Migrate all OpenStack modules to use openstack_cloud_from_module.

Have it return the shade library since it's responsible for
importing shade and shade is needed for the exceptions.

Only pull specific OpenStack arguments for the constructor

Rather than passing **module.params to the shade constructor, pull out
only the values that make sense. This should prevent the issues with
module parameters stepping on shade parameters.

Replace module.params.pop with module.params.get

We don't need to pop these anymore since the shade constructor is now
using opt-in values.

Using real urls is ungood. Use example.com domains. Also, get rid of the
antiquated port numbers.

(cherry picked from commit 0f893027c4)
2018-02-15 17:59:05 +01:00
Pilou
bca8b80069 vars.clean: remove unused method inject_facts (#34838)
* vars.clean: remove unused method inject_facts

Removing this unused method seems better than fixing the typo.

* Fix typo in comments

(cherry picked from commit b3ce136256)
2018-02-15 08:56:38 -08:00
Nathaniel Case
c1dcbb42c7
Alter ASA regexes to be byte-strings (#36176) (#36239)
(cherry picked from commit f67ff4a78e)
2018-02-15 10:57:11 -05:00
Ganesh Nalawade
38717551f8
Updating URL to Nuage Python VSPK documentation (#36213) (#36232)
Fixes ansible/ansible#35766
(cherry picked from commit cffa3caa60)
2018-02-15 18:36:03 +05:30