Commit graph

53 commits

Author SHA1 Message Date
John R Barker
05cf76cbd7
Backport/2.5/38191 (#38327)
* issue:38167 add support for onyx version 3.6.6000 for onyx_linkagg (#38191)

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 72d42bd065)

* fragment
2018-04-05 12:27:56 +01:00
John R Barker
08029a38df
issue:37307 Add support for changes in pfc output in onyx 3.6.6000 (#… (#38330)
* issue:37307 Add support for changes in pfc output in onyx 3.6.6000 (#37651)

* issue:37307 Add support for changes in pfc output in onyx 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 9dfb665e43)

* fragment
2018-04-05 12:27:37 +01:00
Renato Orgito
4e3e2c712a Have the ios_interface module include CDP when checking neighbors (#38046)
* Add CDP support for the neighbors option (#37655)

(cherry picked from commit 0f90853f67147d68ad5899407e96a53eed8e4d46)

* Add ios_interface CDP support to changelog
2018-04-05 11:51:18 +01:00
Jordan Borean
09dc621238
win_service: backport of special char in name handler (#38250)
* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets (#37897)

* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets

* compare username in lowercase for test

(cherry picked from commit f37a44430f)

* Added changelog fragment
2018-04-04 13:43:33 +10:00
Jordan Borean
f2b0171b93
azure_rm_virtualmachine - backport of docs change around images supported (#37764)
* Updated text for azure_rm_virtualmachine around images that can be used (#37686)

(cherry picked from commit 04539ca448)

* Added changelog fragment
2018-04-03 08:32:02 +10:00
Jordan Borean
800980ec83
win_copy: backport 2.5 preserve local tmp path when sending multiple files (#37977)
* win_copy: added fix for win_copy deleting local tmp folder (#37964)

(cherry picked from commit b1ac65d95a)

* Added changelog fragment
2018-04-03 08:30:49 +10:00
Jordan Borean
886a88a967
win_uri: backport fix custom header override (#37889)
* append request headers instead of replacing (#37845)

(cherry picked from commit 2c44061a04)

* Added changelog fragment
2018-04-03 08:30:09 +10:00
Jordan Borean
0c88f199ec
azure_rm_networkinterface: backport no public IP fix (#37762)
* azure_rm_networkinterface: fixed issue when public ip address should not be created (#36824)

* fixed issue when public ip address should not be created

* adding test for public ip address

* fixed samples

* another fix to sample formatting

* fixed test

* fix test

* fixed test

* another attempt to fix test

* maybe it works now

* still wrong

* improved check per customer request

* removed stupid semicolon

* updated test to match main scenario

* changed ip configurations to list

* another attempt

(cherry picked from commit 89401f13f7)

* Added changelog fragment
2018-04-03 06:32:01 +10:00
Jordan Borean
c056b8a35c
win_reboot: backport warning message arguments (#37971)
* win_reboot: fixed up warning message for dep args (#37898)

(cherry picked from commit c4e7b54630)

* Added changelog fragment
2018-04-03 06:31:07 +10:00
Jordan Borean
d0f1a23c45
Ansible.ModuleUtils.FileUtil - backport catch DirectoryNotFoundException (#37976)
* Ansible.ModuleUtils.FileUtil: catch DirectoryNotFoundException when testing a path (#37968)

(cherry picked from commit 68e44e082e)

* Added changelog fragments
2018-04-03 06:30:53 +10:00
Toshio Kuratomi
8f5565f948 Add changelog for https://github.com/ansible/ansible/pull/37460 2018-03-29 19:10:47 -07:00
Toshio Kuratomi
4ecd16b2ae Bkprt py3 pull fix (#37663)
* Compare byte strings to byte strings

* Fix a traceback in ansible-pull on python3 comparing output from
  subprocess with a text string.
* Rename variables that hold byte strings so we are clear that those are
  not text strings.
* Use to_text() to transform variable that's being displayed as it's
  less fragile than str().

Fixes #36962

(cherry picked from commit b98ad3a12b)

* Add changelog entry for python3 ansible-pull fix
2018-03-29 15:16:12 -07:00
Toshio Kuratomi
389c4d1536 Bkprt py3 ec2 user data (#37664)
* Fix use of user_data field with spot_price in ec2 module (#37628)

The user_data field is base64 encoded inside of the boto library.  In
Python3, base64 must be used with byte strings.  So we make sure to
encode the user_data into a byte string before passing it on to the boto
library.

Fixes #34978

(cherry picked from commit 0d55081ba8)

* Python3 ec2 fix added to changelog
2018-03-29 15:13:42 -07:00
Toshio Kuratomi
97a0516cf6 Bkprt py3 csvfile (#37665)
* Fix csvfile traceback on Python3 (#37625)

* Fix csvfile traceback on Python3

The csvfile lookup uses some custom iterators.  These needed to be
ported to handle the python3 iterator protocol.  In addition, the
csvfile module takes an iterator of byte strings in Python2 and an
iterator of text strings in Python3

Fixes #36808

(cherry picked from commit 09325b619e)

* Add changelog entry for csvfile python3 fix
2018-03-29 15:11:14 -07:00
Toshio Kuratomi
64cdeba7a2 Bkprt py3 jira (#37800)
* make jira authentication Python3 compatible (#33862)

* make jira authentication Python3 compatible

(cherry picked from commit a51a699314)

* Add changelog fragment for py3 jira fix
2018-03-29 14:59:15 -07:00
Toshio Kuratomi
8d008d00ed Py3 vargrant inv (#37803)
* Fix dynamic inventory for vagrant does not work on python3 (#37631)

* Fix dynamic inventory for vagrant does not work on python3 #35129

(cherry picked from commit 1b121fc9e4)

* Add vagrant python3 fix to the changelog
2018-03-29 14:58:19 -07:00
Toshio Kuratomi
f23c100419 Bkprt py3 haproxy (#37791)
* Fix python3 interpreter issue (#34811) (#35176)

* Fix python3 interpreter issue (#34811)

* Update ansible.module_utils._text (#34811)

* Convert to text later to account for multibyte characters

(cherry picked from commit 340064bfb9)

* Add a changelog fragment for haproxy python3 fix
2018-03-29 14:57:40 -07:00
Jordan Borean
4e5f17e52d win_certificate_store: backport fix of typo key_storage (#37862)
* win_certificate_store: fix typo stopping key_storage from working (#37810)

(cherry picked from commit b7ce2b1c5a)

* Added changelog fragment
2018-03-29 14:18:53 -07:00
Trishna Guha
a716fe97e3
nxos bugfixes cherry-pick (#38091)
* Fix nxos_switchport (#37328)

(cherry picked from commit ff57fd0bb4)

* Fix nxos_l2_interface and test typo (#37336)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit ba5e562c76)

* fix ios_l2_interface (#37389)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dd37857884)

* fix required args for nxos_snapshot and docs improvement (#37232)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit a10df8b0b5)

* add nxos_snapshot test for missing required param (#37248)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 2501834c42)

* Ensure network_cli nxos test is run only once - remove unnecessary files (#37462)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 957ab02e52)

* Integration Tests only: nxos_user (#37852)

* add new integration file to nxos_user

* fix shippable error

* change nxapi to connection

* review comments

(cherry picked from commit 63da50e1d8)

* fix UnboundLocalError nxos_bgp_af module (#37610)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 00abe6dbe7)

* Fix nxos_vrf issues (#37092)

* fix nxos_vrf issues

* fix doc

(cherry picked from commit dc61f4c6b1)

* fix nxos_vrf_af issues (#37211)

(cherry picked from commit 74e79d9f5e)

* fix nxos_udld issues (#37418)

(cherry picked from commit 05b266cc66)

* fix nxos_vlan issues (#38008)

(cherry picked from commit 6f2cb28bb9)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-03-29 08:47:32 -04:00
Matt Martz
0b0bb65198
Backport #36372 for 2.5 (#37666)
* Fix name parameter templating in include_role module (#36372)

An IncludedFile() object built using the original_task will have
its _task bound to the original_task. The iterative reassignment of
original_task._role_name during with_item loops leaves all returned
included_files with the same ._task._role_name (the final name from
the with_items list). This commit builds IncludedFile() objects
from an original_task.copy() to avoid the problematic binding.

(cherry picked from commit 54e70fc783)

* Test include role with items in name #36372 (#37001)

* Tests for #36372

* Tests for #36372

* Tests for #36372

(cherry picked from commit 8c4f349743)

* Add changelog for #36372
2018-03-28 11:05:03 -05:00
Matt Martz
687780323a
Backport #37881 for 2.5.1 (#37937)
* Don't overwrite builtin jinja2 filters with tests (#37881)

* Don't overwrite builtin jinja2 filters with tests. Fixes #37856

* Fix tests and other callers of _get_filters

(cherry picked from commit 1f824bd620)

* Add changelog for #37881
2018-03-28 11:04:44 -05:00
Matt Martz
e33f1777fe
Backport #37646 for 2.5 (#37653)
* Fix py3 issue in wait_for_connection (#37646)

(cherry picked from commit 6c3e565ba3)

* Add changelog entry for #36470
2018-03-28 11:04:06 -05:00
Matt Davis
2c2dd1a1b3 New release v2.5.0 2018-03-22 17:50:20 -07:00
Matt Davis
144e5ae65a New release v2.5.0rc3 2018-03-15 18:12:31 -07:00
Toshio Kuratomi
c264061272 Bkprt conn err msg no template (#37381)
*  Connection error messages are unsafe: wrap them (#37329)

* Check that connection error msg are not unsafe

* Connection error messages are unsafe: wrap them

For example, in case of error, docker connection plugin returns exception
message containing Go template. These messages weren't tagged as unsafe
and were consequently rendered:

The conditional check 'result is failed' failed. The error was:
{
  'msg': u'Docker version check ([\'/usr/bin/docker\', \'version\', \'--format\', "\'{{.Server.Version}}\'"]) failed: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.35/version: dial unix /var/run/docker.sock: connect: permission denied\n',
  'failed': True
}:
template error while templating string: unexpected '.'.
String: Docker version check (['/usr/bin/docker', 'version', '--format', "'{{.Server.Version}}'"]) failed: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.35/version: dial unix /var/run/docker.sock: connect: permission denied

(cherry picked from commit 4378542ac7)

* Add a changelog for the no-template error message fix
2018-03-15 13:52:33 -07:00
Toshio Kuratomi
36186c3a04 Bkprt onyx tmp file (#37358)
* issue:36955 remove creating temp file for debug

Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 9031533c0c)

* Add changelog fragment for the onyx tempfile issue
2018-03-15 13:50:02 -07:00
Matt Davis
0a2db12370 fix changelog yamllint failure 2018-03-09 17:53:10 -08:00
Matt Davis
2ee6a85463 New release v2.5.0rc2 2018-03-08 23:39:28 -08:00
Matt Davis
643fe472e7 2.5.0rc2 changelog catchup/cleanup 2018-03-08 23:29:46 -08:00
Sam Doran
e02b237649 Do not try to add an entry if none exist (#37152) (#37213)
When commit revisions are disabled, there will be no revision items returned.
Add note about setting ANSIBLE_PERSISTENT_COMMAND_TIMEOUT to a higer value to avoid timeouts.

(cherry picked from commit 3134ba6bee)
2018-03-08 14:55:43 -08:00
Jordan Borean
acef6d25b1 powershell: backport environment string handler fixes 2.5 (#37223)
* win: handle non string as an environment value (#37215)

* win: handle non string as an environment value

* Changed powershell environment handler to use .net function instead for special chars

(cherry picked from commit 708869edd6)

* Added changelog fragement for powershell environment handler fix

* typo in changelog
2018-03-08 14:49:22 -08:00
John R Barker
934d1df0d1
2.5 network changelog (#37179)
Add details of major Network features added in Ansible 2.5
2018-03-08 12:38:04 +00:00
Toshio Kuratomi
0fd9c9b014
Bkprt unarchive fix (#37159)
* Fix unarchive with strip-components in extra_opts (#37048)

* Fix unarchive with strip-components in extra_opts

When unarchive is given extra_opts to strip all leading directories, it
could end up trying to change the permissions on the root directory.
Tar archives shouldn't contain absolute paths anyways so make sure that
all paths are relative as we handle them.

Fixes #21397

(cherry picked from commit cca0ccaf97)
2018-03-07 18:41:29 -08:00
Jordan Borean
09de6dc020
win_uri: backport return value fix for non 200 responses (#37156)
* win_uri: return response info on non 200 responses, convert DateTime values to ISO 8601 (#37104)

(cherry picked from commit c1f5e11cdf)

* Added changelog fragment for win_uri return value fix
2018-03-08 10:38:32 +10:00
Matt Martz
3b1be8d881
Backport #37151 for 2.5 (#37154)
* Add ansible-config and ansible-inventory to setup.py scripts (#37151)

(cherry picked from commit bd43776acf)

* Add changelog entry for #37151
2018-03-07 17:02:54 -06:00
Jordan Borean
33773624fb
win_wait_for: fix local port check on port not accessible externally (#37093)
* win_wait_for: use loopback IP instead of hostname if 127.0.0.1 is used (#36762)

* win_wait_for: use loopback IP instead of hostname if 127.0.0.1 is used

* removed reverse dns lookup in port check

(cherry picked from commit 67ffde4ac1)

* Added changelog for win_wait_for local port fix
2018-03-07 08:55:39 +10:00
Jordan Borean
f0a808e02c Win lineinfix fix (#36888)
* Win lineinfile fix (#35100)

* win_lineinfile: fix #33858. Removed conversion from \r\n

* win_lineinfile: added test for #33858

* win_lineinfile: added documentation and more tests for change

* win_lineinfile: fixed wrong hash in testing

(cherry picked from commit e15a903bdf)

* Added changelog for win_lineinfile fix

* fix typo in changelog
2018-03-06 13:05:31 -08:00
Toshio Kuratomi
4ad30ad9b5 Clarify Docker SDK rather than Docker API 2018-03-06 09:00:26 -08:00
Toshio Kuratomi
111c2d6c1f Add a changelog fragment for the docker 3 api changes. 2018-03-06 07:08:49 -08:00
Toshio Kuratomi
38a498bcfd
Bkprt py3 maven artifact (#37041)
* Python3 issues in maven_artifact (#37035)

Fixes #33761

(cherry picked from commit 1bc860fafd)

* Add a changelog for the python3 maven_artifact fix
2018-03-05 18:48:29 -08:00
Sam Doran
2bcc02e653 Add changelog fragment 2018-03-05 21:19:13 +00:00
Toshio Kuratomi
9711c60b01
Bkprt py3 znode (#37038)
* fix python3 compatibility for znode module

kazoo client requires bytes and not string

(cherry picked from commit 2d98a2de68)
2018-03-05 13:01:48 -08:00
John R Barker
e1174f8864
fix yamllint issue (#36636) 2018-02-23 13:30:48 +00:00
Matt Davis
98882b725f 2.5.0rc1 CHANGELOG prep 2018-02-22 17:34:03 -08:00
Jordan Borean
f8d8d84f05 Win feature error cp (#36559)
* win_feature: better error handling to make it easier to debug issues (#36491)

* win_feature: better error handling to make it easier to debug issues

* removed ignroed pslint rules that are no longer needed

(cherry picked from commit ef4f8851dc)

* Added changelog for win_feature error handling fix
2018-02-22 15:05:13 -08:00
Toshio Kuratomi
e93cc41211
Bp 2.5 ansible interpreter py3 (#36561)
* Fix types when evaluating interpreter (#36541)

* Fix types when evaluating interpreter. Fixes #36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)

(cherry picked from commit a4df4d33ac)

* Changelog entry for the ansible_*_interpreter fix
2018-02-21 20:05:14 -08:00
Sam Doran
84debca5fb Check for regexp match when using insertbefore or insertafter (#36474) (#36552)
Add tests to cover this scenario
Add changelog fragment
Fixes #36156

(cherry picked from commit 723daf3e3a)
2018-02-21 18:08:45 -08:00
scottb
138ed416eb Changelog fragment copy edits. (#36555)
* Changelog fragment copy edits.

* Typo fixes.

* Typo fix 2.
2018-02-21 16:21:31 -08:00
Matt Davis
61c1241a77 reformat multiline bugfix entries 2018-02-21 13:51:40 -08:00
Matt Martz
2c8d9beca3 cherry-pick #36470 for 2.5 (#36525)
* Re-use logic from StrategyBase._load_included_file in StrategyModule.run for free and linear (#36470)

This improves include_role performance and recursion limits

(cherry picked from commit 10fefc7156)

* Add changelog for 36470
2018-02-21 09:34:13 -08:00