Matt Clay
c5d9c98cdf
Use runtime instead of datetime for test output.
...
(cherry picked from commit 31a5b874a1
2018-08-23 14:21:12 -07:00
Matt Martz
0854dc3f7f
Add AnsibleModule signature schema, and fix associated issues ( #43512 ) ( #43515 )
...
* Add AnsibleModule signature schema, and fix associated issues (#43512 )
(cherry picked from commit 01c0446cb5
2018-08-13 18:12:37 -07:00
Matt Clay
bf8f228fd5
Update Shippable integration test groups. ( #43118 )
...
* Update Shippable integration test groups.
* Update integration test group aliases.
* Rebalance AWS and Azure tests with extra group.
* Rebalance Windows tests with another group.
(cherry picked from commit 4e489d1be8
2018-07-24 10:02:00 -07:00
Trishna Guha
e3993bd01b
nxos_nxapi fix pick-2.5 ( #42490 )
...
* Enforcing NXAPI default HTTP behavior (#41817 )
* nxos_nxapi http default behavior
* Use nxos_nxapi module in prepare_nxos_tests
* Refactor nxos_nxapi configure test to use yaml block
* Extend nxos_nxapi https & http test cases
* Removed NXOS internal release naming
* Resolved ansibot sanity errors
* Fix typo in prepare_nxos_tests
* Address PR comments
* Shippable indicates this is no longer needed
* Add port change logic and testing
(cherry picked from commit db7300904d#42688 )
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d5e9653c96
2018-07-23 09:20:54 -07:00
Sviatoslav Sydorenko
0b080de855
[2.5] Fix ios_vlan to correctly identify unmodified config when having long interface names ( #40145 ) ( #40656 )
...
Change the command to get the interface in a vlan "show vlan" => "show vlan brief"
Change the parsing of the return command of the switch.
The return of the ios command is fixed so i cut with fix number of carracter.
Adding looking for the next line to add the forgeted interfaces.
(cherry picked from commit 3903ca5
2018-05-24 15:55:13 +02:00
John R Barker
54413642db
removed_in: 2.6 is valid ( #40399 ) ( #40407 )
...
(cherry picked from commit fe4368ce15
2018-05-18 16:23:50 +01:00
Trishna Guha
299047d963
cherry-pick stable-2.5 ( #40177 )
...
* Fix nxos terminal plugin regex (#39659 )
Fix nxos terminal plugin regex to match
command prompt without newline character as prefix
(cherry picked from commit 0ac222d68b#39947 )
* remove purge from nxos_logging doc, argspec
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* shippable
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit f1103a7a02#39929 )
* IT cases for nxos_logging
* review comment
(cherry picked from commit 2557c0662a#40028 )
(cherry picked from commit 6fac574f17#39968 )
(cherry picked from commit 0407c51447#40066 )
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 5cf61d7401
2018-05-16 12:19:39 +05:30
Matt Clay
1ecfca84e6
Make docs-build sanity test disabled by default.
...
(cherry picked from commit a7d7df1450
2018-05-09 21:55:11 -07:00
Trishna Guha
079b7cb1fe
nxos and ios bugfix stable-2.5 ( #39845 )
...
* nxos_linkagg normalize interface (#39591 )
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 3c35dd4f7f#39658 )
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit dddcbb7198#39760 )
* fix nxos_snmp_user issues
* shipppable fix
(cherry picked from commit e3bfbe5875
2018-05-08 12:38:22 +05:30
Trishna Guha
69564206e0
nxos bugfixes stable-2.5 ( #39719 )
...
* Handle nxos_feature issue where json isn't supported (#39150 )
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 9eff1f1d74#39318 )
* add integration test cases for snmp_contact
* removing unnecessary files
(cherry picked from commit bdb75cd82c#39178 )
* fix nxos_ntp issues
* review comments
* fix idempotent fail case
(cherry picked from commit 2f99a17856#38544 )
This fixes an issue we recently encounteredi with nxos_interface:
```
Traceback (most recent call last):
File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 777, in main
have = map_config_to_obj(want, module)
File "/tmp/ansible_JmLoba/ansible_module_nxos_interface.py", line 606, in map_config_to_obj
obj['speed'] = re.search(r'speed (\d+)', body).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
```
(cherry picked from commit dca6e2d94d#39258 )
(cherry picked from commit 1afec5a48e#39275 )
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 86817cdd52#39074 )
* Fix misuse of 'self' in lib/ansible/module_utils/network/eos/eos.py. Method load_config
* Fix all instances of self.config(self,...
(cherry picked from commit 80d7e22f5e#39642 )
* fix snmp_host issues
* source files
* fix shippable
* remove defaults to match arg spec
(cherry picked from commit f99bae1776#39444 )
* fix snmp_traps code
* add IT cases
* fix shippable
* fix shippable without ignore
(cherry picked from commit 99748cbfa4
2018-05-04 15:25:55 +05:30
Matt Clay
784956c219
Sync stable-2.5 test infrastructure with devel. ( #39544 )
...
Sync stable-2.5 test infrastructure with devel:
- shippable.yml
- test/runner/
- test/sanity/
- test/utils/
- docs/docsite/rst/dev_guide/testing/sanity/
- test/integration/targets/*/aliases
2018-05-01 15:47:24 -07:00
Matt Clay
aa534d8be9
Move var precedence check to integration tests.
...
(cherry picked from commit 8daa80e5bb
2018-04-30 16:20:16 -07:00
John R Barker
96efaa3ff3
Explicitly exclude W504 ( #38539 ) ( #38550 )
...
pycodestyle 2.4 has changed the default for W504
(cherry picked from commit 38491fe93d
2018-04-10 21:01:26 +01:00
Jordan Borean
09dc621238
win_service: backport of special char in name handler ( #38250 )
...
* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets (#37897 )
* win_service: fix when dealing with paths with special chars and change WMI to CIM cmdlets
* compare username in lowercase for test
(cherry picked from commit f37a44430f
2018-04-04 13:43:33 +10:00
René Moser
f230d8e9c4
cs_router: fix missing doc ( #37107 )
...
* cs_router: fix missing doc
* update ignore.txt
(partly cherry picked from commit e1297af18a
2018-03-07 19:12:25 +01:00
René Moser
c054527d65
cs_ip_address.py: fix missing doc ( #37109 )
...
* cs_ip_address.py: fix missing doc
* update ignore.txt
(partly cherry picked from commit 67d8c8f5c6
2018-03-07 19:12:25 +01:00
John R Barker
e03b17e2e5
filesystem: fix documentation ( #36556 ) ( #36633 )
...
(cherry picked from commit 07927f52ae
2018-03-06 08:35:54 +00:00
Jordan Borean
f8d8d84f05
Win feature error cp ( #36559 )
...
* win_feature: better error handling to make it easier to debug issues (#36491 )
* win_feature: better error handling to make it easier to debug issues
* removed ignroed pslint rules that are no longer needed
(cherry picked from commit ef4f8851dc
2018-02-22 15:05:13 -08:00
Abhijeet Kasurde
980b6a00e2
Fixup VMware module docs issues ( #36409 ) ( #36523 )
...
Fix various argspec vs documentation issue
(cherry picked from commit 5d0ed38e3a
2018-02-22 08:44:09 -08:00
Matt Clay
8db5d139a1
Fix path handling in validate-modules sanity test.
...
(cherry picked from commit a9b58b84d8
2018-02-20 13:57:58 -08:00
John R Barker
8833823195
Ensure docs are valid before checking deprecation ( #36160 ) ( #36182 )
...
(cherry picked from commit 3e22efa0ba
2018-02-14 15:39:36 +00:00
John R Barker
c232d6cb85
Fix more docs vs argspec ( #36048 ) ( #36052 )
...
(cherry picked from commit 17c0d3eae0
2018-02-12 18:05:39 +00:00
Jordan Borean
a0178b79f1
win_uri: fixes ( #35487 )
...
* win_uri: moved away from Invoke-WebRequest and fixed multiple issues
* fixes from review
2018-02-07 20:58:47 +11:00
Pilou
54882d4715
dimensiondata: fix broken import ( #35634 )
...
* Fix broken import
* Remove never reached statements
exit_json and fail_json methods call sys.exit, subsequent statements
can not be executed.
2018-02-07 00:44:42 +01:00
Toshio Kuratomi
86242e6871
Enable wildcard import pylint ( #35786 )
...
* Wildcard imports should be taken care of. Enable the pylint check for them
* Remove wildcard import code-smell test as we're now checking via pylint
* Add unused-wildcard-import as ignored in our compat code.
These three files use wildcard imports so that they can export
symbols in a compatible location. The real code lives elsewhere.
So disable the pylint tests for the relevant sections of code.
2018-02-06 15:17:49 -08:00
Toshio Kuratomi
a5b80464df
Fix packaging/os modules for wildcard imports and get_exception
2018-02-06 08:44:49 -08:00
Abhijeet Kasurde
1119709b56
Remove get_exception from modules
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-06 07:49:24 -08:00
Pierre-Louis Bonicoli
2646ea9b86
yum_repository: Python 3.7 error have been fixed
...
See 232dc7110c
2018-02-02 09:43:58 -08:00
Toshio Kuratomi
4a48fdba1d
Update code smell blacklists ( #35621 )
...
Update blacklist for get_exception, boilerplate, and no-wildcard.
f5, lenovo, and junos have updated their code.
2018-02-01 12:24:07 -08:00
Matt Clay
b9c5147be2
Move import sanity test files into own directory. ( #35593 )
2018-02-01 09:52:31 -08:00
Matt Clay
2d565d14ed
Add pslint sanity test settings.
...
Globally ignore rule: PSUseShouldProcessForStateChangingFunctions
2018-01-31 06:31:05 -08:00
Jordan Borean
62b87bc925
change .encode to to_bytes ( #35522 )
...
ignore backup dir in test integration targets folder
2018-01-31 08:58:03 +10:00
Matt Martz
c282e4e00f
Replace LooseVersion comparison with int/float comparison. Fixes #35435 ( #35519 )
2018-01-30 15:27:22 -06:00
Matt Martz
f659cc5963
Guard against assignments that are not ast.Name in docs parsing ( #35513 )
2018-01-30 12:56:16 -06:00
John R Barker
a23c95023b
Module deprecation: docs, scheme and tests ( #34100 )
...
Enforce module deprecation.
After module has reached the end of it's deprecation cycle we will replace it with a docs stub.
* Replace deprecated modules with docs-only sub
* Use of deprecated past deprecation cycle gives meaningful message (see examples below)
* Enforce documentation.deprecation dict via `schema.py`
* Update `ansible-doc` and web docs to display documentation.deprecation
* Document that structure in `dev_guide`
* Ensure that all modules starting with `_` have a `deprecation:` block
* Ensure `deprecation:` block is only used on modules that start with `_`
* `removed_in` A string which represents when this module needs **deleting**
* CHANGELOG.md and porting_guide_2.5.rst list removed modules as well as alternatives
* CHANGELOG.md links to porting guide index
To ensure that meaningful messages are given to the user if they try to use a module at the end of it's deprecation cycle we enforce the module to contain:
```python
if __name__ == '__main__':
removed_module()
```
2018-01-30 12:23:52 +00:00
Jordan Borean
4da19f2d6b
Added code-smell check to verify filenames are allowed with Windows ( #35436 )
2018-01-29 13:46:02 -08:00
Matt Clay
7abdab6c9e
Convert ansible-test compile into a sanity test.
2018-01-25 09:45:36 -08:00
Pilou
0ce8d389a4
azure_rm_dnsrecordset: fix broken import and minor updates ( #34983 )
...
* fix broken import
Error was:
lib/ansible/modules/cloud/azure/azure_rm_dnsrecordset.py:223:0: NameError: name 'ARecord' is not defined
* doc: use formatting functions
* remove unused dict
2018-01-25 09:39:49 -08:00
Dag Wieers
417accf88d
Skip parameters that are being deprecated ( #35319 )
...
* Skip parameters that are being deprecated
So in most cases when parameters are deprecated, you may not want to
advertise them in the documentation. One reason for this is because
these parameters were not introduced within Ansible but predate
upstreaming them.
So this change avoids reporting parameters that are not documented and
are deprecated. It's only a small subset of the existing E322 errors.
* Add support for E323 with these changes
* Unsure about the other issues now
* Add better error message with E321
* Restore some erroneously remove files
* Readd false positives to ignore.txt
2018-01-25 11:10:49 -06:00
Matt Clay
e0010f15e4
Add pslint sanity test. ( #35303 )
...
* Add pslint sanity test.
* Fix `no-smart-quotes` sanity test.
* Add docs for `pslint` sanity test.
2018-01-24 17:22:14 -08:00
Matt Clay
cc65636a10
Add PSScriptAnalyzer to default container.
2018-01-24 08:36:28 -08:00
Colins-Git
7fac5cd7d2
Support for creation and modification of bridge and bridge slaves for nmcli ( #34071 )
...
Fixes : #31737
2018-01-24 11:00:09 +05:30
Dag Wieers
46e53f90a7
ACI: Rename aci_intf_policy_* to aci_interface_policy_* ( #35170 )
...
* ACI: Rename aci_intf_policy_* to aci_interface_policy_*
* Modify documentation accordingly
* Fix validity ignore file
2018-01-22 12:40:15 +01:00
Dag Wieers
fa5adabcbf
aci_rest: Additional notes and simplify examples ( #35091 )
...
Add additional notes, improve examples
2018-01-21 10:59:08 +01:00
Tim Rupp
ca8982f96c
Fixes some bugs and things ( #35122 )
...
Removes deprecations and fixes bugs.
2018-01-20 10:40:20 -08:00
Matt Martz
f9c2c9570d
Clean up imports to prevent issues with mutable data being used in modules ( #35112 )
...
* Clean up imports to prevent issues with mutable data being used in modules
* Remove un-needed mock
2018-01-19 16:33:16 -06:00
Matt Martz
3742ff9230
Fix CaptureStd in validate-modules to work on both py3 and py2 ( #35060 )
2018-01-18 14:50:31 -06:00
Dag Wieers
2fd5a99989
ACI: Fix validate-module tests E322 and E323 ( #35052 )
2018-01-18 19:18:43 +01:00
John R Barker
9a32f5c889
Add missing extends_documentation_fragment ( #35013 )
...
NXOS modules need more work, though that will all be in
module_docs_fragments/nxos.py
2018-01-17 16:31:53 -05:00
Matt Martz
3c400c5899
ANSIBLE_METADATA doesn't support YAML currently, change 315 to invalid data type ( #35009 )
2018-01-17 14:15:22 -06:00
