Commit graph

36261 commits

Author SHA1 Message Date
Brian Coca
4d7e174748 centralize doc/config plugin lists (#38775)
* centralize doc/config plugin lists

also update list for generation in docsite
added note to ensure they are in sync

* updated shell page to list plugins

added some more docs hinting at plugins being configurable

* fix edit link for plugins

(cherry picked from commit bdbb89378f)
2018-04-16 13:02:29 -07:00
s-hertel
b523910269 add changelog 2018-04-16 11:09:30 -04:00
Brian Coca
23fd9bb328 better handling of diff key types in compose
also made separator configurable
fixed some exception types
better error msgs

(cherry picked from commit c679186f17)
2018-04-16 11:09:30 -04:00
Martin Krizek
1684823196
Use correct action in warning about missing name (#38481)
(cherry picked from commit fd96bcd22f)
2018-04-16 14:42:11 +02:00
Deepak Agrawal
829f9fda7a
doc changes for backup option of network _config modules (#38797) 2018-04-16 12:30:05 +05:30
Abhijeet Kasurde
6030535917
VMware: Set default network type as 'dhcp' (#38755)
If user does not specify any network type then set network type
to dhcp. There are additional checks around 'ip', 'netmask' and
'type' in network spec.

Fixes: #38466

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 9b139baacb)
2018-04-14 21:58:49 +05:30
Alicia Cozine
30d338f664 Add details to see decrypted vault value (#37341) (#38746)
* Improves ansible-vault section of network getting started
(cherry picked from commit 521ea56e77)
2018-04-13 17:54:34 +01:00
Alicia Cozine
0fdfb27e0f corrects Junos network_cli example & variables (#38601) (#38705)
* corrects Junos network_cli example & variables

* vdacosta feedback, thanks
2018-04-13 16:43:42 +01:00
Abhijeet Kasurde
1de0515af9 nmcli: change default value of autoconnect (#38686)
There was discrepancy between documentation and actual code.

Fixes: #38671

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit f1cd254265)
2018-04-13 11:28:39 -04:00
Alicia Cozine
e8469a5117
inaugural Network FAQ (#38359) (#38703)
(cherry picked from commit ea99cf3231)
2018-04-13 09:00:57 -05:00
Ganesh Nalawade
0143aa9416
Fix in eos get_config cliconf api (#38682) (#38720)
If format is passed as None to get_config api, wrong command is
genereted ie. `show running-configuration | None | section interface`.
Add format type in command only if format value is either not `text`
or  `None`.
(cherry picked from commit 88662d0c56)

Update changelog
2018-04-13 15:55:14 +05:30
Sviatoslav Sydorenko
fdcbcf313a Suppress a UserWarning about unknown dist option 2018-04-13 00:59:32 +02:00
Sviatoslav Sydorenko
7993dc90e5 Refactor setup.py helper code 2018-04-13 00:59:32 +02:00
Sviatoslav Sydorenko
34861a3524 Shield setup module from accidental setup exec
This might happen when third-parties like analizers import this
module for testing purposes.
2018-04-13 00:59:32 +02:00
Sviatoslav Sydorenko
c1c65168d5 Update python requirements in distribution meta
This has been discussed during #38413 review, but got missed.
2018-04-13 00:59:32 +02:00
Sviatoslav Sydorenko
9011a0abc6 Add a list or extra URLs to distribution metadata
This should enable Warehouse PYPI implementation pypa/warehouse#3604
to pull data from GitHub and show it on the project page.
2018-04-13 00:59:32 +02:00
Martin Krizek
5f98ee878e
Give hint when lookup fails on one element list (#38406) (#38480)
(cherry picked from commit 81a8c42115)
2018-04-12 20:54:04 +02:00
Sam Doran
3a6f93c190
fixed documentation to include esxi host (#38668) (#38673)
(cherry picked from commit c0243a8a31)
2018-04-12 11:42:37 -04:00
Jordan Borean
0ce544c29b
win_setup: backport 2.5 fix for machine sid to work in domains with lots of users (#38659)
* win_setup: fix for machine sid to work in domains with lots of users (#38646)

(cherry picked from commit 2fc3ac3516)

* Added changelog fragment
2018-04-12 20:30:34 +10:00
Jordan Borean
5f8812ec23
minor typo fix https://github.com/ansible/ansible/pull/38589 2018-04-12 19:06:36 +10:00
Will Thames
86f5a82457
Use a temp directory that is more likely to exist (#38645)
`env:SystemDrive\temp` does not necessarily exist

`env:temp` is much more likely to exist. Use that

(cherry picked from commit 4ba29c8bf1)
2018-04-12 19:02:49 +10:00
Ganesh Nalawade
955ef020ef
Add troubleshooting URL for persistent socket path related issue (#38542) (#38577)
* Add troubleshooting URL for persistent socket path related issue

socket path timeout related error messages are not displayed on the
console as the ansible-connection process does not have access to it.
Until this is fixed need to point to troubleshooting URL so that
users can take corrective actions.

* Fix CI issue

* Update changelog fragments
(cherry picked from commit 53d3e7e306)
2018-04-12 10:43:02 +05:30
Sam Doran
4b436847fc Add changelog entry 2018-04-11 17:54:59 -04:00
Brian Coca
78484137c0 restrore showing stderr on script success (#38177)
* restore showing stderr on script success

accidentally removed during transition to plugin, with toggle for those
who prefer the quiet way

fixes #33776

* stderr display if no other errors capture first
* fixed issue with error encoding

(cherry picked from commit eef70d028f)
2018-04-11 17:54:59 -04:00
Sam Doran
0f524a1632
Fix edgeos_config: {backup: yes} (#37619) (#37733)
* Fix edgeos_config: {backup: yes}

* Add actual plugin copy

(cherry picked from commit 6aed74a97d)
2018-04-11 17:50:13 -04:00
Sam Doran
27f2653c7f Update installation docs for RHEL based distributions. (#38053)
Upstream rpms are no longer in Extras but EPEL as well as releases.ansible.com.
Add instructions for adding Ansible Engine repo to RHEL.
2018-04-11 16:28:09 -04:00
Toshio Kuratomi
48a4b00ade When I rebased the README as rst PR, I missed a few changes.
(cherry picked from commit 98a6827be0)
2018-04-11 13:26:41 -07:00
Sviatoslav Sydorenko
9fd122d7be Add docs badge to README
(cherry picked from commit 2a55c64da9)
2018-04-11 11:58:09 -07:00
Stephen Weber
28651a85ab Convert README from Markdown to ReStructured Text and use as longdesc (#22330)
* Convert README from Markdown to ReStructured Text and use as longdesc

Discussion in #13758 led to deciding to switch README to rst and having
setup.py consume it as the long_description.

* Fix long string in setup.py for pep8 compliance

* Open README.rst as read-only

* Update usages of root README.md to README.rst

Unsure about the file ./packaging/debian/docs as it (only) contains the
text README.md. I believe it's referencing ./packaging/debian/README.md
but maybe someone who knows debian packaging could review it?

* Pick up fixes that had been merged into README.md after the initial conversion to rst

(cherry picked from commit 7afa34ae8a)
2018-04-11 11:57:24 -07:00
Toshio Kuratomi
430195f0f1 README.md was renamed. Fix deb build reference to the README
(cherry picked from commit 19a5f96a1a)
2018-04-11 11:23:44 -07:00
Trishna Guha
91c8a8dccc
nxos_igmp_snooping fix cherry-pick (#38596)
* fix nxos_igmp_snooping issues (#38566)

* fix nxos_igmp_snooping issue

* shippable error fix

(cherry picked from commit ed42331105)

* update nxos changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-04-11 12:47:33 -04:00
Nathaniel Case
8b8455523d
Fall back to ValueError if JSONDecodeError is not available (#38276) (#38423)
(cherry picked from commit e05cad785e)
2018-04-11 09:01:47 -04:00
Ganesh Nalawade
23e57fe095
Add junos connection type check (#38527) (#38579)
junos_netconf works only with connection=network_cli
Add check to report appropriate error if any other
connection type is used.
(cherry picked from commit 16c2d3717e)

Update Changelog fragments
2018-04-11 14:03:07 +05:30
John R Barker
96efaa3ff3
Explicitly exclude W504 (#38539) (#38550)
pycodestyle 2.4 has changed the default for W504
(cherry picked from commit 38491fe93d)
2018-04-10 21:01:26 +01:00
Toshio Kuratomi
0a441eb2f1
Bkprt py3 consul kv (#37802)
* consul_kv: decodes kv values from Consul to utf-8 (#35894)

* Decodes kv values from Consul to utf-8.

* Switches to using module utils to perform text decoding.

* Adds self to authors list to help community maintenance.

(cherry picked from commit a4a2b4a381)

* Add a changelog fragment for consul_kv python3 fix
2018-04-10 10:03:30 -07:00
Ricardo Carrillo Cruz
bbcb7d9118
Cherry pick 35568 (#38347)
* eos_vlan: Modified logic to allow for more than 6 interfaces to be assigned to … (#35568)

* Modified logic to allow for more than 6 interfaces to be assigned to a vlan

* arista output to json.  removing logic for string size.

(cherry picked from commit 99627ab99d)

* Add changelog fragment
2018-04-10 18:57:56 +02:00
Trishna Guha
7f55954cc1
nxos_igmp and nxos_hsrp fix (#38513)
* fix nxos_igmp issues (#38496)

(cherry picked from commit 361437b042)

* fix nxos_hsrp issues (#38410)

* fix nxos_hsrp issues

* shippable fix

* add examples for md5 auth

(cherry picked from commit dabe5e6d07)

* update changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-04-10 01:51:41 -04:00
Jordan Borean
0525d4cf9d
winrm: backport 2.5 added flag handler for kinit to request forwardable ticket when delegation is set (#38508)
* winrm: added flag handler for kinit to request forwardable ticket when delegation is set (#37815)

(cherry picked from commit 22f2388ef1)

* Added changelog fragment
2018-04-10 14:24:21 +10:00
Jordan Borean
7e621b3dbe
win_uri: backport 2.5 fix for when status codes are provided as a comma separated list (#38509)
* fix for when status codes are provided as a comma separated list (#38080)

* fix for when status codes are provided as an array of strings

* convert status codes to int, additional tests

(cherry picked from commit c38617a736)

* Added changelog fragment
2018-04-10 14:24:00 +10:00
Jordan Borean
3ac6c6ebd9
win_exec_wrapper: fix tests after recent change (#38504) (#38506)
(cherry picked from commit 0d374f28d2)
2018-04-10 11:31:03 +10:00
Adrian Likins
31e28a04a5 Fix 'New Vault password' on vault 'edit' (#35923) (#38003)
* Fix 'New Vault password' on vault 'edit'

ffe0ddea96 introduce a
change on 'ansible-vault edit' that tried to check
for --encrypt-vault-id in that mode. But '--encrypt-vault-id'
is not intended for 'edit' since the 'edit' should always
reuse the vault secret that was used to decrypt the text.

Change cli to not check for --encrypt-vault-id on 'edit'.

VaultLib.decrypt_and_get_vault_id() was change to return
the vault secret used to decrypt (in addition to vault_id
and the plaintext).

VaultEditor.edit_file() will now use 'vault_secret_used'
as returned from decrypt_and_get_vault_id() so that
an edited file always gets reencrypted with the same
secret, regardless of any vault id configuration or
cli options.

Fixes #35834

(cherry picked from commit 6e737c8cb6)
2018-04-09 14:57:34 -07:00
Dag Wieers
b9ccac8550 Fix incorrect RN used in module (#38249)
This is backported from devel as this bug makes the module fail for VMM
domains.
2018-04-09 14:46:59 -07:00
Ondra Machacek
9d0ebfdea6 ovirt: Cherry picks of recent fixes to devel branch (#38341)
* ovirt_host_networks: Fix idempotency

* ovirt_hosts: Fix failed_state after PM fence

* ovirt_host_networks: Fix of bond assignment (#38054)

* ovirt_host_networks: Fix of bond assignment

* ovirt_host_networks: Fix bond modes

* ovirt_host_networks: Fix incorrect prefix documentation

* ovrit_cluster: fix for CPU arch entity #37425 (#37436)

* ovrit_cluster: fix for CPU arch entity #37425

* Corrected Indentation

* Condition to check if `architecture` is defined
2018-04-09 14:35:50 -07:00
Jordan Borean
9bb2a36289
win_updates: backport 2.5 handle failure on module load (#38498)
* win_updates: handle if module failed to run (#38363)

(cherry picked from commit ccc56e138a)

* Added changelog fragment
2018-04-10 06:39:09 +10:00
Jordan Borean
38a13f41cd
powershell: 2.5 backport display non-ascii characters in command outputs (#38365)
* powershell: display non-ascii characters in command outputs (#37229)

(cherry picked from commit 71e8527d7c)

* Added changelog fragment
2018-04-10 05:25:02 +10:00
Markos Chandras
2e881f2929 modules: zypper: Optimize the 'search' subcommand (#37191) (#37234)
When looking for installed packages we do not need to query
repositories since we only care about the rpmdb. As such, we can
disable all the repositories operations in order to improve the
performance of that step

Before this patch, when using 'state: present' in the zypper module,
the operation was taking about 12 seconds to complete:

time ansible-playbook foo.yml 1>/dev/null

real	0m12.614s
user	0m10.880s
sys	0m0.683s

After this patch:

time ansible-playbook foo.yml 1>/dev/null

real	0m4.193s
user	0m2.560s
sys	0m0.575s

see:
https://bugzilla.opensuse.org/show_bug.cgi?id=1084525
(cherry picked from commit 5234b78b5f)
2018-04-09 11:54:39 -07:00
Martin Krizek
28b41f5c83 Update playbooks_loops.rst (#38440) (#38475)
Missing parentheses
+label: docsite_pr

(cherry picked from commit 061ecac3b5)
2018-04-09 11:35:04 -07:00
Adam Miller
f96c109286
Backport azure_rm_image Tag fix for 2.5 (#38131) (#38228)
* fix typo (#38131)

(cherry picked from commit 1c00a14c31)

* add changelog fragment for 38131 backport to 2.5

Signed-off-by: Adam Miller <admiller@redhat.com>

* Fixes #37700 Azure image can be created with tag (#37981)

* image can be create or add

* update tags

* can remove all tags

* Update azure_rm_common.py
2018-04-09 10:46:42 -05:00
Ganesh Nalawade
4875477d17
Fix junos transport check (#38460) (#38467)
For connection=local check only if the transport value in
provider is cli and the respective module support cli
transport. If not report back appropriate error message.
(cherry picked from commit e10e0d42d8)
2018-04-09 19:13:40 +05:30
John R Barker
4f0389ad4e
Backport/2.5/38386 (#38462)
* openssl_certificate: Handle dump() in check_mode (#38386)

Currently, when ones run the module in check_mode it tries to retrieve
values from the actual certificate generated in the generate() function.

Since in check_mode we call dump() without calling generate(), self.cert
is None, leading to self.cert.get_notBefore(), self.cert.get_notAfter()
and self.cert.get_serial_number() raising an error.

>  NoneType' object has no attribute 'get_notBefore'

The solution is to have two way to handle dump() method, whether its run
in check_mode=True or check_mode=False leading to different way the
information is retrieved.
(cherry picked from commit 99497ce54c)
2018-04-09 09:49:09 +01:00