Commit graph

36125 commits

Author SHA1 Message Date
Julien Vey
9e9f910cb6 ec2_group:documentation explicit a behaviour for sg rules (#36627) 2018-02-27 16:07:18 +10:00
Matt Clay
78cc85fa27 Fix rst link syntax.
(cherry picked from commit 3937082892)
2018-02-26 11:18:38 -08:00
David Newswanger
e1eae55e55
skip fmg_script unit test if the pyFMG script is not present (#36732) (#36749)
* skip fmg_script unit test if the pyFMG script is not present

* appease the sanity test gods

(cherry picked from commit 6bd715a17d)
2018-02-26 12:41:14 -05:00
Peter Sprygada
b86f07324e fix cliconf get_config method to match base signature (#36682)
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class.  Without this patch, the
get_config method calls will fail in some cirumstances.

(cherry picked from commit fb6a8c0133)
2018-02-26 10:57:25 -05:00
René Moser
eb12520854
cs_sshkeypair: fix ssh key rename (#36726) (#36730)
* tests: cs_sshkeypair: add reproducer for failed key rename

* cs_sshkeypair: fix rename ssh key

(cherry picked from commit cdb2969703)
2018-02-26 15:45:39 +01:00
John R Barker
5052db2698
NSO ValueBuilder improvements. 4.5 leaf-list compatability. (#36583) (#36735)
Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.
(cherry picked from commit 2789cc5c09)
2018-02-26 13:50:11 +00:00
John R Barker
d67d19bc1f
Backport/2.5/36722 (#36733)
* Fix sanity checks in OpenStack docs fragment (#36722)

Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
(cherry picked from commit 8b52006d5c)
2018-02-26 13:48:38 +00:00
Peter Sprygada
0aa62a54cd allows ib_spec attrs to be filtered in update (#36673)
* allows ib_spec attrs to be filtered in update

This change will allow the ib_spec entries to be be filtered on a change
object by setting the update keyword to false.  The default value for
update is true.  When the update keyword is set to false, the keyed
entry will be removed from the update object before it is sent to the
api endpoint.

fixes #36563

* fix up pep8 issues

(cherry picked from commit 93b795baf0)
2018-02-26 08:17:55 -05:00
John R Barker
6bf30f65b9
Fix typos (#36671) (#36724)
Fix minor typos
(cherry picked from commit 487ff1fe9b)
2018-02-26 11:27:24 +00:00
Trishna Guha
b1bdc5dae2
nxos_vlan, nxos_linkagg fix (#36711)
* fix nxos_vlan aggregate (#36710)

* fix nxos_vlan aggregate

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 44332bda78)

* nxos_linkagg fix (#36706)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit d6912cf40e)
2018-02-26 13:01:20 +05:30
Ganesh Nalawade
d60eac9bc4
Decouple config and state check in vlan and vrf network modules (#36386) (#36704)
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules

Fixes #35567
Fixes #34754

`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.

Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.

* Fix CI failures

* Fix review comment

* Fixed integration test failure

(cherry picked from commit 5a6b893240)
2018-02-26 10:16:39 +05:30
Matt Clay
a48254275f Temporarily disable subversion test on osx.
(cherry picked from commit f283edcb19)
2018-02-24 17:26:39 -08:00
Ed Costello
b717765d59 Fix documentation of validate_certificates option in aws doc_fragment.
Unignore sanity test failures for AWS modules caused by this common
fragment.

(cherry picked from commit 2a0c7c4331)
2018-02-23 21:42:36 -08:00
John R Barker
e1174f8864
fix yamllint issue (#36636) 2018-02-23 13:30:48 +00:00
Matt Davis
e77c1b9e42 New release v2.5.0rc1 2018-02-22 17:40:29 -08:00
Matt Davis
98882b725f 2.5.0rc1 CHANGELOG prep 2018-02-22 17:34:03 -08:00
Matt Davis
97a7c3f39c rename versioned CHANGELOGs with dash 2018-02-22 17:32:58 -08:00
Matt Davis
2ddcdb8720 Revert "Add force option to systemd module (#35925)"
(mistaken cherry pick)

This reverts commit 9935cda4a3.
2018-02-22 17:10:05 -08:00
Dag Wieers
917e5ae5d8 Improve convert_bool error message
The error message as it was confused me when the value was 'enabled' and
there was also a module parameter named 'enabled'.

    enabled is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

So by clearly describing it as a value, the confusion would have been
avoided.

    The value 'enabled' is not a valid boolean.  Valid booleans include: yes, on, 1, true, ...

(cherry picked from commit 487cf0ee8d)
2018-02-22 16:36:29 -08:00
Matt Davis
ed9781bbfb
Do not cache the loop item label so that it will update with each item (#36609)
Add integration test for #36430 (#36432)

(cherry picked from commit d1f76939e5)
(cherry picked from commit 9fced4f0a9)
2018-02-22 16:08:00 -08:00
Dag Wieers
b1e125b718 Backport missing integration tests (#36610)
Somehow this file was missing from the previous backport.
2018-02-22 15:18:06 -08:00
John R Barker
3d1c8bc2e1 Network Getting started docs (#36337) (#36597)
* first draft of getting started guide
(cherry picked from commit 51a010a696)
2018-02-22 15:15:11 -08:00
Jordan Borean
f8d8d84f05 Win feature error cp (#36559)
* win_feature: better error handling to make it easier to debug issues (#36491)

* win_feature: better error handling to make it easier to debug issues

* removed ignroed pslint rules that are no longer needed

(cherry picked from commit ef4f8851dc)

* Added changelog for win_feature error handling fix
2018-02-22 15:05:13 -08:00
Matt Martz
9bd7147bb8 Start of tests for modify_module, specifically to ensure proper shebang replacement on old style modules (#36602) (#36606)
(cherry picked from commit a7062b7587)
2018-02-22 14:56:03 -08:00
Chris Houseknecht
7e378e791c
Bump OpenShift client req to 0.4.3. Fixes openshift_scale. (#36580) 2018-02-22 16:14:26 -05:00
Abhijeet Kasurde
980b6a00e2 Fixup VMware module docs issues (#36409) (#36523)
Fix various argspec vs documentation issue

(cherry picked from commit 5d0ed38e3a)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-22 08:44:09 -08:00
Ryan Brown
c4e94af4e9 [cloud] catch NoCredentialsError in boto3_conn (#36545) 2018-02-21 23:18:41 -05:00
Toshio Kuratomi
e93cc41211
Bp 2.5 ansible interpreter py3 (#36561)
* Fix types when evaluating interpreter (#36541)

* Fix types when evaluating interpreter. Fixes #36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)

(cherry picked from commit a4df4d33ac)

* Changelog entry for the ansible_*_interpreter fix
2018-02-21 20:05:14 -08:00
Sam Doran
84debca5fb Check for regexp match when using insertbefore or insertafter (#36474) (#36552)
Add tests to cover this scenario
Add changelog fragment
Fixes #36156

(cherry picked from commit 723daf3e3a)
2018-02-21 18:08:45 -08:00
mikedlr
26cdfd84a0 Bring aws_ssm None fixes into stable (from #36456) (#36492)
* aws ssm parameter lookup - change to reutrn Nones for missing variables

* aws ssm parameter lookup - fix error case message to dump response

* aws ssm parameter lookup - fix integration test cases
2018-02-21 20:53:31 -05:00
Julien Vey
7965ecb962 efs: improve documentation about the update of an efs (#36473)
(cherry picked from commit 3abaa43b1c)
2018-02-21 20:36:04 -05:00
scottb
138ed416eb Changelog fragment copy edits. (#36555)
* Changelog fragment copy edits.

* Typo fixes.

* Typo fix 2.
2018-02-21 16:21:31 -08:00
Dag Wieers
df78df5d90 Apply all devel ACI changes missing from stable-2.5 (#36553) 2018-02-21 15:36:47 -08:00
Matt Davis
61c1241a77 reformat multiline bugfix entries 2018-02-21 13:51:40 -08:00
Matt Davis
0057cfa066 remove plugin sections from reno config
* we'll generate those at runtime using plugin metadata instead of trying to cobble together from sections
2018-02-21 13:12:33 -08:00
Julien Vey
54f9f06edc [cloud] ec2_group: fix check mode when using tags (#36503)
Fixes #36412
2018-02-21 15:39:29 -05:00
Sam Doran
cb73fba369 Add note to use script module rather than inline here documents (#32863)
* Add example on how to use a here document with shell module

* Remove here doc example and add note to use script module instead

(cherry picked from commit 5e7ee9df0a)
2018-02-21 15:10:12 -05:00
Toshio Kuratomi
7f9fdbbb30 Revert "remove query/q (#36315)"
This reverts commit b47d2e07e1.

query is a feature for 2.5.  We're not reverting it now.

(cherry picked from commit 03a6d72633)
2018-02-21 11:03:55 -08:00
Sloane Hertel
741b941f33 [cloud] If inventory file isn't able to be parsed by aws_ec2, raise an AnsibleParserError (#36387) (#36459)
* If inventory file isn't able to be parsed by aws_ec2, return an empty dict instead of None

* Raise an AnsibleParserError instead

* remove extra lines

* aws_ec2 inventory plugin - fix path matching logic
2018-02-21 13:50:14 -05:00
Sloane Hertel
32515884ef [cloud] Change to longer interval jittered backoffs for AWS facts (#36266) (#36464)
* Change to longer interval jittered backoffs for security group fact gathering

* Add the ECS throttling error code to the list of things to retry on
2018-02-21 13:49:28 -05:00
Sloane Hertel
77af8f36cb [cloud] Retry WAF actions on WAFStaleDataException (#36405) (#36507)
Add a util to run functions with AWSRetry to retry on WAFStaleDataExceptions and update ChangeToken for each attempt
2018-02-21 13:46:29 -05:00
Sloane Hertel
234ba3f8b3 [ec2_vpc_net_facts] Fix UnsupportedOperation for regions other than u… (#35302) (#36512)
* [ec2_vpc_net_facts] Fix UnsupportedOperation for regions other than us-east-1

* Make fix more Pythonic

* Fix the exception handling for the module
2018-02-21 13:45:38 -05:00
Matt Martz
2c8d9beca3 cherry-pick #36470 for 2.5 (#36525)
* Re-use logic from StrategyBase._load_included_file in StrategyModule.run for free and linear (#36470)

This improves include_role performance and recursion limits

(cherry picked from commit 10fefc7156)

* Add changelog for 36470
2018-02-21 09:34:13 -08:00
Sloane Hertel
bcc3ce8d74 [cloud] Better handling of absent AWS SES identity notification information. (#36354) (#36515)
* Better handling of absent AWS SES identity notification information.

Fixes #36065

aws_ses_identity module now handles the cases where information about
the notification setup for the identity isn't returned by the AWS api.

This seems to happen in an edge case, believed to be eventual
consistency on registering new identities. So this case is treated
as if has been no notification setup for the identity yet.

Also fix 2 flake8 warnings in the module, a missing newline and unused
import.

* Increase the Boto Retries on SES APIs to deal with throttling.

This should address the unstable integration test failing due to
parallel runs in shippable hitting AWS throttling.

* Add retries loading SES details for inclusion in successful response.

There seems to be an eventual consistency behaviour with identity
registration. It's possible to still get no identity back after
registration.

This can cause failures in the shippable builds. This should fix that by
creating a retry of retrieving the identity information after
registration.

A similar retry loop has been added to notification attributes to ensure
this doesn't suffer from the same failure.

* Add missing sleep in get_notification_attributes to avoid busy loop.
2018-02-21 12:33:33 -05:00
Brian Coca
7188165dd1 remove query/q (#36315)
* remove query/q

remove and fixed tests for removed func

* paren fix

(cherry picked from commit b47d2e07e1)
2018-02-21 10:45:50 -05:00
Brian Coca
c6af155049 catch all cases of no inventory when asked to fail
fixes #36034

(cherry picked from commit fdbd1297cf)
2018-02-21 10:45:50 -05:00
Trishna Guha
16845be9b1
nxos fixes (#36514)
* fix nxos_pim module doc (#36505)

* fix nxos_pim module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review

(cherry picked from commit 9598978e12)

* nxos_vrf fix (#36494)

* nxos_vrf fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Address review

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 713828804d)
2018-02-21 20:15:09 +05:30
Sam Doran
9935cda4a3 Add force option to systemd module (#35925)
* Add force option to systemd module

* Use multi-line YAML syntax in examples

* Add version_added for new option

(cherry picked from commit 2bffcfa63b)
2018-02-21 08:30:20 -05:00
René Moser
7e1ff91a5a
cs_user: fix return user_api_secret for ACS v4.10 and later (#36447) (#36489)
(cherry picked from commit 6402a3e504)
2018-02-21 11:04:52 +01:00
Jordan Borean
9b00fd4ca1
fetch: set fail_on_missing: True as default as per docs (#36469)
* fetch: set fail_on_missing: True as default as per docs

* Updated docs for fetch to say behaviour was changed in 2.5 and updated tests

(cherry picked from commit df8a5d7a4f)
2018-02-21 18:11:32 +10:00