Commit graph

36573 commits

Author SHA1 Message Date
Brian Coca
cee1cbf65b make individual bad paths a warning
still error if none of the paths provided was usable

fixes #39044

(cherry picked from commit e4dbabbef2)
2018-04-30 17:20:32 -04:00
Brian Coca
18d0fe6b30 minimize loading files/plugins
avoids some repetitive loading
 - read config file only once
 - now cache the ini parser per file
 - optimize shell plugin loading

tried to 'optimize' vars_plugins loading but it creates issues with precedence,
probalby due to iterator not being reset, will look into it in subsequent fix/PR

(cherry picked from commit 42912e1ac8)
2018-04-30 12:49:53 -04:00
Brian Coca
b595c6254f return empty host list when pattern is empty
fixes #37894

(cherry picked from commit 2e852fcd6d)
2018-04-30 12:48:56 -04:00
Brian Coca
19ab7b4b64 ignore version when deciding callback loading (#38281)
* ignore version when deciding callback loading

The code already defaulted to load the callback if the properties are not present
there was no need for us to also check the version

fixes #38270

* fix error msg on set optoins to use correct name

(cherry picked from commit 1850bb752f)
2018-04-30 12:47:58 -04:00
Brian Coca
80486090d5 protect against plugins using verify incorrectly
assume false on any errors

(cherry picked from commit ef40e5e3b2)

backport of #36591
2018-04-30 12:47:04 -04:00
Alicia Cozine
27b1044bc1
Update intermediate_concepts.rst (#39500) (#39503)
Updated  GitHub Repos section to better explain what ansible-network@redhat.com is for (not an email list, but adding to the network-automation github repo.
(cherry picked from commit 9773157da6)
2018-04-30 11:35:53 -05:00
Sloane Hertel
4de31cd96b
Add changelog for #37010 (#39511) 2018-04-30 12:29:11 -04:00
Toshio Kuratomi
e7aa8bc0e3 Need to convert filenames to byte strings before using them in APIs
Under a non-utf-8 locale (for instance, LC_ALL=C), passing a non-ascii
filename to many APIs will traceback.  Fix that by explicitly converting
to byte strings before passing to external APIs.

May fix #27262

(cherry picked from commit 2976b653ce)

Add a changelog for filename encoding in template action fix

(cherry picked from commit d90c36e320)
2018-04-30 09:26:02 -07:00
Brian Coca
b5a5211cd4 remove slice docs (#37946)
(cherry picked from commit b533ebe20d)

backport of #37946
2018-04-30 10:14:19 -04:00
Alicia Cozine
8ce45ec4d6
fixes broken link in aci module docs (#39247) (#39450)
* fixes broken link in aci module docs

* makes correct fix for aci broken link

(cherry picked from commit 4801bf96a5)
2018-04-30 08:49:58 -05:00
Matt Clay
f9ba5bc5e9 Disable failing tests. 2018-04-27 16:14:06 -07:00
Will Thames
b9df2e5c9f [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock - fixes #37003 (#37010) (#39210)
* [cloud] ec2_vpc_route_table: ignore routes without DestinationCidrBlock

Add module warnings rather than silently skipping

* Permit warnings for routes tables containing vpc endpoints to be turned off

* Add tests to ensure a VPC endpoint associated with a route table does not result in a traceback

(cherry picked from commit da3f7a8db1)
2018-04-27 15:56:32 -04:00
Alicia Cozine
7577a8c24d
Last docs link fixes (#39391) (#39445)
* should not need <>, but fails without

* adds anchor to keywords page, uses it on plugins pages

* fixes envvar link errors

* harmonize file name and ref name as python_3

(cherry picked from commit c8a9b411bc)
2018-04-27 13:55:13 -05:00
Brian Coca
86663c8060 fixy typo (#39430)
(cherry picked from commit 01e7f44e0d)
2018-04-27 11:06:56 -07:00
Jordan Borean
05f04c173c Change except Error when trying to get a missing option
(cherry picked from commit 25dea1f72c)
2018-04-27 11:57:14 -04:00
Benn Roth
515bb78ee1 minor accuracy fix
Don't round the parameter 12.04 in the explanatory paragraph unless `version()` rounds the parameter

(cherry picked from commit 5cf544e03e5f833e1614fa940849976550d55448)
(cherry picked from commit 56967497d5)
2018-04-27 11:56:09 -04:00
Adrian Lopez
f77f605115 chkconfig localizes messages, ansible fails to recognise
In the particular case of executin "chkconfig --list NAME", ansible
checks the stderr looking for a particular english message.
This message is different in other languages, Spanish for example
(although it have been corrected in the latests versions)

Fixes #29818

(cherry picked from commit e7db3c0eba)
2018-04-27 11:26:57 -04:00
Sam Doran
070c7b77ab Backport #39366 - call diff callback also when task diff is true (#39372)
* call diff callback also when task diff is true (#39366)

fixes #31129

(cherry picked from commit d76298b5d3)

* Add changelog entry
2018-04-27 10:20:15 -04:00
Jordan Borean
655ffa5368
Win file path special char 2.5 (#39397)
* win_file: Handle [] in paths, fix touch in check mode (#37901)

* win_file: Handle [] in paths, fix touch in check mode

* Fixed typo for p/invoke command

(cherry picked from commit 4b57fa91d0)

* Added changelog fragment for win_file special char fix

(cherry picked from commit 61bcf4740f)
2018-04-27 08:54:02 +10:00
Adam Miller
c1d91bfcaa
Backport fix for fw_offline/FW_VERSION globals in firewalld (#39394)
Fixes #38161

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-04-26 17:36:31 -05:00
Matt Davis
a02592baec fix yamllint sanity failure 2018-04-26 10:51:13 -07:00
Matt Davis
48b75cad8e New release v2.5.2 2018-04-26 10:39:44 -07:00
mwpeterson
f529d75865 Update test-module (#39331)
Update test-module To use C.DEFAULT_LOCAL_TMP

(cherry picked from commit efdd92e1c0)
2018-04-26 08:56:00 -07:00
Ondra Machacek
757fb5263f Backports to 2.5 of recent oVirt fixes (#38835)
* ovirt_disks: Fix fail condition for LUN disk

Fixes: https://github.com/ansible/ansible/issues/38661

* ovirt_host_networks: Fix removing of network attachments

* ovirt: Support removing unmanaged networks

* ovirt: FCP storage domains don't have to have target
2018-04-26 11:48:53 -04:00
Toshio Kuratomi
cb27ed5a58 Winrm encoding in exception fix (#39333)
Exceptions need to use native strings.  We need to make sure we're
combining native strings with native strings.

(cherry picked from commit 0b643009db)

Add changelog entry for winrm encoding fix

(cherry picked from commit a5e33969b1)
2018-04-25 17:15:43 -07:00
Matt Clay
75c5bc0ef7 Update the cloudstack test container reference.
(cherry picked from commit ac1fbbeabc)
2018-04-25 12:32:23 -07:00
Alicia Cozine
d1e6b9a199
Reduce warnings (#39254) (#39323)
* fixes from 4b52a54e18
* leaves out the stub 2.6 porting guide
2018-04-25 13:50:28 -05:00
Matt Martz
3bcca725fc
Documentation for query/q. Fixes #38275 (#38558) (#39316)
(cherry picked from commit 476d1f818e)
2018-04-25 13:34:19 -05:00
Alicia Cozine
b88161055f
removes broken link to old module name (#39249) (#39307) 2018-04-25 11:37:27 -05:00
Alicia Cozine
6458a6699b
fixes broken links in Amazon module docs (#39248) (#39306)
(cherry picked from commit 0d38c80395)
2018-04-25 11:37:04 -05:00
Abhijeet Kasurde
7dbe964de5
We need to return virtual_facts after VMWare platform detection (#39149)
(cherry picked from commit 4f36d7965e)
2018-04-25 17:54:54 +05:30
Toshio Kuratomi
6b4b2d5381 Add note about the dangers of ANSIBLE_DEBUG (#39261)
* Add note about the dangers of ANSIBLE_DEBUG

* Wording tweaks

(cherry picked from commit 72456711c3)
2018-04-24 20:44:09 -07:00
Matt Clay
6c03fcdc0e Fix mysql-server install/upgrade on Ubuntu 16.04. (#39241)
* Fix mysql-server install/upgrade on Ubuntu 16.04.
* Prevent service restart in docker_secret test.

(cherry picked from commit 996f9c2467)
2018-04-24 13:37:25 -07:00
Alicia Cozine
f0761660bb
corrects links to 'list_of' pages (#39161) (#39230) 2018-04-24 12:27:26 -05:00
Loïc Blot
0e961f9ace k8s inventory: add pod nodeport (#39107)
Node port field is not populated on K8S pods, and it's certainely the most useful port to use in pod when we need to interact with ansible outside of the cluster
2018-04-24 18:32:10 +02:00
Alicia Cozine
b372eb0947
adds index page for roadmaps to support internal links (#39109) (#39192)
* adds index page for roadmaps to support internal links

* includes only roadmaps index page in TOC

(cherry picked from commit becc2a0347)
2018-04-24 08:46:32 -05:00
Jordan Borean
6ab0d60e81
Ansible.ModuleUtils.FileUtil - backport 2.5 Add ability to test non file system provider paths (#39203)
* Ansible.ModuleUtils.FileUtil - Add ability to test non file system provider paths (#39200)


(cherry picked from commit b6afe6946d)

* Added changelog fragment
2018-04-24 13:17:43 +10:00
Jordan Borean
250d5b74fa
Fix for win_get_url module (Fixes #39151) - 2.5 backport (#39207)
* Fix for win_get_url module (#39152)


(cherry picked from commit 0c96863ec6)

* Added changelog fragment
2018-04-24 12:46:40 +10:00
Brian Coca
299861a302 remove slice filter as it already exists in jinja 2018-04-23 18:33:32 -04:00
Matt Martz
ec8bce2051 Add changelog for #38302 2018-04-23 18:01:21 -04:00
Brian Coca
711769db4f allow incremental update for vars in loop for set_fact/include_vars (#38302)
* fix set_fact/include_vars looping

* tests for all behaviours affected

* add tests with injection off/on

(cherry picked from commit 2afb1090b1)
2018-04-23 18:01:21 -04:00
Alicia Cozine
1a96cd67d0 Internal refs (#39094)
* fixes community refs

* fixes appendix refs

* fixes scenario refs, keeps ACI guide link to devel

* fixes windows refs

* fixes user guide refs

* fixes dev guide refs

(cherry picked from commit bbfd6c6ab1)
2018-04-23 12:36:38 -07:00
Alicia Cozine
ea765be993 Link fixes (#39038)
* fixes links on plugins pages

* fixes links in community pages

* fixes links in user guide

* adds anchors on playbooks pages

(cherry picked from commit 408e29cbd2)
2018-04-23 12:36:08 -07:00
Alicia Cozine
3a0e8efc21 Fixes more rST errors (#39042)
* removes include, avoids duplicate label rST warnings

* reduces literal_block errors on playbooks_filters

* addresses TOC errors

* ref error on modules page

* trying ref for list_of_database_modules

(cherry picked from commit 64dcc7def0)
2018-04-23 12:35:37 -07:00
Alicia Cozine
628492f8b3 avoids not-in-toc errors with :orphan:
(cherry picked from commit 0fef3f1b48)
2018-04-23 12:15:59 -07:00
Toshio Kuratomi
cd7042857c Fix copy to only follow symlinks for files in the non-recursive case
Revert "**Temporary**"

This reverts commit 28b86b1148.

We don't need this now that copy has been fixed

(cherry picked from commit f332151f59)
2018-04-20 12:48:32 -07:00
Ganesh Nalawade
94d40c8515
Fix ios and iosxr terminal prompt regex (#39063) (#39089)
Fixes #38732

Make matching leading newline for cli prompt
optional as there are cases when returned repsonse
for ios/iosx remote host doesn't have newline before
cli prompt.
(cherry picked from commit eebfa66c2b)
2018-04-20 23:49:19 +05:30
Matt Martz
d6872a7b07
Backport #38747 for 2.5 - Block copy and reparenting improvements (#38829)
* Attempt 4: Prevent reparenting a block with itself (#38747)

* More concisely reparent, ensuring we don't go too shallow or too deep in this process. Fixes #38357

* More explicit reparenting, with a short circuit for a common case

* We need new_block to have a parent, otherwise we lose context with this approach

* Remove duplicate parent assignment

* Change callers of Block.copy to not use exclude_parent=True, when including the parent, exclude tasks

(cherry picked from commit f474195a3b)

* Add changelog for #38747
2018-04-20 12:31:56 -05:00
Matt Martz
0bbb67383b
Backport #38827 for 2.5 - Allow inheriting attrs from static parents (#38847)
* Skip self._parent on dynamic, defer to grandparent for attr lookup (#38827)

* Skip self._parent on dynamic, defer to grandparent for attr lookup

* Revert _inheritable

* Add tests for include inheritance from static blocks

Fixes #38037 #36194

(cherry picked from commit 354aa8d602)

* Add changelog for #38827
2018-04-20 11:45:28 -05:00
Matt Martz
017f9a4876
Backport #37083 for 2.5 - IncludedFile comparison fix for free strategy (#38981)
* Consider parent also when comparing IncludedFile (#37083)

* Consider parent also when comparing IncludedFile

* Add new tests for IncludedFile and convert to pytest

(cherry picked from commit cdb79b0e3a)

* Add changelog for #37083
2018-04-20 11:42:30 -05:00