Commit graph

1037 commits

Author SHA1 Message Date
Abhijeet Kasurde
91b703b0f0 [2.8] VMware: Handle VMs with no configurations
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 7505550500)
2019-06-17 16:23:40 -07:00
ShachafGoldstein
dfc47bd6d6 win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog

(cherry picked from commit a87495d07c)
2019-06-17 15:48:47 -07:00
Matt Williams
133c7adad5 Return results even when the cache is disabled (#55505)
* Return results even when the cache is disabled

By default the cache is disabled and so the results of the API call
are not placed in there for the return statement to fetch.

* Always update self._cache to return

(cherry picked from commit cf00883c9d)
2019-06-17 15:47:20 -07:00
Sloane Hertel
4b0c8f1a12 [FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog

(cherry picked from commit 598a058afe)
2019-06-17 15:45:58 -07:00
Eric Pulvino
dcb06ab78f Fix lack of support for Cumulus Linux with Hostname module in Ansible v2.8.0. (#57493)
(cherry picked from commit 1661c87bae)
2019-06-17 15:13:06 -07:00
Matt Martz
1422785f1f [stable-2.8] Provide a better error when python-dnf install fails (#57622)
(cherry picked from commit c3ca375)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-06-17 14:24:04 -07:00
xuxiaowei0512
b88a39fc22 add changelogs fragments 2019-06-17 14:23:29 -07:00
Martin Nečas
dd678197d3 Ovirt host facts fix (#57793)
* ovirt host facts fix (#57790)

* add changelog
2019-06-17 13:01:47 -07:00
Sebastiaan Mannem
7b73604058 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-06-17 13:01:08 -07:00
Strahinja Kustudic
3368780cbd Added environment variables to gcp_compute to align with gcp_* modules (#57776)
Added all variables that are also used by the gcp_* modules as described
in the docs
https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables

(cherry picked from commit 8e9f29c40c)
2019-06-17 12:55:57 -07:00
Paul Belanger
335c2026fa Add missing changelog fragments
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00
Abhijeet Kasurde
034d030a89 [2.8] VMware: Fix vmware_guest_move undefined VM name error
* Updated testcase
* Added check mode support
* Added check for mutual exclusive for Name and UUID

Fixes: #57580

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 00604d3f2c)
2019-06-17 12:51:13 -07:00
Strahinja Kustudic
dbaecb648e Improve speed of the gpc_compute dynamic inventory (#57591)
To get all instances gcp_compute made a call to the Google API for each
zone separately. Because of this if all zones needed to be queried
fetching hosts lasted 30+ seconds. Now the module will use a single
query that will return all the instances, so the execution should last
just a few seconds.

This commit also suppresses a warning from the google-auth library about
using user credentials because if an Ansible user wants to use user
credentials, there is no need to warn him about it.

(cherry picked from commit f6a0f9874d)
2019-06-17 11:38:16 -07:00
Sloane Hertel
01386cca4a preserve same order as inventory manager when using host lookup (#57769)
* preserve same order as inventory manager when using host lookup (#55331)

* preserve same order as inventory manager when using inventory_hostnames lookup

add a test

* move generic code

(cherry picked from commit afb5e02c19)

* changelog
2019-06-17 11:22:21 -07:00
Mikhail Yohman
395b722585 Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix

(cherry picked from commit d07d394779)
2019-06-14 19:24:06 -07:00
Martin Krizek
ea735a1602 Fix --diff to produce output when creating a new file (#57744)
* Fix --diff to produce output when creating a new file

Fixes #57618

* Make the check more defensive

(cherry picked from commit 1fa7bfcd5d)
2019-06-14 19:23:08 -07:00
YuandongXu
2645c43a2b backport/2.8/57270 update vrf to fix bugs (#57270) (#57757)
* update vrf to fix bugs (#57270)

* update vrf

* update vrf

(cherry picked from commit 76e06fa7c2)

* add changelog fragment fot PR 57757.
2019-06-14 19:21:40 -07:00
YuandongXu
814349c368 Backport/2.8/56976 update ce_ntp.py to fix bug (#57175)
* update ce_ntp.py and remove the root tag name to find all nodes (#56976)

* add a maintainer

* update ce_ntp.py and remove the root tag name to find all node

* update ce_ntp.py and remove the root tag name to find all node

(cherry picked from commit 0137c4343b)

* add changelogs  fragments

* add changelogs  fragments
2019-06-14 19:20:07 -07:00
krisvasudevan
211a2da2b9 Backport to fix bug in nios member module (#57218)
* Bug fixes for the nios member object (#56045)

* Bug fixes in api.py

* Examples updated in nios_member.py

* Update lib/ansible/module_utils/net_tools/nios/api.py

Co-Authored-By: Sumit Jaiswal <sjaiswal@redhat.com>

(cherry picked from commit d998791b4a)

* Create 56045-nios-member-module.yaml

* Bug fixes to nios_member module
2019-06-14 11:51:44 -07:00
Simon Dodsley
35ffd2825d Make purefa_pgsnap module handle its own exit correctly
(cherry picked from commit d4c0269fbbb177165d9eeb2dbec450f8552face8)
2019-06-14 09:35:21 -07:00
Ian Wienand
daef4d9c95 openssh_keypair: make fingerprint result a string (#57295)
The extant documentation says that the fingerprint return value is a
single string, but it is currently being returned as a split list.
Convert the returned value to a string as documented, and add some
basic test-case coverage for the return values.

(cherry picked from commit 6f06fc9945)
2019-06-11 19:54:54 -07:00
Jordan Borean
074b71f7fe win_chocolatey - honour version when bootstrapping chocolatey and fix package listing - 2.8 (#57380)
* win_chocolatey - honour version when bootstrapping chocolatey and fix package listing (#57208)

* win_chocolatey - honour version when bootstrapping chocolatey

* skip upgrade all step

* Fix install latest step

* Remove test changes now that Chocolatey is released

* tweak the package version detection

(cherry picked from commit b5b75daaa5)

* removed disabled alias
2019-06-11 19:54:11 -07:00
Trishna Guha
28db439e01 nxos_logging facilties defaults (#57144) (#57444)
* Add new logging facilties defaults (#57144)


(cherry picked from commit 1dc3fe5317)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:53:02 -07:00
Trishna Guha
b428d36724 nxos_install_os: Fix nxapi local failures (#55993) (#57446)
* nxos_install_os: Fix nxapi local failures (#55993)

* Fix nxapi failures

* Remove logit debug calls

* Remove msg_timestamps

* Fix code alignment issue

(cherry picked from commit 7c73dd3e78)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:51:50 -07:00
Trishna Guha
30aba1a7fd nxos_vlan purge fix 2.8 (#57442)
* nxos_vlan: fix broken purge behavior (issue #57101) (#57229)

* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check

(cherry picked from commit 6bb13bbb84)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:50:35 -07:00
James Cassell
769cc117a7 group_chars: default change warning only when needed
(cherry picked from commit 1fb0335243)
2019-06-11 19:49:18 -07:00
dw
b6d74466d4 [stable-2.8] Fix file descriptor leak in lineinfile module. (#57328)
(cherry picked from commit 3fadf4a1cb)

Co-authored-by: dw <dw@botanicus.net>
2019-06-11 19:48:42 -07:00
Sumit Jaiswal
e6e797af6e Backport PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57347)
* PR to fix the bug 57215 & 56300 under Nios Host_Record module (#57221)

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix bug 57215 & 56300

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* shippable error fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit e620e27609)

* B_PR for PR57721

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* renaming changelog file

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* renaming changelog file

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-11 19:48:07 -07:00
Sloane Hertel
95b1b42d4f improve conditional warnings (#57190)
* Fix order for warning on templated conditionals

Fix bare variable warnings when the variable is a boolean

* changelog

* Add tests for cases that should and should not give warnings

If the behavior may change when the default behavior for CONDITIONAL_BARE_VARS becomes False there should be a warning. Boolean type conditionals will not change in behavior so don't warn.

* oops, forgot to add files

* typo

(cherry picked from commit 21cd24a0dd)
2019-06-11 19:44:01 -07:00
Dominik Holler
86cb4089ca Handle binding:vnic_type as optional (#55526)
According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.

(cherry picked from commit bc50a52ee2)
2019-06-11 12:38:22 -07:00
Matt Clay
485ebaa799
[stable-2.8] Fix RuntimeError on Python 3.8. (#57520)
* [stable-2.8] Fix RuntimeError on Python 3.8.
(cherry picked from commit b9a0086aac)

Co-authored-by: Matt Clay <matt@mystile.com>

* Add changelog fragment.
2019-06-10 15:21:15 -07:00
Toshio Kuratomi
9a2e582eb2 New release v2.8.1 2019-06-06 11:19:28 -07:00
Abhijeet Kasurde
4ddc8b4769 [2.8] VMware: Use short unique task name for schedule task
* Updated documentation
* Updated task name logic

Fixes: #56987

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 13:32:56 -07:00
Brian Coca
36580c4450 Not native, but text (#55676) (#56935)
* Not native, but text (#55676)

* use to_text instead of to_native
* cleaned up some imports and other pyflakisms
* fix missing lib messages

(cherry picked from commit 27dcf8aaab)

* readded still used import
2019-06-03 09:42:14 -07:00
Felix Fontein
5c88199db3 [2.8] docker_image: fix compatibility bugs (#57085)
* docker_image: fix default handling of old docker-build options nocache and rm (#56610)

* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.

(cherry picked from commit 56e2d48612)

* docker_image: fix module failing when build option is used without specifying path (#56940)

* Fix module failing when build option is used without specifying path.

* Add changelog.

(cherry picked from commit 86928a5f74)

* Extend docker_image tests. (#57090)


(cherry picked from commit c54d79bc13)
2019-06-03 09:34:58 -07:00
Fabrice
6857fb2c39 k8s: Fix .to_dict not needed (#56147)
* k8s: Fix .to_dict not needed

* Add changelog fragment

(cherry picked from commit 7364e79c0d)
2019-06-03 09:31:55 -07:00
Nathaniel Case
d2538a0dea [stable-2.8] Plugin paths need to be sent in exectutor, too (#57126)
* Combine `_start_connection` methods into executor
(cherry picked from commit 4142cd5)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
2019-06-03 09:25:15 -07:00
Rohit
3ae459b3b4 Vyos interface desc fix28 (#57228)
* vyos interfacefix and  test cases

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
(cherry picked from commit be1820d3aff5958991911aed55c7e7627bcbc1d8)

* backport 28

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-06-03 09:21:12 -07:00
Andrey Klychkov
f0664476b7 postgresql_db: add note to doc about pg_dump Backport/2.8/57297 (#57308)
* postgresql_db: add note to doc about pg_dump (backport of #57297)
* Update lib/ansible/modules/database/postgresql/postgresql_db.py
2019-06-03 10:23:41 -05:00
xuxiaowei0512
19ffe970f7 Backport/2.8/57057 add terminal initial prompt for initial connection (#57178)
* add terminal initial prompt for initial connection (#57057)


(cherry picked from commit 9e1f184b2d)

* changelogs fragments

* update changelogs fragments
2019-05-30 10:33:01 -07:00
Mariusz Mazur
01c6915eba Backport/2.8/57163 (#57173)
* kubevirt_pvc: improve failure handling (#57163)


(cherry picked from commit cac34ac568)

* kubevirt_pvc: changelog fragment
2019-05-30 10:16:01 -07:00
Tim Hunter
7d0237f4db update pkg_mgr.py for Amazon Linux support (#56618)
(cherry picked from commit 4c00fc7b32)
2019-05-30 10:11:41 -07:00
szymon3
f79af725fc Backport/2.8/56912 (#57161)
* Update rabbitmq_queue.py (#56912)

change description for when `state=absent`

(cherry picked from commit 00067c8d54)

* Add changelog fragment for PR 56912
2019-05-30 09:47:02 -05:00
Ondra Machacek
4591f36dcd kubevirt_vm: Improve create VM from template (#56833)
* kubevirt_vm: Improve create VM from template

* kubevirt_vm: Fix checking of VM update

* kubevirt: Fix RS and presets template parameters

* kubevirt_vm: simplify previous change + update comments (#56897)
2019-05-30 07:41:39 -07:00
Rohit
77e50980b5 Nxos facts fix backport (#57150)
* text format fan info mismatch and module info check (#57009)

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
(cherry picked from commit b143918f30)

* nxos facts fix backport to stable 2.8

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-30 06:24:59 -07:00
Nathan Swartz
0365d73102 Backport/2.8/57135 (#57137)
* Fix netapp_e_iscsi_target chap secret size and clearing functionality.

* Add changelogs fragment for PR #57135
2019-05-29 11:55:59 -07:00
ShachafGoldstein
f511bec4ff Win_hostname module: Change name check to WMI (#56420)
* Change name check to WMI

* Changelog fragment

* Fixed per review

(cherry picked from commit 94566ed79c)
2019-05-28 17:17:11 -07:00
Felix Fontein
0d48ead822 docker_container: fix container creation with networks_cli_compatible=yes (#56687)
* Fix behavior.

* Add changelog.

* Add simple test to prevent #56620.

(cherry picked from commit d8dcd20294)
2019-05-28 17:14:09 -07:00
Tyler Hartley
0128006023 Make second group match of ufw status output optional (#56678)
* Make second group match of ufw status output optional

Fixes #56674

* Fix comparison logic.

* Add changelog fragment

(cherry picked from commit 1d22909f7c)
2019-05-28 16:28:33 -07:00
Bharat Kunwar
7d9aa0d829 Apply tags conditionally so that the module does not throw up an erro… (#56710)
* Apply tags conditionally so that the module does not throw up an error when using an older distro of openstacksdk

(cherry picked from commit c517538bd81149f5b507617e5f3385f98ec4642a)

* Update 56575-os_stack-apply_tag_conditionally_to_fix_the_module.yaml
2019-05-28 16:21:24 -07:00