Commit graph

44672 commits

Author SHA1 Message Date
Sandra McCann
69696dc83e update docsite breadcrumbs from sphinx_rtd_theme (#57316) (#57423)
* improve breadcrumbs
* get edit on github working again
(cherry picked from commit 3136007032)
2019-06-05 14:58:35 -05:00
Jordan Borean
77e88ae5d4 Mark win_chocolatey as unstable in 2.8 until next release 2019-06-05 06:15:05 -07:00
Abhijeet Kasurde
4ddc8b4769 [2.8] VMware: Use short unique task name for schedule task
* Updated documentation
* Updated task name logic

Fixes: #56987

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-06-03 13:32:56 -07:00
Brian Coca
36580c4450 Not native, but text (#55676) (#56935)
* Not native, but text (#55676)

* use to_text instead of to_native
* cleaned up some imports and other pyflakisms
* fix missing lib messages

(cherry picked from commit 27dcf8aaab)

* readded still used import
2019-06-03 09:42:14 -07:00
Felix Fontein
503eaea2ad Improve docs w.r.t. networks_cli_compatible. (#56971)
(cherry picked from commit b33c9dad40)
2019-06-03 09:35:25 -07:00
Felix Fontein
5c88199db3 [2.8] docker_image: fix compatibility bugs (#57085)
* docker_image: fix default handling of old docker-build options nocache and rm (#56610)

* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.

(cherry picked from commit 56e2d48612)

* docker_image: fix module failing when build option is used without specifying path (#56940)

* Fix module failing when build option is used without specifying path.

* Add changelog.

(cherry picked from commit 86928a5f74)

* Extend docker_image tests. (#57090)


(cherry picked from commit c54d79bc13)
2019-06-03 09:34:58 -07:00
Fabrice
6857fb2c39 k8s: Fix .to_dict not needed (#56147)
* k8s: Fix .to_dict not needed

* Add changelog fragment

(cherry picked from commit 7364e79c0d)
2019-06-03 09:31:55 -07:00
Felix Fontein
059589794e Fix assignments in docker tests. (#57249)
(cherry picked from commit 7cd229aa97)
2019-06-03 09:31:15 -07:00
Nathaniel Case
d2538a0dea [stable-2.8] Plugin paths need to be sent in exectutor, too (#57126)
* Combine `_start_connection` methods into executor
(cherry picked from commit 4142cd5)

Co-authored-by: Nathaniel Case <ncase@redhat.com>
2019-06-03 09:25:15 -07:00
Rohit
3ae459b3b4 Vyos interface desc fix28 (#57228)
* vyos interfacefix and  test cases

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
(cherry picked from commit be1820d3aff5958991911aed55c7e7627bcbc1d8)

* backport 28

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-06-03 09:21:12 -07:00
Andrey Klychkov
f0664476b7 postgresql_db: add note to doc about pg_dump Backport/2.8/57297 (#57308)
* postgresql_db: add note to doc about pg_dump (backport of #57297)
* Update lib/ansible/modules/database/postgresql/postgresql_db.py
2019-06-03 10:23:41 -05:00
Bill Nottingham
9184255340 Adjust assorted terminology and wording around product offerings. (#57242) (#57245)
* Adjust assorted terminology and wording around product offerings. 
(cherry-picked from c493593b4b) 

* Update docs/docsite/rst/dev_guide/style_guide/trademarks.rst
* Update docs/docsite/rst/user_guide/modules_support.rst
* Update docs/docsite/rst/reference_appendices/tower.rst
2019-05-31 14:56:35 -05:00
Anatoly Kamchatnov
2128e7c14f Windows FAQ: fix reference
(cherry picked from commit 8bf56642bd49d28b2aee30871ddb1a1e0974a302)
2019-05-30 11:33:52 -07:00
Daniel Mellado Area
e826eca1f2 Fix junos_facts test (#57065)
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.

(cherry picked from commit 0ada6b8d8d)
2019-05-30 11:12:27 -07:00
xuxiaowei0512
19ffe970f7 Backport/2.8/57057 add terminal initial prompt for initial connection (#57178)
* add terminal initial prompt for initial connection (#57057)


(cherry picked from commit 9e1f184b2d)

* changelogs fragments

* update changelogs fragments
2019-05-30 10:33:01 -07:00
Mariusz Mazur
01c6915eba Backport/2.8/57163 (#57173)
* kubevirt_pvc: improve failure handling (#57163)


(cherry picked from commit cac34ac568)

* kubevirt_pvc: changelog fragment
2019-05-30 10:16:01 -07:00
Tim Hunter
7d0237f4db update pkg_mgr.py for Amazon Linux support (#56618)
(cherry picked from commit 4c00fc7b32)
2019-05-30 10:11:41 -07:00
szymon3
f79af725fc Backport/2.8/56912 (#57161)
* Update rabbitmq_queue.py (#56912)

change description for when `state=absent`

(cherry picked from commit 00067c8d54)

* Add changelog fragment for PR 56912
2019-05-30 09:47:02 -05:00
Ondra Machacek
4591f36dcd kubevirt_vm: Improve create VM from template (#56833)
* kubevirt_vm: Improve create VM from template

* kubevirt_vm: Fix checking of VM update

* kubevirt: Fix RS and presets template parameters

* kubevirt_vm: simplify previous change + update comments (#56897)
2019-05-30 07:41:39 -07:00
Rohit
77e50980b5 Nxos facts fix backport (#57150)
* text format fan info mismatch and module info check (#57009)

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
(cherry picked from commit b143918f30)

* nxos facts fix backport to stable 2.8

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-05-30 06:24:59 -07:00
Nathan Swartz
0365d73102 Backport/2.8/57135 (#57137)
* Fix netapp_e_iscsi_target chap secret size and clearing functionality.

* Add changelogs fragment for PR #57135
2019-05-29 11:55:59 -07:00
ShachafGoldstein
f511bec4ff Win_hostname module: Change name check to WMI (#56420)
* Change name check to WMI

* Changelog fragment

* Fixed per review

(cherry picked from commit 94566ed79c)
2019-05-28 17:17:11 -07:00
Felix Fontein
0d48ead822 docker_container: fix container creation with networks_cli_compatible=yes (#56687)
* Fix behavior.

* Add changelog.

* Add simple test to prevent #56620.

(cherry picked from commit d8dcd20294)
2019-05-28 17:14:09 -07:00
Tyler Hartley
0128006023 Make second group match of ufw status output optional (#56678)
* Make second group match of ufw status output optional

Fixes #56674

* Fix comparison logic.

* Add changelog fragment

(cherry picked from commit 1d22909f7c)
2019-05-28 16:28:33 -07:00
Bharat Kunwar
7d9aa0d829 Apply tags conditionally so that the module does not throw up an erro… (#56710)
* Apply tags conditionally so that the module does not throw up an error when using an older distro of openstacksdk

(cherry picked from commit c517538bd81149f5b507617e5f3385f98ec4642a)

* Update 56575-os_stack-apply_tag_conditionally_to_fix_the_module.yaml
2019-05-28 16:21:24 -07:00
Yury V. Zaytsev
776aa014ac route53_facts: add check mode support (#56900)
* route53_facts: add check mode support

* route53_facts: add changelog fragment mentioning check mode support

* route53_facts: alter changelog fragment type from `minor_changes` to `bugfixes`

* Update changelogs/fragments/56900-route53-facts-check-mode.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-05-28 15:37:26 -07:00
Klaus Frank
64890cc456 [2.8] VMware: Fix python 3 incompatibility
Add Python2 and Python3 compatible `string.translate` for hostname customization.

Fixes: #54118
(cherry picked from commit 8f89d1d3da)
2019-05-28 15:29:21 -07:00
Lukas Kämmerling
116262e5e8 Backport hcloud_volume attach step should be idempotent 2019-05-28 15:06:19 -07:00
Felix Fontein
0a624eaad3 [2.8] [docker_network] Fix idempotency when using aux_addresses in ipam_config (#56972)
* [docker_network] Fix idempotency when using aux_addresses in ipam_config (#56901)

* [docker_network] Fix idempotency when using aux_addresses in ipam_config

Mismatch between keys returned by Docker API (AuxilliaryAddresses) vs
expected by Ansible module (aux_addresses) resulted in tasks always
have status 'changed'. The existing code normalizing one set of
keys to another missed this special case where converting
CamelCase to lowercase is not sufficent.

Please see
https://github.com/moby/moby/blob/master/api/types/network/network.go
for reference.

* Correct keywords formatting in changelog file

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit 37df89b2d8)

* docker_network: Integration tests for IPAM config idempotence (#56975)

Integration tests for pull request #56901 which fixes found issues with idempotence.

(cherry picked from commit 6a50c6aae4)
2019-05-28 15:01:52 -07:00
Felix Fontein
4388886d48 docker conncetion plugin: accept 'dev' as 'newest version' (#56947)
* Accept 'dev' as 'newest version'.

* Add changelog.

* Fix YAML.

(cherry picked from commit 2f523ad08e)
2019-05-28 15:00:10 -07:00
Sandra McCann
4ef102ae79 Correct repository name to install (#56991) (#57078)
(cherry picked from commit e17434c19f)
2019-05-28 14:33:11 -05:00
Sandra McCann
4b1c9c1b29 fixed doc build errors (#56735) (#57080)
(cherry picked from commit ac22cd31b6)
2019-05-28 14:32:47 -05:00
Nathaniel Case
5a1985cb06 [stable-2.8] eos_l2_interface handle "Interface does not exist" (#56787) (#56982)
* [stable-2.8] eos_l2_interface handle "Interface does not exist" (#56787)

* Quick and dirty attempt to handle eapi error

* Well this should probably change

* Hopefully this works correctly?

* Fix check_rc handling with httpapi

* Add tests that should hopefully cover the error

* Fix warnings

* Improve tests.
(cherry picked from commit cebb363fcc)

Co-authored-by: Nathaniel Case <ncase@redhat.com>

* Add changelog

* Remove backport overreach

* Fix debug statements in new tests while I'm here
2019-05-28 07:18:11 -07:00
Martin Krizek
0a3410f5c6 ansible-test: prefer shlex.quote (#56823)
(cherry picked from commit 484c023316)
2019-05-26 08:53:13 -07:00
Paul Belanger
cb6ece6b4e [stable-2.8] Don't validate ip address for mgmt interface (#56136)
It is possible the EOS appliance doesn't have an IP address on the
management1 interface, instead just check we have found that interface.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit f9589bd)

Co-authored-by: Paul Belanger <pabelanger@redhat.com>
2019-05-24 14:29:01 -07:00
Nathaniel Case
d617e6cd84 [stable-2.8] eos_config: Fix test issues (#56180) (#56916)
* [stable-2.8] eos_config: Fix test issues (#56180)

* Alter tests to pass

* Change diff_against to make changed work again

* Add another diff_against

* Expose supports_sessions across all EOS connection types

* Change session warning to failure

* supports_sessions needs to be a method to survive the rpc boundary

* Alter tests to match
(cherry picked from commit 0bead36)
2019-05-24 14:27:59 -07:00
Nathaniel Case
39c5758a87 [stable-2.8] Don't detect update if vrf not set. (#56235) (#56421)
* [stable-2.8] Don't detect update if vrf not set. (#56235)
(cherry picked from commit ea41bbc)
2019-05-24 14:27:32 -07:00
Sam Doran
0a40b0ed45 [stable-2.8] Update instructions for running module directly (#56883)
The internals of AnsiballZ changed silghtly
(cherry picked from commit 50b1a66649)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-05-24 12:08:49 -07:00
Nathaniel Case
92e4a98219 [stable-2.8] Don't fail trying to read boot image without enable (#56126) (#56134)
* [stable-2.8] Don't fail trying to read boot image without enable (#56126)

Also add a message when network_os_image can't be acquired.
(cherry picked from commit 3d9da0c)

Co-authored-by: Nathaniel Case <ncase@redhat.com>

* Add changelog

* Fix changelog
2019-05-24 11:54:22 -07:00
Matt Martz
20d17fe0ea [stable-2.8] Validate types before asserting lengths (#56882)
(cherry picked from commit 9c5b721)

Co-authored-by: Matt Martz <matt@sivel.net>
2019-05-24 11:33:24 -07:00
Brian Coca
9844ea49c5 Always keep subset data for callbacks (#56881)
results were only being preserved during no_log
  fixes #56704

(cherry picked from commit 4adb7cfb5f)
2019-05-24 11:33:00 -07:00
Martin Krizek
eb9d192130 yum: handle "_none_" value for proxy (#56725)
* yum: handle "_none_" value for proxy

Fixes #56538

* Fix sanity check

(cherry picked from commit 7b9d7e6b5c)
2019-05-24 10:52:35 -07:00
Sam Doran
bd011688dd [stable-2.8] Ensure uri module always returns status even on failure (#56240)
- Also return url and update docs for other values to indicate they are only returned on success.
- Add integration tests
- Use info variable for common return values
- Use -1 as default status rather than None. This is lines up with with existing code in urls.py
- Add unit tests to ensure status and url are returned on failure
(cherry picked from commit 8f4f3750fe)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-05-24 10:52:05 -07:00
Swartz, Nathan
e71b4e2e57 Fix workload profileId indexing in netapp_e_volume module
This commit reflects the changes in PR #56747 in the devel branch
2019-05-24 10:50:48 -07:00
Brian Coca
73484808c8 Preserve ssh error (#56460)
* Preserve ssh error

* more details on fail

* removed redundant caption to errors

(cherry picked from commit 22b9525aa9)
2019-05-24 10:28:13 -07:00
Will Thames
c52335a616 Make ansible adhoc work with include_role (#56163)
* Make ansible adhoc work with include_role

Fix logic condition so that include_role works
without

```
ERROR! 'async_val' is not a valid attribute for a IncludeRole

The error appears to be in 'None': line 0, column 0, but may
be elsewhere in the file depending on the exact syntax problem.

(could not open file to display line)
```

* Add include_role test for adhoc

(cherry picked from commit cd95843ea5)
2019-05-24 10:26:45 -07:00
Brian Coca
53cfa05568 Prevent vars premature templating (#56117)
Avoid premature vars templating
  * added tests
  * avoid 'is template' warning in vars, since we want them for latter templating

(cherry picked from commit 1da47bfa8c)
2019-05-24 10:25:42 -07:00
Andrey Klychkov
206087e342 Backport/2.8/56703 (#56829)
* postgresql_db: bugfix 56703 (#56734)

(cherry picked from commit f9108e23e7)

* postgresql_db bugfix (backport/2.8/56703)
2019-05-24 09:31:47 -07:00
Felix Fontein
6c078e18a8 openssl_pkcs12: fix crash due to wrong path used for loading key in check mode (#56808)
* Used wrong path for private key.

* Add changelog.

(cherry picked from commit 391a1042c2)
2019-05-24 09:31:22 -07:00
Alicia Cozine
5f67bd5ef9
CLI docs include license not copyright (#56871) (#56874)
(cherry picked from commit fc94d79c47)
2019-05-23 17:18:50 -05:00