Commit graph

36491 commits

Author SHA1 Message Date
Sloane Hertel
43cfb89c2a 2.5 backport - fix cache timeout behavior ()
* Fix cache timeout behavior

(cherry picked from commit c1400ce909)

* changelog
2018-06-07 17:01:50 -07:00
Gaudenz Steinlin
515a625e13 dictionary changed size during iteration error () ()
Iterating an object and changing it at the same time is unsecure and no longer permitted in Python >= 3.6

Provisioning an instance fail with the Python error: "RuntimeError: dictionary changed size during iteration"
2018-06-07 17:01:21 -07:00
Jesse Pretorius
7e04385baf os_server_action: Document the python-novaclient requirement ()
Without also installing the python-novaclient library, this module
simply does not work.

Fixes: 
2018-06-07 16:54:36 -07:00
Jesse Pretorius
be9de94eea Correct the OpenStack plugin example config ()
The current example configuration is not
quite right, so this patch implements a
fix which corrects it

The 'inventory_hostname' argument is removed
as it's the same value as the default.

(cherry picked from commit 12218f33a5c429676da8f3db0f91553c63a0314f)
2018-06-07 16:48:49 -07:00
Jesse Pretorius
c142e2f1a3 os_project_access: clean up some things ()
* os_project_access: correct example tasks

The example task does not work. Fix it so that it does.

(cherry picked from commit 028b5965b66656ffe7810cea3bcc0e505339ebc2)

* os_project_access: Remove unused function

The _get_allowed_projects function is not used anywhere,
so we can remove it and be free of nova_client for this
module.

(cherry picked from commit c190a2826d6935848278867c67f36f2b56728f94)
2018-06-07 16:48:04 -07:00
Jesse Pretorius
d525d7cf5f os_server: Remove nova_client usage ()
The os_server module uses the deprecated nova_client function, and
therefore ends up requiring python-novaclient installed. In this
patch we switch the ip detachment to make use of a shade function,
removing the need for python-novaclient.

(cherry picked from commit 055d89cd32385fa891e17a24aadc2c68397f307d)
2018-06-07 16:46:34 -07:00
Alicia Cozine
723dcea33e Make alias autodetection for symlinked modules independent of glob() order. () ()
(cherry picked from commit 2a29b2ff7f)
2018-06-07 12:25:10 -07:00
Alicia Cozine
609c792072 Better error message if the template is not utf-8 encoded () ()
* Better error message if the template is not utf-8 encoded

Also document this in the porting guide
(cherry picked from commit cef4d862bc)
2018-06-07 12:24:13 -07:00
Trishna Guha
ebc36eed8c fix nxos output truncated issue and nxos_banner issue ()
* fix nxos output truncated issue

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix nxos_banner issue ()

(cherry picked from commit b6afb77a8a)

* add changelog for nxos_banner fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-06-07 09:45:30 -07:00
Jordan Borean
60ab7b2807 winrm: fix up unit tests () ()
(cherry picked from commit ad8e13e9f8)
2018-06-06 15:57:00 -07:00
Alicia Cozine
04a5fc5e5a Backport/2.5/39948 ()
* Fix formatting error in rst plugin template ()

The hyperlink syntax used is wrong and the resulting
rendered documents have broken links.

(cherry picked from commit aaf2ff629d)

* Add missing > to fix 'edit this document' link ()

(cherry picked from commit ebdf6d0fab)

* Fix problems in documentation generation ()

* Treat C(...) as inline literal (as opposed to interpreted text).

* Making test for true and false more precise, to avoid matching 1, 1.0, etc.

* The 'is sameas' test already takes care of definedness.

(cherry picked from commit f16933492d)

* Namespace the aliases ref target by plugin type ()

(cherry picked from commit 7ce1afebf0)

* Use colspan on td instead of divs for hierarchical tables ()

Address Firefox table-rendering issues in docs. Refactor to use colspan to provide table cells which can vary in width and indentation; the outermost has the greatest colspan, and each nested key has a colspan of one less than the parent, with padding cells for indentation.
Apply styling to table cells to get the table height to work without hacks or browser-specific
styling.  Simplify the markup and CSS by removing extra divs. Use two passes over the options, return values, and return facts in the Jinja2 module-docs template: one to determine the maximum nesting depth to compute the maximum colspan needed, plus one to lay out the rows.
(cherry picked from commit fa5c0282a4)
2018-06-06 13:32:02 -07:00
Matt Davis
456af458fc
add codename to release.py 2018-05-31 16:16:35 -07:00
Matt Davis
8e7251a6b7
bump to pre-2.5.5 2018-05-31 15:25:15 -07:00
Matt Davis
048690fdc4 New release v2.5.4 2018-05-31 14:56:01 -07:00
Matt Martz
959821f40e Backport for 2.5 - synchronize _remote_is_local ()
* Use _remote_is_local=True for local connection in synchronize ()

* All instances of local connection should use _remote_is_local=True. Fixes 

* Switch to instance attribute for synchronize

* Add test that shows that synchronize _remote_is_local addresses tmpdir building

(cherry picked from commit ad7ba91f75)

* Add changelog entry for 
2018-05-30 17:28:23 -04:00
Brian Coca
f1cd7a99be remove extra )
(cherry picked from commit 062f0444a1)
2018-05-30 16:28:58 -04:00
Brian Coca
a970ecba57 added information on keyword/vars separation () ()
* added information on keyword/vars separation

fixes 

* updated as per fb

(cherry picked from commit bc93038943)
2018-05-30 16:12:54 -04:00
Brian Coca
5a77aceae5 fix 'doas' become_method support, previously committed patch not submitted to devel branch () ()
* fix become_method 'doas' support by properly specifying becomecmd

a repatch of https://github.com/ansible/ansible/pull/13451/ which was never committed to 'devel' branch.

* fix play_context test for become_method doas to match new becomecmd

(cherry picked from commit be3670f528)
2018-05-30 16:03:58 -04:00
Brian Coca
f7f8d2b133 add keywords handling to ansible-doc ()
also add check for sequence of string types before we force a join

(cherry picked from commit 73b9892605)
2018-05-30 12:32:25 -07:00
Sloane Hertel
b1c4d6310d Fix broken aws_ses_identity test - backport ()
* Fix failing aws_ses_identity integration tests ()

* Fix failing aws_ses_identity integration tests

Reduce boilerplate with yaml anchor

* remove unstable test alias

* Update feedback forwarding check to use desired state rather than
repeated API calls.

(cherry picked from commit 571c183f59)

* changelog
2018-05-30 10:43:02 -07:00
Brian Coca
be46ea7bf2 use correct object in error
fixes 

(cherry picked from commit 0339c8037b)
2018-05-30 12:53:15 -04:00
Matt Clay
48f6670b49 Fix FreeBSD package install in test setup.sh.
(cherry picked from commit c3d3b6cedc)
2018-05-30 09:26:04 -07:00
Alicia Cozine
b48b5c585e
adds table of connections by platform () ()
(cherry picked from commit 43ca9d1548)
2018-05-30 08:17:04 -05:00
Trishna Guha
8e8b469416
nxos bugfixes 2.5.4 cherry-pick ()
* Fix legacy Nexus 3k integration test and module issues. ()

* Add setup ignore_errors for nxos_config test

* Fix parse_fan_info for n3k

* Skip bidir tests for N3k

* Omit vni config for n3k

* Skip unsupported nxos_vrf_af test on N3K

* Add legacy N3K platform tag

(cherry picked from commit 63e16431b7)

* Skip N35 and N3L platforms for nxos_evpn_global test ()

(cherry picked from commit ad69ef88e7)

* add normalize_interface in module_utils and fix nxos_l3_interface module ()

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 0b7932db30)

* nxos_interface: Disable switchport for loopback/svi ()

* nxos_interface: Disable switchport for loopback/svi

* Replace interface_type with get_interface_type(name)

(cherry picked from commit d04a989bd2)

* fixes bug with matching nxos prompts ()

This change addresses an issue where the prompt matching regular
expressions would not match a prompt if the hostname starts with a
numeric value.  Before this change, the connection would fail with a
socket.timeout() error.  This change updates the termnal_stdout_re
values to now check for a number.

See Github issue 

(cherry picked from commit d829ff6993)

* fix nxos_vrf and migrate get_interface_type to module_utils ()

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit b4baa2d484)

* nxos_vlan fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* changelog nxos bugfixes 2.5.4

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-05-30 11:21:53 +05:30
Yuwei Zhou
5f384ec0a6 Fix by ensuring that the first nic in the nic list is primary () () 2018-05-29 10:28:54 +08:00
Benoit Dunand-Laisin
116a504825 Fixes Module always updates installed plugins ()
* Update jenkins_plugin.py

When setting state=latest, plugin are always updated because old sha1 is bytes and and is compared to new sha1 which is str (so it always detecting a sha1 change)

* Add changelog
2018-05-25 10:09:17 -04:00
Jordan Borean
7ffbdd5214
win_scheduled_task fix doc example with datestamp ()
(cherry picked from commit 0df6b085c0)
2018-05-25 11:40:19 +10:00
Sam Doran
b20b29ac0a
Insert set commands if a delete command is entered () ()
(cherry picked from commit 8b4e36e711)
2018-05-24 13:21:16 -04:00
Nathaniel Case
d6a07186fd
Backport ios test fixes to 2.5 ()
* Ios test fixes ()

* Return messages generated from edit_config to module

* This does not seem to work that way

* Change test IP addresses to not conflict with device config

(cherry picked from commit eb818df1ec)

* Search all assigned ipv6 addresses instead of just the first ()

* Search all assigned ipv6 addresses instead of just the first

* Add test for idempotency with multiple ipv6 addresses assigned

(cherry picked from commit e8d02a3a0f)

* Fix ios test pt. 2 ()

* Add missing idempotence assert

* Remove dhcp with other addresses on ipv6

(cherry picked from commit f88412b7cd)
2018-05-24 10:22:46 -04:00
saydamir
3f2831c6e2 ec2_instance - fix instance creation with IPv6 ()
IPv6 addresses and IPv6 address count may not be specified on the same request https://docs.aws.amazon.com/cli/latest/reference/ec2/assign-ipv6-addresses.html#options
2018-05-24 10:10:23 -04:00
Sviatoslav Sydorenko
0b080de855
[2.5] Fix ios_vlan to correctly identify unmodified config when having long interface names () ()
Change the command to get the interface in a vlan "show vlan" => "show vlan brief"
Change the parsing of the return command of the switch.
The return of the ios command is fixed so i cut with fix number of carracter.
Adding looking for the next line to add the forgeted interfaces.
(cherry picked from commit 3903ca5)

Co-authored-by: pierremahot <pierre.mahot@orange.fr>
2018-05-24 15:55:13 +02:00
Martin Krizek
18581adbb5
Backport: apt: don't markmanual if apt-mark is not installed ()
(cherry picked from commit a3cfe0d72f)
2018-05-24 09:27:38 +02:00
Jordan Borean
12ac23bad3
Win get url auth 2.5 ()
* Fixed WebRequest init ()


(cherry picked from commit 4fbdc1a497)

* Added changelog fragment
2018-05-24 14:42:39 +10:00
Matt Martz
fac5a14ded Backport for 2.5 - synchronize fixes ()
* Group logic detecting user, ensure rsync_opts is a list if omitted. Fixes 

(cherry picked from commit ea176427b4)

* Add changelog for 
2018-05-24 12:04:18 +10:00
Daryl Tucker
70a60b6166
Updates to fileglob Documentation ()
(cherry picked from commit 5edc46431a)
2018-05-24 12:01:00 +10:00
Jordan Borean
a63b6d363b
winrm: add better exception handling for krb5 auth with pexpect () ()
* winrm: add better exception handling for krb5 auth with pexpect

* Added changelog fragment

* Added exception handler in case kinit path isn't valid, added test cases

* fixed for Python 2 compatibility

(cherry picked from commit 5e28e282a5)
2018-05-24 07:17:21 +10:00
Sviatoslav Sydorenko
2cb9f7f5b9
[backport] Detect separate git dir and set git config path value appropriately
PR 

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 0a701ff)

Co-authored-by: Senya <senya@riseup.net>
2018-05-23 21:01:07 +02:00
Ludek Finstrle
786911d26f constructed inventory does not use group variables from previous inventory
* Add support for loading invenotry group variables in constructed plugin

(cherry picked from commit 81cfbbbeb9)
2018-05-23 10:59:26 -04:00
Sam Doran
02e66617f2
Make xenserver_facts actually work () ()
* Get the str value of xmlrpc.client.DateTime

* get_all_records should be used instead of get_all

* Facts returned with 'ansible_facts'

* Remove some redundant code

* Add cheese as maintainer

* Add changelog entry

(cherry picked from commit d45b044992)
2018-05-22 14:01:19 -04:00
Sam Doran
dbcecb64b8
Fix ctrl+c in pause module and add tests () ()
Backport # 40134 - Ensure Ctrl+C interrupt for pause module works in all cases
2018-05-22 13:11:21 -04:00
Sam Doran
4c279f5e45
EdgeOS module improvements () ()
* Update docs and use to_text on strings

* Add warning to use network_cli

(cherry picked from commit d5dbd8c76d)
2018-05-22 12:52:57 -04:00
Sam Doran
9bef06ccd9
Add better error messages and checking to known_hosts () ()
(cherry picked from commit 13aff08748)
2018-05-22 12:42:39 -04:00
Nathaniel Case
7df6df9017
Ios fixes 2.5 ()
* Ios test fixes ()

* Return messages generated from edit_config to module

* This does not seem to work that way

* Change test IP addresses to not conflict with device config

* Add test for idempotency with multiple ipv6 addresses assigned
2018-05-22 12:00:29 -04:00
Sam Doran
e877469533
Do not join flag parameters in iptables module () ()
* Do not join flag parameters

This put a comma between every character of the tcp flag parameters, resulting in a bad iptables command.

Fixes 

* Use suboptions to ensure tcp_flags options are lists

* Add unit tests for tcp_flags

* Add example of how to use tcp_flags

(cherry picked from commit c9d3bb59a4)
2018-05-22 11:29:33 -04:00
Artem Goncharov
13c88fe2d2 fixes issue 39472: ()
With python 3.6 spwd.getspnam returns PermissionError instead of
KeyError if user does not have privileges

(cherry picked from commit 0023b1ee9eca1286493c56ce5e1aa1b2272c3e39)
2018-05-22 11:29:00 -04:00
Alicia Cozine
7c49648a39
uses .txt for shared content () ()
(cherry picked from commit 69eef14e3b)
2018-05-22 10:21:08 -05:00
Jordan Borean
9d8d1de182
winrm: source user from options than remote_user () ()
* winrm: source user from options than remote_user ()

* winrm: source user from options than remote_user

* fixed up mock for kerberos import

* Added changelog fragment

* get hostname from option as well

(cherry picked from commit 1ac180c74d)

* Also removed uneeded method that wasn't backported
2018-05-22 10:46:13 +10:00
Jordan Borean
6eb0af96de
win_environment: Added explicit check for null, empty string with state=present () ()
* win_environment: Added explicit check for null, empty string with state=present

* Added changelog fragment

(cherry picked from commit db195831fd)
2018-05-22 07:15:34 +10:00
Martin Krizek
d60f70b47b
Clarify in docs that end_play affects all hosts () ()
(cherry picked from commit b116eaa485)
2018-05-21 07:47:51 +02:00
Ryan S. Brown
d0cf81883c Move EC2 ASG changelog entry to correct directory 2018-05-18 13:57:52 -04:00