Commit graph

3457 commits

Author SHA1 Message Date
Michael DeHaan
404765162d Merge pull request #6184 from patrys/patch-1
Properly match existing security group
2014-02-26 08:10:27 -05:00
Patryk Zawadzki
da1efee21f Properly match existing security group
If we don't care about `vpc_id` then neither should the code.
2014-02-26 13:39:03 +01:00
Guido Kollerie
a000f37132 Emphasize target is on remote host. List supported file types.
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
2014-02-26 12:56:24 +01:00
jctanner
6fa898c511 Merge pull request #5092 from willthames/ec2_snapshot
Module to create EC2 snapshots
2014-02-26 06:10:17 -05:00
jctanner
1277b45b3c Merge pull request #5941 from sivel/rax-name-search-opts
rax module: Use regex start and end of string with name base filters
2014-02-26 05:56:39 -05:00
Brian Coca
53d71a3949 added octal representation of mode and made md5 checksumming optional
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-25 21:33:14 -05:00
Joshua Conner
9c72b52c01 docker: add 'version_added' to the appropriate documentation entries 2014-02-25 17:04:01 -08:00
Chris Church
1d6bdd451b Fix setup module to gather facts from PowerPC Macs. 2014-02-25 18:27:36 -05:00
Joshua Conner
66eb91c2f8 docker: update to docker-py 0.3.0, plus full port binding support, container names, links 2014-02-25 15:24:46 -08:00
James Tanner
0cca4a3919 Fixes #5255 yum: set disabled repos before enabled repos and fix the parameters used 2014-02-25 14:53:48 -05:00
James Cammarata
03cb2f5ffa Merge branch 'git_version_tags' of https://github.com/j2sol/ansible into j2sol-git_version_tags 2014-02-25 13:05:29 -06:00
James Cammarata
cb79947054 Fixing the unicode issue in uri for EL6 platforms
Fixes #5869
2014-02-25 13:04:05 -06:00
James Cammarata
6fe369fca0 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
2014-02-24 23:38:51 -06:00
James Cammarata
97eededc99 Handle unicode content in the uri module properly
Fixes #5869
2014-02-24 23:34:17 -06:00
Stefan J. Betz
789ae4697c Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
2014-02-24 18:52:35 -06:00
Michael DeHaan
05bf80751b Merge pull request #6158 from risaacson/issues_5165
If you try to resize a lvol to the current size return a changed=False and don't fail.
2014-02-24 19:17:43 -05:00
Richard C Isaacson
bf30707670 If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
2014-02-24 16:56:08 -06:00
Kyle Kelley
b5eb4d2a71 Fix expires 2014-02-24 15:54:55 -06:00
James Cammarata
be0be16e89 Merge branch '5853-python-2.5-apt_repository-fix' of https://github.com/timurbatyrshin/ansible into timurbatyrshin-5853-python-2.5-apt_repository-fix 2014-02-24 15:20:29 -06:00
James Cammarata
3b2d409906 Fixing several bugs in assemble and updating tests
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
  resulting in it never being used by the module as the default behavior
  was remote_src=True (issue #5581)
* the remote_src param was not listed in the generic file params, leading
  to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
  fragments do not run together on one line

Fixes #5581
2014-02-24 14:27:23 -06:00
James Cammarata
f03d6a67c8 Adding new tests for assemble role 2014-02-24 14:27:23 -06:00
Richard C Isaacson
aaf0a182e1 Merge remote-tracking branch 'jeromew/ansible_script_creates' into issues_4986 2014-02-24 10:16:39 -06:00
Scott Patten
dbde446358 In the route53 module, documenting that TXT and SPF requests
must be surrounded by quotes.

Otherwise you get a cryptic error message from Route 53.
2014-02-21 19:36:22 -08:00
James Cammarata
2157880029 Adding the backup destination to the resut dictionary for lineinfile 2014-02-20 13:31:54 -05:00
Michael DeHaan
d5c7290b93 Merge pull request #6066 from jsmartin/riak_module_fix
Properly fetching the riak version
2014-02-19 16:51:04 -05:00
James Laska
dbd3194e9c Resolves issue#6067 by allowing exact_count=0 2014-02-19 16:29:15 -05:00
muffl0n
b0f00cc097 already call expanduser in action_plugin 2014-02-19 21:41:57 +01:00
James Martin
0e3356c40e Properly fetching the riak version, and properly setting the python interpreter. 2014-02-19 12:12:02 -05:00
Michael DeHaan
30611eaac5 Merge pull request #6036 from mxxcon/patch-1
docs_pull_request: Add parameters highlighting
2014-02-18 13:58:44 -05:00
Michael DeHaan
6b2bbbb9ff Merge pull request #6045 from garaden/pypi_mirrors_gone
Set use_mirrors default to "no" for the pip module
2014-02-18 13:58:11 -05:00
Michael DeHaan
dc3ca7b37e Merge pull request #6051 from illenseer/devel
Fix zfs create command for properties with spaces
2014-02-18 13:54:47 -05:00
Brian Coca
310b23ee8d removed with
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-18 12:33:48 -05:00
James Cammarata
8880819395 Merge branch 'devel' of https://github.com/mtpereira/ansible into mtpereira-devel 2014-02-18 10:33:30 -06:00
Matthew Phipps
de99cc6fbf Remove use_mirrors from pip module
PyPI moved to a CDN on 2013-05-26, so mirrors are now largely
unnecessary and pip removed the functionality in 1.5. More importantly
(and why I wrote this request): on 2014-02-15 the mirror directory was
taken offline, so mirrors may not work anymore even for pip versions
that support them.
2014-02-18 10:49:22 -05:00
Matthew Phipps
63ff6c8493 pip module wasn't adding -e when using VCS 2014-02-18 10:39:51 -05:00
jeromew
7a14cb61c4 Add creates= and removes= to the script: action 2014-02-18 12:52:09 +00:00
Nils Pascal Illenseer
858004984b Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
2014-02-18 11:30:17 +01:00
James Cammarata
daa3253b52 Merge branch 'devel' of https://github.com/calebbrown/ansible into calebbrown-devel 2014-02-17 15:38:56 -06:00
James Cammarata
9c9a940af6 Merge branch 'fix-5679' of https://github.com/jirutka/ansible into jirutka-fix-5679 2014-02-17 14:54:29 -06:00
Richard C Isaacson
7d670f8308 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 2014-02-17 11:46:23 -06:00
James Cammarata
1544c93bf2 Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 2014-02-17 10:04:12 -06:00
James Cammarata
87bf16930e Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
Conflicts:
	library/database/postgresql_user
2014-02-17 09:57:31 -06:00
mxxcon
4e4be3edc0 docs_pull_request: Add parameters highlighting
Added highlighting to parameter references in docs so that they standout a bit better.
2014-02-15 23:26:21 -05:00
Michael DeHaan
56befa9468 Document ansible_managed changing the template. 2014-02-15 14:13:42 -05:00
Michael DeHaan
6f9ca7cfa5 Some minor docs corrections. 2014-02-15 14:05:42 -05:00
James Cammarata
9dd9487692 Merge branch 'mohangk-fix_rds_modify_security_group' into devel 2014-02-15 09:34:46 -06:00
James Cammarata
7eb2a4c290 Merge branch 'fix_rds_modify_security_group' of https://github.com/mohangk/ansible into mohangk-fix_rds_modify_security_group 2014-02-14 14:43:42 -06:00
Richard Isaacson
bab91f9ed8 Merge pull request #6015 from angstwad/docfix
Spelling correction.
2014-02-14 11:04:44 -06:00
Richard Isaacson
ffeb507761 Merge pull request #5645 from resmo/fix/apt_pkg_version
apt: fixed pkg=<name>=<version> fails if package is not yet installed.

Tested and it fixes the problem on more recent versions of apt.
2014-02-14 11:01:35 -06:00
Paul Durivage
0dbd5d3e18 Spelling correction 2014-02-14 10:47:27 -06:00
Amir H. Hajizamani
cf5b1620b7 Remove superfluous/invalid quote
Allow the example to be copy-pasted with minimal confusion about the error.
2014-02-14 16:44:55 +00:00
Peter Gehres
b5761750c4 Adding the region to the output of the ec2 module's creation of a new instance. 2014-02-13 22:40:49 -08:00
Michael DeHaan
c91ceddfac Add the start of an integration test structure using Ansible playbooks, also added an assert action plugin to make writing those easier. 2014-02-13 18:28:29 -05:00
James Cammarata
0d79132757 Merge pull request #5998 from jimi-c/issue_3978_boto_ssl_cert_validation
Adding 'validate_certs' option to EC2 modules
2014-02-13 14:42:30 -06:00
James Cammarata
fdb7c733c1 Updating CHANGELOG for the new validate_certs feature
Also removing validate_cert option from the cloudformation module docs,
as it does not use the standard ec2 connection.
2014-02-13 14:40:39 -06:00
Richard Isaacson
686f87e42e Merge pull request #5944 from sean-/devel
Fix broken behavior when removing all auxiliary groups from a user. See #5933 for more details.

Tests by hand correct and passes "make clean tests".
2014-02-13 13:54:38 -06:00
James Cammarata
056d54ebd3 Adding 'validate_certs' option to EC2 modules
When disabled, the boto connection will be instantiated without validating
the SSL certificate from the target endpoint. This allows the modules to connect
to Eucalyptus instances running with self-signed certs without errors.

Fixes #3978
2014-02-13 12:32:49 -06:00
Will Thames
c8127ea874 ec2 module fails when state is not absent
tagged_instances is initialised in a scope not visible
when state is not absent.
2014-02-13 19:51:33 +10:00
Pavel Antonov
e02cf2aab7 Refactore unused code 2014-02-12 17:06:58 -05:00
Pavel Antonov
dddd4b2522 Added modules description and examples 2014-02-12 17:06:58 -05:00
Pavel Antonov
df41ed90b8 Docker supports links and port binding. Added docker_image module 2014-02-12 17:06:58 -05:00
Michael DeHaan
0cdf8d3162 Merge pull request #5981 from angstwad/docfix
Documentation updates to rax_files, rax_files_objects
2014-02-12 14:21:10 -05:00
James Cammarata
a1b7a93b69 Modified cloudformation module to use common ec2 module functions
Fixes #3688
2014-02-12 12:54:47 -06:00
Michael DeHaan
e89dafc6c1 Merge pull request #5039 from bpennypacker/airbrake
airbrake: Made the reporting URL an optional parameter
2014-02-12 12:32:28 -05:00
Paul Durivage
f18db0dd20 Doc updates 2014-02-12 11:22:15 -06:00
Robin Roth
660fa9183c remove check for version string
this check does not get used anywhere and is not needed as zypper/rpm can handle version information directly
2014-02-12 17:14:43 +01:00
Richard Isaacson
eb4a730933 Merge pull request #5969 from risaacson/pull_5136
Updates for the unarchive module and action_plugin.
2014-02-12 10:10:25 -06:00
Richard C Isaacson
598b9c6b7c Cleanup per notes.
Some small changes to per notes from @mpdehann.
2014-02-12 10:01:10 -06:00
Richard C Isaacson
cb7c2b7524 Updates for the unarchive module and action_plugin.
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.

PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!

Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.

Tests were added via a playbook with archive files to verify functionality.

All tests fire clean including custom playbooks across multiple linux and solaris systems.
2014-02-12 01:57:00 -06:00
Richard C Isaacson
e6c9705058 Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136 2014-02-11 22:55:34 -06:00
Michael DeHaan
f07091ed69 Merge pull request #5962 from sivel/rax-facts-docs-update
rax_facts and rax_keypair modules: update docs
2014-02-11 16:39:59 -05:00
Matt Martz
e8952a5a99 The OpenStack auth attributes apply to rax_keypair also 2014-02-11 14:25:13 -06:00
jctanner
fe94c0cd05 Merge pull request #5957 from sivel/rax-no-default-disk-config
rax module: Don't set a default for disk_config
2014-02-11 11:55:06 -05:00
Matt Martz
8095aa6584 Don't set a default disk_config. Defaulting to 'auto', causes issues with new images 2014-02-10 16:12:32 -06:00
Sean Chittenden
5e0cf6663a Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
2014-02-10 13:08:53 -08:00
Matt Martz
bd3c7c3efa The name parameter for search_opts is a regex string, so make sure we include start and end of string characters 2014-02-10 13:18:03 -06:00
Mohan Krishnan
fb3c8c90e5 Allow explict setting of vpc_security_groups to allow modification of security groups of RDS instances within a VPC 2014-02-10 14:01:45 +07:00
Brian Coca
f475de2316 hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
2014-02-09 20:47:01 -05:00
Brian Coca
a1de284dba made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
2014-02-09 17:46:18 -05:00
Michael DeHaan
d3c1b8de78 Merge pull request #5883 from amirhhz/improve-ec2-module-docs
Improve ec2 module docs
2014-02-09 14:07:35 -05:00
Scott Anderson
baf508a379 Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key. 2014-02-08 18:35:26 -05:00
Jon Chen
970997c764 fix linode typo 2014-02-07 20:47:57 -05:00
Jesse Keating
4593e3c357 Make sure requested version tag gets downloaded
There is a subtle bug in how the git module currently works. If the
version you request is a tag name, and you've already got the repo
cloned, and the tag name is a new tag, but refers to the already checked
out working copy, the git module would exit early without change. This
is bad as it means the new tag ref was not fetched and could not be used
in later tasks.

This change will check if the version is a remote tag, and if the tag
doesn't exist locally. If that is true, it'll do a fetch.

The activity could still be seen as not a change, because the working
copy won't be updated, if the new tag refers to the already checked out
copy, but that's not different than before and can be fixed as a more
comprehensive overhaul of tracking change in the git module.
2014-02-07 14:13:04 -08:00
Richard Isaacson
66967bde14 Merge pull request #5905 from artursvonda/update-postgresql-docs
Added port documentation to postgresql_db and postgresql_user.
2014-02-07 14:31:09 -06:00
James Tanner
a62af82757 Make ec2 exact_count and count mutually exclusive 2014-02-07 13:42:43 -05:00
James Tanner
70ebb05190 Return a tagged_instances list for hosts that matched the count_tag 2014-02-07 13:07:34 -05:00
Richard Isaacson
5a15762739 Merge pull request #5826 from romeotheriault/fix_follow_redirects
A fix for uri module regarding following redirects. The old behavior would follow redirects either way. This change clarifies the functionality and makes it a bit more explicit. Comparing the old behavior to the new 'yes' == 'all', 'no' == 'safe' and now 'no' will not follow any redirects. Historic behavior is still supported and documented with a push to the new values.
2014-02-07 11:36:51 -06:00
Arturs Vonda
6d85082586 Added port documentation to postgresql_db and postgresql_user 2014-02-07 18:27:55 +02:00
jctanner
6e7f684958 Merge pull request #5901 from jctanner/ec2_tag_exact_count_2
Add exact_count and count_tag to the ec2 module.
2014-02-07 10:57:01 -05:00
James Tanner
f101768a9d Make an example that sets the instance Names 2014-02-07 10:49:13 -05:00
James Tanner
005ef837d9 Update docstrings 2014-02-07 10:34:45 -05:00
James Tanner
fd919062cb Add exact_count and count_tag to the ec2 module. 2014-02-06 23:25:57 -05:00
Afterburn
398c71c1b7 small change to docs 2014-02-06 20:35:42 -07:00
Afterburn
2fe00ac8c9 small change to docs 2014-02-06 20:34:38 -07:00
Brian Coca
0233584343 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-02-06 11:59:37 -05:00
jctanner
0bc0315171 Merge pull request #5880 from willthames/ec2_modules_refactor
Create a common EC2 connection argument spec for EC2 modules
2014-02-06 11:08:09 -05:00
Will Thames
7600c664fe Create a common EC2 connection argument spec for EC2 modules
Refactor the currently well-factored ec2 modules (i.e. those that already use ec2_connect) to
have a common argument spec. The idea is that new modules can use this spec without duplication
of code, and that new functionality can be added to the ec2 connection code (e.g. security
token argument)
2014-02-06 15:27:41 +10:00
willthames
27fc3b8006 Module to create EC2 snapshots
Two methods of creating a snapshot
* use volume_id
* use device_name and instance_id

The latter is more useful with inventory
2014-02-06 09:44:43 +10:00
jctanner
a1d2b5f257 Merge pull request #5363 from bcoca/acl_improved
acl module: acl now supports 'default'
2014-02-05 18:40:59 -05:00
Brian Coca
54a79bfc75 fixed docstring and changed type to etype avoiding python builtin
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-05 18:36:29 -05:00