Commit graph

35593 commits

Author SHA1 Message Date
Paul B
ccdc93ab59 contrib(inventory): fix Scaleway inventory used w/env variable token (#35701)
In order to authenticate with the Scaleway API for the contrib dynamic
inventory Scaleway the environment variable SCALEWAY_TOKEN was read
only if a value was set in the configuration .ini file.

This PR fixes that allowing to read only the environment variable
without needing to set a token in the configuration file.

Closes #35693
2018-02-05 08:32:49 +00:00
Mike Wiebe
0de810fdf7 Fix nxos_bgp tests and prepare_nxos_tests refactor (#35694) 2018-02-05 12:13:30 +05:30
saichint
109bc89bbe fix nxos_ospf_vrf issues (#35616) 2018-02-05 10:59:13 +05:30
René Moser
588cd749ac
cs_network: implement support acl (#35706) 2018-02-04 19:23:57 +01:00
Abhijeet Kasurde
02b28d4584
VMware: Refactor vmware_vmkernel module (#35531)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-04 06:08:45 +05:30
Abhijeet Kasurde
367258507a
VMware: Provide verbose message about non-existent VM (#35682)
This fix adds a verbose message about non-existent VM when specified
with operation, due to idempotency we can not detect correct state.

Fixes: #27384

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-04 05:23:24 +05:30
Rob Nieuwenhuizen
4094ba7682 Digitalocean public private ip (#27269)
* When using private networking the ip_address key contains the private ip.
Add the following info to module output when available:
  - private_ipv4_address
  - public_ipv4_address
  - private_ipv6_address
  - public_ipv6_address
2018-02-04 03:45:16 +05:30
René Moser
c6f397b160
cs_vpc: fix network_domain param ignored (#35690) 2018-02-03 21:21:24 +01:00
Ivan Bojer
196f2f382b removed panos_nat_policy (#34432)
* removed panos_nat_policy

* merge

* removed extra line
2018-02-03 11:35:17 +00:00
Ivan Bojer
fb545b72c3 new module that allows for adding DynamicAddressGroup tags to the firewall (#35201)
* new module that allows for adding dag tags
2018-02-03 11:34:04 +00:00
Joshua Smith
e1c9c6eded Update example syntax in playbooks_tags.rst. (#35680) 2018-02-03 11:33:02 +00:00
Joshua Smith
060890f3b2 Update example syntax in playbooks_loops.rst. (#35679) 2018-02-03 11:32:11 +00:00
Joshua Smith
aeb749e116 Update example syntax in playbooks_lookups.rst. (#35678) 2018-02-03 11:31:12 +00:00
Joshua Smith
1b7e5d19a2 Update example syntax in playbooks_intro.rst. (#35677) 2018-02-03 11:30:54 +00:00
Joshua Smith
0a5ff792e4 Update example syntax in playbooks_filters.rst. (#35676) 2018-02-03 11:30:24 +00:00
Joshua Smith
6179bd378c Update example syntax in playbooks_error_handling.rst. (#35675) 2018-02-03 11:29:58 +00:00
Joshua Smith
3fe6de475b Update example syntax in playbooks_delegation.rst. (#35674) 2018-02-03 11:29:40 +00:00
Joshua Smith
203c8f4334 Update example syntax in playbooks_conditionals.rst (#35673) 2018-02-03 11:29:22 +00:00
Joshua Smith
6c1a63dd14 Update example syntax (#35670)
* Update examples in guide_rolling_upgrade.rst.

* Update examples playbooks_best_practices.rst.

* Update examples in playbooks_checkmode.rst.
2018-02-03 11:28:22 +00:00
Mike Wiebe
5a198e1e6a Add minor conditional checks to nxos_bgp sanity test (#35476)
* Add minor conditional checks to nxos_bgp sanity test

* Make ansibot happy
2018-02-03 10:37:10 +05:30
Bruno
767f32c2b2 added aci_static_binding_to_epg module (#35581)
* added aci_static_binding_to_epg module

* fixing pep8 issues

* fixed documentation yaml ':' error

* fix aliases error

* small documentation fixes suggested in PR
2018-02-03 00:49:29 +01:00
Bruno
e5687a1592 added aci_fabric_node module (#35586) 2018-02-03 00:49:12 +01:00
Dag Wieers
bee765fa6b
ACI: Change RETURN output as discussed (#35617)
* ACI: Change result output as discussed

* Update all modules to use new aci.exit_json()

* Update output_level spec and docs

* Fix integration tests

* Small PEP8 fix

* Asorted fixes to tests and aci_rest

* More test fixes and support for ANSIBLE_DEBUG

* Fix another PEP8 issues

* Move response handling inside ACI module

* Reform of ACI error handling and error output

* Diff multiline json output

* Fix a few more tests

* Revert aci_bd tests

* Small correction

* UI change: existing->current, original->previous

* UI change: config->sent

* Update all modules with RETURN values

* Fix a few more tests

* Improve docstring and add 'raw' return value

* Fix thinko

* Fix sanity/pep8 issues

* Rewrite unit tests to comply with new design
2018-02-03 00:41:56 +01:00
Matt Clay
685dd5e8b4 Disable failing aws_waf_web_acl tests. 2018-02-02 15:21:14 -08:00
Ryan S. Brown
415ed50876 Add aws_waf_rule to CHANGELOG 2018-02-02 17:55:15 -05:00
Will Thames
4e30eff651 [cloud][aws] New module: aws_waf_rule module (#33124)
Add a new module for managing AWS WAF rules

Preceded by aws_waf_condition and to be succeeded by aws_waf_web_acl
2018-02-02 17:54:27 -05:00
David Newswanger
69cd705634
Add vyos smoke integration tests. (#35456)
* added preliminary vyos smoke tests

* added comments, determined current tests are sufficient

* add tests for check mode in module_utils.network.vyos

* removed vyos_smoke from shippable

* added comment explaining why AWS/Shippable tests won't work
2018-02-02 16:04:19 -05:00
Sloane Hertel
7917e3c988
Fix syntax error so route table tests always try to clean up (#35663)
* Always try to clean up after route table tests

* Wait for a new VPC a chance to become available before attempting to get its current state
2018-02-02 15:38:47 -05:00
Willem van Ketwich
4faad64579 [cloud][aws] New module: cloudfront_invalidation (#35601)
* Remove redundant default for target_paths

* Make invalidation requests idempotent

* Remove redundant exception handling around boto3_conn

* Add cloudfront_invalidation to the changelog
2018-02-02 15:09:55 -05:00
Dag Wieers
36bd24f121
aci_epg: Add support for Preferred Group Membership (#35265)
* aci_epg: Add support for Preferred Group Membership

* ACI defaults to 'no'

* Add 'version_added'

* Make use of aci.boolean()
2018-02-02 19:23:19 +01:00
Joshua Smith
7b76da2d4c Update some examples to use proper YAML syntax. (#35640)
* Update some examples to use proper YAML syntax.

* Make the requested changes so this builds properly.

Also fix emphasis line numbers to match what was being emphasized before
the change.
2018-02-02 18:20:03 +00:00
Dag Wieers
3dfede5642
ACI: Implement aci.boolean() to return an ACI boolean (#35610)
* ACI: Implement aci.boolean() to return an ACI boolean

A boolean value in ACI is not always standardized to yes/no.
Sometimes we have active/inactive, or enabled/disabled
Whereas the interface we want is a true YAML boolean.

We did not modify enabled/disabled values at this time.
I first want to determine if this implementation is acceptable.

* Support enabled/disabled as well, with deprecation messages

* Fix typo

* Fix PEP8 issue

* Ensure the aci object exists before using it

* Add comment to ensure this gets fixed in v2.9

* Fix typo
2018-02-02 18:54:48 +01:00
Pierre-Louis Bonicoli
2646ea9b86 yum_repository: Python 3.7 error have been fixed
See 232dc7110c
2018-02-02 09:43:58 -08:00
Pilou
d608eb9530 Check that AnsibleUndefinedVariable doesn't occur when an unused variable references an undefined variable (#35571)
* Check that AnsibleUndefinedVariable doesn't occur

* AnsibleUndefinedVariable exc.: don't modify type
2018-02-02 09:25:13 -08:00
Russell Teague
c37b997abc Update BOTMETA for VMware maintainers (#35609) 2018-02-02 11:20:52 -05:00
Martin Krizek
24c6de7c49
Use value of delegated transport for var lookup (#35658) 2018-02-02 17:17:19 +01:00
Martin Krizek
c3199dca6c
Add any_errors_fatal in nested failed block test (#35499) 2018-02-02 16:25:55 +01:00
Trishna Guha
a4b7df70c7
nxos_vlan ValueError fix (#35559)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-02 20:51:34 +05:30
Nathaniel Case
e8755175d7
Fix paramiko connections to hosts with uppercase characters (#35555) 2018-02-02 10:08:40 -05:00
Nathaniel Case
f3337e1fba
ios test changes (#35510)
* Fix over-byte

* Update ios tests to call `provider`

To continue to support testing `connection: local`

* Fix command dict handling in ios_user

* Clean up unit tests, too
2018-02-02 09:50:15 -05:00
Abhijeet Kasurde
d7d9e40dd1
VMware: Deprecate vsphere_guest module (#35648)
This change deprecates vsphere_guest in favor of vmware_guest and other
related modules.

The major reasons behind deprecation are -

- Pysphere - Unofficial Python bindings of vCenter deprecated in the year 2013.
- VMware provides official Python bindings for vCenter, which is used in vmware_guest.
- vcsim - simulator used in integration testing of vmware module does not support PySphere
  APIs, which makes it more difficult to test vsphere_guest.

Please see [deprecation plan](https://github.com/ansible/community/wiki/VMware%3A-vsphere_guest_deprecation)

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-02 20:03:57 +05:30
Sloane Hertel
fd72e4aef2
Make an aws_credentials documentation fragment for plugins using environment vars (#35578) 2018-02-02 08:50:11 -05:00
jctanner
4ec16867fd Fix loop/with typo in loops doc (#35652) 2018-02-02 13:33:13 +00:00
Trishna Guha
dc4a41a4af change testfiles for nxos_file_copy (#35641)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-02 12:54:53 +00:00
René Moser
785e888ea0 doc: fix loop examples (#34991) 2018-02-02 13:52:28 +01:00
Ludovic Rivallain
fe57285f9a vmware: Add new module 'vmware_datastore_host' (#35004)
* vmware: Add new module 'vmware_datastore_host'

Signed-off-by: Ludovic Rivallain <ludovic.rivallain@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-02 18:16:10 +05:30
Ivan Bojer
82e6a91c3f new module panos_query_rules (#35203)
* new module
2018-02-02 12:38:27 +00:00
Ivan Bojer
9ddf8b8ee5 remove panos_security_policy (#34433)
* remove panos_security_policy

* added depreciation notice

* - deprecation notice

* properly document deprecated module

* merge changes

* merge changes

* parser expects srt for deprecations attributes
2018-02-02 12:35:02 +00:00
Mike Cavedon
e59d3dd524 Update playbooks_best_practices.rst (#35627)
* Update playbooks_best_practices.rst

If deploying to the first 10 hosts in Boston it should be "-limit boston[0:9]" and the next 10 should be "-limit boston[10:19]". The doc as written would skip the first host (boston[0]) and try to deploy to a host that doesn't exist (boston[20])

* Typo fix
2018-02-02 12:21:21 +00:00
Dag Wieers
ddbe52d0f4
Simplify auth logic (#35647) 2018-02-02 12:58:04 +01:00